GNU bug report logs - #28262
[PATCH] Handle the same HTTP redirects everywhere.

Previous Next

Full log

View this message in rfc822 format

From: ludo <at> gnu.org (Ludovic Courtès)
To: Tobias Geerinckx-Rice <me <at> tobias.gr>
Cc: 28262-done <at> debbugs.gnu.org
Subject: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere.
Date: Thu, 07 Sep 2017 11:43:07 +0200

Hi,

Tobias Geerinckx-Rice <me <at> tobias.gr> skribis:

>> As a followup, we should look into merging the two ‘http-fetch’
>> procedures.  I don’t think the initial motivation for having two
>> separate implementations still holds.
>
> I'll push this fix and close this bug, but if you have the time I'd love
> to know more about that initial motivation. The two have grown quite apart.

Initially (guix http-client) existed simply to paper over API changes in
Guile’s (web client) and to work around bugs in older Guile version.
This is because (guix http-client) is used on the “host” side, where we
support(ed) older releases of Guile 2.0.

(guix build download) didn’t really have this constraint because the
Guile used on the “build” side was known, and known to be recent enough
in most cases.  So all it did was to add a higher-level API above what
Guile provides, which follows redirects, etc.

Since 36626c556ed75219bce196ac93d148f6b9af984c we require Guile >=
2.0.9, so some of the bugs/workarounds we had no longer apply and the
separation probably no longer makes sense.

HTH!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.