From unknown Mon Jun 16 23:48:56 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28262 <28262@debbugs.gnu.org> To: bug#28262 <28262@debbugs.gnu.org> Subject: Status: [PATCH] Handle the same HTTP redirects everywhere. Reply-To: bug#28262 <28262@debbugs.gnu.org> Date: Tue, 17 Jun 2025 06:48:56 +0000 retitle 28262 [PATCH] Handle the same HTTP redirects everywhere. reassign 28262 guix-patches submitter 28262 Tobias Geerinckx-Rice severity 28262 normal tag 28262 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 28 09:44:58 2017 Received: (at submit) by debbugs.gnu.org; 28 Aug 2017 13:44:58 +0000 Received: from localhost ([127.0.0.1]:58952 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmKLU-0004tN-MZ for submit@debbugs.gnu.org; Mon, 28 Aug 2017 09:44:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40857) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmKLS-0004tB-TH for submit@debbugs.gnu.org; Mon, 28 Aug 2017 09:44:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmKLM-0003Fj-8K for submit@debbugs.gnu.org; Mon, 28 Aug 2017 09:44:45 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:38436) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmKLM-0003Ff-5J for submit@debbugs.gnu.org; Mon, 28 Aug 2017 09:44:44 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmKLH-0001uV-IH for guix-patches@gnu.org; Mon, 28 Aug 2017 09:44:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmKLF-0003ET-MR for guix-patches@gnu.org; Mon, 28 Aug 2017 09:44:39 -0400 Received: from tobias.gr ([2001:470:cc92::1]:45598) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dmKLF-0003EN-DF for guix-patches@gnu.org; Mon, 28 Aug 2017 09:44:37 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 6ee8bd85 for ; Mon, 28 Aug 2017 13:44:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=from:to :subject:date:message-id:mime-version:content-type :content-transfer-encoding; s=201706; bh=J1/4zqMH7e3z9g0/v4vA3Iu kVYYwTvcOeXLSoVoqVS0=; b=BVCm4lCETqsL4oXTVLqagmSp+ZPSPgRcPh1q+kC 2F5s5GVJ/0TJsh+qak/vYIiONF41rF+SL4BUmiITrOM6lWENgYWhXdxUOm3Rt1q1 AUw/JuuGonG9BmC21pX1ntCqFfqM3ieqIM1CMxS+Htss1M4t9wcwsr+84DjkDR0P 5UotrNb7gNKIcWyumVMuZxoanT40qmjM0pRcc2OuVbAXWQD7apvrvr2XffRyfTOu k/vQ7dvDdU27lUe4C/7YNDNhMOiIzEcicFQIrB2pFl52sVufM7jSaLZvTiPDYFci Ku75EWf0WVxNGLtSWwnuREWhbFxpXvbYkWcM0yHtoAVCxwQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id c49c1c20 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for ; Mon, 28 Aug 2017 13:44:28 +0000 (UTC) From: Tobias Geerinckx-Rice To: guix-patches@gnu.org Subject: [PATCH] Handle the same HTTP redirects everywhere. Date: Mon, 28 Aug 2017 15:46:10 +0200 Message-Id: <20170828134610.30984-1-me@tobias.gr> X-Mailer: git-send-email 2.13.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) * guix/download.scm (http-fetch): Complete the hard-coded list of HTTP redirect status codes. * guix/http-client.scm (http-fetch): Likewise. * guix/scripts/lint.scm (probe-uri): Likewise. --- Guix, There are three (that I know of) hard-coded lists of HTTP redirect status codes in Guix. All were different, and all were incomplete. This patch doesn't address the duplication, but does add all missing codes. Specifically the newer HTTP/1.1 codes, including 303 ‘See Other’. It's not strictly a plain redirect, but used as such in the wild[1], and treating it as such is probably enough for our purposes. This allows at least lightdm-gtk-greeter to be built again. Why its sources waren't mirrored to begin with I do not know, nor did I check. Kind regards, T G-R [1]: https://launchpad.net/lightdm-gtk-greeter/2.0/2.0.2/+download/lightdm-gtk-greeter-2.0.2.tar.gz guix/build/download.scm | 5 ++++- guix/http-client.scm | 6 +++++- guix/scripts/lint.scm | 7 ++++++- 3 files changed, 15 insertions(+), 3 deletions(-) diff --git a/guix/build/download.scm b/guix/build/download.scm index 6ef623334..bcf22663b 100644 --- a/guix/build/download.scm +++ b/guix/build/download.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2015 Steve Sprang +;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -763,7 +764,9 @@ certificates; otherwise simply ignore them." file)) ((301 ; moved permanently 302 ; found (redirection) - 307) ; temporary redirection + 303 ; see other + 307 ; temporary redirection + 308) ; permanent redirection (let ((uri (resolve-uri-reference (response-location resp) uri))) (format #t "following redirection to `~a'...~%" (uri->string uri)) diff --git a/guix/http-client.scm b/guix/http-client.scm index 3c5441c38..8db332093 100644 --- a/guix/http-client.scm +++ b/guix/http-client.scm @@ -2,6 +2,7 @@ ;;; Copyright © 2012, 2013, 2014, 2015, 2016, 2017 Ludovic Courtès ;;; Copyright © 2015 Mark H Weaver ;;; Copyright © 2012, 2015 Free Software Foundation, Inc. +;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -259,7 +260,10 @@ Raise an '&http-get-error' condition if downloading fails." ((200) (values data (response-content-length resp))) ((301 ; moved permanently - 302) ; found (redirection) + 302 ; found (redirection) + 303 ; see also + 307 ; temporary redirect + 308) ; permanent redirect (let ((uri (resolve-uri-reference (response-location resp) uri))) (close-port port) (format #t (G_ "following redirection to `~a'...~%") diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm index aceafc674..b27732d39 100644 --- a/guix/scripts/lint.scm +++ b/guix/scripts/lint.scm @@ -6,6 +6,7 @@ ;;; Copyright © 2016 Danny Milosavljevic ;;; Copyright © 2016 Hartmut Goebel ;;; Copyright © 2017 Alex Kost +;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; ;;; This file is part of GNU Guix. ;;; @@ -411,7 +412,11 @@ for connections to complete; when TIMEOUT is #f, wait as long as needed." (close-connection port)))) (case (response-code response) - ((301 302 307) + ((301 ; moved permanently + 302 ; found (redirection) + 303 ; see also + 307 ; temporary redirect + 308) ; permanent redirect (let ((location (response-location response))) (if (or (not location) (member location visited)) (values 'http-response response) -- 2.13.1 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 28 09:50:22 2017 Received: (at 28262) by debbugs.gnu.org; 28 Aug 2017 13:50:22 +0000 Received: from localhost ([127.0.0.1]:58962 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmKQn-000522-RS for submit@debbugs.gnu.org; Mon, 28 Aug 2017 09:50:21 -0400 Received: from tobias.gr ([51.15.135.5]:46480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmKQm-00051t-0X for 28262@debbugs.gnu.org; Mon, 28 Aug 2017 09:50:20 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 5af782b8 for <28262@debbugs.gnu.org>; Mon, 28 Aug 2017 13:50:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject :from:to:references:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=201706; bh=eH8MFddE2E rE9/SK4odKqdleoFxGwGufP5g8XlAi62w=; b=bsHm9NggF9L44lMP6RZC1xzF6C bMOM1pbxmEKZEpXw8cdF4+1YOFvAEY4WmaZT3CRdO02QzK784ciGwZ0VkG/QiI5a /JnJV0ytv/yE26qXQgpZgoeoxab6fMGE+iCdbln8a814kqJD2ta67M7SANT4iAjl C97yky37eQB6aZyWD4B8pOd4WQyEGRRl+u68vFw9HZcoXcPY+ChH9pDaAqs4cKTE PEbEDbwTj6x9xXAM8XFpCLWj0yo95GiKw41BqHIAUE/yKTgaV8Kxw0tTxPaqzG54 uws37WKAxAkLhQlOLWWuo1OQGQHPs892cb9TRMyLAb0+jjtYqc/OxDIegMoA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 98164e92 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO) for <28262@debbugs.gnu.org>; Mon, 28 Aug 2017 13:50:15 +0000 (UTC) Subject: Re: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere. From: Tobias Geerinckx-Rice To: 28262@debbugs.gnu.org References: <20170828134610.30984-1-me@tobias.gr> Message-ID: <92edb6ea-1ba3-4fe2-d64e-ebf487c0bbb9@tobias.gr> Date: Mon, 28 Aug 2017 15:52:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170828134610.30984-1-me@tobias.gr> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28262 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Tobias Geerinckx-Rice wrote on 28/08/17 at 15:46: > diff --git a/guix/http-client.scm b/guix/http-client.scm > index 3c5441c38..8db332093 100644 > --- a/guix/http-client.scm > +++ b/guix/http-client.scm > @@ -259,7 +260,10 @@ Raise an '&http-get-error' condition if downloading fails." > ((200) > (values data (response-content-length resp))) > ((301 ; moved permanently > - 302) ; found (redirection) > + 302 ; found (redirection) > + 303 ; see also > + 307 ; temporary redirect > + 308) ; permanent redirect s/redirect$/redirection/ > diff --git a/guix/scripts/lint.scm b/guix/scripts/lint.scm > index aceafc674..b27732d39 100644 > --- a/guix/scripts/lint.scm > +++ b/guix/scripts/lint.scm > @@ -411,7 +412,11 @@ for connections to complete; when TIMEOUT is #f, wait as long as needed." > (close-connection port)))) > > (case (response-code response) > - ((301 302 307) > + ((301 ; moved permanently > + 302 ; found (redirection) > + 303 ; see also > + 307 ; temporary redirect > + 308) ; permanent redirect > (let ((location (response-location response))) > (if (or (not location) (member location visited)) > (values 'http-response response) Dittums. Kind regards, T G-R From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 31 09:10:27 2017 Received: (at 28262) by debbugs.gnu.org; 31 Aug 2017 13:10:27 +0000 Received: from localhost ([127.0.0.1]:36508 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnPEp-00072n-27 for submit@debbugs.gnu.org; Thu, 31 Aug 2017 09:10:27 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnPEo-00072Z-2U for 28262@debbugs.gnu.org; Thu, 31 Aug 2017 09:10:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dnPEe-0006fa-3Q for 28262@debbugs.gnu.org; Thu, 31 Aug 2017 09:10:21 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:33913) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dnPEd-0006fQ-W9; Thu, 31 Aug 2017 09:10:16 -0400 Received: from [193.50.110.184] (port=46184 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dnPEc-0007sN-AL; Thu, 31 Aug 2017 09:10:15 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Tobias Geerinckx-Rice Subject: Re: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere. References: <20170828134610.30984-1-me@tobias.gr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 31 Aug 2017 15:10:12 +0200 In-Reply-To: <20170828134610.30984-1-me@tobias.gr> (Tobias Geerinckx-Rice's message of "Mon, 28 Aug 2017 15:46:10 +0200") Message-ID: <871snrsx1n.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28262 Cc: 28262@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hey Tobias, Tobias Geerinckx-Rice skribis: > * guix/download.scm (http-fetch): Complete the hard-coded list of HTTP > redirect status codes. Actually guix/build/download.scm. > * guix/http-client.scm (http-fetch): Likewise. > * guix/scripts/lint.scm (probe-uri): Likewise. > --- > > Guix, > > There are three (that I know of) hard-coded lists of HTTP redirect status > codes in Guix. All were different, and all were incomplete. > > This patch doesn't address the duplication, but does add all missing > codes. Specifically the newer HTTP/1.1 codes, including 303 =E2=80=98See = Other=E2=80=99. > It's not strictly a plain redirect, but used as such in the wild[1], and > treating it as such is probably enough for our purposes. > > This allows at least lightdm-gtk-greeter to be built again. Why its > sources waren't mirrored to begin with I do not know, nor did I check. Good catch, go for it! As a followup, we should look into merging the two =E2=80=98http-fetch=E2= =80=99 procedures. I don=E2=80=99t think the initial motivation for having two separate implementations still holds. Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 05 12:19:53 2017 Received: (at 28262-done) by debbugs.gnu.org; 5 Sep 2017 16:19:53 +0000 Received: from localhost ([127.0.0.1]:51665 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpGZs-0008BL-RI for submit@debbugs.gnu.org; Tue, 05 Sep 2017 12:19:52 -0400 Received: from tobias.gr ([51.15.135.5]:42072) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dpGZq-0008BA-H5 for 28262-done@debbugs.gnu.org; Tue, 05 Sep 2017 12:19:51 -0400 Received: by tobias.gr (OpenSMTPD) with ESMTP id 99158b9f; Tue, 5 Sep 2017 16:19:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=tobias.gr; h=subject:to :cc:references:from:message-id:date:mime-version:in-reply-to :content-type:content-transfer-encoding; s=201706; bh=ou8WjD2x75 tjKOwdCPtHunZCeLD5rU/iWl8QdRmdWe4=; b=gJV7b8YWXZu/d/TCnytfOB0LN1 z/BlHJ+lIuGw2XxEMsL+LsQQEuFS0wTgJ8XD37/RkC0ZDA9aJplJ/LvGaRhau1hK TTUutVzM23fw8BvpZjgX/KdFgwUo21C3N/Jp1M/BdvTGRlwpKtlEeympV3Dre7oJ VaBaYTRqkhy2zGgZF2Xn1Sr9Tpx0Aq1+IHMLjkIHBkQ9As/kGX2v/+v10XSP8JQs VbGgcvXIy/1I5kCaMUYcD/gLnYAseX6X4m2JZfiKpRe3HiQ4mtSpURDCqLxQY2Ec syn6WCoR4nwnQggZzpvFiXCdTcUUOZJ3vef4R8KQIdWv0t7BXp3H8SioyJFQ== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 9370ccf1 (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128:NO); Tue, 5 Sep 2017 16:19:46 +0000 (UTC) Subject: Re: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere. To: ludo@gnu.org References: <20170828134610.30984-1-me@tobias.gr> <871snrsx1n.fsf@gnu.org> From: Tobias Geerinckx-Rice Message-ID: <59e6850f-250d-6f21-ee49-78da1145b338@tobias.gr> Date: Tue, 5 Sep 2017 18:21:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <871snrsx1n.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28262-done Cc: 28262-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) Ludo', Ludovic Courtès wrote on 31/08/17 at 15:10: > Actually guix/build/download.scm. Thanks! > As a followup, we should look into merging the two ‘http-fetch’ > procedures. I don’t think the initial motivation for having two > separate implementations still holds. I'll push this fix and close this bug, but if you have the time I'd love to know more about that initial motivation. The two have grown quite apart. > Tobias Geerinckx-Rice skribis: >> Specifically the newer HTTP/1.1 codes I wrote that? Great. Now I feel old. Kind regards, T G-R From debbugs-submit-bounces@debbugs.gnu.org Thu Sep 07 05:43:20 2017 Received: (at 28262-done) by debbugs.gnu.org; 7 Sep 2017 09:43:20 +0000 Received: from localhost ([127.0.0.1]:53827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dptLE-0007BY-J3 for submit@debbugs.gnu.org; Thu, 07 Sep 2017 05:43:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47069) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dptLD-0007BM-RJ for 28262-done@debbugs.gnu.org; Thu, 07 Sep 2017 05:43:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dptL3-0001P9-Sw for 28262-done@debbugs.gnu.org; Thu, 07 Sep 2017 05:43:14 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49118) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dptL3-0001P4-Q2; Thu, 07 Sep 2017 05:43:09 -0400 Received: from [193.50.110.57] (port=54978 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dptL3-0001A7-42; Thu, 07 Sep 2017 05:43:09 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Tobias Geerinckx-Rice Subject: Re: [bug#28262] [PATCH] Handle the same HTTP redirects everywhere. References: <20170828134610.30984-1-me@tobias.gr> <871snrsx1n.fsf@gnu.org> <59e6850f-250d-6f21-ee49-78da1145b338@tobias.gr> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 21 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Thu, 07 Sep 2017 11:43:07 +0200 In-Reply-To: <59e6850f-250d-6f21-ee49-78da1145b338@tobias.gr> (Tobias Geerinckx-Rice's message of "Tue, 5 Sep 2017 18:21:36 +0200") Message-ID: <87o9qmyhck.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28262-done Cc: 28262-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, Tobias Geerinckx-Rice skribis: >> As a followup, we should look into merging the two =E2=80=98http-fetch= =E2=80=99 >> procedures. I don=E2=80=99t think the initial motivation for having two >> separate implementations still holds. > > I'll push this fix and close this bug, but if you have the time I'd love > to know more about that initial motivation. The two have grown quite apar= t. Initially (guix http-client) existed simply to paper over API changes in Guile=E2=80=99s (web client) and to work around bugs in older Guile version. This is because (guix http-client) is used on the =E2=80=9Chost=E2=80=9D si= de, where we support(ed) older releases of Guile 2.0. (guix build download) didn=E2=80=99t really have this constraint because the Guile used on the =E2=80=9Cbuild=E2=80=9D side was known, and known to be r= ecent enough in most cases. So all it did was to add a higher-level API above what Guile provides, which follows redirects, etc. Since 36626c556ed75219bce196ac93d148f6b9af984c we require Guile >=3D 2.0.9, so some of the bugs/workarounds we had no longer apply and the separation probably no longer makes sense. HTH! Ludo=E2=80=99. From unknown Mon Jun 16 23:48:56 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator