GNU bug report logs - #28258
26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28258: closed (26.0.50; [PATCH] Let file-name-base succeed
 when buffer-file-name is nil)
Date: Sun, 24 Sep 2017 08:08:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sun, 24 Sep 2017 08:07:18 +0000
with message-id <CAArVCkRmgdb5j5GvM31pTg6uYdfsMZhFRDNuUmtiY-Dhir31kQ <at> mail.gmail.com>
and subject line Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil
has caused the debbugs.gnu.org bug report #28258,
regarding 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28258: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28258
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Mohammed Sadiq <sadiq <at> sadiqpk.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50;
 [PATCH] Let file-name-base succeed when buffer-file-name is nil
Date: Mon, 28 Aug 2017 07:52:22 +0530

[Message part 3 (text/plain, inline)]

Let file-name-base succeed when buffer-file-name is nil.

Hi. This is my first patch to GNU Emacs. Please let me know if it is
sensible or not.

Thanks

[0001-Let-file-name-base-succeed-when-buffer-file-name-is-.patch (text/x-diff, inline)]

From efb4f12c9083ad3930eaf5da8929d4e6b33609eb Mon Sep 17 00:00:00 2001
From: "Mohammed Sadik P. K" <sadiq <at> sadiqpk.org>
Date: Mon, 28 Aug 2017 07:34:25 +0530
Subject: [PATCH] Let file-name-base succeed when buffer-file-name is nil

FILENAME is an optional argument for file-name-base.  So it shouldn't
fail when no filename is associated with current buffer.

* lisp/files.el (file-name-base): Don't fail when buffer-file-name
is nil.
---
 lisp/files.el | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/lisp/files.el b/lisp/files.el
index 872fc46e87..d75d402545 100644
--- a/lisp/files.el
+++ b/lisp/files.el
@@ -4467,8 +4467,9 @@ file-name-extension
 (defun file-name-base (&optional filename)
   "Return the base name of the FILENAME: no directory, no extension.
 FILENAME defaults to `buffer-file-name'."
-  (file-name-sans-extension
-   (file-name-nondirectory (or filename (buffer-file-name)))))
+  (let ((filename (or filename (buffer-file-name))))
+    (and filename
+        (file-name-sans-extension (file-name-nondirectory filename)))))
 
 (defcustom make-backup-file-name-function
   #'make-backup-file-name--default-function
-- 
2.11.0

[Message part 5 (text/plain, inline)]

In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-08-27 built on rose
Repository revision: 853ed4533bbddf16c50ad12ed1db70fa252715fb
Windowing system distributor 'The X.Org Foundation', version 11.0.11902000
System Description:	Debian GNU/Linux 9.1 (stretch)

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.
Making completion list...
delete-backward-char: Text is read-only

Configured features:
XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY
ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB
TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD

Important settings:
  value of $LC_MONETARY: en_GB.UTF-8
  value of $LC_NUMERIC: en_GB.UTF-8
  value of $LC_TIME: en_GB.UTF-8
  value of $LANG: en_US.UTF-8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv
bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs
format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg
epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode
mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047
rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date
mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page menu-bar
rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock
syntax facemenu font-core term/tty-colors frame cl-generic cham georgian
utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean
japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european
ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer
cl-preloaded nadvice loaddefs button faces cus-face macroexp files
text-properties overlay sha1 md5 base64 format env code-pages mule
custom widget hashtable-print-readable backquote dbusbind inotify
dynamic-setting system-font-setting font-render-setting move-toolbar gtk
x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 95499 5650)
 (symbols 48 20292 1)
 (miscs 40 43 93)
 (strings 32 28804 1235)
 (string-bytes 1 763186)
 (vectors 16 14660)
 (vector-slots 8 492593 5734)
 (floats 8 49 67)
 (intervals 56 217 0)
 (buffers 992 12))

[Message part 6 (message/rfc822, inline)]

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Glenn Morris <rgm <at> gnu.org>, 28258-done <at> debbugs.gnu.org
Cc: Mohammed Sadiq <sadiq <at> sadiqpk.org>
Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when
 buffer-file-name is nil
Date: Sun, 24 Sep 2017 08:07:18 +0000

[Message part 7 (text/plain, inline)]

Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Di., 19. Sep. 2017 um
10:46 Uhr:

> Philipp Stephani <p.stephani2 <at> gmail.com> schrieb am Di., 19. Sep. 2017 um
> 10:31 Uhr:
>
>> Glenn Morris <rgm <at> gnu.org> schrieb am Di., 19. Sep. 2017 um 02:41 Uhr:
>>
>>>
>>> > I do agree that the calling convention of `file-name-base' is odd. How
>>> > about making the argument mandatory (initially only by changing the
>>> > advertised calling convention and the docstring)?
>>>
>>> Sounds good to me.
>>>
>>
>> OK, here's a patch.
>>
>
> New version of the patch, with all callers and the manual fixed.
>

Pushed to master as 1eb4e5c3c8.

[Message part 8 (text/html, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.