From unknown Sat Jun 14 00:06:05 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28258 <28258@debbugs.gnu.org> To: bug#28258 <28258@debbugs.gnu.org> Subject: Status: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil Reply-To: bug#28258 <28258@debbugs.gnu.org> Date: Sat, 14 Jun 2025 07:06:05 +0000 retitle 28258 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-= name is nil reassign 28258 emacs submitter 28258 Mohammed Sadiq severity 28258 wishlist tag 28258 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 22:23:12 2017 Received: (at submit) by debbugs.gnu.org; 28 Aug 2017 02:23:12 +0000 Received: from localhost ([127.0.0.1]:58488 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dm9hn-00029a-UY for submit@debbugs.gnu.org; Sun, 27 Aug 2017 22:23:12 -0400 Received: from eggs.gnu.org ([208.118.235.92]:54708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dm9hm-00029O-Kd for submit@debbugs.gnu.org; Sun, 27 Aug 2017 22:23:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dm9hg-0006VG-F2 for submit@debbugs.gnu.org; Sun, 27 Aug 2017 22:23:05 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41967) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dm9hg-0006Uv-Am for submit@debbugs.gnu.org; Sun, 27 Aug 2017 22:23:04 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45677) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dm9he-0006i8-Ra for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 22:23:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dm9hb-0006Nu-LI for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 22:23:02 -0400 Received: from us2-ob3-3.mailhostbox.com ([208.91.199.218]:49177) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dm9hb-0006J9-Be for bug-gnu-emacs@gnu.org; Sun, 27 Aug 2017 22:22:59 -0400 Received: from rose (unknown [117.249.176.225]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sadiq@sadiqpk.org) by us2.outbound.mailhostbox.com (Postfix) with ESMTPSA id 7A99CCA9C2 for ; Mon, 28 Aug 2017 02:22:42 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sadiqpk.org; s=20160628; t=1503886963; bh=vnOzE56j5FEOfUrAE4UXNyGPo/sQXW2cFd4IQXXqPKg=; h=From:To:Subject:Date; b=dLybiYWp9hsmqUkYTROWCKJ4Beq0s7rdfhQ4nBnpw6dGwanmgJLAEb5Y9I+h28RDh uvkVlC6uMdWitXx547fUz8esbfdCLjm0TOZjGuMkhLj1+iV+PT0IKTo1aSAeFy3LPu WQY0GDHLcjMVndo9t/q125pFejwC9jrCuEAb7Zmc= From: Mohammed Sadiq To: bug-gnu-emacs@gnu.org Subject: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil Date: Mon, 28 Aug 2017 07:52:22 +0530 Message-ID: <87k21o8m8x.fsf@rose> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-CMAE-Score: 0 X-CMAE-Analysis: v=2.2 cv=AbTBJzfG c=1 sm=1 tr=0 a=a4xM6SKlOPztAz5wXzXJJw==:117 a=a4xM6SKlOPztAz5wXzXJJw==:17 a=Nx9P28zXeZGLW8zPJyEA:9 a=FkaavPx6D78fk1eNWGUA:9 a=CkxXAERhc60I61HGDTkA:9 a=S0EmJ8sqXQ4rp835:21 a=U5kSAaI0ZLpVI0xp:21 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --=-=-= Content-Type: text/plain Let file-name-base succeed when buffer-file-name is nil. Hi. This is my first patch to GNU Emacs. Please let me know if it is sensible or not. Thanks --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-Let-file-name-base-succeed-when-buffer-file-name-is-.patch Content-Description: Let file-name-base succeed when buffer-file-name is nil >From efb4f12c9083ad3930eaf5da8929d4e6b33609eb Mon Sep 17 00:00:00 2001 From: "Mohammed Sadik P. K" Date: Mon, 28 Aug 2017 07:34:25 +0530 Subject: [PATCH] Let file-name-base succeed when buffer-file-name is nil FILENAME is an optional argument for file-name-base. So it shouldn't fail when no filename is associated with current buffer. * lisp/files.el (file-name-base): Don't fail when buffer-file-name is nil. --- lisp/files.el | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lisp/files.el b/lisp/files.el index 872fc46e87..d75d402545 100644 --- a/lisp/files.el +++ b/lisp/files.el @@ -4467,8 +4467,9 @@ file-name-extension (defun file-name-base (&optional filename) "Return the base name of the FILENAME: no directory, no extension. FILENAME defaults to `buffer-file-name'." - (file-name-sans-extension - (file-name-nondirectory (or filename (buffer-file-name))))) + (let ((filename (or filename (buffer-file-name)))) + (and filename + (file-name-sans-extension (file-name-nondirectory filename))))) (defcustom make-backup-file-name-function #'make-backup-file-name--default-function -- 2.11.0 --=-=-= Content-Type: text/plain In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-08-27 built on rose Repository revision: 853ed4533bbddf16c50ad12ed1db70fa252715fb Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9.1 (stretch) Recent messages: For information about GNU Emacs and the GNU system, type C-h C-a. Making completion list... delete-backward-char: Text is read-only Configured features: XPM JPEG TIFF GIF PNG RSVG IMAGEMAGICK SOUND GPM DBUS GSETTINGS NOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE M17N_FLT LIBOTF XFT ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 LIBSYSTEMD Important settings: value of $LC_MONETARY: en_GB.UTF-8 value of $LC_NUMERIC: en_GB.UTF-8 value of $LC_TIME: en_GB.UTF-8 value of $LANG: en_US.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message subr-x puny seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib dired dired-loaddefs format-spec rfc822 mml easymenu mml-sec password-cache epa derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils elec-pair time-date mule-util tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray minibuffer cl-preloaded nadvice loaddefs button faces cus-face macroexp files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote dbusbind inotify dynamic-setting system-font-setting font-render-setting move-toolbar gtk x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 95499 5650) (symbols 48 20292 1) (miscs 40 43 93) (strings 32 28804 1235) (string-bytes 1 763186) (vectors 16 14660) (vector-slots 8 492593 5734) (floats 8 49 67) (intervals 56 217 0) (buffers 992 12)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 11:55:17 2017 Received: (at 28258) by debbugs.gnu.org; 29 Aug 2017 15:55:17 +0000 Received: from localhost ([127.0.0.1]:60881 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmirF-00017G-2z for submit@debbugs.gnu.org; Tue, 29 Aug 2017 11:55:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36301) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmirC-00016y-D2 for 28258@debbugs.gnu.org; Tue, 29 Aug 2017 11:55:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmir6-0003X3-6K for 28258@debbugs.gnu.org; Tue, 29 Aug 2017 11:55:09 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:42880) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmiqv-0003Ne-6A; Tue, 29 Aug 2017 11:54:57 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dmiqt-0004Nw-D5; Tue, 29 Aug 2017 11:54:55 -0400 From: Glenn Morris To: Mohammed Sadiq Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil References: <87k21o8m8x.fsf@rose> X-Spook: Drug war ARPA Legion of Doom 22nd SAS Zachawi ASPIC Mena X-Ran: Y`@|Em`H~U6=Ri.()yO=^K3O;[C0l_$O|9=mB^)90H[w-3VO]{y/Q4UQW[.78I")94cHCL X-Hue: brightblue X-Debbugs-No-Ack: yes X-Attribution: GM Date: Tue, 29 Aug 2017 11:54:55 -0400 In-Reply-To: <87k21o8m8x.fsf@rose> (Mohammed Sadiq's message of "Mon, 28 Aug 2017 07:52:22 +0530") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mohammed Sadiq wrote: > * lisp/files.el (file-name-base): Don't fail when buffer-file-name > is nil. [...] > --- a/lisp/files.el > +++ b/lisp/files.el > @@ -4467,8 +4467,9 @@ file-name-extension > (defun file-name-base (&optional filename) > "Return the base name of the FILENAME: no directory, no extension. > FILENAME defaults to `buffer-file-name'." > - (file-name-sans-extension > - (file-name-nondirectory (or filename (buffer-file-name))))) > + (let ((filename (or filename (buffer-file-name)))) > + (and filename > + (file-name-sans-extension (file-name-nondirectory filename))))) Hi, and thanks for the patch. IIUC: file-name-base currently errors when called with no applicable file name, and you want it to instead return nil? This seems rather unusual for an Emacs file-related function. I would have thought this unlikely to be applied, but maybe you could explain why you want it? From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 12:10:34 2017 Received: (at 28258) by debbugs.gnu.org; 29 Aug 2017 16:10:34 +0000 Received: from localhost ([127.0.0.1]:60900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmj62-0003KE-F0 for submit@debbugs.gnu.org; Tue, 29 Aug 2017 12:10:34 -0400 Received: from us2-ob1-4.mailhostbox.com ([162.210.70.57]:47745) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmj60-0003K6-B6 for 28258@debbugs.gnu.org; Tue, 29 Aug 2017 12:10:33 -0400 Received: from 172.16.214.65 (unknown [172.16.214.65]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: sadiq@sadiqpk.org) by us2.outbound.mailhostbox.com (Postfix) with ESMTPSA id 759F1180975; Tue, 29 Aug 2017 16:10:31 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sadiqpk.org; s=20160628; t=1504023031; bh=9MTvBTPOQFuRrwh+YoDXYkU2wTdcI2NWp40GP6N7mxA=; h=Date:From:To:Cc:In-Reply-To:References:Subject; b=XGgchC3MuaPyvwHPrHruK4iTXHfUaqDB9B0MsuPrdPSdCJxO4JtsevGUSOpCthkUt r17ghGTs8Y8LhF+mquCXG8KNKwtWuIEWDlPvvKS9///1ZKuFvh0WlWHABDQXXfj6/s J6w+SzzFT57KpGQ8HoGJgKK4nGck4miiIcHSgMP8= Date: Tue, 29 Aug 2017 21:40:31 +0530 (IST) From: Mohammed Sadiq To: Glenn Morris Message-ID: <1188947996.68721.1504023031457@webmail.mailhostbox.com> In-Reply-To: References: <87k21o8m8x.fsf@rose> Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Priority: 3 Importance: Medium X-Mailer: Open-Xchange Mailer v7.8.3-Rev22 X-Originating-Client: open-xchange-appsuite X-CMAE-Score: 0 X-CMAE-Analysis: v=2.2 cv=Z6GcJDZA c=1 sm=1 tr=0 a=nf9kGWJ/Yk0yo5ZsUxXxOw==:117 a=IkcTkHD0fZMA:10 a=f7P9GQdqspX4-Ohf0dcA:9 a=QEXdDO2ut3YA:10 X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) > On August 29, 2017 at 9:24 PM Glenn Morris wrote: > Hi, and thanks for the patch. > IIUC: file-name-base currently errors when called with no applicable > file name, and you want it to instead return nil? This seems rather > unusual for an Emacs file-related function. I would have thought this > unlikely to be applied, but maybe you could explain why you want it? The signature of `file-name-base' is (file-name-base &optional FILENAME). That is, the FILENAME argument is optional. So I believe it shouldn't be an error to not give the optional argument. And so calling the function in a buffer with no file associated shouldn't be an error. I'm not sure if my assertion is right. Feel free to do what it is felt to be right. :) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 29 13:02:56 2017 Received: (at 28258) by debbugs.gnu.org; 29 Aug 2017 17:02:56 +0000 Received: from localhost ([127.0.0.1]:60960 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmjui-0006Q7-LP for submit@debbugs.gnu.org; Tue, 29 Aug 2017 13:02:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36761) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dmjuf-0006Pt-Mi for 28258@debbugs.gnu.org; Tue, 29 Aug 2017 13:02:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dmjuV-0007lA-3Y for 28258@debbugs.gnu.org; Tue, 29 Aug 2017 13:02:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44897) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dmjuJ-0007gQ-O8; Tue, 29 Aug 2017 13:02:31 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dmjuJ-0001NK-D5; Tue, 29 Aug 2017 13:02:31 -0400 From: Glenn Morris To: Mohammed Sadiq Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> X-Spook: Attorney General e-cash Bacteria Toxic Al-Qaeda Brush X-Ran: r4kk@g?X4z!/dU^~5BQ5Xn_gxL_?TE#w&IH3yiR (Mohammed Sadiq's message of "Tue, 29 Aug 2017 21:40:31 +0530 (IST)") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Mohammed Sadiq wrote: >> IIUC: file-name-base currently errors when called with no applicable >> file name, and you want it to instead return nil? This seems rather >> unusual for an Emacs file-related function. I would have thought this >> unlikely to be applied, but maybe you could explain why you want it? > > The signature of `file-name-base' is (file-name-base &optional FILENAME). > That is, the FILENAME argument is optional. So I believe it shouldn't > be an error to not give the optional argument. And so calling the function > in a buffer with no file associated shouldn't be an error. I'm not sure > if my assertion is right. Thanks for explaining. I don't think I agree, but then the fact that the argument is optional and defaults to buffer-file-name also seems atypical to me (eg I don't think any other file-name- functions behaves like that). Let's wait and see if anyone else feels strongly one way or the other. From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 13:12:56 2017 Received: (at 28258) by debbugs.gnu.org; 18 Sep 2017 17:12:56 +0000 Received: from localhost ([127.0.0.1]:46738 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtzbM-0002BK-9l for submit@debbugs.gnu.org; Mon, 18 Sep 2017 13:12:56 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:44572) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dtzbK-0002B6-5C for 28258@debbugs.gnu.org; Mon, 18 Sep 2017 13:12:54 -0400 Received: by mail-io0-f179.google.com with SMTP id v36so3851023ioi.1 for <28258@debbugs.gnu.org>; Mon, 18 Sep 2017 10:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gAkLfqGy76O5Rs+qqAsHxl+eDheHpZ435V9VPedb9mM=; b=q/8J8NEdb8CMMV8CMTm6IUoTtL1nb+gHSjb4i/kTLmh79MqVeXcae6oUNi1FArV3Ia bdu7rlwDVlNwtzUd3fCpK3FsGJTQm39FisoSgN0DjSmFSAbDyQIHMsFBc8IPFnAAgsmm lacif4XxlcmDhPIBCQKoJ9jddLVXrKemHDfojDBA2aH4Dkrmlsh1MEpgsnnuM4RTTm3j w6m/ML6qXazFPu+EMdRdMl1o2/WH5v21dfrZiTcGuH+AyrejJbcXGJZTNmLmAy3bIX/z fIQFZIxbVfjkbqt0OcSu/y1/0xeeQmb8Fe+FMpFpKTRSZybQHbnL0xTuYPEQznwXnpyq sHjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gAkLfqGy76O5Rs+qqAsHxl+eDheHpZ435V9VPedb9mM=; b=sXVNUdcMs14+TWQT/sjq2mn7ziTO4YeBaDSwrr9RfzXNfK+xIC5aqmvpVMZtZcC/sz /inoh5lZdOxF56sYbl0XSR2xZFrOMiMUK3VwaghigUHuT2U92nV0p5QI5lnYYkXHOymA tklIfVIY/qxt4sRTYoWw+ZYMmlDRvZZeGNxhd3sGqmcfWJM6jyegyZDak6vXNe3gqH6N xQcRuLZ+l2NOhlNNi5q0QtyQVjNZv1BqVpMccwE6lIGXtnHoL5wKumBBJiQ9gXXDTnT8 4A+7LytiYmrHZ2W6pdr9aY6TwMpJ/j2L0iAGmrHdPkqjCB1oG7zh0BvknhdOgE5HcSoZ X8AA== X-Gm-Message-State: AHPjjUivNaIxOU4obkl35vZ0Onani5Cj1+QxitT+Ltx5SSFcj8RiGKUz oElvYCSKuidJo08j5rWf5mkjVTVfl4x/LtToNZ0= X-Google-Smtp-Source: AOwi7QDETW1n+5TohKl3Tr9E/JeFGkv/79HUHsqhUDj26Z6B5sOmGEEoZ8Cxf0U8fnR+p6E32ssOgGV5sxEcP88FdII= X-Received: by 10.202.66.196 with SMTP id p187mr11062301oia.52.1505754767327; Mon, 18 Sep 2017 10:12:47 -0700 (PDT) MIME-Version: 1.0 References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> In-Reply-To: From: Philipp Stephani Date: Mon, 18 Sep 2017 17:12:36 +0000 Message-ID: Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil To: Glenn Morris , Mohammed Sadiq Content-Type: multipart/alternative; boundary="001a113d688c068537055979da8a" X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --001a113d688c068537055979da8a Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Di., 29. Aug. 2017 um 19:03 Uhr: > Mohammed Sadiq wrote: > > >> IIUC: file-name-base currently errors when called with no applicable > >> file name, and you want it to instead return nil? This seems rather > >> unusual for an Emacs file-related function. I would have thought this > >> unlikely to be applied, but maybe you could explain why you want it? > > > > The signature of `file-name-base' is (file-name-base &optional FILENAME). > > That is, the FILENAME argument is optional. So I believe it shouldn't > > be an error to not give the optional argument. And so calling the > function > > in a buffer with no file associated shouldn't be an error. I'm not sure > > if my assertion is right. > > Thanks for explaining. I don't think I agree, but then the fact that the > argument is optional and defaults to buffer-file-name also seems > atypical to me (eg I don't think any other file-name- functions behaves > like that). Let's wait and see if anyone else feels strongly one way or > the other. > > > > Changing from raising an error to returning nil is a breaking change: callers currently can rely on the return value being never nil, and can rely on errors being raised. Changing this would break these assumptions. Even ignoring that, I think raising an error is the right thing to do: unless given a filename, the function can't fulfil its promise, and raising an error is the most appropriate reaction to this. (There are already way too many Elisp functions that silently ignore errorneous situations.) I do agree that the calling convention of `file-name-base' is odd. How about making the argument mandatory (initially only by changing the advertised calling convention and the docstring)? --001a113d688c068537055979da8a Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Di= ., 29. Aug. 2017 um 19:03=C2=A0Uhr:
Mohammed Sadiq wrote:

>> IIUC: file-name-base currently errors when called with no applicab= le
>> file name, and you want it to instead return nil? This seems rathe= r
>> unusual for an Emacs file-related function. I would have thought t= his
>> unlikely to be applied, but maybe you could explain why you want i= t?
>
> The signature of `file-name-base' is (file-name-base &optional= FILENAME).
> That is, the FILENAME argument is optional. So I believe it shouldn= 9;t
> be an error to not give the optional argument. And so calling the func= tion
> in a buffer with no file associated shouldn't be an error. I'm= not sure
> if my assertion is right.

Thanks for explaining. I don't think I agree, but then the fact that th= e
argument is optional and defaults to buffer-file-name also seems
atypical to me (eg I don't think any other file-name- functions behaves=
like that). Let's wait and see if anyone else feels strongly one way or=
the other.




Changing from raising an error to retu= rning nil is a breaking change: callers currently can rely on the return va= lue being never nil, and can rely on errors being raised. Changing this wou= ld break these assumptions.
Even ignoring that, I think raising a= n error is the right thing to do: unless given a filename, the function can= 't fulfil its promise, and raising an error is the most appropriate rea= ction to this. (There are already way too many Elisp functions that silentl= y ignore errorneous situations.)
I do agree that the calling conv= ention of `file-name-base' is odd. How about making the argument mandat= ory (initially only by changing the advertised calling convention and the d= ocstring)?
--001a113d688c068537055979da8a-- From debbugs-submit-bounces@debbugs.gnu.org Mon Sep 18 20:42:10 2017 Received: (at 28258) by debbugs.gnu.org; 19 Sep 2017 00:42:10 +0000 Received: from localhost ([127.0.0.1]:47008 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6c6-0001ZV-Fm for submit@debbugs.gnu.org; Mon, 18 Sep 2017 20:42:10 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1du6c5-0001ZC-0R for 28258@debbugs.gnu.org; Mon, 18 Sep 2017 20:42:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1du6bz-0006vN-2I for 28258@debbugs.gnu.org; Mon, 18 Sep 2017 20:42:03 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58936) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1du6bp-0006p3-1n; Mon, 18 Sep 2017 20:41:53 -0400 Received: from rgm by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1du6bo-0002dB-KB; Mon, 18 Sep 2017 20:41:52 -0400 From: Glenn Morris To: Philipp Stephani Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> X-Spook: Bomb threat Contamination Exon Shell CESID Public Health X-Ran: *ke1H!:nh(3<8uY5z$1q`Dk""}Y?SsQ;Vf/2et4T*Nns93JC^c>BAgEfq&h0/? X-Hue: black X-Debbugs-No-Ack: yes X-Attribution: GM Date: Mon, 18 Sep 2017 20:41:52 -0400 In-Reply-To: (Philipp Stephani's message of "Mon, 18 Sep 2017 17:12:36 +0000") Message-ID: User-Agent: Gnus (www.gnus.org), GNU Emacs (www.gnu.org/software/emacs/) MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org, Mohammed Sadiq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Philipp Stephani wrote: > Changing from raising an error to returning nil is a breaking change: > callers currently can rely on the return value being never nil, and can > rely on errors being raised. Changing this would break these assumptions. > Even ignoring that, I think raising an error is the right thing to do: > unless given a filename, the function can't fulfil its promise, and raising > an error is the most appropriate reaction to this. (There are already way > too many Elisp functions that silently ignore errorneous situations.) I think you've summarized things very well. > I do agree that the calling convention of `file-name-base' is odd. How > about making the argument mandatory (initially only by changing the > advertised calling convention and the docstring)? Sounds good to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 19 04:31:48 2017 Received: (at 28258) by debbugs.gnu.org; 19 Sep 2017 08:31:48 +0000 Received: from localhost ([127.0.0.1]:47221 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duDwa-000853-FW for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:31:48 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:51181) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duDwY-0007yW-7z for 28258@debbugs.gnu.org; Tue, 19 Sep 2017 04:31:46 -0400 Received: by mail-io0-f173.google.com with SMTP id w94so8196158ioi.7 for <28258@debbugs.gnu.org>; Tue, 19 Sep 2017 01:31:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JTw897Xku9RwqZu5yd/LTAmM7Y+GlVBcvXL3arxI/rU=; b=nIWTuPmNHgq0TvPLH1oT/7tVwr9f1/3X4ITBkD0ggWS7SVK86yYuYLxUbnxqfkMVYP yubKwg8Mkl0qbZwzMz6Z3T3zpd8RPXlCtXCoCNiUlpEfGVbAYIuDc7EuDfWia/UGNr1g Vv1ZSM05rLMbTAH0yygvmv57E4Nzy62pDgy5kmA4TdPu+PKluIg1Xehpy9ByiMb01pKH 94/sas5Nh2aeGAAdQ+NwtQ6VsM066zaG+88akINjWBeQxcrxyiykWD1DTmoda6kFO3Ye SxfmrOhhg5kVkryHJTuH9hYKfY85ZfLKlgsBU8vFSh5Jee3GZ7CILbsMU6PG71D6lufS 0UZQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JTw897Xku9RwqZu5yd/LTAmM7Y+GlVBcvXL3arxI/rU=; b=UvCxhaP104BHxwil2kFIutZ4BDgbwhqQJwtO9v+1/OYbrnEXUTStRH8XGFKSFDO20p 3UnEqwVPrx0YE4BuKlJ5SVqM5iBxmbKMpVDigevOXVJssdtf7m4QwJYwBUDyQdwBUT7j PM0XLPdSZCYyVtgpZ8A2MvhPBVhQJFX1nu9tj97ueA7Kg3CefnYA3++tPhFfCwGrtBjf X1/DrsJOlNgG9mIYC5kf1NrzTS8Cg4LZAgb501UGEG7qmpcy2Dirf+WzGD4BjARKMXE1 zl/xR2yijEs5BFyHRkBoq5LQzlP6RaDoPcvWd79WtIg/gMuhpmNBMso+kc48tEl4Waxv Sd4Q== X-Gm-Message-State: AHPjjUgREK5XCE76uOAzVkyLQ6ik6xOPDJdRNN1LhjPJL8tO0Tb2oPix ZvYZ68KXn1LVOonY9QYRrnpbRxN7awmR3zru2Q8= X-Google-Smtp-Source: AOwi7QBdetN5B97Pp1Mq+LDTseL2ytC183Z1GNxrveG2R3FaPUhigo1l730tW70gCo/S7t/3hosK5/mJxD9acWwzaQo= X-Received: by 10.202.81.138 with SMTP id f132mr560177oib.273.1505809900447; Tue, 19 Sep 2017 01:31:40 -0700 (PDT) MIME-Version: 1.0 References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> In-Reply-To: From: Philipp Stephani Date: Tue, 19 Sep 2017 08:31:29 +0000 Message-ID: Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil To: Glenn Morris Content-Type: multipart/mixed; boundary="001a113b1160374ecc055986b0dd" X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org, Mohammed Sadiq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --001a113b1160374ecc055986b0dd Content-Type: multipart/alternative; boundary="001a113b1160374ec6055986b0db" --001a113b1160374ec6055986b0db Content-Type: text/plain; charset="UTF-8" Glenn Morris schrieb am Di., 19. Sep. 2017 um 02:41 Uhr: > > > I do agree that the calling convention of `file-name-base' is odd. How > > about making the argument mandatory (initially only by changing the > > advertised calling convention and the docstring)? > > Sounds good to me. > OK, here's a patch. --001a113b1160374ec6055986b0db Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Glenn = Morris <rgm@gnu.org> schrieb am Di= ., 19. Sep. 2017 um 02:41=C2=A0Uhr:

> I do agree that the calling convention of `file-name-base' is odd.= How
> about making the argument mandatory (initially only by changing the > advertised calling convention and the docstring)?

Sounds good to me.

OK, here's a pat= ch.=C2=A0
--001a113b1160374ec6055986b0db-- --001a113b1160374ecc055986b0dd Content-Type: text/plain; charset="US-ASCII"; name="0001-lisp-files.el-file-name-base-Make-FILENAME-argument-ma.txt" Content-Disposition: attachment; filename="0001-lisp-files.el-file-name-base-Make-FILENAME-argument-ma.txt" Content-Transfer-Encoding: base64 Content-ID: <15e99437c614392b6bc1> X-Attachment-Id: 15e99437c614392b6bc1 RnJvbSA4YWI2NmI1NGFmZGMwMmFjYTkwYTRjNTFhNDI2MjA1YWMwMjRmZjA1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFR1ZSwgMTkgU2VwIDIwMTcgMTA6Mjk6NDIgKzAyMDAKU3ViamVjdDogW1BBVENIXSAqIGxp c3AvZmlsZXMuZWwgKGZpbGUtbmFtZS1iYXNlKTogTWFrZSBGSUxFTkFNRSBhcmd1bWVudAogbWFu ZGF0b3J5LgoKLS0tCiBldGMvTkVXUyAgICAgIHwgMyArKysKIGxpc3AvZmlsZXMuZWwgfCA0ICsr LS0KIDIgZmlsZXMgY2hhbmdlZCwgNSBpbnNlcnRpb25zKCspLCAyIGRlbGV0aW9ucygtKQoKZGlm ZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MKaW5kZXggMzcxY2RmNjg2Yy4uZGU5M2FlODRm YSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIvZXRjL05FV1MKQEAgLTQzLDYgKzQzLDkgQEAg V2hlbiB5b3UgYWRkIGEgbmV3IGl0ZW0sIHVzZSB0aGUgYXBwcm9wcmlhdGUgbWFyayBpZiB5b3Ug YXJlIHN1cmUgaXQgYXBwbGllcywKIAwKICogSW5jb21wYXRpYmxlIExpc3AgQ2hhbmdlcyBpbiBF bWFjcyAyNy4xCiAKKyoqIFRoZSBGSUxFTkFNRSBhcmd1bWVudCB0byAnZmlsZS1uYW1lLWJhc2Un IGlzIG5vdyBtYW5kYXRvcnkgYW5kIG5vCitsb25nZXIgZGVmYXVsdHMgdG8gJ2J1ZmZlci1maWxl LW5hbWUnLgorCiAMCiAqIExpc3AgQ2hhbmdlcyBpbiBFbWFjcyAyNy4xCiAKZGlmZiAtLWdpdCBh L2xpc3AvZmlsZXMuZWwgYi9saXNwL2ZpbGVzLmVsCmluZGV4IGM1NWM4MDk3YzEuLmZlN2NiMWE4 YTkgMTAwNjQ0Ci0tLSBhL2xpc3AvZmlsZXMuZWwKKysrIGIvbGlzcC9maWxlcy5lbApAQCAtNDQ3 OSw4ICs0NDc5LDggQEAgZmlsZS1uYW1lLWV4dGVuc2lvbgogICAgICAgICAgICAgIiIpKSkpKQog CiAoZGVmdW4gZmlsZS1uYW1lLWJhc2UgKCZvcHRpb25hbCBmaWxlbmFtZSkKLSAgIlJldHVybiB0 aGUgYmFzZSBuYW1lIG9mIHRoZSBGSUxFTkFNRTogbm8gZGlyZWN0b3J5LCBubyBleHRlbnNpb24u Ci1GSUxFTkFNRSBkZWZhdWx0cyB0byBgYnVmZmVyLWZpbGUtbmFtZScuIgorICAiUmV0dXJuIHRo ZSBiYXNlIG5hbWUgb2YgdGhlIEZJTEVOQU1FOiBubyBkaXJlY3RvcnksIG5vIGV4dGVuc2lvbi4i CisgIChkZWNsYXJlIChhZHZlcnRpc2VkLWNhbGxpbmctY29udmVudGlvbiAoZmlsZW5hbWUpICIy Ny4xIikpCiAgIChmaWxlLW5hbWUtc2Fucy1leHRlbnNpb24KICAgIChmaWxlLW5hbWUtbm9uZGly ZWN0b3J5IChvciBmaWxlbmFtZSAoYnVmZmVyLWZpbGUtbmFtZSkpKSkpCiAKLS0gCjIuMTQuMQoK --001a113b1160374ecc055986b0dd-- From debbugs-submit-bounces@debbugs.gnu.org Tue Sep 19 04:46:49 2017 Received: (at 28258) by debbugs.gnu.org; 19 Sep 2017 08:46:49 +0000 Received: from localhost ([127.0.0.1]:47238 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duEB6-000074-R0 for submit@debbugs.gnu.org; Tue, 19 Sep 2017 04:46:49 -0400 Received: from mail-io0-f178.google.com ([209.85.223.178]:47699) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1duEB5-00006r-0H for 28258@debbugs.gnu.org; Tue, 19 Sep 2017 04:46:47 -0400 Received: by mail-io0-f178.google.com with SMTP id e189so8337464ioa.4 for <28258@debbugs.gnu.org>; Tue, 19 Sep 2017 01:46:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vHTYBauIIU1VkF0R6P4YPBhEe+OoUeOs81Xjl288f9U=; b=ADLoX3b28ujwZLCfvzXVazOa4ZNsnY+XgfM7LHsHecLbKXV8nzoKMG+oW4cEPZ663h 5iL93OoIiwNM65Hjt0m4F9d7IRRaTWP2Z2vUypX2h8SshlkLh1Le6V+cRMK9cLRvaZSu V1phHPqt2KQmhcNXjF742sl+qpR7pIFkjgTUrX1o6fEE31hNauKiSzdPexwfinujp15y /q6XSGYPHOwvRKZO4mokok1GoMMUeBnX5m6D+iWUJf8gUowRV+hkVxUfwrGTTQmaR2Hg +VbyS5bC4WFDtvfoHFWzYpewwyr+2r/SoNBuJD/1KlMSD7NL06w2yk1na54ABb9rnv4N sYYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vHTYBauIIU1VkF0R6P4YPBhEe+OoUeOs81Xjl288f9U=; b=c2r/RR6OR6XTr+xlbGYdxWTQgISsV3kPPaxaOU4KTFtkXzr8bBWcjMGNli6As4tNwS HKWPsDFIUX9M77PSx8oJIOlQ4j4I4H2yLrd4jAA1VyPKh8k8JHW1wGOfSBsgNzKRuVNo HrYt0eoieR6SFJ3BJiCNszmNtWZL/2B69GCOARjxuRojOD3aH+9wUGl7TDCk+ycNaLaL QGt5Q1FcpqhcDsMK21Z5v52Hj/DbetqxNs+qUb1soqLiJQIFsAdP+ifjuTNYn7ZH/RsI iR5VobqrPyP/nRuZTylfySRDKA0XCWXSY/lg1yYhiEuwqij9DBiE1Ippuxl/MZ2u0EZ6 oOIA== X-Gm-Message-State: AHPjjUi51ybO7Vjk1N2NcwwABcttMUbYOitcz1PSQ9B1L92jBClxahD3 v0aRisDBc6nkNtHdLB2XdWfu47vELiqq7fOTqcM= X-Google-Smtp-Source: AOwi7QDLuaY9JcjQNn+p8fO81KEsEhS+7DeTOESjmDbe0uw5m2VzQVCx5Bm+mdz+r0RIlTvKCgd79RiFi6k/DNoOBLU= X-Received: by 10.202.56.214 with SMTP id f205mr600055oia.316.1505810801294; Tue, 19 Sep 2017 01:46:41 -0700 (PDT) MIME-Version: 1.0 References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> In-Reply-To: From: Philipp Stephani Date: Tue, 19 Sep 2017 08:46:30 +0000 Message-ID: Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil To: Glenn Morris Content-Type: multipart/mixed; boundary="001a113ca93ae93169055986e5e3" X-Spam-Score: -2.0 (--) X-Debbugs-Envelope-To: 28258 Cc: 28258@debbugs.gnu.org, Mohammed Sadiq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.0 (--) --001a113ca93ae93169055986e5e3 Content-Type: multipart/alternative; boundary="001a113ca93ae93165055986e5e1" --001a113ca93ae93165055986e5e1 Content-Type: text/plain; charset="UTF-8" Philipp Stephani schrieb am Di., 19. Sep. 2017 um 10:31 Uhr: > Glenn Morris schrieb am Di., 19. Sep. 2017 um 02:41 Uhr: > >> >> > I do agree that the calling convention of `file-name-base' is odd. How >> > about making the argument mandatory (initially only by changing the >> > advertised calling convention and the docstring)? >> >> Sounds good to me. >> > > OK, here's a patch. > New version of the patch, with all callers and the manual fixed. --001a113ca93ae93165055986e5e1 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Di., 19. Sep. 2017 um 10:31=C2=A0Uhr:
Glenn Morris <rgm@gnu.org> schrieb am Di., 19. Sep. 2017 um 02:41=C2=A0Uhr:
<= /div>

> I do agree that the calling convention of `file-name-base' is odd.= How
> about making the argument mandatory (initially only by changing the > advertised calling convention and the docstring)?

Sounds good to me.

OK, here's a patch.=C2=A0

New version of the patch, with all= callers and the manual fixed.=C2=A0
--001a113ca93ae93165055986e5e1-- --001a113ca93ae93169055986e5e3 Content-Type: text/plain; charset="US-ASCII"; name="0001-Make-FILENAME-argument-of-file-name-base-mandatory.txt" Content-Disposition: attachment; filename="0001-Make-FILENAME-argument-of-file-name-base-mandatory.txt" Content-Transfer-Encoding: base64 Content-ID: <15e9951427a62f787891> X-Attachment-Id: 15e9951427a62f787891 RnJvbSA4OWYwMWRhMmFmZDhiNDFmOWFmMzkzN2E4YTE5MDNjNTc5MTZkMTllIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwIFN0ZXBoYW5pIDxwaHN0QGdvb2dsZS5jb20+CkRh dGU6IFR1ZSwgMTkgU2VwIDIwMTcgMTA6Mjk6NDIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBNYWtl IEZJTEVOQU1FIGFyZ3VtZW50IG9mICdmaWxlLW5hbWUtYmFzZScgbWFuZGF0b3J5CgoqIGxpc3Av ZmlsZXMuZWwgKGZpbGUtbmFtZS1iYXNlKTogTWFrZSBGSUxFTkFNRSBhcmd1bWVudCBtYW5kYXRv cnkuCgoqIGxpc3AvYXV0b2luc2VydC5lbCAoYXV0by1pbnNlcnQtYWxpc3QpOgoqIGxpc3AvcHJv Z21vZGVzL2NwZXJsLW1vZGUuZWwgKGNwZXJsLWVsZWN0cmljLXBvZCk6CiogbGlzcC9wcm9nbW9k ZXMvaWRsd2F2ZS5lbCAoaWRsd2F2ZS1wYXJzZS1kZWZpbml0aW9uKToKKiBsaXNwL3RleHRtb2Rl cy9yZWZ0ZXgtcmVmLmVsIChyZWZ0ZXgtcmVwbGFjZS1wcmVmaXgtZXNjYXBlcyk6IEZpeAphbGwg Y2FsbGVycy4KLS0tCiBkb2MvbGlzcHJlZi9maWxlcy50ZXhpICAgICAgIHwgIDQgKy0tLQogZXRj L05FV1MgICAgICAgICAgICAgICAgICAgICB8ICAzICsrKwogbGlzcC9hdXRvaW5zZXJ0LmVsICAg ICAgICAgICB8IDEwICsrKysrLS0tLS0KIGxpc3AvZmlsZXMuZWwgICAgICAgICAgICAgICAgfCAg NCArKy0tCiBsaXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLmVsIHwgIDIgKy0KIGxpc3AvcHJvZ21v ZGVzL2lkbHdhdmUuZWwgICAgfCAgMiArLQogbGlzcC90ZXh0bW9kZXMvcmVmdGV4LXJlZi5lbCB8 ICAyICstCiA3IGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyksIDEzIGRlbGV0aW9ucygt KQoKZGlmZiAtLWdpdCBhL2RvYy9saXNwcmVmL2ZpbGVzLnRleGkgYi9kb2MvbGlzcHJlZi9maWxl cy50ZXhpCmluZGV4IDZiZTk5OGYwYjIuLmU0YTRiZmU1OTggMTAwNjQ0Ci0tLSBhL2RvYy9saXNw cmVmL2ZpbGVzLnRleGkKKysrIGIvZG9jL2xpc3ByZWYvZmlsZXMudGV4aQpAQCAtMjEwNiw3ICsy MTA2LDcgQEAgRmlsZSBOYW1lIENvbXBvbmVudHMKIG5vdCBhbiBleHRlbnNpb24uCiBAZW5kIGRl ZnVuCiAKLUBkZWZ1biBmaWxlLW5hbWUtYmFzZSAmb3B0aW9uYWwgZmlsZW5hbWUKK0BkZWZ1biBm aWxlLW5hbWUtYmFzZSBmaWxlbmFtZQogVGhpcyBmdW5jdGlvbiBpcyB0aGUgY29tcG9zaXRpb24g b2YgQGNvZGV7ZmlsZS1uYW1lLXNhbnMtZXh0ZW5zaW9ufQogYW5kIEBjb2Rle2ZpbGUtbmFtZS1u b25kaXJlY3Rvcnl9LiAgRm9yIGV4YW1wbGUsCiAKQEAgLTIxMTQsOCArMjExNCw2IEBAIEZpbGUg TmFtZSBDb21wb25lbnRzCiAoZmlsZS1uYW1lLWJhc2UgIi9teS9ob21lL2Zvby5jIikKICAgICBA cmVzdWx0e30gImZvbyIKIEBlbmQgZXhhbXBsZQotCi1UaGUgQHZhcntmaWxlbmFtZX0gYXJndW1l bnQgZGVmYXVsdHMgdG8gQGNvZGV7YnVmZmVyLWZpbGUtbmFtZX0uCiBAZW5kIGRlZnVuCiAKIEBu b2RlIFJlbGF0aXZlIEZpbGUgTmFtZXMKZGlmZiAtLWdpdCBhL2V0Yy9ORVdTIGIvZXRjL05FV1MK aW5kZXggMzcxY2RmNjg2Yy4uZGU5M2FlODRmYSAxMDA2NDQKLS0tIGEvZXRjL05FV1MKKysrIGIv ZXRjL05FV1MKQEAgLTQzLDYgKzQzLDkgQEAgV2hlbiB5b3UgYWRkIGEgbmV3IGl0ZW0sIHVzZSB0 aGUgYXBwcm9wcmlhdGUgbWFyayBpZiB5b3UgYXJlIHN1cmUgaXQgYXBwbGllcywKIAwKICogSW5j b21wYXRpYmxlIExpc3AgQ2hhbmdlcyBpbiBFbWFjcyAyNy4xCiAKKyoqIFRoZSBGSUxFTkFNRSBh cmd1bWVudCB0byAnZmlsZS1uYW1lLWJhc2UnIGlzIG5vdyBtYW5kYXRvcnkgYW5kIG5vCitsb25n ZXIgZGVmYXVsdHMgdG8gJ2J1ZmZlci1maWxlLW5hbWUnLgorCiAMCiAqIExpc3AgQ2hhbmdlcyBp biBFbWFjcyAyNy4xCiAKZGlmZiAtLWdpdCBhL2xpc3AvYXV0b2luc2VydC5lbCBiL2xpc3AvYXV0 b2luc2VydC5lbAppbmRleCAyODIwYzhhOWFmLi5hNDNlMDY4YTRkIDEwMDY0NAotLS0gYS9saXNw L2F1dG9pbnNlcnQuZWwKKysrIGIvbGlzcC9hdXRvaW5zZXJ0LmVsCkBAIC0xNDEsMTQgKzE0MSwx NCBAQCBhdXRvLWluc2VydC1hbGlzdAogICAgICAiCiAuXFxcIiBZb3UgbWF5IGRpc3RyaWJ1dGUg dGhpcyBmaWxlIHVuZGVyIHRoZSB0ZXJtcyBvZiB0aGUgR05VIEZyZWUKIC5cXFwiIERvY3VtZW50 YXRpb24gTGljZW5zZS4KLS5USCAiIChmaWxlLW5hbWUtYmFzZSkKKy5USCAiIChmaWxlLW5hbWUt YmFzZSAoYnVmZmVyLWZpbGUtbmFtZSkpCiAgICAgICIgIiAoZmlsZS1uYW1lLWV4dGVuc2lvbiAo YnVmZmVyLWZpbGUtbmFtZSkpCiAgICAgICIgIiAoZm9ybWF0LXRpbWUtc3RyaW5nICIlWS0lbS0l ZCAiKQogICAgICAiXG4uU0ggTkFNRVxuIgotICAgICAoZmlsZS1uYW1lLWJhc2UpCisgICAgIChm aWxlLW5hbWUtYmFzZSAoYnVmZmVyLWZpbGUtbmFtZSkpCiAgICAgICIgXFwtICIgc3RyCiAgICAg ICJcbi5TSCBTWU5PUFNJUwotLkIgIiAoZmlsZS1uYW1lLWJhc2UpCisuQiAiIChmaWxlLW5hbWUt YmFzZSAoYnVmZmVyLWZpbGUtbmFtZSkpCiAgICAgICJcbiIKICAgICAgXwogICAgICAiCkBAIC0y MTEsNyArMjExLDcgQEAgYXV0by1pbnNlcnQtYWxpc3QKIAogCiBcKHByb3ZpZGUgJyIKLSAgICAg ICAoZmlsZS1uYW1lLWJhc2UpCisgICAgICAgKGZpbGUtbmFtZS1iYXNlIChidWZmZXItZmlsZS1u YW1lKSkKICAgICAgICAiKQogXDs7OyAiIChmaWxlLW5hbWUtbm9uZGlyZWN0b3J5IChidWZmZXIt ZmlsZS1uYW1lKSkgIiBlbmRzIGhlcmVcbiIpCiAgICAgKCgiXFwudGV4aVxcKG5mb1xcKT9cXCci IC4gIlRleGluZm8gZmlsZSBza2VsZXRvbiIpCkBAIC0yMTksNyArMjE5LDcgQEAgYXV0by1pbnNl cnQtYWxpc3QKICAgICAgIlxcaW5wdXQgdGV4aW5mbyAgIEBjIC0qLXRleGluZm8tKi0KIEBjICUq KnN0YXJ0IG9mIGhlYWRlcgogQHNldGZpbGVuYW1lICIKLSAgICAgKGZpbGUtbmFtZS1iYXNlKSAi LmluZm9cbiIKKyAgICAgKGZpbGUtbmFtZS1iYXNlIChidWZmZXItZmlsZS1uYW1lKSkgIi5pbmZv XG4iCiAgICAgICAiQHNldHRpdGxlICIgc3RyICIKIEBjICUqKmVuZCBvZiBoZWFkZXIKIEBjb3B5 aW5nXG4iCmRpZmYgLS1naXQgYS9saXNwL2ZpbGVzLmVsIGIvbGlzcC9maWxlcy5lbAppbmRleCBj NTVjODA5N2MxLi5mZTdjYjFhOGE5IDEwMDY0NAotLS0gYS9saXNwL2ZpbGVzLmVsCisrKyBiL2xp c3AvZmlsZXMuZWwKQEAgLTQ0NzksOCArNDQ3OSw4IEBAIGZpbGUtbmFtZS1leHRlbnNpb24KICAg ICAgICAgICAgICIiKSkpKSkKIAogKGRlZnVuIGZpbGUtbmFtZS1iYXNlICgmb3B0aW9uYWwgZmls ZW5hbWUpCi0gICJSZXR1cm4gdGhlIGJhc2UgbmFtZSBvZiB0aGUgRklMRU5BTUU6IG5vIGRpcmVj dG9yeSwgbm8gZXh0ZW5zaW9uLgotRklMRU5BTUUgZGVmYXVsdHMgdG8gYGJ1ZmZlci1maWxlLW5h bWUnLiIKKyAgIlJldHVybiB0aGUgYmFzZSBuYW1lIG9mIHRoZSBGSUxFTkFNRTogbm8gZGlyZWN0 b3J5LCBubyBleHRlbnNpb24uIgorICAoZGVjbGFyZSAoYWR2ZXJ0aXNlZC1jYWxsaW5nLWNvbnZl bnRpb24gKGZpbGVuYW1lKSAiMjcuMSIpKQogICAoZmlsZS1uYW1lLXNhbnMtZXh0ZW5zaW9uCiAg ICAoZmlsZS1uYW1lLW5vbmRpcmVjdG9yeSAob3IgZmlsZW5hbWUgKGJ1ZmZlci1maWxlLW5hbWUp KSkpKQogCmRpZmYgLS1naXQgYS9saXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLmVsIGIvbGlzcC9w cm9nbW9kZXMvY3BlcmwtbW9kZS5lbAppbmRleCBhYmQ3N2JkOTczLi5lOTU2NjM3NTcyIDEwMDY0 NAotLS0gYS9saXNwL3Byb2dtb2Rlcy9jcGVybC1tb2RlLmVsCisrKyBiL2xpc3AvcHJvZ21vZGVz L2NwZXJsLW1vZGUuZWwKQEAgLTIzMTQsNyArMjMxNCw3IEBAIGNwZXJsLWVsZWN0cmljLXBvZAog CQkJCQkJIG5pbCB0KSkpKSA7IE9ubHkgb25lCiAJCSAgICAgKHByb2duCiAJCSAgICAgICAoZm9y d2FyZC13b3JkLXN0cmljdGx5IDEpCi0JCSAgICAgICAoc2V0cSBuYW1lIChmaWxlLW5hbWUtYmFz ZSkKKwkJICAgICAgIChzZXRxIG5hbWUgKGZpbGUtbmFtZS1iYXNlIChidWZmZXItZmlsZS1uYW1l KSkKIAkJCSAgICAgcCAocG9pbnQpKQogCQkgICAgICAgKGluc2VydCAiIE5BTUVcblxuIiBuYW1l CiAJCQkgICAgICAgIiAtIFxuXG49aGVhZDEgU1lOT1BTSVNcblxuXG5cbiIKZGlmZiAtLWdpdCBh L2xpc3AvcHJvZ21vZGVzL2lkbHdhdmUuZWwgYi9saXNwL3Byb2dtb2Rlcy9pZGx3YXZlLmVsCmlu ZGV4IDkyMzFlMTE4OTAuLjkyYTQyYjFjYjkgMTAwNjQ0Ci0tLSBhL2xpc3AvcHJvZ21vZGVzL2lk bHdhdmUuZWwKKysrIGIvbGlzcC9wcm9nbW9kZXMvaWRsd2F2ZS5lbApAQCAtNTI0MCw3ICs1MjQw LDcgQEAgaWRsd2F2ZS1wYXJzZS1kZWZpbml0aW9uCiAJICBjbGFzcwogCSAgKGNvbmQgKChub3Qg KGJvdW5kcCAnaWRsd2F2ZS1zY2FubmluZy1saWIpKQogCQkgKGxpc3QgICdidWZmZXIgKGJ1ZmZl ci1maWxlLW5hbWUpKSkKLTsJCSgoc3RyaW5nPSAoZG93bmNhc2UgKGZpbGUtbmFtZS1iYXNlKSkK KzsJCSgoc3RyaW5nPSAoZG93bmNhc2UgKGZpbGUtbmFtZS1iYXNlIChidWZmZXItZmlsZS1uYW1l KSkKIDsJCQkgIChkb3duY2FzZSBuYW1lKSkKIDsJCSAobGlzdCAnbGliKSkKIDsJCSh0IChjb25z ICdsaWIgKGZpbGUtbmFtZS1ub25kaXJlY3RvcnkgKGJ1ZmZlci1maWxlLW5hbWUpKSkpCmRpZmYg LS1naXQgYS9saXNwL3RleHRtb2Rlcy9yZWZ0ZXgtcmVmLmVsIGIvbGlzcC90ZXh0bW9kZXMvcmVm dGV4LXJlZi5lbAppbmRleCBjMmM1Y2EzZGUwLi5mOWYyMzIwMWI0IDEwMDY0NAotLS0gYS9saXNw L3RleHRtb2Rlcy9yZWZ0ZXgtcmVmLmVsCisrKyBiL2xpc3AvdGV4dG1vZGVzL3JlZnRleC1yZWYu ZWwKQEAgLTMxNCw3ICszMTQsNyBAQCByZWZ0ZXgtcmVwbGFjZS1wcmVmaXgtZXNjYXBlcwogICAg ICAgICAgICAgICAoc2F2ZS1tYXRjaC1kYXRhCiAgICAgICAgICAgICAgICAgKGNvbmQKICAgICAg ICAgICAgICAgICAgKChlcXVhbCBsZXR0ZXIgImYiKQotICAgICAgICAgICAgICAgICAgKGZpbGUt bmFtZS1iYXNlKSkKKyAgICAgICAgICAgICAgICAgIChmaWxlLW5hbWUtYmFzZSAoYnVmZmVyLWZp bGUtbmFtZSkpKQogICAgICAgICAgICAgICAgICAoKGVxdWFsIGxldHRlciAiRiIpCiAgICAgICAg ICAgICAgICAgICAobGV0ICgobWFzdGVyZGlyIChmaWxlLW5hbWUtZGlyZWN0b3J5IChyZWZ0ZXgt VGVYLW1hc3Rlci1maWxlKSkpCiAgICAgICAgICAgICAgICAgICAgICAgICAoZmlsZSAoZmlsZS1u YW1lLXNhbnMtZXh0ZW5zaW9uIChidWZmZXItZmlsZS1uYW1lKSkpKQotLSAKMi4xNC4xCgo= --001a113ca93ae93169055986e5e3-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 24 04:07:36 2017 Received: (at 28258-done) by debbugs.gnu.org; 24 Sep 2017 08:07:36 +0000 Received: from localhost ([127.0.0.1]:55141 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw1wu-0006pn-BV for submit@debbugs.gnu.org; Sun, 24 Sep 2017 04:07:36 -0400 Received: from mail-oi0-f51.google.com ([209.85.218.51]:46304) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dw1ws-0006pZ-Ny for 28258-done@debbugs.gnu.org; Sun, 24 Sep 2017 04:07:35 -0400 Received: by mail-oi0-f51.google.com with SMTP id a74so3360912oib.3 for <28258-done@debbugs.gnu.org>; Sun, 24 Sep 2017 01:07:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=qLgZQc6mp/75OxWmnkebCmp79MpdSb0HPSQmLdllkV0=; b=JAgjS5heG+DGkx9iT1HD9CxcBUQ9c3AVfR0rQ4OXjeFEyyOeQ+scTPmLxZMbll9Acq 0r5XyQgBYyx3CM4Eenj3bFYP6OD4SHBjblXNh4mDdQDT82Px/vvIvxmGBVXbeyg9YxYC 6VGEnAbrcgV63dj6xJ1efoUwz3G5HiCiQxnyAu9Q9o8lbNpNgNHlyFcz0pPldaRzlWDO b3vPG6q9UwT+ccqFmCHRtFGdfxfSPI3qa0iQO9raUzjjy4GQnIyJs/YJpak6x89TYGjp RBJWE9l1ylBMbBxBn4133kzc3Z0AZrrcwfG8KEbvJ9WcAvO7QFtHfxiW5qHrU+BITt0D DkPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=qLgZQc6mp/75OxWmnkebCmp79MpdSb0HPSQmLdllkV0=; b=DsHVPFq+vHBHnmYtkuhS2rPBSXoGV0ivlbE21jgunGbnCweuGAt1PjOPk62zqcu4g3 QbiLmOxzMozBqzK+UuzhEbOsB4FcKfg6cBG5MQwJzRvvkHUnpksVXZaN1K+xNyFwtLZ6 YkLDlcVnADi4OzHbDljLKLBI7f9E0scMzhQvhTUIvpwtW++Xwe+8RkJg9IXB3qc5ULx2 73JQX+1Y9PnooqgwF/07G6F1r6WaiYoK3gllqKKAwYcbEOKX4FB9F6kx3/M7yoCitjjH PPQeD7RjRfNXMlmAl2c7g1lZk/1YT9r2yaFzTStSHpiRmsHirdDCxMDnBvMrNaYk0dfJ UTBA== X-Gm-Message-State: AHPjjUgdtVkhfNE1qJpw4J2dlM99yMVIuhovHEOzxOpA1lFbM8ywiHNs faWmMVNx3WdTIb8osQYVoVrYEpJ6pFctnmrsEkE= X-Google-Smtp-Source: AOwi7QDbkKZrKIqNh28Fy0lNyPxWpUeREZroabnzi9KhYzVxUqw9Im7AQNK9EGsJQZ7KiJQ229272ET5trx6im2U9+Q= X-Received: by 10.202.56.214 with SMTP id f205mr4020247oia.316.1506240449102; Sun, 24 Sep 2017 01:07:29 -0700 (PDT) MIME-Version: 1.0 References: <87k21o8m8x.fsf@rose> <1188947996.68721.1504023031457@webmail.mailhostbox.com> In-Reply-To: From: Philipp Stephani Date: Sun, 24 Sep 2017 08:07:18 +0000 Message-ID: Subject: Re: bug#28258: 26.0.50; [PATCH] Let file-name-base succeed when buffer-file-name is nil To: Glenn Morris , 28258-done@debbugs.gnu.org Content-Type: multipart/alternative; boundary="001a113ca93aea468e0559eaeef3" X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: 28258-done Cc: Mohammed Sadiq X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) --001a113ca93aea468e0559eaeef3 Content-Type: text/plain; charset="UTF-8" Philipp Stephani schrieb am Di., 19. Sep. 2017 um 10:46 Uhr: > Philipp Stephani schrieb am Di., 19. Sep. 2017 um > 10:31 Uhr: > >> Glenn Morris schrieb am Di., 19. Sep. 2017 um 02:41 Uhr: >> >>> >>> > I do agree that the calling convention of `file-name-base' is odd. How >>> > about making the argument mandatory (initially only by changing the >>> > advertised calling convention and the docstring)? >>> >>> Sounds good to me. >>> >> >> OK, here's a patch. >> > > New version of the patch, with all callers and the manual fixed. > Pushed to master as 1eb4e5c3c8. --001a113ca93aea468e0559eaeef3 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


Philip= p Stephani <p.stephani2@gmail.c= om> schrieb am Di., 19. Sep. 2017 um 10:46=C2=A0Uhr:
Philipp Stephani <p.stephani2@gmail.com> schrieb am Di., 19. Sep. 2017= um 10:31=C2=A0Uhr:
Glenn Morris <rgm@gnu.org> schrieb am Di., 19= . Sep. 2017 um 02:41=C2=A0Uhr:

> I do agree that the calling convention of `file-name-base' is odd.= How
> about making the argument mandatory (initially only by changing the > advertised calling convention and the docstring)?

Sounds good to me.

OK, here's a patch.=C2=A0

New version of the patch, with all callers and the ma= nual fixed.=C2=A0

Pushed = to master as 1eb4e5c3c8.=C2=A0
--001a113ca93aea468e0559eaeef3-- From unknown Sat Jun 14 00:06:05 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 22 Oct 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator