From unknown Wed Aug 20 05:43:12 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28250 <28250@debbugs.gnu.org> To: bug#28250 <28250@debbugs.gnu.org> Subject: Status: slf4j-api: enable tests Reply-To: bug#28250 <28250@debbugs.gnu.org> Date: Wed, 20 Aug 2025 12:43:12 +0000 retitle 28250 slf4j-api: enable tests reassign 28250 guix-patches submitter 28250 Julien Lepiller severity 28250 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 27 07:33:05 2017 Received: (at submit) by debbugs.gnu.org; 27 Aug 2017 11:33:05 +0000 Received: from localhost ([127.0.0.1]:57091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlvoP-0003EC-LF for submit@debbugs.gnu.org; Sun, 27 Aug 2017 07:33:05 -0400 Received: from eggs.gnu.org ([208.118.235.92]:47545) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dlvoN-0003Dh-NL for submit@debbugs.gnu.org; Sun, 27 Aug 2017 07:33:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlvoH-0003cA-Fm for submit@debbugs.gnu.org; Sun, 27 Aug 2017 07:32:58 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41425) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dlvoH-0003c6-D4 for submit@debbugs.gnu.org; Sun, 27 Aug 2017 07:32:57 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dlvoG-0002cd-35 for guix-patches@gnu.org; Sun, 27 Aug 2017 07:32:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dlvoC-0003bS-Vd for guix-patches@gnu.org; Sun, 27 Aug 2017 07:32:56 -0400 Received: from lepiller.eu ([89.234.186.109]:39226 helo=localhost) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dlvoC-0003a1-L6 for guix-patches@gnu.org; Sun, 27 Aug 2017 07:32:52 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by localhost (OpenSMTPD) with ESMTPSA id 39b294d5 (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for ; Sun, 27 Aug 2017 11:32:49 +0000 (UTC) Date: Sun, 27 Aug 2017 13:31:42 +0200 From: Julien Lepiller To: guix-patches@gnu.org Subject: slf4j-api: enable tests Message-ID: <20170827133142.6a7b6482@lepiller.eu> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/8+QIuMroZam2d3LF6wG4+5L" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --MP_/8+QIuMroZam2d3LF6wG4+5L Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, I found what prevented the tests to pass in slf4j-api. In slf4j-api/pom.xml, the jar file is created with all classes, except those in impl/. I did the same with a new pase where I delete the impl/ directory and regenerate the jar file. Maybe I should fix teh build.xml file instead? Then, tests pass except for one file. This file is an abstract class meant to be extended by other test cases, but it's not a test case in itself, hence the failure. This time, I implemented another phase where I fix the build.xml file to exclude this file from testing. I'm working on other packages, and it's not the first time I see some tests I need to disable because they shouldn't be run. Maybe I could add arguments to the ant build system, such as #:test-include and #:test-exclude, defaulting to '("**/*.java") and '() respectively? Thank you :) --MP_/8+QIuMroZam2d3LF6wG4+5L Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-gnu-java-slf4j-api-Fix-tests.patch >From 2a9b0420c249b4b896f5980a55be8ae5595bd96b Mon Sep 17 00:00:00 2001 From: Julien Lepiller Date: Sun, 27 Aug 2017 13:19:31 +0200 Subject: [PATCH] gnu: java-slf4j-api: Fix tests. * gnu/packages/java.scm (java-slf4j-api)[arguments]: Enable tests Adjust the jar content to prevent a test failure. --- gnu/packages/java.scm | 24 +++++++++++++++++++----- 1 file changed, 19 insertions(+), 5 deletions(-) diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm index da68487b0..caa76f335 100644 --- a/gnu/packages/java.scm +++ b/gnu/packages/java.scm @@ -4170,12 +4170,26 @@ more efficient storage-wise than an uncompressed bitmap (as implemented in the #t)))) (build-system ant-build-system) (arguments - ;; FIXME: org.slf4j.NoBindingTest fails with the ominous "This code - ;; should have never made it into slf4j-api.jar". - `(#:tests? #f - #:jar-name "slf4j-api.jar" + `(#:jar-name "slf4j-api.jar" #:source-dir "slf4j-api/src/main" - #:test-dir "slf4j-api/src/test")) + #:test-dir "slf4j-api/src/test" + #:phases + (modify-phases %standard-phases + (add-after 'build 'regenerate-jar + (lambda _ + ;; pom.xml ignores these files in the jar creation process. If we don't, + ;; we get the error "This code should have never made it into slf4j-api.jar" + (delete-file-recursively "build/classes/org/slf4j/impl") + (zero? (system* "jar" "-cf" "build/jar/slf4j-api.jar" "-C" + "build/classes" ".")))) + (add-before 'check 'dont-test-abstract-classes + (lambda _ + ;; abstract classes are not meant to be run with junit + (substitute* "build.xml" + (("") + (string-append "" + "")))))))) (inputs `(("java-junit" ,java-junit) ("java-hamcrest-core" ,java-hamcrest-core))) -- 2.14.1 --MP_/8+QIuMroZam2d3LF6wG4+5L-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 08 12:05:40 2017 Received: (at 28250) by debbugs.gnu.org; 8 Sep 2017 16:05:40 +0000 Received: from localhost ([127.0.0.1]:56226 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqLmm-0007sf-Jq for submit@debbugs.gnu.org; Fri, 08 Sep 2017 12:05:40 -0400 Received: from eggs.gnu.org ([208.118.235.92]:38902) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqLmk-0007sQ-PK for 28250@debbugs.gnu.org; Fri, 08 Sep 2017 12:05:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dqLmZ-0001qP-Vo for 28250@debbugs.gnu.org; Fri, 08 Sep 2017 12:05:33 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38444) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dqLmZ-0001qF-SE; Fri, 08 Sep 2017 12:05:27 -0400 Received: from [193.50.110.231] (port=41884 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dqLmZ-00037T-Ff; Fri, 08 Sep 2017 12:05:27 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Julien Lepiller Subject: Re: [bug#28250] slf4j-api: enable tests References: <20170827133142.6a7b6482@lepiller.eu> Date: Fri, 08 Sep 2017 18:05:25 +0200 In-Reply-To: <20170827133142.6a7b6482@lepiller.eu> (Julien Lepiller's message of "Sun, 27 Aug 2017 13:31:42 +0200") Message-ID: <877ex989bu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28250 Cc: 28250@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Julien Lepiller skribis: >>>From 2a9b0420c249b4b896f5980a55be8ae5595bd96b Mon Sep 17 00:00:00 2001 > From: Julien Lepiller > Date: Sun, 27 Aug 2017 13:19:31 +0200 > Subject: [PATCH] gnu: java-slf4j-api: Fix tests. > > * gnu/packages/java.scm (java-slf4j-api)[arguments]: Enable tests > Adjust the jar content to prevent a test failure. I don=E2=80=99t fully understand what=E2=80=99s at play but this looks like= a step in the right direction to me, so I=E2=80=99d say go ahead! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 08 14:43:57 2017 Received: (at 28250-done) by debbugs.gnu.org; 8 Sep 2017 18:43:57 +0000 Received: from localhost ([127.0.0.1]:56355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqOFx-0005A2-EU for submit@debbugs.gnu.org; Fri, 08 Sep 2017 14:43:57 -0400 Received: from lepiller.eu ([89.234.186.109]:38902 helo=localhost) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dqOFu-00059q-Jc for 28250-done@debbugs.gnu.org; Fri, 08 Sep 2017 14:43:55 -0400 Received: from localhost (static-176-182-42-79.ncc.abo.bbox.fr [176.182.42.79]) by localhost (OpenSMTPD) with ESMTPSA id b4a1a8ab (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256:NO) for <28250-done@debbugs.gnu.org>; Fri, 8 Sep 2017 18:43:53 +0000 (UTC) Date: Fri, 8 Sep 2017 20:42:42 +0200 From: Julien Lepiller To: 28250-done@debbugs.gnu.org Subject: Re: [bug#28250] slf4j-api: enable tests Message-ID: <20170908204242.0eb68024@lepiller.eu> In-Reply-To: <877ex989bu.fsf@gnu.org> References: <20170827133142.6a7b6482@lepiller.eu> <877ex989bu.fsf@gnu.org> X-Mailer: Claws Mail 3.15.1-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Le Fri, 08 Sep 2017 18:05:25 +0200, ludo@gnu.org (Ludovic Courtès) a écrit : > Julien Lepiller skribis: > > >>From 2a9b0420c249b4b896f5980a55be8ae5595bd96b Mon Sep 17 00:00:00 > >>2001 > > From: Julien Lepiller > > Date: Sun, 27 Aug 2017 13:19:31 +0200 > > Subject: [PATCH] gnu: java-slf4j-api: Fix tests. > > > > * gnu/packages/java.scm (java-slf4j-api)[arguments]: Enable tests > > Adjust the jar content to prevent a test failure. > > I don’t fully understand what’s at play but this looks like a step in > the right direction to me, so I’d say go ahead! > > Thanks, > Ludo’. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FSL_HELO_NON_FQDN_1 No description available. 3.6 HELO_LOCALHOST No description available. -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain X-Debbugs-Envelope-To: 28250-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: Le Fri, 08 Sep 2017 18:05:25 +0200, ludo@gnu.org (Ludovic Courtès) a écrit : > Julien Lepiller skribis: > > >>From 2a9b0420c249b4b896f5980a55be8ae5595bd96b Mon Sep 17 00:00:00 > >>2001 > > From: Julien Lepiller > > Date: Sun, 27 Aug 2017 13:19:31 +0200 > > Subject: [PATCH] gnu: java-slf4j-api: Fix tests. > > > > * gnu/packages/java.scm (java-slf4j-api)[arguments]: Enable tests > > Adjust the jar content to prevent a test failure. > > I don’t fully understand what’s at play but this looks like a step in > the right direction to me, so I’d say go ahead! > > Thanks, > Ludo’. [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 FSL_HELO_NON_FQDN_1 No description available. 3.6 HELO_LOCALHOST No description available. -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RP_MATCHES_RCVD Envelope sender domain matches handover relay domain Le Fri, 08 Sep 2017 18:05:25 +0200, ludo@gnu.org (Ludovic Court=C3=A8s) a =C3=A9crit : > Julien Lepiller skribis: >=20 > >>From 2a9b0420c249b4b896f5980a55be8ae5595bd96b Mon Sep 17 00:00:00 > >>2001 =20 > > From: Julien Lepiller > > Date: Sun, 27 Aug 2017 13:19:31 +0200 > > Subject: [PATCH] gnu: java-slf4j-api: Fix tests. > > > > * gnu/packages/java.scm (java-slf4j-api)[arguments]: Enable tests > > Adjust the jar content to prevent a test failure. =20 >=20 > I don=E2=80=99t fully understand what=E2=80=99s at play but this looks li= ke a step in > the right direction to me, so I=E2=80=99d say go ahead! >=20 > Thanks, > Ludo=E2=80=99. Actually, since there was no answer on this bug, I already pushed it a few days ago. I forgot to close the ticket. Pushed as dcf7a8a660554eb952e6412637e26bb523af03e8. From unknown Wed Aug 20 05:43:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 07 Oct 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator