GNU bug report logs - #28241
man page in r-minimal contains timestamp

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28241 in the body.
You can then email your comments to 28241 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: "'bug-guix\@gnu.org'" <bug-guix <at> gnu.org>
Subject: man page in r-minimal contains timestamp
Date: Sat, 26 Aug 2017 14:59:47 +0200

The compressed man page at “share/man/man1/R.1.gz” provided by r-minimal
contains a time-dependent string.

Comparing the uncompressed man pages built at different times on
different machines shows me this:

--8<---------------cut here---------------start------------->8---
diff /tmp/berlin/share/man/man1/R.1  /tmp/hydra/share/man/man1/R.1
2c2
< .TH R "1" "July 2017" "R 3.4.0" FSF
---
> .TH R "1" "May 2017" "R 3.4.0" FSF
--8<---------------cut here---------------end--------------->8---

The man page is created with a rule in “doc/Makefile.in”:

     @$(HELP2MAN) --include=$(srcdir)/R.aux --no-info --output=R.1 \
       --name="a language for data analysis and graphics" \
       $(top_builddir)/bin/R

“doc/R.aux” does not contain a timestamp, nor does the help output of R
itself.  Is help2man to blame here?

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #8 received at 28241 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 28241 <at> debbugs.gnu.org
Subject: Re: bug#28241: man page in r-minimal contains timestamp
Date: Sat, 26 Aug 2017 15:11:06 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> The man page is created with a rule in “doc/Makefile.in”:
>
>      @$(HELP2MAN) --include=$(srcdir)/R.aux --no-info --output=R.1 \
>        --name="a language for data analysis and graphics" \
>        $(top_builddir)/bin/R
>
> “doc/R.aux” does not contain a timestamp, nor does the help output of R
> itself.  Is help2man to blame here?

help2man supports SOURCE_DATE_EPOCH and it does the right thing when it
is set.

--8<---------------cut here---------------start------------->8---
$ guix environment --ad-hoc r-minimal help2man
$ help2man --include=R-3.4.0/doc/R.aux --no-info --output foo.1 R
$ grep August foo.1
.TH R "1" "August 2017" "R version 3.4.0 (2017-04-21) -- "You Stupid Darkness"" "User Commands"

$ SOURCE_DATE_EPOCH=0 help2man --include=R-3.4.0/doc/R.aux --no-info --output foo.1 R
$ grep August foo.1
$ grep January foo.1
.TH R "1" "January 1970" "R version 3.4.0 (2017-04-21) -- "You Stupid Darkness"" "User Commands"
--8<---------------cut here---------------end--------------->8---

Is SOURCE_DATE_EPOCH not set at the time help2man runs?  “r-minimal”
uses the gnu-build-system, which has a build phase set-SOURCE-DATE-EPOCH
that sets SOURCE_DATE_EPOCH to 1.

Where is this lost?

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #11 received at 28241 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 28241 <at> debbugs.gnu.org
Subject: Re: bug#28241: man page in r-minimal contains timestamp
Date: Sun, 27 Aug 2017 02:46:17 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Is SOURCE_DATE_EPOCH not set at the time help2man runs?  “r-minimal”
> uses the gnu-build-system, which has a build phase set-SOURCE-DATE-EPOCH
> that sets SOURCE_DATE_EPOCH to 1.
>
> Where is this lost?

Simple: R simply doesn’t use our help2man.  It comes with
tools/help2man.pl, which does not respect SOURCE_DATE_EPOCH.

Overwriting the HELP2MAN variable causes the tests to fail, so I need to
investigate how these versions differ.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Message #16 received at 28241-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 28241-done <at> debbugs.gnu.org
Subject: Re: bug#28241: man page in r-minimal contains timestamp
Date: Mon, 28 Aug 2017 15:53:39 +0200

Ricardo Wurmus <rekado <at> elephly.net> writes:

> Ricardo Wurmus <rekado <at> elephly.net> writes:
>
>> Is SOURCE_DATE_EPOCH not set at the time help2man runs?  “r-minimal”
>> uses the gnu-build-system, which has a build phase set-SOURCE-DATE-EPOCH
>> that sets SOURCE_DATE_EPOCH to 1.
>>
>> Where is this lost?
>
> Simple: R simply doesn’t use our help2man.  It comes with
> tools/help2man.pl, which does not respect SOURCE_DATE_EPOCH.
>
> Overwriting the HELP2MAN variable causes the tests to fail, so I need to
> investigate how these versions differ.

This is now fixed with commit 174fbd5f3b2f286cf06e58787853db6b8f0f5b35.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.