GNU bug report logs - #28227
26.0.50; Tramp tests are slow

Previous Next

Full log

View this message in rfc822 format

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: 28227 <at> debbugs.gnu.org, npostavs <at> users.sourceforge.net
Subject: bug#28227: 26.0.50; Tramp tests are slow
Date: Fri, 01 Sep 2017 14:28:33 +0200

Gemini Lasswell <gazally <at> runbox.com> writes:

Hi Gemini,

> Here's a new patch which uses defun and doesn't have the let binding.
> Performance is not noticably different.

Looks good to me, thanks a lot! You could apply this to master.

`tramp-prefix-method-regexp-alist' might be renamed to
`tramp-method-regexp-alist'.

And `tramp-*-regexp-alist' might be derived from `tramp-*-format-alist',
as the docstring says. Otherwise, you would use the same string literals
twice, which is always good for errors during maintenance. Something like

(defconst tramp-prefix-regexp-alist
  (mapcar (lambda (x) (cons (car x) (concat "^" (regexp-quote (cdr x)))))
          tramp-prefix-format-alist)
  "Alist of regexps matching the beginnings of Tramp file names.
Keyed by Tramp syntax. Derived from `tramp-prefix-format-alist'.")

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.