GNU bug report logs - #28227
26.0.50; Tramp tests are slow

Previous Next

Full log

Message #17 received at 28227 <at> debbugs.gnu.org (full text, mbox):

From: Gemini Lasswell <gazally <at> runbox.com>
To: npostavs <at> users.sourceforge.net
Cc: Michael Albinus <michael.albinus <at> gmx.de>, 28227 <at> debbugs.gnu.org
Subject: Re: bug#28227: 26.0.50; Tramp tests are slow
Date: Thu, 31 Aug 2017 07:46:33 -0700

[Message part 1 (text/plain, inline)]

Here's a new patch which uses defun and doesn't have the let binding.
Performance is not noticably different.

[0001-Reduce-Tramp-s-memory-usage.patch (text/plain, attachment)]

[Message part 3 (text/plain, inline)]

npostavs <at> users.sourceforge.net writes:

> Gemini Lasswell <gazally <at> runbox.com> writes:
>
>> +(defmacro tramp-lookup-syntax (alist)
>> +  "Look up a syntax string in ALIST according to `tramp-compat-tramp-syntax.'
>> +Raise an error if `tramp-syntax' is invalid."
>> +  `(let ((result (cdr (assq (tramp-compat-tramp-syntax) ,alist))))
>> +     (or result
>> +         (error "Wrong `tramp-syntax' %s" tramp-syntax))))
>
> Was there a reason to defmacro instead of defun here?  If it's
> performance, perhaps defsubst could work instead?
>
> (also, the let-binding seems redundant)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.