GNU bug report logs - #28227
26.0.50; Tramp tests are slow

Previous Next

Package: emacs;

Reported by: Gemini Lasswell <gazally <at> runbox.com>

Date: Thu, 24 Aug 2017 21:05:01 UTC

Severity: normal

Found in version 26.0.50

Done: Gemini Lasswell <gazally <at> runbox.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: npostavs <at> users.sourceforge.net
To: Gemini Lasswell <gazally <at> runbox.com>
Cc: Michael Albinus <michael.albinus <at> gmx.de>, 28227 <at> debbugs.gnu.org
Subject: bug#28227: 26.0.50; Tramp tests are slow
Date: Wed, 30 Aug 2017 22:26:33 -0400

Gemini Lasswell <gazally <at> runbox.com> writes:

> +(defmacro tramp-lookup-syntax (alist)
> +  "Look up a syntax string in ALIST according to `tramp-compat-tramp-syntax.'
> +Raise an error if `tramp-syntax' is invalid."
> +  `(let ((result (cdr (assq (tramp-compat-tramp-syntax) ,alist))))
> +     (or result
> +         (error "Wrong `tramp-syntax' %s" tramp-syntax))))

Was there a reason to defmacro instead of defun here?  If it's
performance, perhaps defsubst could work instead?

(also, the let-binding seems redundant)
This bug report was last modified 7 years and 338 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.