GNU bug report logs - #28188
[PATCH] gnu: libreoffice: Fix icons, enable liblangtag.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28188 in the body.
You can then email your comments to 28188 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: libreoffice: Fix icons, enable liblangtag.
Date: Tue, 22 Aug 2017 21:26:00 +0200 (CEST)

[Message part 1 (text/plain, inline)]

Hi,

this patch fixes the names of the icons in the libreoffice desktop 
files, installs additional desktop files for “math” and the 
“startcenter”, and tunes the build configuration (enable liblangtag, 
enable parallel build -- seems to work fine on my machine).

It's a bit of everything, not sure if it should be split into 2 
commits (one for the desktop files & icons, one for the build 
options)?

cheers,

Thomas

[0001-gnu-libreoffice-Fix-icons-enable-liblangtag.patch (text/x-patch, inline)]

From d2384b4dbe8ac91226153f021039df0aa38bab27 Mon Sep 17 00:00:00 2001
From: Thomas Danckaert <thomas.danckaert <at> gmail.com>
Date: Tue, 22 Aug 2017 19:25:11 +0200
Subject: [PATCH] gnu: libreoffice: Fix icons, enable liblangtag.

* gnu/packages/libreoffice.scm (libreoffice) [inputs]: Add liblangtag.
  [arguments]: Correct icon names in .desktop files; copy desktop files &
  icons for libreoffice-math and libreoffice-startcenter; enable parallel
  build; enable liblangtag.
---
 gnu/packages/libreoffice.scm | 23 +++++++++++++----------
 1 file changed, 13 insertions(+), 10 deletions(-)

diff --git a/gnu/packages/libreoffice.scm b/gnu/packages/libreoffice.scm
index 16a8d257d..cca222b1f 100644
--- a/gnu/packages/libreoffice.scm
+++ b/gnu/packages/libreoffice.scm
@@ -837,6 +837,7 @@ and to return information on pronunciations, meanings and synonyms.")
        ("libetonyek" ,libetonyek)
        ("libexttextcat" ,libexttextcat)
        ("libfreehand" ,libfreehand)
+       ("liblangtag" ,liblangtag)
        ("libmspub" ,libmspub)
        ("libmwaw" ,libmwaw)
        ("libodfgen" ,libodfgen)
@@ -919,15 +920,16 @@ and to return information on pronunciations, meanings and synonyms.")
                      (substitute* (string-append out src)
                        (("Exec=libreoffice[0-9]+\\.[0-9]+ ")
                         (string-append "Exec=" out "/bin/libreoffice "))
-                       (("Icon=libreoffice[0-9]+\\.[0-9]+")
-                        "Icon=libreoffice")
+                       (("Icon=libreoffice.*")
+                        (string-append "Icon=" app "\n"))
                        (("LibreOffice [0-9]+\\.[0-9]+")
                         "LibreOffice"))
-                     (symlink-output src dst)
-                     (install-file (string-append
+                     (symlink-output src dst)))
+                 (define (install-appdata app)
+                   (install-file (string-append
                                     "sysui/desktop/appstream-appdata/"
                                     "libreoffice-" app ".appdata.xml")
-                                   (string-append out "/share/appdata"))))
+                                   (string-append out "/share/appdata")))
                  (symlink-output "/lib/libreoffice/program/soffice"
                                  "/bin/soffice")
                  (symlink-output "/lib/libreoffice/program/soffice"
@@ -940,16 +942,18 @@ and to return information on pronunciations, meanings and synonyms.")
                   "workdir/CustomTarget/sysui/share/libreoffice/openoffice.org.xml"
                   "/share/mime/packages/libreoffice.xml")
                  (for-each install-desktop-file
+                           '("base" "calc" "draw" "impress" "writer"
+                             "math" "startcenter"))
+                 (for-each install-appdata
                            '("base" "calc" "draw" "impress" "writer"))
-                 (mkdir-p (string-append out "/share/icons"))
+                 (mkdir-p (string-append out "/share/icons/hicolor"))
                  (copy-recursively "sysui/desktop/icons/hicolor"
-                                   (string-append out "/share/icons/")))
+                                   (string-append out "/share/icons/hicolor")))
                #t)))
        #:configure-flags
         (list
           "--enable-release-build"
           "--enable-verbose"
-          "--without-parallelism" ; otherwise the build fails
           "--disable-fetch-external" ; disable downloads
           "--with-system-libs" ; enable all --with-system-* flags
           (string-append "--with-boost-libdir="
@@ -969,8 +973,7 @@ and to return information on pronunciations, meanings and synonyms.")
           "--disable-firebird-sdbc" ; embedded firebird
           "--disable-gltf"
           "--without-doxygen"
-          "--disable-gtk3"
-          "--disable-liblangtag")))
+          "--disable-gtk3")))
     (home-page "https://www.libreoffice.org/")
     (synopsis "Office suite")
     (description "LibreOffice is a comprehensive office suite.  It contains
-- 
2.14.1

Message #8 received at 28188 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Thomas Danckaert <post <at> thomasdanckaert.be>, 28188 <at> debbugs.gnu.org
Subject: Re: [bug#28188] [PATCH] gnu: libreoffice: Fix icons,
 enable liblangtag.
Date: Tue, 22 Aug 2017 22:52:55 +0200

[Message part 1 (text/plain, inline)]

Thomas Danckaert <post <at> thomasdanckaert.be> writes:

> Hi,
>
> this patch fixes the names of the icons in the libreoffice desktop 
> files, installs additional desktop files for “math” and the 
> “startcenter”, and tunes the build configuration (enable liblangtag, 
> enable parallel build -- seems to work fine on my machine).
>
> It's a bit of everything, not sure if it should be split into 2 
> commits (one for the desktop files & icons, one for the build 
> options)?

The patch looks good to me.  Thanks for looking after LibreOffice!

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 28188 <at> debbugs.gnu.org (full text, mbox):

From: Thomas Danckaert <post <at> thomasdanckaert.be>
To: mbakke <at> fastmail.com
Cc: 28188-done <at> debbugs.gnu.org, 28188 <at> debbugs.gnu.org
Subject: Re: [bug#28188] [PATCH] gnu: libreoffice: Fix icons, enable
 liblangtag.
Date: Thu, 24 Aug 2017 19:54:58 +0200 (CEST)

From: Marius Bakke <mbakke <at> fastmail.com>
Subject: Re: [bug#28188] [PATCH] gnu: libreoffice: Fix icons, enable 
liblangtag.
Date: Tue, 22 Aug 2017 22:52:55 +0200

> The patch looks good to me.  Thanks for looking after LibreOffice!

Thanks for taking a look!

pushed, closing, etc...

Thomas

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.