GNU bug report logs - #28169
26.0.50; make versionclean deletes emacs-module.h.in

Previous Next

Package: emacs;

Reported by: Sven Joachim <svenjoac <at> gmx.de>

Date: Mon, 21 Aug 2017 07:07:01 UTC

Severity: normal

Tags: patch

Found in version 26.0.50

Done: Eli Zaretskii <eliz <at> gnu.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Sven Joachim <svenjoac <at> gmx.de>
Subject: bug#28169: closed (Re: bug#28169: 26.0.50; make versionclean
 deletes emacs-module.h.in)
Date: Mon, 21 Aug 2017 16:31:01 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#28169: 26.0.50; make versionclean deletes emacs-module.h.in

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 28169 <at> debbugs.gnu.org.

-- 
28169: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28169
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Eli Zaretskii <eliz <at> gnu.org>
To: Sven Joachim <svenjoac <at> gmx.de>
Cc: 28169-done <at> debbugs.gnu.org
Subject: Re: bug#28169: 26.0.50; make versionclean deletes emacs-module.h.in
Date: Mon, 21 Aug 2017 19:30:22 +0300
> From: Sven Joachim <svenjoac <at> gmx.de>
> Date: Mon, 21 Aug 2017 09:06:42 +0200
> Cc: Sven Joachim <svenjoac <at> gmx.de>
> 
> I ran "make -C src versionclean all" and found that
> src/emacs-module.h.in was gone.  Commit 1b75af59b3 ("Fix emacs-module.h
> cleaning") already handled the "make clean" case, but overlooked the
> versionclean target, here is a patch for that:

Thanks, pushed.

[Message part 3 (message/rfc822, inline)]
From: Sven Joachim <svenjoac <at> gmx.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; make versionclean deletes emacs-module.h.in
Date: Mon, 21 Aug 2017 09:06:42 +0200
[Message part 4 (text/plain, inline)]
Tags: patch

I ran "make -C src versionclean all" and found that
src/emacs-module.h.in was gone.  Commit 1b75af59b3 ("Fix emacs-module.h
cleaning") already handled the "make clean" case, but overlooked the
versionclean target, here is a patch for that:

[Makefile.in.diff (text/x-diff, inline)]
diff --git a/src/Makefile.in b/src/Makefile.in
index 57969d5fc5..dde3f1d3fb 100644
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -659,7 +659,7 @@ distclean:
 maintainer-clean: distclean
 	rm -f TAGS
 versionclean:
-	-rm -f emacs$(EXEEXT) emacs-*.*.*$(EXEEXT) ../etc/DOC*
+	-rm -f emacs$(EXEEXT) emacs-*.*.*[0-9]$(EXEEXT) ../etc/DOC*
 extraclean: distclean
 	-rm -f *~ \#*
 

This bug report was last modified 7 years and 273 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.