GNU bug report logs - #28163
[PATCH 1/3] gnu: libksysguard: Enable more tests (not all working yet).

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28163 in the body.
You can then email your comments to 28163 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: guix-patches <at> gnu.org
Subject: [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working
 yet).
Date: Sun, 20 Aug 2017 20:07:27 +0200

* gnu/packages/kde.scm (libksysguard)[arguments]<#:phases>'check':
  Set QT_QPA_PLATFORM=offscreen. Enable all tests except of the
  failing one.
---
 gnu/packages/kde.scm | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/kde.scm b/gnu/packages/kde.scm
index a65a61f96..0f21b8a9d 100644
--- a/gnu/packages/kde.scm
+++ b/gnu/packages/kde.scm
@@ -301,8 +301,10 @@ used in KDE development tools Kompare and KDevelop.")
              (substitute* "processcore/CMakeLists.txt"
                (("KAUTH_HELPER_INSTALL_DIR") "KDE_INSTALL_LIBEXECDIR"))))
          (replace 'check
-           (lambda _         ;other tests require a display and therefore fail
-             (zero? (system* "ctest" "-R" "chronotest")))))))
+           (lambda _
+             (setenv "QT_QPA_PLATFORM" "offscreen")
+             ;; TODO: Fix this failing test-case
+             (zero? (system* "ctest" "-E" "processtest")))))))
     (home-page "https://www.kde.org/info/plasma-5.10.4.php")
     (synopsis "Network enabled task and system monitoring")
     (description "KSysGuard can obtain information on system load and
-- 
2.13.5

Message #8 received at 28163 <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: 28163 <at> debbugs.gnu.org
Subject: Re: bug#28163: Acknowledgement ([PATCH 1/3] gnu: libksysguard: Enable
 more tests (not all working yet).)
Date: Sun, 20 Aug 2017 20:12:29 +0200

Despite the subject, this is a single patch :-) I carved it out from a
larger `git am` patch-set, but it is independent from the others.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Message #11 received at 28163 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 28163 <at> debbugs.gnu.org
Cc: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
Subject: re: [PATCH 1/3] gnu: libksysguard: Enable more tests (not all
 working yet)
Date: Wed, 23 Aug 2017 16:40:57 +0300

[Message part 1 (text/plain, inline)]

This patch works on my aarch64 machine. I would move the setenv line to
a separate phase before the 'check phase.

LGTM!

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #16 received at 28163-close <at> debbugs.gnu.org (full text, mbox):

From: Hartmut Goebel <h.goebel <at> crazy-compilers.com>
To: Efraim Flashner <efraim <at> flashner.co.il>, 28163-close <at> debbugs.gnu.org
Subject: Re: [PATCH 1/3] gnu: libksysguard: Enable more tests (not all working
 yet)
Date: Thu, 24 Aug 2017 12:46:03 +0200

Pushed as e3c13d044f8c7fdeef5079e16591dc4302f5c31b after moving the
setenf into a phase called "check-setup".

Thanks for reviewing.

-- 
Regards
Hartmut Goebel

| Hartmut Goebel          | h.goebel <at> crazy-compilers.com               |
| www.crazy-compilers.com | compilers which you thought are impossible |

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.