From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 19 15:49:34 2017 Received: (at submit) by debbugs.gnu.org; 19 Aug 2017 19:49:34 +0000 Received: from localhost ([127.0.0.1]:45853 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dj9kU-0001kX-Fo for submit@debbugs.gnu.org; Sat, 19 Aug 2017 15:49:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:40046) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dj9kS-0001kL-RL for submit@debbugs.gnu.org; Sat, 19 Aug 2017 15:49:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dj9kM-0000HV-Jw for submit@debbugs.gnu.org; Sat, 19 Aug 2017 15:49:27 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:37851) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dj9kM-0000HP-HF for submit@debbugs.gnu.org; Sat, 19 Aug 2017 15:49:26 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59249) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dj9kL-00082W-8L for guix-patches@gnu.org; Sat, 19 Aug 2017 15:49:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dj9kI-0000G5-6T for guix-patches@gnu.org; Sat, 19 Aug 2017 15:49:25 -0400 Received: from dd5424.kasserver.com ([85.13.138.252]:44929) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dj9kH-0000F3-Vi for guix-patches@gnu.org; Sat, 19 Aug 2017 15:49:22 -0400 Received: from localhost (193-83-111-109.hdsl.highway.telekom.at [193.83.111.109]) by dd5424.kasserver.com (Postfix) with ESMTPA id 08644B58187D for ; Sat, 19 Aug 2017 21:49:18 +0200 (CEST) From: Stefan =?utf-8?Q?Reich=C3=B6r?= To: guix-patches@gnu.org Subject: [PATCH] gnu: Add honcho. User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Sat, 19 Aug 2017 21:49:18 +0200 Message-ID: <87valj72yp.fsf@xsteve.at> MIME-Version: 1.0 Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-Add-honcho.patch X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) >From fd43ad462227e46d34c48c5a7ae41009f0d20d45 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Reich=C3=B6r?= Date: Sat, 19 Aug 2017 21:46:38 +0200 Subject: [PATCH] gnu: Add honcho. * gnu/packages/python.scm (python-honcho): New variable. --- gnu/packages/python.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index 6da5ad8..afa7ca5 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -5226,6 +5226,31 @@ cluster without needing to write any wrapper code yourself.") (define-public python2-gridmap (package-with-python2 python-gridmap)) +(define-public python-honcho + (package + (name "python-honcho") + (version "1.0.1") + (source + (origin + (method url-fetch) + (uri (pypi-uri "honcho" version)) + (sha256 + (base32 "0vpadk37y27m98x9lk151k96vp319w7jv8f6hdr7fdz3s8m412f1")))) + (build-system python-build-system) + (propagated-inputs + `(("python-jinja2" ,python-jinja2))) + (home-page "https://github.com/nickstenning/honcho") + (synopsis "Manage Procfile-based applications") + (description + "A Procfile is a file which describes how to run an application +consisting of serveral processes. honcho starts all listed processes. +The output of all running processes is collected by honcho and +displayed.") + (license license:expat))) + +(define-public python2-honcho + (package-with-python2 python-honcho)) + (define-public python-pexpect (package (name "python-pexpect") -- 2.7.4 From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 18:00:11 2017 Received: (at 28151) by debbugs.gnu.org; 21 Aug 2017 22:00:11 +0000 Received: from localhost ([127.0.0.1]:48288 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djujz-000446-4f for submit@debbugs.gnu.org; Mon, 21 Aug 2017 18:00:11 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49051) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djujv-00043w-2d for 28151@debbugs.gnu.org; Mon, 21 Aug 2017 18:00:07 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id A317C21B4A; Mon, 21 Aug 2017 18:00:06 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Mon, 21 Aug 2017 18:00:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=xPm1ZNdyWvS1yqp3yszcVb8Ptu/WfO3pBqifx84KL Yc=; b=UmYo4T8+LLz8+GOVMiVgdj0PtVbA2ll+rCifooYxWi0vYE2M9d0Vm9vcM Kp3YMwhpUftEu5gm8llkpyyJ0KWNNUUtWlFtzkTFWpMnqFFRE4ahqjkc/4Fe5VKs p4ldtoPZu8ppCT6h79q13z0dRJApFdY3mGvWkr8mxPv3A+hE3fg9od4Vlz/FldQC xPFDEsHvs+zQdW3sMcZriahNyWXwNBR6Sjc0dtNzRtNf6+Qs/XNB9d6HaUvqcNdO 3ZJlF5NLHfgSO3U2cFx7ABClqHaxisOTN87e+gq89YNFBGqLA2UAylh3Fe3j5L1F Xn+sWZOwNCDwYvk4aGKYWaf66Bu/g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=xPm1ZNdyWvS1yqp3ys zcVb8Ptu/WfO3pBqifx84KLYc=; b=kbqR/4svezQ/V/kdOsPrI1B2XaJCyoERu7 Pf7tc7ohOnrSZTzycmsnQiw2dcP4i4XqRoDzWYzubj2MtMby3mRuKEYQcFG5bryH OSLNUht+xSkkw0wyCdX6Vo3Xj+ahmpA2ecpZG4HD/Y2lroNMz8w8mv+C0ginfX1x ZD7oAPYLkjolMlwDgv6k9uQ80rumMuyedv4cUg66Pr9STOlR4xJTk01lsncTcUfm JmuUyv/LmhRBf2nc2GQNGwpuFb/wQgDxbAPYGi/sI2Q0dmzreh6n96tjipmdZwc4 406Gj0URextTgVrMmrp1D0SyGb5FYa9JbYY0fT/xoWTYuSjbaRpg== X-ME-Sender: X-Sasl-enc: KGiRNqIVVhBXIW6cfvmbD26ZvCHQLTGzJxnYwvaRlLtW 1503352806 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 37C1C24604; Mon, 21 Aug 2017 18:00:06 -0400 (EDT) From: Marius Bakke To: Stefan =?utf-8?Q?Reich=C3=B6r?= , 28151@debbugs.gnu.org Subject: Re: [bug#28151] [PATCH] gnu: Add honcho. In-Reply-To: <87valj72yp.fsf@xsteve.at> References: <87valj72yp.fsf@xsteve.at> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Tue, 22 Aug 2017 00:00:04 +0200 Message-ID: <87378k4m57.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28151 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Reich=C3=B6r writes: > * gnu/packages/python.scm (python-honcho): New variable. Thanks! I noticed this runs no tests, can you try to add a phase that invokes "pytest" instead of relying on the default "setup.py test"? It looks like it might require some extra (native) inputs, but they should already be in Guix: https://github.com/nickstenning/honcho/blob/master/tox.ini#L17 Also, since this seems to be some kind of process manager, perhaps it would be better suited in 'admin.scm' (without the 'python-' prefix)? Just a question, anyway. The patch looks good to me (but make sure it passes `guix lint`). TIA! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmbV+QACgkQoqBt8qM6 VPqITwgA1XlW9YbJdIKZJYP78r73WWuIopsfQbKNJmRv7msdT6r/O7IB0qqcI20Q nLYQ03L1bOiJf5BUN/LktdL7kDovhU/mEWmD8oAL5fi7D4CVKJRspmMa94n2C+LO a+A81PhpHcpz/Es/np+YHyhhKiZZpdDnLzmwhdLV+dydbRGZ7GnKzggGCXkmdac8 fz6+Eq2TEE+tu5iMwEvU6AdMFnOcG0aFUV25fFrbKpNaPHjdmHlzzfD9YZPwdzOq WDfJ6nkHeQRasrmkAmuMye8+UWnPSwHZXEjcptjPVkDeDbqYqzulcwYNkIv8foqB vvOF/90/6+hoEPOYpVrNwiTWRobi3Q== =RXmJ -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 22 15:43:17 2017 Received: (at submit) by debbugs.gnu.org; 22 Aug 2017 19:43:17 +0000 Received: from localhost ([127.0.0.1]:49894 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkF4r-0000GX-Rp for submit@debbugs.gnu.org; Tue, 22 Aug 2017 15:43:17 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkF4j-0000Fu-6u for submit@debbugs.gnu.org; Tue, 22 Aug 2017 15:43:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkF4c-00044N-Il for submit@debbugs.gnu.org; Tue, 22 Aug 2017 15:42:51 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:34819) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkF4c-00044J-Eu for submit@debbugs.gnu.org; Tue, 22 Aug 2017 15:42:50 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44686) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkF4Z-00063V-O8 for guix-patches@gnu.org; Tue, 22 Aug 2017 15:42:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkF4W-00040u-Gv for guix-patches@gnu.org; Tue, 22 Aug 2017 15:42:47 -0400 Received: from dd5424.kasserver.com ([85.13.138.252]:55738) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkF4W-00040R-6Z for guix-patches@gnu.org; Tue, 22 Aug 2017 15:42:44 -0400 Received: from localhost (37-186-9-252.ip.as39912.net [37.186.9.252]) by dd5424.kasserver.com (Postfix) with ESMTPA id 8D17DB5804CD for ; Tue, 22 Aug 2017 21:42:37 +0200 (CEST) From: Stefan =?utf-8?Q?Reich=C3=B6r?= To: guix-patches@gnu.org Subject: Re: [bug#28151] [PATCH] gnu: Add honcho. In-Reply-To: <87378k4m57.fsf@fastmail.com> (Marius Bakke's message of "Tue, 22 Aug 2017 00:00:04 +0200") References: <87valj72yp.fsf@xsteve.at> <87378k4m57.fsf@fastmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Tue, 22 Aug 2017 21:42:36 +0200 Message-ID: <87378jo0cz.fsf@xsteve.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Marius Bakke writes: > Stefan Reich=C3=B6r writes: > >> * gnu/packages/python.scm (python-honcho): New variable. > > Thanks! I noticed this runs no tests, can you try to add a phase that > invokes "pytest" instead of relying on the default "setup.py test"? > > It looks like it might require some extra (native) inputs, but they > should already be in Guix: > > https://github.com/nickstenning/honcho/blob/master/tox.ini#L17 I tried to add a py.test check phase. But I failed. By reading python.scm I found two ways to do such tests a) before installation (arguments '(#:phases (modify-phases %standard-phases (replace 'check (lambda _ (zero? (system* "py.test" "-vv" ))))))) b) after installation (arguments `(#:phases (modify-phases %standard-phases (delete 'check) (add-after 'install 'check (lambda* (#:key outputs inputs #:allow-other-keys) ;; It's easier to run tests after install. ;; Make installed package available for running the tests (add-installed-pythonpath inputs outputs) (zero? (system* "py.test" "-vv"))))))) I added the following to get pytest dependencies in: (native-inputs `(("python-pytest" ,python-pytest) ("python-mock" ,python-mock) ("python-tox" ,python-tox))) ;for tests Both ways have the same effect: They don't collect any tests: ,---- | platform linux -- Python 3.5.3 -- py-1.4.32 -- pytest-2.7.3 -- /gnu/store= /bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python | rootdir: /tmp/guix-build-python-honcho-1.0.1.drv-0/honcho-1.0.1, inifile:= =20 | collecting ... collected 0 items `---- When I run py.test on my Ubuntu machine, the tox.ini file is picked up and I can run the tests: ,---- | platform linux2 -- Python 2.7.12, pytest-2.8.7, py-1.4.31, pluggy-0.3.1 | rootdir: /home/stefan/work/git/honcho, inifile: tox.ini | plugins: mock-0.8.1 | collected 123 items=20 |=20 | tests/test_colour.py .. | tests/test_environ.py .......................................... | tests/test_export_base.py ............. | tests/test_export_runit.py .. | tests/test_export_supervisord.py .. | tests/test_export_upstart.py ..... | tests/test_manager.py ............... | tests/test_printer.py .............. | tests/test_process.py .............. | tests/integration/test_check.py . | tests/integration/test_export.py ... | tests/integration/test_run.py .... | tests/integration/test_start.py ...... |=20 | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D 123 passed in 19.25 seconds =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D `---- Of course, the python versions are different. But the test for the guix package seems to be run either in a wrong directory or some files (tox.ini) are missing... Sorry - I have no idea how to proceed. > Also, since this seems to be some kind of process manager, perhaps it > would be better suited in 'admin.scm' (without the 'python-' prefix)? This was also my first intention. However, after reading https://honcho.readthedocs.io/en/latest/, I thought that honcho could also be used as python library. No idea how many users will do that... > Just a question, anyway. The patch looks good to me (but make sure it > passes `guix lint`). > > TIA! Stefan. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 22 16:09:04 2017 Received: (at submit) by debbugs.gnu.org; 22 Aug 2017 20:09:04 +0000 Received: from localhost ([127.0.0.1]:49906 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkFTp-0002gL-PD for submit@debbugs.gnu.org; Tue, 22 Aug 2017 16:09:04 -0400 Received: from eggs.gnu.org ([208.118.235.92]:60184) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkFTf-0002fz-72 for submit@debbugs.gnu.org; Tue, 22 Aug 2017 16:08:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkFTY-0000nK-Ia for submit@debbugs.gnu.org; Tue, 22 Aug 2017 16:08:37 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52424) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkFTY-0000nC-Em for submit@debbugs.gnu.org; Tue, 22 Aug 2017 16:08:36 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51155) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkFTW-0006mO-Ry for guix-patches@gnu.org; Tue, 22 Aug 2017 16:08:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkFTT-0000lR-Ke for guix-patches@gnu.org; Tue, 22 Aug 2017 16:08:34 -0400 Received: from dd5424.kasserver.com ([85.13.138.252]:56562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkFTT-0000ke-Al for guix-patches@gnu.org; Tue, 22 Aug 2017 16:08:31 -0400 Received: from localhost (37-186-9-252.ip.as39912.net [37.186.9.252]) by dd5424.kasserver.com (Postfix) with ESMTPA id 95B9CB5804CD for ; Tue, 22 Aug 2017 22:08:26 +0200 (CEST) From: Stefan =?utf-8?Q?Reich=C3=B6r?= To: guix-patches@gnu.org Subject: Re: [bug#28151] [PATCH] gnu: Add honcho. In-Reply-To: <87378jo0cz.fsf@xsteve.at> ("Stefan =?utf-8?Q?Reich=C3=B6r=22?= =?utf-8?Q?'s?= message of "Tue, 22 Aug 2017 21:42:36 +0200") References: <87valj72yp.fsf@xsteve.at> <87378k4m57.fsf@fastmail.com> <87378jo0cz.fsf@xsteve.at> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Tue, 22 Aug 2017 22:08:26 +0200 Message-ID: <87y3qbmklh.fsf@xsteve.at> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.0 (/) Stefan Reich=C3=B6r writes: > Marius Bakke writes: > >> Stefan Reich=C3=B6r writes: >> >>> * gnu/packages/python.scm (python-honcho): New variable. >> >> Thanks! I noticed this runs no tests, can you try to add a phase that >> invokes "pytest" instead of relying on the default "setup.py test"? >> >> It looks like it might require some extra (native) inputs, but they >> should already be in Guix: >> >> https://github.com/nickstenning/honcho/blob/master/tox.ini#L17 > > I tried to add a py.test check phase. But I failed. > > By reading python.scm I found two ways to do such tests > > a) before installation > (arguments > '(#:phases > (modify-phases %standard-phases > (replace 'check > (lambda _ > (zero? (system* "py.test" "-vv" ))))))) > > b) after installation > (arguments > `(#:phases > (modify-phases %standard-phases > (delete 'check) > (add-after 'install 'check > (lambda* (#:key outputs inputs #:allow-other-keys) > ;; It's easier to run tests after install. > ;; Make installed package available for running the tests > (add-installed-pythonpath inputs outputs) > (zero? (system* "py.test" "-vv"))))))) > > > I added the following to get pytest dependencies in: > (native-inputs > `(("python-pytest" ,python-pytest) > ("python-mock" ,python-mock) > ("python-tox" ,python-tox))) ;for tests > > Both ways have the same effect: They don't collect any tests: > ,---- > | platform linux -- Python 3.5.3 -- py-1.4.32 -- pytest-2.7.3 -- /gnu/sto= re/bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python > | rootdir: /tmp/guix-build-python-honcho-1.0.1.drv-0/honcho-1.0.1, inifil= e:=20 > | collecting ... collected 0 items > `---- > > When I run py.test on my Ubuntu machine, the tox.ini file is picked up > and I can run the tests: > ,---- > | platform linux2 -- Python 2.7.12, pytest-2.8.7, py-1.4.31, pluggy-0.3.1 > | rootdir: /home/stefan/work/git/honcho, inifile: tox.ini > | plugins: mock-0.8.1 > | collected 123 items=20 > |=20 > | tests/test_colour.py .. > | tests/test_environ.py .......................................... > | tests/test_export_base.py ............. > | tests/test_export_runit.py .. > | tests/test_export_supervisord.py .. > | tests/test_export_upstart.py ..... > | tests/test_manager.py ............... > | tests/test_printer.py .............. > | tests/test_process.py .............. > | tests/integration/test_check.py . > | tests/integration/test_export.py ... > | tests/integration/test_run.py .... > | tests/integration/test_start.py ...... > |=20 > | =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D 123 passed in 19.25 seconds =3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > `---- > > Of course, the python versions are different. But the test for the guix > package seems to be run either in a wrong directory or some files > (tox.ini) are missing... > > Sorry - I have no idea how to proceed. To follow up on my mail. I took a look at the downloaded honcho distribution .tgz: /gnu/store/74vi1s1rjhr9xzn0vzsqh8rx2b121lsj-honcho-1.0.1.tar.gz It does not contain the tests. If we really need to run the tests we can't use the release tarball. I am not sure if this is worth the extra hassle... What do you think? > >> Also, since this seems to be some kind of process manager, perhaps it >> would be better suited in 'admin.scm' (without the 'python-' prefix)? > > This was also my first intention. > > However, after reading https://honcho.readthedocs.io/en/latest/, > I thought that honcho could also be used as python library. > No idea how many users will do that... > >> Just a question, anyway. The patch looks good to me (but make sure it >> passes `guix lint`). >> >> TIA! > > > Stefan. From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 22 16:21:14 2017 Received: (at 28151) by debbugs.gnu.org; 22 Aug 2017 20:21:14 +0000 Received: from localhost ([127.0.0.1]:49925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkFfm-0002yw-FY for submit@debbugs.gnu.org; Tue, 22 Aug 2017 16:21:14 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39505) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkFfk-0002yn-2K for 28151@debbugs.gnu.org; Tue, 22 Aug 2017 16:21:12 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 93D96214C4; Tue, 22 Aug 2017 16:21:11 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Tue, 22 Aug 2017 16:21:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=dOtafHG1xwD65BhzajIZQ5C2T8oZyC3Du/JGgzWiN uE=; b=u2zZY4vpLcilrGnNNjfH1s6fGbT6nro4lS+4D9TM0VHsWY26ZCiSz3Pg4 yZ8cAr9ebp3Dv2HnDVO/wrEIK+CBkG4N3iCaStVkpyfASJwe5u1FzRNvMvHq67uK 4+tgntUJblmzK5XuCqkeek23EcNFfHk1o+aS4h0Rq1U/n5x0JGy87rVci6J+VjEU UbO3vCG8XOFnQoMzl0lF8DwivaXkLd8ZZiYKW3+Pc3JL0DdGsR2zW7viWG4Zur/x bpt4EgXbiJUeiAMh2EDgD5g9r2y6qxpagB+QA0soDGUHG2eGUd9WKMdPJGT/FDVU YzTMnpvtuAWVYSCf3FUyEQU6RLf6Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=dOtafHG1xwD65Bhzaj IZQ5C2T8oZyC3Du/JGgzWiNuE=; b=cWuRr9GBPvm/GBtP9blzs/76/vSTsyQD/9 ULzpbK7RzJhZa3TjBECh6yL7ey62Wd/QpLlcb3DKqq5xyA13iZSi120mKxotygdm i4Lzx3ZNpQTJ6y7JeDVggfcHl7mZrhxq3tEjhueaklvv0BLsuPfT+0QEnPRh0+3I fwb3oYhmqt4u+8dPv2souBRgYuFldd+DrI+/6bhpIYIjskU2q25Ukx8gNPwYCi9M Ys48l+2Fk/QPnJdHYnxuRH+tebXmtiV9qRhFgsiRPWrlsWk/aJPj4I0KkexZCfvO Ia0nirIXfOp5Q3H1FSKU6k9RkuSet7w028dBA/Bmt1lHf5TW5BXw== X-ME-Sender: X-Sasl-enc: IJo+2NP9O3X1LJOc0t3erK5bHG92nfcJTHJBmvvXQ44H 1503433271 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 2B73224335; Tue, 22 Aug 2017 16:21:11 -0400 (EDT) From: Marius Bakke To: Stefan =?utf-8?Q?Reich=C3=B6r?= , 28151@debbugs.gnu.org Subject: Re: [bug#28151] [PATCH] gnu: Add honcho. In-Reply-To: <87378jo0cz.fsf@xsteve.at> References: <87valj72yp.fsf@xsteve.at> <87378k4m57.fsf@fastmail.com> <87378jo0cz.fsf@xsteve.at> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Tue, 22 Aug 2017 22:21:09 +0200 Message-ID: <87pobn2w22.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28151 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Reich=C3=B6r writes: > Marius Bakke writes: > >> Stefan Reich=C3=B6r writes: >> >>> * gnu/packages/python.scm (python-honcho): New variable. >> >> Thanks! I noticed this runs no tests, can you try to add a phase that >> invokes "pytest" instead of relying on the default "setup.py test"? >> >> It looks like it might require some extra (native) inputs, but they >> should already be in Guix: >> >> https://github.com/nickstenning/honcho/blob/master/tox.ini#L17 > > I tried to add a py.test check phase. But I failed. > > By reading python.scm I found two ways to do such tests > > a) before installation > (arguments > '(#:phases > (modify-phases %standard-phases > (replace 'check > (lambda _ > (zero? (system* "py.test" "-vv" ))))))) > > b) after installation > (arguments > `(#:phases > (modify-phases %standard-phases > (delete 'check) > (add-after 'install 'check > (lambda* (#:key outputs inputs #:allow-other-keys) > ;; It's easier to run tests after install. > ;; Make installed package available for running the tests > (add-installed-pythonpath inputs outputs) > (zero? (system* "py.test" "-vv"))))))) > > > I added the following to get pytest dependencies in: > (native-inputs > `(("python-pytest" ,python-pytest) > ("python-mock" ,python-mock) > ("python-tox" ,python-tox))) ;for tests > > Both ways have the same effect: They don't collect any tests: > ,---- > | platform linux -- Python 3.5.3 -- py-1.4.32 -- pytest-2.7.3 -- /gnu/sto= re/bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python > | rootdir: /tmp/guix-build-python-honcho-1.0.1.drv-0/honcho-1.0.1, inifil= e:=20 > | collecting ... collected 0 items > `---- Aaah, sorry. I was browsing the GitHub source code and failed to notice that the distribution tarball on PyPi does not contain any tests. So we can either switch to using the GitHub snapshots so that we can notice breakage early, or lose tests but gain the integrity guarantees from using the PGP-signed tarball on PyPi. I don't really have a strong preference, but it's worth creating an upstream issue in either case IMO. Ideally we'd have both. I'll let you be the judge, being the end user and all :) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmckjUACgkQoqBt8qM6 VPox9wf+LWor9sUXTs5HT02oZ+7g6Gn/fLSQit5jvSyE8tHRDJLUhKSUMLwwhrrG auuodbBSmnxWf/GPeoXG4rj24h0+vxUbjP0O0R31HQepKzyDVnX8KE3NaCy3+r0U nMF4vtOXTMQLnXeS7gl01u5NsEx2uOs2yHy7OQIEzdGZMud8QBhZ/G642mKZ2+7z SgWyEtVwW8kB2CnDF0leTCJXCEKXW/+uN5yXIHgg+rk6+KY4OHhFUlPVmhlcAAVr MVzhtXbTydE03akckPGvgXrTcwg6kC2ZFtsf6dqHhvnSadl+VPpHkcAeFEgXS2u+ IcNcOvSe7u+8iF5FJzjdSClvFHiEHQ== =LXHO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 16:23:34 2017 Received: (at submit) by debbugs.gnu.org; 23 Aug 2017 20:23:34 +0000 Received: from localhost ([127.0.0.1]:51761 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkcBW-0003yO-SX for submit@debbugs.gnu.org; Wed, 23 Aug 2017 16:23:34 -0400 Received: from eggs.gnu.org ([208.118.235.92]:51060) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkcBV-0003yB-AK for submit@debbugs.gnu.org; Wed, 23 Aug 2017 16:23:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkcBP-0005Ui-24 for submit@debbugs.gnu.org; Wed, 23 Aug 2017 16:23:24 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:47452) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkcBO-0005Uc-Ub for submit@debbugs.gnu.org; Wed, 23 Aug 2017 16:23:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42031) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dkcBN-00063e-LR for guix-patches@gnu.org; Wed, 23 Aug 2017 16:23:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dkcBK-0005Rj-AP for guix-patches@gnu.org; Wed, 23 Aug 2017 16:23:21 -0400 Received: from dd5424.kasserver.com ([85.13.138.252]:50721) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dkcBJ-0005NU-Vt for guix-patches@gnu.org; Wed, 23 Aug 2017 16:23:18 -0400 Received: from localhost (37-186-9-252.ip.as39912.net [37.186.9.252]) by dd5424.kasserver.com (Postfix) with ESMTPA id 17498B58018E for ; Wed, 23 Aug 2017 22:23:12 +0200 (CEST) From: Stefan =?utf-8?Q?Reich=C3=B6r?= To: guix-patches@gnu.org Subject: Re: [bug#28151] [PATCH] gnu: Add honcho. In-Reply-To: <87pobn2w22.fsf@fastmail.com> (Marius Bakke's message of "Tue, 22 Aug 2017 22:21:09 +0200") References: <87valj72yp.fsf@xsteve.at> <87378k4m57.fsf@fastmail.com> <87378jo0cz.fsf@xsteve.at> <87pobn2w22.fsf@fastmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) Date: Wed, 23 Aug 2017 22:23:12 +0200 Message-ID: <87inheqbin.fsf@xsteve.at> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Marius Bakke writes: >> >> Both ways have the same effect: They don't collect any tests: >> ,---- >> | platform linux -- Python 3.5.3 -- py-1.4.32 -- pytest-2.7.3 -- /gnu/store/bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python >> | rootdir: /tmp/guix-build-python-honcho-1.0.1.drv-0/honcho-1.0.1, inifile: >> | collecting ... collected 0 items >> `---- > > Aaah, sorry. I was browsing the GitHub source code and failed to notice > that the distribution tarball on PyPi does not contain any tests. > > So we can either switch to using the GitHub snapshots so that we can > notice breakage early, or lose tests but gain the integrity guarantees > from using the PGP-signed tarball on PyPi. > > I don't really have a strong preference, but it's worth creating an > upstream issue in either case IMO. Ideally we'd have both. > > I'll let you be the judge, being the end user and all :) I switched to the github tarball and I was able to get the testsuite to pass. Attached is my current attempt. Stefan. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-gnu-Add-honcho.patch >From dc289a9c328f6a8f77e88decfa93695da4c735f6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Stefan=20Reich=C3=B6r?= Date: Wed, 23 Aug 2017 22:19:57 +0200 Subject: [PATCH] gnu: Add honcho. * gnu/packages/python.scm (python-honcho): New variable. --- gnu/packages/python.scm | 47 +++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 47 insertions(+) diff --git a/gnu/packages/python.scm b/gnu/packages/python.scm index d328178..9578f1c 100644 --- a/gnu/packages/python.scm +++ b/gnu/packages/python.scm @@ -5226,6 +5226,53 @@ cluster without needing to write any wrapper code yourself.") (define-public python2-gridmap (package-with-python2 python-gridmap)) +(define-public python-honcho + (package + (name "python-honcho") + (version "1.0.1") + (source + (origin + (method url-fetch) + (uri (string-append + "https://github.com/nickstenning/honcho/archive/v" + version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 "0zizn61n5z5hq421hkypk9pw8s6fpxw30f4hsg7k4ivwzy3gjw9j")))) + (build-system python-build-system) + (native-inputs + `(("python-pytest" ,python-pytest-3.0) + ("python-mock" ,python-mock) + ("python-tox" ,python-tox) + ("which" ,which))) ;for tests + (propagated-inputs + `(("python-jinja2" ,python-jinja2))) + (arguments + `(#:phases + (modify-phases %standard-phases + (delete 'check) + (add-after 'install 'check + (lambda* (#:key outputs inputs #:allow-other-keys) + ;; fix honcho path in testsuite + (substitute* "tests/conftest.py" + (("'honcho'") (string-append "'" (assoc-ref outputs "out") + "/bin/honcho" "'"))) + ;; It's easier to run tests after install. + ;; Make installed package available for running the tests + (add-installed-pythonpath inputs outputs) + (zero? (system* "py.test" "-v"))))))) + (home-page "https://github.com/nickstenning/honcho") + (synopsis "Manage Procfile-based applications") + (description + "A Procfile is a file which describes how to run an application +consisting of serveral processes. honcho starts all listed processes. +The output of all running processes is collected by honcho and +displayed.") + (license license:expat))) + +(define-public python2-honcho + (package-with-python2 python-honcho)) + (define-public python-pexpect (package (name "python-pexpect") -- 2.7.4 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 15:29:53 2017 Received: (at 28151-done) by debbugs.gnu.org; 24 Aug 2017 19:29:53 +0000 Received: from localhost ([127.0.0.1]:53193 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkxpA-00026a-OK for submit@debbugs.gnu.org; Thu, 24 Aug 2017 15:29:52 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:45875) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkxp9-00026S-32 for 28151-done@debbugs.gnu.org; Thu, 24 Aug 2017 15:29:51 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 88A9F20C89; Thu, 24 Aug 2017 15:29:50 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Thu, 24 Aug 2017 15:29:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=rDi7b9w6CftKEBUFl6zoKNeTg+hVUNeaIlPZeSOnR 6Y=; b=B4F/9eTHD53bEIknyb4mlQLDXWoQnxlrR049WgQBiYQPYRvhRCAXSYgdb IrAhoELNdcWIlcm+AyeEdkX+2B2o7/Y2pKDmTkCGuh1k1oDq6S6nB64CcGwEE/dM AORSiDY+3F0rPJZk3R63YfpN8DnSGRlGw4reqgm/VGfdf91bvA+6fKkVLyAEXBiK HjZOOKQhgHLZTS71ImNFPb4P2eSH6gtDy0nclPl4nvrCD/4LVgAoUSMuyFXRloFY GmeUhikjG7ZHwtdIkiKEF/dZ7nowZHdZ+2gML1p7cvLQ2QecK4LohVXmapDmHS60 BroWugncnhZENPFRYXXMD30tPMc9Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=rDi7b9w6CftKEBUFl6 zoKNeTg+hVUNeaIlPZeSOnR6Y=; b=fUnXid09q82Bino0KZE/Am3XMhFDYttAsb F1fEovsstGJ5YTQq8/JltbMTqwuyuN0sXLkhVCs0zWNZrz8ER0+Tn2gfod9W+rnp bMLLFaVuLBU8BAu+3EQbIklf0qVSKiIBnxFlYcu5D89PCKfrQMN7BUCuMi/DWhV3 +IZdvNPEShmUccGJgZT8fJ7Q4Lnf/EYzpFWckYaOMoNCvQXz9iKna0+ISB3+1kBv uqr6QGD/NYsfwY/7F8z+3FDjgNjrTRjG4WgZ0/x/Jyl/IgBcfeuxxTP3B2u+OI48 5klvE8lyh4CYP7q8Dpt+JnYjs6yBbdP+pqiVZsv57zkIDdvtJW5A== X-ME-Sender: X-Sasl-enc: EFLcF+6VP7nP8PMj3Nh919haPATLZqHWSEPDIGj5hUrl 1503602990 Received: from localhost (unknown [92.62.32.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 13906240B1; Thu, 24 Aug 2017 15:29:49 -0400 (EDT) From: Marius Bakke To: Stefan =?utf-8?Q?Reich=C3=B6r?= , 28151-done@debbugs.gnu.org Subject: Re: [bug#28151] [PATCH] gnu: Add honcho. In-Reply-To: <87inheqbin.fsf@xsteve.at> References: <87valj72yp.fsf@xsteve.at> <87378k4m57.fsf@fastmail.com> <87378jo0cz.fsf@xsteve.at> <87pobn2w22.fsf@fastmail.com> <87inheqbin.fsf@xsteve.at> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Thu, 24 Aug 2017 21:29:47 +0200 Message-ID: <87k21s228k.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28151-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Stefan Reich=C3=B6r writes: > Marius Bakke writes: > >>> >>> Both ways have the same effect: They don't collect any tests: >>> ,---- >>> | platform linux -- Python 3.5.3 -- py-1.4.32 -- pytest-2.7.3 -- /gnu/s= tore/bf54hnwd8mb63zmssc23fwslf5zvxpxs-python-wrapper-3.5.3/bin/python >>> | rootdir: /tmp/guix-build-python-honcho-1.0.1.drv-0/honcho-1.0.1, inif= ile:=20 >>> | collecting ... collected 0 items >>> `---- >> >> Aaah, sorry. I was browsing the GitHub source code and failed to notice >> that the distribution tarball on PyPi does not contain any tests. >> >> So we can either switch to using the GitHub snapshots so that we can >> notice breakage early, or lose tests but gain the integrity guarantees >> from using the PGP-signed tarball on PyPi. >> >> I don't really have a strong preference, but it's worth creating an >> upstream issue in either case IMO. Ideally we'd have both. >> >> I'll let you be the judge, being the end user and all :) > > I switched to the github tarball and I was able to get the testsuite to p= ass. Great! > > Attached is my current attempt. Pushed as 84342e2fa95fb5ff972c5c216b0548787e25f142. Thanks! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmfKSwACgkQoqBt8qM6 VPqUJgf/WCnCOZytwrQCmiwvhhI6hUJGmUWQklMcR5a/u36ZpRtn1uiY6UJoBuju S7PR3MDYHa9Yq8ol56AkmyHCqxd8lVb4mIVccnYFRYLJtqGSk/hPHhT7z66CdrV/ 3vKwP7/QXlFoy4lit7YORMJL3Dbvoin2IwSBvvXTVDY2+lJb3NHbokOZnjd1n8cR If24NTaJrPiSJxjLpSqy5vMnadrMJaxZx26haQRGj/XHubkwVf+3anmTvQDZ6th4 jwRf9yHDyV5JgYTOszjuGpH8Nfqhcf//jSCkqkdjVfOWuCoEowJaynVs9x5ZbU3F z+rcL9aZ//uvdGdMkG35Y4PPdSwhfQ== =ZGsB -----END PGP SIGNATURE----- --=-=-=-- From unknown Fri Aug 15 20:49:19 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 22 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator