GNU bug report logs - #28129
[PATCH 0/1] gnu: python-internetarchive: Update to 1.7.1.

Previous Next

Package: guix-patches;

Reported by: Oleg Pykhalov <go.wigust <at> gmail.com>

Date: Thu, 17 Aug 2017 20:37:02 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <mbakke <at> fastmail.com>

Bug is archived. No further changes may be made.

Full log


Message #13 received at 28129-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Oleg Pykhalov <go.wigust <at> gmail.com>, 28129-done <at> debbugs.gnu.org
Subject: Re: [bug#28129] [PATCH 0/1] gnu: python-internetarchive: Update to
 1.7.1.
Date: Mon, 21 Aug 2017 23:45:54 +0200
[Message part 1 (text/plain, inline)]
Oleg Pykhalov <go.wigust <at> gmail.com> writes:

> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=27699
>
> Danny Milosavljevic <dannym <at> scratchpost.org> writes:
>> After I fixed up the test invocation, still 11 tests of 105 fail,
>> apparently mostly because the Requests mock doesn't work.  Could you
>> take a look?
>
>> The mocking is done in tests/conftest.py in internetarchive-1.6.0.
>
> 11 failed, whose (maybe) all require internet connections.  When Guix
> build a package he has no networking inside chroot, has it?
>
> So, we cannot pass those tests.  Could we just disable them selectively
> (not all 105)?

Hmf.  It amazes me that pytest still has no "networking?" toggle.

The tests can be disabled selectively on the command line with the "-k"
switch.  See 'python-pyopenssl' for an example.  In this case it would
be something like "not test_item_with_kwargs and not test_ia and not...".

Would you like to try it?  I applied this patch regardless since it's
apparently not a new problem.  Thanks!
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 8 years and 4 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.