GNU bug report logs - #28116
MATE (and mate-terminal + caja)

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28116 in the body.
You can then email your comments to 28116 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: guix-patches <at> gnu.org
Subject: MATE (and mate-terminal + caja)
Date: Wed, 16 Aug 2017 20:56:50 +0000

[Message part 1 (text/plain, inline)]

Hi,

appended are the patches to add the minimal base of the
MATE Desktop Environment which is required to log into
it use it with the panel.

I have tested the package "mate" successfully on x86_64 in a VM.

mate-terminal and caja work outside of the environment,
and can be tested with any desktop environment/manager.

There are some descriptions which can be improved
because the upstream description was super short.

Some last input checks must be done aswell, I'll
send this as version 1 of the patch series now.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-mate-Fetch-sources-via-https.patch (text/plain, attachment)]

[0002-gnu-Add-caja.patch (text/plain, attachment)]

[0003-gnu-Add-mate-terminal.patch (text/plain, attachment)]

[0004-gnu-Add-marco.patch (text/plain, attachment)]

[0005-gnu-Add-mate-session-manager.patch (text/plain, attachment)]

[0006-gnu-Add-mate-panel.patch (text/plain, attachment)]

[0007-gnu-Add-libmatemixer.patch (text/plain, attachment)]

[0008-gnu-Add-libmatekbd.patch (text/plain, attachment)]

[0009-gnu-Add-mate-settings-daemon.patch (text/plain, attachment)]

[0010-gnu-Add-mate.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #8 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: 28116 <at> debbugs.gnu.org
Subject: Re: [bug#28116] MATE (and mate-terminal + caja)
Date: Wed, 23 Aug 2017 21:04:28 +0000

[Message part 1 (text/plain, inline)]

Version 2 appended:
[abyayala] 9:00pm guix > ls *.patch
4.0K 0001-gnu-mate-Fetch-sources-via-https.patch                    4.0K 0005-gnu-Add-mate-terminal.patch         4.0K 0009-gnu-Add-libmatemixer.patch          4.0K 0013-gnu-Add-mate-media.patch
4.0K 0002-gnu-Add-caja.patch                                        4.0K 0006-gnu-Add-marco.patch                 4.0K 0010-gnu-Add-libmatekbd.patch            4.0K 0014-gnu-Add-mate-control-center.patch
4.0K 0003-gnu-mate-themes-Update-to-3.22.13.patch                   4.0K 0007-gnu-Add-mate-session-manager.patch  4.0K 0011-gnu-Add-mate-settings-daemon.patch  4.0K 0015-gnu-Add-mate.patch
4.0K 0004-gnu-mate-desktop-Add-gtk-doc-back-to-native-inputs.patch  4.0K 0008-gnu-Add-mate-panel.patch            8.0K 0012-gnu-Add-mate-applets.patch

This adds an almost complete MATE desktop, 6 upstream applications are still missing but the MATE experience is there.
Missing are power-manager and screensavers for example.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-mate-Fetch-sources-via-https.patch (text/plain, attachment)]

[0002-gnu-Add-caja.patch (text/plain, attachment)]

[0003-gnu-mate-themes-Update-to-3.22.13.patch (text/plain, attachment)]

[0004-gnu-mate-desktop-Add-gtk-doc-back-to-native-inputs.patch (text/plain, attachment)]

[0005-gnu-Add-mate-terminal.patch (text/plain, attachment)]

[0006-gnu-Add-marco.patch (text/plain, attachment)]

[0007-gnu-Add-mate-session-manager.patch (text/plain, attachment)]

[0008-gnu-Add-mate-panel.patch (text/plain, attachment)]

[0009-gnu-Add-libmatemixer.patch (text/plain, attachment)]

[0010-gnu-Add-libmatekbd.patch (text/plain, attachment)]

[0011-gnu-Add-mate-settings-daemon.patch (text/plain, attachment)]

[0012-gnu-Add-mate-applets.patch (text/plain, attachment)]

[0013-gnu-Add-mate-media.patch (text/plain, attachment)]

[0014-gnu-Add-mate-control-center.patch (text/plain, attachment)]

[0015-gnu-Add-mate.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 28116 <at> debbugs.gnu.org
Subject: mate partial review
Date: Thu, 24 Aug 2017 23:42:46 +0300

[Message part 1 (text/plain, inline)]

I did all the building on my aarch64 board and didn't test the graphical
aspects of running the programs. I also didn't check the
synopsis/description, but some of them do look like they need some work.

patch 1: it turns out the home pages should also be https.

mate-icon-theme and mate-themes don't need gtk in the inputs to build.

libmateweather, mate-panel, mate-control-center: needs a configure flag

mate-applet: it built fine for me with upower as an input

mate-control-center: librsvg and gdk-pixbuf should be propagated

caja: I enabled the display server and the tests still failed on me

mate-metapackage: I copied the build from xfce, it seemed to build fine
for me.

I've attached a diff of what I have. I suggest you alphabetize the
inputs, it makes checking for duplicate or missing inputs much easier.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[mate.diff (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 28116 <at> debbugs.gnu.org
Subject: Re: [bug#28116] mate partial review
Date: Fri, 25 Aug 2017 18:11:25 +0000

[Message part 1 (text/plain, inline)]

Efraim Flashner transcribed 16K bytes:
> I did all the building on my aarch64 board and didn't test the graphical
> aspects of running the programs. I also didn't check the
> synopsis/description, but some of them do look like they need some work.

Thanks for this first review.
I'll apply this as far as I can guess, having it all in one
patch makes it hard to read but I'll figure it out.

> patch 1: it turns out the home pages should also be https.
> 
> mate-icon-theme and mate-themes don't need gtk in the inputs to build.
> 
> libmateweather, mate-panel, mate-control-center: needs a configure flag
> 
> mate-applet: it built fine for me with upower as an input
> 
> mate-control-center: librsvg and gdk-pixbuf should be propagated
> 
> caja: I enabled the display server and the tests still failed on me
> 
> mate-metapackage: I copied the build from xfce, it seemed to build fine
> for me.

Why use it like this? I copied my version from "gnome".

> I've attached a diff of what I have. I suggest you alphabetize the
> inputs, it makes checking for duplicate or missing inputs much easier.
> 
> -- 
> Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted

> diff --git a/gnu/packages/mate.scm b/gnu/packages/mate.scm
> index 40359ede2a..d33b1445b9 100644
> --- a/gnu/packages/mate.scm
> +++ b/gnu/packages/mate.scm
> @@ -66,9 +66,8 @@
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)
> -       ("gtk+" ,gtk+)
>         ("icon-naming-utils" ,icon-naming-utils)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "The MATE desktop environment icon theme")
>      (description
>       "This package contains the default icon theme used by the MATE desktop.")
> @@ -91,11 +90,10 @@
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)))
>      (inputs
> -     `(("gtk+" ,gtk+)
> -       ("gdk-pixbuf" ,gdk-pixbuf)
> +     `(("gdk-pixbuf" ,gdk-pixbuf)
>         ("gtk-engines" ,gtk-engines)
>         ("murrine" ,murrine)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis
>       "Official themes for the MATE desktop")
>      (description
> @@ -131,7 +129,7 @@ themes for both gtk+-2 and gtk+-3.")
>         ("startup-notification" ,startup-notification)))
>      (propagated-inputs
>       `(("dconf" ,dconf))) ; mate-desktop-2.0.pc
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Library with common API for various MATE modules")
>      (description
>       "This package contains a public API shared by several applications on the
> @@ -152,14 +150,14 @@ desktop and the mate-about program.")
>                  "0z6vfh42fv9rqjrraqfpf6h9nd9h662bxy3l3r48j19xvxrwmx3a"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:configure-flags
> +     '(#:configure-flags
>         (list (string-append "--with-zoneinfo-dir="
>                              (assoc-ref %build-inputs "tzdata")
> -                            "/share/zoneinfo"))
> +                            "/share/zoneinfo")
> +             "--disable-icon-update")
>         #:phases
>         (modify-phases %standard-phases
> -         (add-before
> -          'check 'pre-check
> +         (add-before 'check 'pre-check
>            (lambda* (#:key inputs #:allow-other-keys)
>              (substitute* "data/check-timezones.sh"
>                (("/usr/share/zoneinfo/zone.tab")
> @@ -179,7 +177,7 @@ desktop and the mate-about program.")
>        ;; both of these are requires.private in mateweather.pc
>       `(("libsoup" ,libsoup)
>         ("libxml2" ,libxml2)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "MATE library for weather information from the Internet")
>      (description
>       "This library provides access to weather information from the internet for
> @@ -220,7 +218,7 @@ the MATE desktop environment.")
>         ("mate-desktop" ,mate-desktop)))
>      (propagated-inputs
>       `(("dconf" ,dconf)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "MATE Terminal Emulator")
>      (description
>       "MATE Terminal is a terminal emulation application that you can
> @@ -255,7 +253,7 @@ configurations (profiles).  MATE Terminal is a fork of GNOME Terminal.")
>         ("dbus-glib" ,dbus-glib)
>         ("libsm" ,libsm)
>         ("mate-desktop" ,mate-desktop)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Session manager for MATE")
>      (description
>       "Mate-session contains the MATE session manager, as well as a
> @@ -303,7 +301,7 @@ configuration program to choose applications starting on login.")
>         ("libcanberra" ,libcanberra)
>         ("fontconfig" ,fontconfig)
>         ("dconf" ,dconf)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Settings Daemon for MATE")
>      (description
>       "Mate-settings-daemon is a fork of gnome-settings-daemon.")
> @@ -331,7 +329,7 @@ configuration program to choose applications starting on login.")
>       `(("glib" ,glib)
>         ("pulseaudio" ,pulseaudio)
>         ("alsa-lib" ,alsa-lib)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Mixer library for the MATE desktop")
>      (description
>       "Libmatemixer is a mixer library for MATE desktop.  It provides an abstract
> @@ -364,7 +362,7 @@ sound systems.")
>         ("cairo" ,cairo)
>         ("libx11" ,libx11)
>         ("libxklavier" ,libxklavier)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "MATE keyboard configuration library")
>      (description
>       "Libmatekbd is a keyboard configuration library for the
> @@ -387,8 +385,7 @@ MATE desktop environment.")
>      (arguments
>       `(#:phases
>         (modify-phases %standard-phases
> -         (add-after
> -          'unpack 'fix-introspection-install-dir
> +         (add-after 'unpack 'fix-introspection-install-dir
>            (lambda* (#:key outputs #:allow-other-keys)
>              (let ((out (assoc-ref outputs "out")))
>                (substitute* '("configure")
> @@ -404,7 +401,7 @@ MATE desktop environment.")
>      (inputs
>       `(("glib" ,glib)
>         ("python" ,python-2)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Freedesktop menu specification implementation for MATE")
>      (description
>       "The package contains an implementation of the freedesktop menu
> @@ -426,9 +423,6 @@ assorted menu related utility programs.")
>          (base32
>           "1nplr8i1mxbxd7pqhcy8j69v25nsp5dk9fq7ffrmjmp39lrf3fh5"))))
>      (build-system glib-or-gtk-build-system)
> -    (arguments
> -     ;; FIXME: Build with upower fails.
> -     `(#:configure-flags (list "--without-upower")))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)
> @@ -440,25 +434,27 @@ assorted menu related utility programs.")
>         ("gobject-introspection" ,gobject-introspection)))
>      (inputs
>       `(("atk" ,atk)
> +       ("dbus" ,dbus)
>         ("dbus-glib" ,dbus-glib)
> +       ("gdk-pixbuf" ,gdk-pixbuf)
>         ("glib" ,glib)
> -       ("libmateweather" ,libmateweather)
> -       ("libwnck" ,libwnck)
> -       ("pango" ,pango)
> +       ("gucharmap" ,gucharmap)
>         ("gtk+" ,gtk+)
>         ("gtksourceview" ,gtksourceview)
>         ("libgtop" ,libgtop)
> -       ("libxml2" ,libxml2)
> -       ("python-pygobject" ,python-pygobject)
> -       ("gucharmap" ,gucharmap)
> -       ("mate-panel" ,mate-panel)
> -       ("wireless-tools" ,wireless-tools)
> -       ("dbus" ,dbus)
>         ("libnotify" ,libnotify)
> +       ("libmateweather" ,libmateweather)
> +       ("libwnck" ,libwnck)
>         ("libx11" ,libx11)
> -       ("gdk-pixbuf" ,gdk-pixbuf)
> -       ("python" ,python-2)))
> -    (home-page "http://mate-desktop.org/")
> +       ("libxml2" ,libxml2)
> +       ("mate-panel" ,mate-panel)
> +       ("pango" ,pango)
> +       ("polkit" ,polkit)
> +       ("python" ,python-2)
> +       ("python-pygobject" ,python-pygobject)
> +       ("upower" ,upower)
> +       ("wireless-tools" ,wireless-tools)))
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Various applets for the MATE Panel")
>      (description
>       "Mate-applets includes various small applications for Mate-panel:
> @@ -517,7 +513,7 @@ Interactive Weather Information Network (IWIN).
>         ("libcanberra" ,libcanberra)
>         ("startup-notification" ,startup-notification)
>         ("cairo" ,cairo)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Multimedia related programs for the MATE desktop")
>      (description
>       "Mate-media includes the MATE media tools for MATE, including
> @@ -543,7 +539,8 @@ MATE-Media is a fork of GNOME-Media.")
>       `(#:configure-flags
>         (list (string-append "--with-zoneinfo-dir="
>                              (assoc-ref %build-inputs "tzdata")
> -                            "/share/zoneinfo"))
> +                            "/share/zoneinfo")
> +             "--with-in-process-applets=all")
>         #:phases
>         (modify-phases %standard-phases
>           (add-before 'configure 'fix-timezone-path
> @@ -590,7 +587,7 @@ MATE-Media is a fork of GNOME-Media.")
>         ("mate-menus" ,mate-menus)
>         ("libsm" ,libsm)
>         ("mate-desktop" ,mate-desktop)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Panel for MATE")
>      (description
>       "Mate-panel contains the MATE panel, the libmate-panel-applet library and
> @@ -614,12 +611,24 @@ infamous 'Wanda the Fish'.")
>           "0mljqcx7k8p27854zm7qzzn8ca6hs7hva9p43hp4p507z52caqmm"))))
>      (build-system glib-or-gtk-build-system)
>      (arguments
> -     `(#:tests? #f))
> +     '(#:configure-flags '("--disable-update-mimedb")
> +       #:tests? #f ; tests fail even with display set
> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-before 'check 'pre-check
> +           (lambda* (#:key inputs #:allow-other-keys)
> +             ;; Tests require a running X server.
> +             (system "Xvfb :1 &")
> +             (setenv "DISPLAY" ":1")
> +             ;; For the missing /etc/machine-id.
> +             (setenv "DBUS_FATAL_WARNINGS" "0")
> +             #t)))))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)
>         ("glib:bin" ,glib "bin")
> -       ("gobject-introspection" ,gobject-introspection)))
> +       ("gobject-introspection" ,gobject-introspection)
> +       ("xorg-server" ,xorg-server))) ; display for the tests
>      (inputs
>       `(("gtk+" ,gtk+)
>         ("exempi" ,exempi)
> @@ -630,7 +639,7 @@ infamous 'Wanda the Fish'.")
>         ("libxml2" ,libxml2)
>         ("mate-desktop" ,mate-desktop)
>         ("startup-notification" ,startup-notification)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "File manager for the MATE desktop")
>      (description
>       "Caja is the official file manager for the MATE desktop.
> @@ -657,6 +666,8 @@ Caja is a fork of Nautilus.")
>          (base32
>           "0flnn0h8f5aqyccwrlv7qxchvr3kqmlfdga6wq28d55zkpv5m7dl"))))
>      (build-system glib-or-gtk-build-system)
> +    (arguments
> +     '(#:configure-flags '("--disable-update-mimedb")))
>      (native-inputs
>       `(("pkg-config" ,pkg-config)
>         ("intltool" ,intltool)
> @@ -676,7 +687,6 @@ Caja is a fork of Nautilus.")
>         ("dbus-glib" ,dbus-glib)
>         ("libxml2" ,libxml2)
>         ("dconf" ,dconf)
> -       ("librsvg" ,librsvg)
>         ("libmatekbd" ,libmatekbd)
>         ("mate-desktop" ,mate-desktop)
>         ("caja" ,caja)
> @@ -688,7 +698,6 @@ Caja is a fork of Nautilus.")
>         ("dbus" ,dbus)
>         ("xmodmap" ,xmodmap)
>         ("cairo" ,cairo)
> -       ("gdk-pixbuf" ,gdk-pixbuf)
>         ("gtk+" ,gtk+)
>         ("libxcursor" ,libxcursor)
>         ("libx11" ,libx11)
> @@ -701,7 +710,10 @@ Caja is a fork of Nautilus.")
>         ("libxklavier" ,libxklavier)
>         ("marco" ,marco)
>         ("pango" ,pango)))
> -    (home-page "http://mate-desktop.org/")
> +    (propagated-inputs
> +     `(("gdk-pixbuf" ,gdk-pixbuf) ; mate-slab.pc
> +       ("librsvg" ,librsvg))) ; mate-slab.pc
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "MATE Desktop configuration tool")
>      (description
>       "MATE control center is MATE's main interface for configuration
> @@ -753,7 +765,7 @@ of various aspects of your desktop.")
>         ("xproto" ,xproto)
>         ("libcanberra" ,libcanberra)
>         ("mate-desktop" ,mate-desktop)))
> -    (home-page "http://mate-desktop.org/")
> +    (home-page "https://mate-desktop.org/")
>      (synopsis "Window manager for the MATE desktop")
>      (description
>       "Marco is a minimal X window manager that uses GTK+ for drawing
> @@ -769,33 +781,42 @@ for use with MATE or as a standalone window manager.")
>      (version (package-version marco))
>      (source #f)
>      (build-system trivial-build-system)
> -    (arguments '(#:builder (mkdir %output)))
> -    (propagated-inputs
> +    (arguments
> +     '(#:modules ((guix build union))
> +       #:builder
> +       (begin
> +         (use-modules (ice-9 match)
> +                      (guix build union))
> +         (match %build-inputs
> +           (((names . directories) ...)
> +            (union-build (assoc-ref %outputs "out")
> +                         directories))))))
> +    (inputs
>       ;; TODO: Add more packages
> -     `(("mate-icon-theme"           ,mate-icon-theme)
> -       ("font-cantarell"            ,font-cantarell)
> -       ("at-spi2-core"              ,at-spi2-core)
> -       ("dbus"                      ,dbus)
> +     `(("at-spi2-core"              ,at-spi2-core)
> +       ("caja"                      ,caja)
>         ("dconf"                     ,dconf)
> +       ("dbus"                      ,dbus)
>         ("desktop-file-utils"        ,desktop-file-utils)
> +       ("font-cantarell"            ,font-cantarell)
>         ("glib-networking"           ,glib-networking)
>         ("gnome-keyring"             ,gnome-keyring)
> -       ("mate-session-manager"      ,mate-session-manager)
> -       ("mate-settings-daemon"      ,mate-settings-daemon)
> -       ("mate-desktop"              ,mate-desktop)
> -       ("mate-terminal"             ,mate-terminal)
> -       ("mate-themes"               ,mate-themes)
> +       ("gvfs"                      ,gvfs)
>         ("libmatekbd"                ,libmatekbd)
> -       ("mate-menu"                 ,mate-menus)
> -       ("libmateweather"            ,libmateweather)
>         ("libmatemixer"              ,libmatemixer)
> -       ("mate-panel"                ,mate-panel)
> +       ("libmateweather"            ,libmateweather)
> +       ("marco"                     ,marco)
> +       ("mate-applets"              ,mate-applets)
>         ("mate-control-center"       ,mate-control-center)
> +       ("mate-desktop"              ,mate-desktop)
> +       ("mate-icon-theme"           ,mate-icon-theme)
>         ("mate-media"                ,mate-media)
> -       ("mate-applets"              ,mate-applets)
> -       ("gvfs"                      ,gvfs)
> -       ("caja"                      ,caja)
> -       ("marco"                     ,marco)
> +       ("mate-menu"                 ,mate-menus)
> +       ("mate-panel"                ,mate-panel)
> +       ("mate-session-manager"      ,mate-session-manager)
> +       ("mate-settings-daemon"      ,mate-settings-daemon)
> +       ("mate-terminal"             ,mate-terminal)
> +       ("mate-themes"               ,mate-themes)
>         ("pinentry-gnome3"           ,pinentry-gnome3)
>         ("pulseaudio"                ,pulseaudio)
>         ("shared-mime-info"          ,shared-mime-info)




-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 28116 <at> debbugs.gnu.org
Subject: Re: [bug#28116] mate partial review
Date: Mon, 28 Aug 2017 14:32:20 +0300

[Message part 1 (text/plain, inline)]

On Fri, Aug 25, 2017 at 06:11:25PM +0000, ng0 wrote:
> Efraim Flashner transcribed 16K bytes:
> > I did all the building on my aarch64 board and didn't test the graphical
> > aspects of running the programs. I also didn't check the
> > synopsis/description, but some of them do look like they need some work.
> 
> Thanks for this first review.
> I'll apply this as far as I can guess, having it all in one
> patch makes it hard to read but I'll figure it out.
> 

sorry about that, I applied all the patches and then just worked on them
all in one go.

> > patch 1: it turns out the home pages should also be https.
> > 
> > mate-icon-theme and mate-themes don't need gtk in the inputs to build.
> > 
> > libmateweather, mate-panel, mate-control-center: needs a configure flag
> > 
> > mate-applet: it built fine for me with upower as an input
> > 
> > mate-control-center: librsvg and gdk-pixbuf should be propagated
> > 
> > caja: I enabled the display server and the tests still failed on me
> > 
> > mate-metapackage: I copied the build from xfce, it seemed to build fine
> > for me.
> 
> Why use it like this? I copied my version from "gnome".
> 

xfce was changed because there were problems with overlapping packages
between xfce and gnome in the example os-config.scm

> 
> -- 
> ng0
> GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
> GnuPG: https://n0is.noblogs.org/my-keys
> https://www.infotropique.org https://krosos.org



-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 28116 <at> debbugs.gnu.org
Subject: Re: [bug#28116] mate partial review
Date: Thu, 31 Aug 2017 12:54:44 +0000

[Message part 1 (text/plain, inline)]

I did the best I could guess with this updated patch series.
If I missed something you addressed already, please point it
out in a format which is more friendly to read than a mono-patch.

If this series is alright I want to sort the inputs of the
longest packages with the version which is then good to go.

Thanks for taking the time to review!
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-mate-Fetch-sources-via-https.patch (text/plain, attachment)]

[0002-gnu-mate-icon-theme-Remove-gtk-from-native-inputs.patch (text/plain, attachment)]

[0003-gnu-mate-themes-Remove-gtk-from-native-inputs.patch (text/plain, attachment)]

[0004-gnu-Add-caja.patch (text/plain, attachment)]

[0005-gnu-mate-themes-Update-to-3.22.13.patch (text/plain, attachment)]

[0006-gnu-mate-desktop-Add-gtk-doc-back-to-native-inputs.patch (text/plain, attachment)]

[0007-gnu-Add-mate-terminal.patch (text/plain, attachment)]

[0008-gnu-Add-marco.patch (text/plain, attachment)]

[0009-gnu-Add-mate-session-manager.patch (text/plain, attachment)]

[0010-gnu-Add-mate-panel.patch (text/plain, attachment)]

[0011-gnu-Add-libmatemixer.patch (text/plain, attachment)]

[0012-gnu-Add-libmatekbd.patch (text/plain, attachment)]

[0013-gnu-Add-mate-settings-daemon.patch (text/plain, attachment)]

[0014-gnu-Add-mate-applets.patch (text/plain, attachment)]

[0015-gnu-Add-mate-media.patch (text/plain, attachment)]

[0016-gnu-Add-mate-control-center.patch (text/plain, attachment)]

[0017-gnu-Add-mate.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Efraim Flashner <efraim <at> flashner.co.il>, 28116 <at> debbugs.gnu.org
Subject: Re: [bug#28116] mate partial review
Date: Thu, 31 Aug 2017 13:21:09 +0000

[Message part 1 (text/plain, inline)]

ng0 transcribed 47K bytes:
> I did the best I could guess with this updated patch series.
> If I missed something you addressed already, please point it
> out in a format which is more friendly to read than a mono-patch.
> 
> If this series is alright I want to sort the inputs of the
> longest packages with the version which is then good to go.
> 
> Thanks for taking the time to review!

You could also read through them here:
https://gitweb.krosos.org/ng0_guix/guix/log/?h=system/mate
http://gitweb.xpcbqhqx6ynktue7.onion/ng0_guix/guix/log/?h=system/mate
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Message #26 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 28116 <at> debbugs.gnu.org
Cc: ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28116] mate partial review
Date: Sun, 3 Sep 2017 18:09:18 +0300

[Message part 1 (text/plain, inline)]

On Thu, Aug 31, 2017 at 01:21:09PM +0000, ng0 wrote:
> ng0 transcribed 47K bytes:
> > I did the best I could guess with this updated patch series.
> > If I missed something you addressed already, please point it
> > out in a format which is more friendly to read than a mono-patch.
> > 
> > If this series is alright I want to sort the inputs of the
> > longest packages with the version which is then good to go.
> > 
> > Thanks for taking the time to review!
> 
> You could also read through them here:
> https://gitweb.krosos.org/ng0_guix/guix/log/?h=system/mate
> http://gitweb.xpcbqhqx6ynktue7.onion/ng0_guix/guix/log/?h=system/mate
> -- 

That worked out well. I think we're about there, I just want you to
check that it works well when used as a DE.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[0001-mate-themes.patch (text/plain, attachment)]

[0002-libmateweather.patch (text/plain, attachment)]

[0003-mate-terminal.patch (text/plain, attachment)]

[0004-mate-session-manager.patch (text/plain, attachment)]

[0005-mate-settings-daemon.patch (text/plain, attachment)]

[0006-libmatemixer.patch (text/plain, attachment)]

[0007-libmakekbd.patch (text/plain, attachment)]

[0008-mate-menus.patch (text/plain, attachment)]

[0009-mate-applets.patch (text/plain, attachment)]

[0010-mate-media.patch (text/plain, attachment)]

[0011-mate-panel.patch (text/plain, attachment)]

[0012-caja.patch (text/plain, attachment)]

[0013-mate-control-center.patch (text/plain, attachment)]

[0014-marco.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #29 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 28116 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28116] mate partial review
Date: Sun, 3 Sep 2017 19:44:41 +0000

[Message part 1 (text/plain, inline)]

Efraim Flashner transcribed 27K bytes:
> On Thu, Aug 31, 2017 at 01:21:09PM +0000, ng0 wrote:
> > ng0 transcribed 47K bytes:
> > > I did the best I could guess with this updated patch series.
> > > If I missed something you addressed already, please point it
> > > out in a format which is more friendly to read than a mono-patch.
> > > 
> > > If this series is alright I want to sort the inputs of the
> > > longest packages with the version which is then good to go.
> > > 
> > > Thanks for taking the time to review!
> > 
> > You could also read through them here:
> > https://gitweb.krosos.org/ng0_guix/guix/log/?h=system/mate
> > http://gitweb.xpcbqhqx6ynktue7.onion/ng0_guix/guix/log/?h=system/mate
> > -- 
> 
> That worked out well. I think we're about there, I just want you to
> check that it works well when used as a DE.

I applied all of your corrections with the exception of:

`(#:phases -> '(#:phases

I see no point or any reason at all to use this for the package definition
it was applied to, used 2 times. The majority of packages uses the first one.

Then there was a cosmetical change with something like
(add-before
 'foo 'bar

becoming

(add-before 'foo 'bar

I haven't applied this because it was outside of the packages I
worked on and didn't fit into any logical set of patches I had.

This can be commited after this series.

Thanks for going through all of this. Now what we achieved with this
change is:
- mate-panel has actual readable/recognizable symbols instead
  of the garbage I assumed that was caused by individual applications
  but turns out it wasn't.
- Mate Control Center looks better.
- Everything is still working.


So, your fixes to my patches LGTM.
Rebased and edited series attached.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[0001-gnu-Add-caja.patch (text/plain, attachment)]

[0002-gnu-Add-mate-terminal.patch (text/plain, attachment)]

[0003-gnu-Add-marco.patch (text/plain, attachment)]

[0004-gnu-Add-mate-session-manager.patch (text/plain, attachment)]

[0005-gnu-Add-mate-panel.patch (text/plain, attachment)]

[0006-gnu-Add-libmatemixer.patch (text/plain, attachment)]

[0007-gnu-Add-libmatekbd.patch (text/plain, attachment)]

[0008-gnu-Add-mate-settings-daemon.patch (text/plain, attachment)]

[0009-gnu-Add-mate-applets.patch (text/plain, attachment)]

[0010-gnu-Add-mate-media.patch (text/plain, attachment)]

[0011-gnu-Add-mate-control-center.patch (text/plain, attachment)]

[0012-gnu-Add-mate.patch (text/plain, attachment)]

[signature.asc (application/pgp-signature, inline)]

Message #32 received at 28116 <at> debbugs.gnu.org (full text, mbox):

From: ng0 <ng0 <at> infotropique.org>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 28116 <at> debbugs.gnu.org, ng0 <ng0 <at> infotropique.org>
Subject: Re: [bug#28116] mate partial review
Date: Sun, 3 Sep 2017 19:50:49 +0000

[Message part 1 (text/plain, inline)]

ng0 transcribed 38K bytes:
> Efraim Flashner transcribed 27K bytes:
> > On Thu, Aug 31, 2017 at 01:21:09PM +0000, ng0 wrote:
> > > ng0 transcribed 47K bytes:
> > > > I did the best I could guess with this updated patch series.
> > > > If I missed something you addressed already, please point it
> > > > out in a format which is more friendly to read than a mono-patch.
> > > > 
> > > > If this series is alright I want to sort the inputs of the
> > > > longest packages with the version which is then good to go.
> > > > 
> > > > Thanks for taking the time to review!
> > > 
> > > You could also read through them here:
> > > https://gitweb.krosos.org/ng0_guix/guix/log/?h=system/mate
> > > http://gitweb.xpcbqhqx6ynktue7.onion/ng0_guix/guix/log/?h=system/mate
> > > -- 
> > 
> > That worked out well. I think we're about there, I just want you to
> > check that it works well when used as a DE.
> 
> I applied all of your corrections with the exception of:
> 
> `(#:phases -> '(#:phases
> 
> I see no point or any reason at all to use this for the package definition
> it was applied to, used 2 times. The majority of packages uses the first one.
> 
> Then there was a cosmetical change with something like
> (add-before
>  'foo 'bar
> 
> becoming
> 
> (add-before 'foo 'bar
> 
> I haven't applied this because it was outside of the packages I
> worked on and didn't fit into any logical set of patches I had.
> 
> This can be commited after this series.
> 
> Thanks for going through all of this. Now what we achieved with this
> change is:
> - mate-panel has actual readable/recognizable symbols instead
>   of the garbage I assumed that was caused by individual applications
>   but turns out it wasn't.
> - Mate Control Center looks better.
> - Everything is still working.
> 
> 
> So, your fixes to my patches LGTM.
> Rebased and edited series attached.

Actually one issue, but not related to MATE:
Please check if on a system with only Mate
and not additionally XFCE or GNOME you have
harddrives accessible. I removed both (XFCE
and GNOME) from the system and as a normal
user my unmounted disks disappeared from
the system view. Not bad, but this has
happened with other WMs/DMs before so I
just assume something is missing.

Still good to go though.
-- 
ng0
GnuPG: A88C8ADD129828D7EAC02E52E22F9BBFEE348588
GnuPG: https://n0is.noblogs.org/my-keys
https://www.infotropique.org https://krosos.org

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.