GNU bug report logs - #28100
[PATCH 0/2] Add FBReader.

Previous Next

Full log

Message #17 received at 28100 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Danny Milosavljevic <dannym <at> scratchpost.org>
Cc: 28100 <at> debbugs.gnu.org
Subject: Re: [bug#28100] [PATCH 1/2] gnu: Add liblinebreak.
Date: Wed, 16 Aug 2017 11:03:57 +0200

Danny Milosavljevic <dannym <at> scratchpost.org> writes:

> * gnu/packages/ebook.scm (liblinebreak): New variable.
> ---
>  gnu/packages/ebook.scm | 20 ++++++++++++++++++++
>  1 file changed, 20 insertions(+)
>
> diff --git a/gnu/packages/ebook.scm b/gnu/packages/ebook.scm
> index 32f4f3b2d..187d1ed63 100644
> --- a/gnu/packages/ebook.scm
> +++ b/gnu/packages/ebook.scm
> @@ -195,3 +195,23 @@ ebooks for convenient reading.")
>                     license:public-domain
>                     license:silofl1.1
>                     license:cc-by-sa3.0))))
> +
> +(define-public liblinebreak
> +  (package
> +    (name "liblinebreak")
> +    (version "2.1")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "mirror://sourceforge/vimgadgets"
> +                                  "/liblinebreak/" version
> +                                  "/liblinebreak-" version ".tar.gz"))
> +              (file-name (string-append name "-" version ".tar.gz"))

this “file-name” field is not necessary.  The tarball is already
properly named.

> +              (sha256
> +               (base32
> +                "1f36dbq7nc77lln1by2n1yl050g9dc63viawhs3gc3169mavm36x"))))
> +    (build-system gnu-build-system)
> +    (home-page "http://vimgadgets.sourceforge.net/liblinebreak/")
> +    (synopsis "Library for detecting where linebreaks are allowed in text")
> +    (description "@code{liblinebreak} is a library that can be used to detect
> +where linebreaks are allowed in a given text.")

“allowed” is a bit vague.  The description on the website is better, in
my opinion:

   Liblinebreak is an implementation of the line breaking algorithm as
   described in Unicode 6.0.0 Standard Annex 14, Revision 26. It breaks
   lines that contain Unicode characters. It is designed to be used in a
   generic text renderer.

Could you use that instead?

It’s good with these changes.

--
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.