From unknown Sat Jun 21 03:16:18 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28093 <28093@debbugs.gnu.org> To: bug#28093 <28093@debbugs.gnu.org> Subject: Status: [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Reply-To: bug#28093 <28093@debbugs.gnu.org> Date: Sat, 21 Jun 2025 10:16:18 +0000 retitle 28093 [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. reassign 28093 guix-patches submitter 28093 Leo Famulari severity 28093 normal tag 28093 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 14 23:32:07 2017 Received: (at submit) by debbugs.gnu.org; 15 Aug 2017 03:32:07 +0000 Received: from localhost ([127.0.0.1]:37609 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhSaG-0007HR-LL for submit@debbugs.gnu.org; Mon, 14 Aug 2017 23:32:07 -0400 Received: from eggs.gnu.org ([208.118.235.92]:33718) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhSaA-0007HL-Co for submit@debbugs.gnu.org; Mon, 14 Aug 2017 23:31:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhSa4-0008BU-1K for submit@debbugs.gnu.org; Mon, 14 Aug 2017 23:31:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:36678) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhSa3-0008BI-UQ for submit@debbugs.gnu.org; Mon, 14 Aug 2017 23:31:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52906) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhSa2-0001v2-Jh for guix-patches@gnu.org; Mon, 14 Aug 2017 23:31:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhSZy-000899-NA for guix-patches@gnu.org; Mon, 14 Aug 2017 23:31:46 -0400 Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50565) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhSZy-00088v-Fs for guix-patches@gnu.org; Mon, 14 Aug 2017 23:31:42 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8F43A20981; Mon, 14 Aug 2017 23:31:41 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Mon, 14 Aug 2017 23:31:41 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-transfer-encoding:content-type:date:from:message-id :mime-version:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=mt2jwTzBPjbaHEDf2wefcvnz7+T51PLbU8Bz1j aJqp4=; b=ZIk9rXytpr03b0D91LkbuNPJ38gpDl3KCzhgWoIRAHKsI1y+EKaG/y 6V3t0TyuihuJCzUSD5qCWZuWKntaWIFbWW+VDRwm7T7q8CDvfiD+DCwPzWTyJdRD hc1GOZPRkUVEYkCaSrNtoLO9k6NcHzhFZVDoHvHXOiOJ/Q04NBb3Q= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:message-id:mime-version:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=mt2jwTzBPjbaHEDf2w efcvnz7+T51PLbU8Bz1jaJqp4=; b=RotnFEaG9QKvzA1o2IGEeuXzq396WcJ0B0 8FdVFsuR/pe6M2fLEmqys+tSpmq6qKm7lnW1i3uhm4nZgn49vqOgYFX9M14RgqUA /UTjP0g8GtYPS38B+51UeiqZWlU31mEeldEQEXaA4J7nkIZo6o7OAYcQoBVuuN11 f/2440mLbmOq8QB/Zv2yu/z3VpaQhrHdp4qc924vVagjIix3YD3M5UxbMTqEoAOr hR97MGm8SMiWEC18/mUWXfNbcBFtBw3Pg00ypU1t2b2BVG9LyrWAKmoorWQ4HLxh tD0rea0/FsvuhA4og69JkJT4jaK1MEyMtbEeP6ZyqtjYINKxaDgA== X-ME-Sender: X-Sasl-enc: crxybvTpHVCRNJLl0ZQgIkPq1iLHpnnErO8mSH6ltocL 1502767901 Received: from jasmine.lan (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 3F3C6246A3 for ; Mon, 14 Aug 2017 23:31:41 -0400 (EDT) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Date: Mon, 14 Aug 2017 23:31:37 -0400 Message-Id: X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.9 (/) * gnu/packages/version-control.scm (cgit)[inputs]: Replace the git@2.10 package with an origin reference of the source code. (git@2.10): Remove variable. --- gnu/packages/version-control.scm | 31 ++++++++++++------------------- 1 file changed, 12 insertions(+), 19 deletions(-) diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 7c1f02d5a..3f76ed7f3 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -9,7 +9,7 @@ ;;; Copyright © 2015, 2016, 2017 Efraim Flashner ;;; Copyright © 2015 Kyle Meyer ;;; Copyright © 2015, 2017 Ricardo Wurmus -;;; Copyright © 2016 Leo Famulari +;;; Copyright © 2016, 2017 Leo Famulari ;;; Copyright © 2016, 2017 ng0 ;;; Copyright © 2017 Tobias Geerinckx-Rice ;;; Copyright © 2017 Vasile Dumitrascu @@ -121,6 +121,8 @@ as well as the classic centralized workflow.") (define-public git (package (name "git") + ;; XXX When updating Git, check if the special 'git:src' input to cgit needs + ;; to be updated as well. (version "2.14.1") (source (origin (method url-fetch) @@ -349,23 +351,6 @@ everything from small to very large projects with speed and efficiency.") (license license:gpl2) (home-page "https://git-scm.com/"))) -;; Some dependent packages directly access internal interfaces which -;; have changed in 2.12. TODO: Remove this for cgit > 1.1. -(define-public git@2.10 - (package - (inherit git) - (version "2.10.4") - (source (origin - (method url-fetch) - (uri (string-append "mirror://kernel.org/software/scm/git/git-" - version ".tar.xz")) - (sha256 - (base32 - "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l")))) - (arguments - `(#:tests? #f - ,@(package-arguments git))))) - (define-public libgit2 (package (name "libgit2") @@ -502,6 +487,8 @@ collaboration using typical untrusted file hosts or services.") (define-public cgit (package (name "cgit") + ;; XXX When updating cgit, try removing the special 'git:src' input and + ;; using the source of the git package. (version "1.1") (source (origin (method url-fetch) @@ -546,7 +533,13 @@ collaboration using typical untrusted file hosts or services.") ;; For building manpage. `(("asciidoc" ,asciidoc))) (inputs - `(("git:src" ,(package-source git@2.10)) + `(("git:src" + ,(origin + (method url-fetch) + (uri "mirror://kernel.org/software/scm/git/git-2.10.4.tar.xz") + (sha256 + (base32 + "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l")))) ("openssl" ,openssl) ("zlib" ,zlib))) (home-page "https://git.zx2c4.com/cgit/") -- 2.14.1 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 02:35:53 2017 Received: (at 28093) by debbugs.gnu.org; 15 Aug 2017 06:35:53 +0000 Received: from localhost ([127.0.0.1]:37639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhVS6-0000JX-Mw for submit@debbugs.gnu.org; Tue, 15 Aug 2017 02:35:53 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:54452 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhVS4-0000JR-MO for 28093@debbugs.gnu.org; Tue, 15 Aug 2017 02:35:45 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id 4859C16FE39; Tue, 15 Aug 2017 07:35:42 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 7EA8A16FE38; Tue, 15 Aug 2017 07:35:39 +0100 (BST) Date: Tue, 15 Aug 2017 07:35:31 +0100 From: Christopher Baines To: Leo Famulari Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Message-ID: <20170815073531.4b72ab02@cbaines.net> In-Reply-To: References: X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/1482cOtmdwjsk+G8K6m3uBU"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28093 Cc: 28093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/1482cOtmdwjsk+G8K6m3uBU Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On Mon, 14 Aug 2017 23:31:37 -0400 Leo Famulari wrote: > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the > git@2.10 package with an origin reference of the source code. > (git@2.10): Remove variable. It would be useful if outside of the changelog, but in the commit message, you could put why you are making the change. As far as I can tell, this won't change the cgit package, so I'm guessing the intent is to neaten up the code? > --- > gnu/packages/version-control.scm | 31 ++++++++++++------------------- > 1 file changed, 12 insertions(+), 19 deletions(-) >=20 > diff --git a/gnu/packages/version-control.scm > b/gnu/packages/version-control.scm index 7c1f02d5a..3f76ed7f3 100644 > --- a/gnu/packages/version-control.scm > +++ b/gnu/packages/version-control.scm > @@ -9,7 +9,7 @@ > ;;; Copyright =C2=A9 2015, 2016, 2017 Efraim Flashner > ;;; Copyright =C2=A9 2015 Kyle Meyer > ;;; Copyright =C2=A9 2015, 2017 Ricardo Wurmus > -;;; Copyright =C2=A9 2016 Leo Famulari > +;;; Copyright =C2=A9 2016, 2017 Leo Famulari > ;;; Copyright =C2=A9 2016, 2017 ng0 > ;;; Copyright =C2=A9 2017 Tobias > Geerinckx-Rice ;;; Copyright =C2=A9 2017 Vasile Dumitrascu > @@ -121,6 +121,8 @@ as well as the classic > centralized workflow.") (define-public git > (package > (name "git") > + ;; XXX When updating Git, check if the special 'git:src' input to > cgit needs > + ;; to be updated as well. > (version "2.14.1") > (source (origin > (method url-fetch) > @@ -349,23 +351,6 @@ everything from small to very large projects > with speed and efficiency.") (license license:gpl2) > (home-page "https://git-scm.com/"))) > =20 > -;; Some dependent packages directly access internal interfaces which > -;; have changed in 2.12. TODO: Remove this for cgit > 1.1. > -(define-public git@2.10 > - (package > - (inherit git) > - (version "2.10.4") > - (source (origin > - (method url-fetch) > - (uri (string-append > "mirror://kernel.org/software/scm/git/git-" > - version ".tar.xz")) > - (sha256 > - (base32 > - > "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l")))) > - (arguments > - `(#:tests? #f > - ,@(package-arguments git))))) > - > (define-public libgit2 > (package > (name "libgit2") > @@ -502,6 +487,8 @@ collaboration using typical untrusted file hosts > or services.") (define-public cgit > (package > (name "cgit") > + ;; XXX When updating cgit, try removing the special 'git:src' > input and > + ;; using the source of the git package. > (version "1.1") > (source (origin > (method url-fetch) > @@ -546,7 +533,13 @@ collaboration using typical untrusted file hosts > or services.") ;; For building manpage. > `(("asciidoc" ,asciidoc))) > (inputs > - `(("git:src" ,(package-source git@2.10)) > + `(("git:src" > + ,(origin > + (method url-fetch) > + (uri > "mirror://kernel.org/software/scm/git/git-2.10.4.tar.xz") > + (sha256 > + (base32 > + > "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l")))) > ("openssl" ,openssl) ("zlib" ,zlib))) > (home-page "https://git.zx2c4.com/cgit/") --Sig_/1482cOtmdwjsk+G8K6m3uBU Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmSljRfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xe8aQ/+K7IIKenfMLD6mGgFuBceVoFbxL8SlemXl5FVPc1AqJdzedhcWfS1zVDO bF4bDUzEZa8Lj4C6b5WbczyhOKBiZR5GK+QlxD+BHtx6NgaJ0RTVGbf2dPTLWK8w hFCv8iohETLQsMV45q8nr2SWimgUbICuH9ihC/T85izf1AxwnGfTx7SMRdn8c+5s b6N0iQqQqHgQjaCI4cJQBI0z+nnxVkFeSUtVSzXy6b1p4ziZo+gk+1LDrd5obwsS WLqBQB1GJWZ91tmZTddcQG5uquaLrdVyzPzYT94YxLmro/Ze7eGtk8VZ+QJOVIsg vq280DeP8o/WEwWLeVBvM4c+Ryj3ogZu1V0qh2kSO3MbkbTMOnKznscPS0vFvc9L 5N7LbUHIaU7avN/KkX0wW3YdwE0z+UWvMlEY1HL1w8iGdIPdGrbhYg/Bu/TNPkAS VEeHiUND6dS8mlO4ErU8FaJtAUKdC8iymQKGZUKMPXpLINaQTIT65Su6TP4d5FDZ pZklW7zZEEukOTd6JybFd2w+0HtceHdJ75zSeHSe4PmSk/x8r7I35FiaK32dE1Ak PHKS6f6mTq1m7eENSRcpsgyiR2KHg1Kl8YozdVB6bYb7f8PI+YX/gf2/+YdMAq8c kRzf+D3CtlQwkWnL5bU0ISToh4Kb1U/X7kdEpxe3DarxDaqT93A= =urhU -----END PGP SIGNATURE----- --Sig_/1482cOtmdwjsk+G8K6m3uBU-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 15:21:42 2017 Received: (at 28093) by debbugs.gnu.org; 15 Aug 2017 19:21:42 +0000 Received: from localhost ([127.0.0.1]:39234 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhhPK-0002an-D9 for submit@debbugs.gnu.org; Tue, 15 Aug 2017 15:21:42 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:45103) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhhPI-0002ah-IO for 28093@debbugs.gnu.org; Tue, 15 Aug 2017 15:21:40 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 645F321E2B; Tue, 15 Aug 2017 15:21:40 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Tue, 15 Aug 2017 15:21:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=Grkw16rwDkbACaNtiOSX92vP4i/aacsdDBQ9OV EFYlw=; b=W4th2GG38UJ4I0Jv32yk+rreUGJZdow9iYZ3J7RgSssoegq+szuicH re1UHkCRnUfeS1sCC3HVSWad7ut1U25SfgRVliLdYaPkzyY3cvNqjt88ytf+TNDB DRGUx9ZJBW53mMA/xCuSxsd/uyxz96BMWE+Zs8EZXd2K5vrF/joQs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=Grkw16rwDkbACaNtiO SX92vP4i/aacsdDBQ9OVEFYlw=; b=VRJV0w4I7o5VhNh5Dburn7HgLbK5FUCpXb MozKz8wZZenAkSv+uAiDIAjOgY9LWqWLBgAJw8EXxQw8vtuo4j7S7SyZ/0dEdqPg 8KqQb/l8X/PvyMeCd6xk5Q8pJfO3nrI6zOqUhc609tDzAmpSC4aWcklyY2uSrrt9 ZdKevZvGWDHU132Hokda2Qq5PInOCAI4hlBS+JMLmobGHI4IDMA0ryUr5SMoz697 koNuSfZLpswo+0H4V1gqefhjfXr0LvGJw+PDXRWKIIz23AYUa0EdI2MM03BUofvo 5HdOFgwbZmDkoFsP6YBShuAzkeKG+h/recZEB+rhxFdB6sZwYERw== X-ME-Sender: X-Sasl-enc: W85zM/zalTdLjDNoyEWL+gZXhKFowvhNbt32frUzhPrd 1502824900 Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 1D5BE246A3; Tue, 15 Aug 2017 15:21:40 -0400 (EDT) Date: Tue, 15 Aug 2017 15:21:36 -0400 From: Leo Famulari To: Christopher Baines Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Message-ID: <20170815192136.GB9893@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="oyUTqETQ0mS9luUI" Content-Disposition: inline In-Reply-To: <20170815073531.4b72ab02@cbaines.net> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28093 Cc: 28093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --oyUTqETQ0mS9luUI Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote: > On Mon, 14 Aug 2017 23:31:37 -0400 > Leo Famulari wrote: >=20 > > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the > > git@2.10 package with an origin reference of the source code. > > (git@2.10): Remove variable. >=20 > It would be useful if outside of the changelog, but in the commit > message, you could put why you are making the change. As far as I can > tell, this won't change the cgit package, so I'm guessing the intent is > to neaten up the code? Recently we started running the test suite of the "main" git package. That caused the build of this package to fail, which also made cgit fail to build, and that was annoying. But, we don't even need to build this source code as a package, since it gets built within the cgit build process, and we don't run the tests there. So, I figured we might as well not provide this as a package at all, since it's really just intended to provide source code to cgit. Does that sound reasonable? If so, I'll summarize this in the commit message. --oyUTqETQ0mS9luUI Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmTSbwACgkQJkb6MLrK fwhcyxAAowvT21uW6FEtX2TNAytiXm+szNumuPixk/b/nHdH90oUt6VKkt4iI1+1 lYHR7ImdCKM0E5L/dNZ9g4oro18GWlDYHfG+y2DMlgfvUhPW7EOIa8czToORru++ 0+NOm3lNIo1kg8r6/GMeR1MwDdoDQ+L0TKiSWReNjFaqjo06DjQqI4mVojFsXIYJ dPjA7h7EnhThaJS60z8hW9JBupilaJzM0KLZDlJKO/DQ70swOyChkvQbDW7yKy+n WXUZjzvHwhBxVOavGDOCWYKQhuFYcIdq3f3bbliQgC3dViBZXS+mFbLZgbd+A8X4 rNmv5iO2WfAWgMBpGmH+vlTTQ9Dlh6Rb1R1p+HvxEwObaq6ii0VagJvrP25tFMGw c5A9FtYpRlLjdAEdoYrgUENPbE9E5IRWxDEn0GXejeAPpOAkPrpHfBmaCtDuyyus 3sGxCVtq+ZWcjcgJ13hHHviSaon5wOuvvYVHZYCUQ9AGNl0NGKMUQjimUcJ06VXN bFHfscEBeGYkOPBA1OPGadmuI3+Fn6aWfaK+cnmSwb+tg8EKGjKP9om0TgRpUu4d BffD63xpxPwp+DrPSJHQrlyfQSimvPLL9MZHfNvK8FVym3k7exDWFqCY4Grux06m tw4TueEkLC9Do+oHwfQrq+ZlKNDhEFBHQyPgRQ/DbgAMPxG84IU= =E3R5 -----END PGP SIGNATURE----- --oyUTqETQ0mS9luUI-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 15:54:41 2017 Received: (at 28093) by debbugs.gnu.org; 15 Aug 2017 19:54:41 +0000 Received: from localhost ([127.0.0.1]:39401 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhhvF-0002rT-5c for submit@debbugs.gnu.org; Tue, 15 Aug 2017 15:54:41 -0400 Received: from li622-129.members.linode.com ([212.71.249.129]:55008 helo=mira.cbaines.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhhvC-0002rM-Lw for 28093@debbugs.gnu.org; Tue, 15 Aug 2017 15:54:39 -0400 Received: by mira.cbaines.net (Postfix, from userid 113) id B169916FE41; Tue, 15 Aug 2017 20:54:36 +0100 (BST) X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on mira.cbaines.net X-Spam-Level: X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from localhost (cpc102582-walt20-2-0-cust14.13-2.cable.virginm.net [86.27.34.15]) by mira.cbaines.net (Postfix) with ESMTPSA id 5934616FE40; Tue, 15 Aug 2017 20:54:36 +0100 (BST) Date: Tue, 15 Aug 2017 20:54:32 +0100 From: Christopher Baines To: Leo Famulari Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Message-ID: <20170815205432.534c28ac@cbaines.net> In-Reply-To: <20170815192136.GB9893@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> <20170815192136.GB9893@jasmine.lan> X-Mailer: Claws Mail 3.15.0-dirty (GTK+ 2.24.31; x86_64-unknown-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; boundary="Sig_/vMW=L6q2/HBF109Su8xnnMq"; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 28093 Cc: 28093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) --Sig_/vMW=L6q2/HBF109Su8xnnMq Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Tue, 15 Aug 2017 15:21:36 -0400 Leo Famulari wrote: > On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote: > > On Mon, 14 Aug 2017 23:31:37 -0400 > > Leo Famulari wrote: > > =20 > > > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the > > > git@2.10 package with an origin reference of the source code. > > > (git@2.10): Remove variable. =20 > >=20 > > It would be useful if outside of the changelog, but in the commit > > message, you could put why you are making the change. As far as I > > can tell, this won't change the cgit package, so I'm guessing the > > intent is to neaten up the code? =20 >=20 > Recently we started running the test suite of the "main" git package. >=20 > That caused the build of this package to fail, which also made cgit > fail to build, and that was annoying. >=20 > But, we don't even need to build this source code as a package, since > it gets built within the cgit build process, and we don't run the > tests there. >=20 > So, I figured we might as well not provide this as a package at all, > since it's really just intended to provide source code to cgit. >=20 > Does that sound reasonable? Yep, makes sense, and the diff looks good to me. > If so, I'll summarize this in the commit message. Great :D --Sig_/vMW=L6q2/HBF109Su8xnnMq Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlmTUXhfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9XflJBAAiGfQYvJNEuOYg2RwGlygNEQSuw0nIlhxUNDLnR6Kpm+zPgqeZ0LlV9Jx m1JBDC5wO7Y7j6aS3m8e2+f/hxW4gTHY/eyfmPcExMNbTLjij/sGHApVnx5qgGIg sYNY5cMgxq13T9tBaGPXQ2HDhnfx67GI0wAlR2wQJ6NH/3XEzmP2iD24qQewDhPv uG0rCeP644CTyU882F3SfzP3f58WJoQDQjYm4SPPJVQWqpl/kohiWdx2p7X9+vzT bmK0DE42W9rX9oRvZH5CAs9ppArIJoetb3UutqKqPq3NEnfy/Gv1Dwj1mDDGwZoZ /Tuqp1PLABHfziAnrGK4cx+z41bd8YabRtVpaFwZkQ+5r3fiynvfvyKEZMwUpVSE kPPJDgdLyy5XTR1TeZgQy1BezQQ1VWKwFPDHI1tie6NnnOAH/+Y+ywWvg4WpqvkE XJTAPN4PTiqtiPW6nck0PhY2uFkcC1VHjbBCqb6tTKoYBMIgaA2tBdBAu0d/dT9C DcKO4UhdQZhD8nuIbRCq7x1VYU3yxF/YO1M6O46b5ppn9CoP6MbGhtU/7NUAqTJe d5RRSdxhUBWEG9VLcZzABV/ZOp17KQlhUg/JLh5Dx3hVKmX3VigutZgKBxaQoBKq Fi6WYuJXkRubzMwztID6Wp86ucJEWfdaaAhsauFO31l0ZYyU9mw= =XA0Q -----END PGP SIGNATURE----- --Sig_/vMW=L6q2/HBF109Su8xnnMq-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 16:16:38 2017 Received: (at 28093) by debbugs.gnu.org; 15 Aug 2017 20:16:38 +0000 Received: from localhost ([127.0.0.1]:39500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhiGT-00038J-WD for submit@debbugs.gnu.org; Tue, 15 Aug 2017 16:16:38 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:59995) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhiGS-00038C-FZ for 28093@debbugs.gnu.org; Tue, 15 Aug 2017 16:16:37 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 63AA0220B1; Tue, 15 Aug 2017 16:15:58 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Tue, 15 Aug 2017 16:15:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=rzDN3kLVS5OuD5wTsT2to9sgOHkOc/50bT3DT58Ez UU=; b=sR4hvlS6bkqbqOQGXZ3DDysvveYk4sNHZxIHRB9MN6Ukxxx6PcwjFntme eFFLoN4Jtz9mNc57RJJhaFoeBB1HfgTfSYjyAPDjXPuAEl7OiKBzWURt3uLmZcx2 J51Wb80NP4xwY8cwa9TwPnrdryAfhOQaDTwgS9gPnz2rh5/hXv8W2pRv9KGXwlt0 hZT+brRrzii23d58sJOv7VjLJ/GlnibrGPwAlx2gOBPwFfy0op19C/Wfze2mR6IP EO3yWCvRTpcUTQ/DGD68Bwui/KQv13kspT5a6UQerpk6THUw8OIFhdlCeSos4QH5 GDr+B0VkHDZmor7dFCUEBIXLV1QOA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=rzDN3kLVS5OuD5wTsT 2to9sgOHkOc/50bT3DT58EzUU=; b=qgqgwMwrhcbtpc0M6hTOhxyOOideEpjH5J 2npqhU2te/w+J4btlZs5rw0OjJpJ0uwugn2fGxALyLpKfzyx8RapwFnP830su3jX sXQ/I82uKqHIVseThXBX77Z1xCZciE9UIk0gkbLeOPxCFUCpkPwQb0C2DTpSvP3e yjIJs3X4VvSEDM5Zd9bHlzNzuhzwpwo3O6jDqDqg3DqNJBgMZFhVwUj/Nj5JYaUS r11Ch3j1iSmAm4Pl1AO6kffUDp3O7IrlIalMF5hudXfhPcVPW9RLjXmGw3AFZX5r 0jn9+uc9wiFN9VlgFcIAYYIROLetIx9ZIOiA7Snk1RxLeyLZ5KSg== X-ME-Sender: X-Sasl-enc: 23KIWRyu2db4M7QmyHa55o+rDIey3nrXG04Gp2LQeYhk 1502828157 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id D7293240AF; Tue, 15 Aug 2017 16:15:57 -0400 (EDT) From: Marius Bakke To: Leo Famulari , Christopher Baines Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. In-Reply-To: <20170815192136.GB9893@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> <20170815192136.GB9893@jasmine.lan> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Tue, 15 Aug 2017 22:15:38 +0200 Message-ID: <87valozixh.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28093 Cc: 28093@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: > On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote: >> On Mon, 14 Aug 2017 23:31:37 -0400 >> Leo Famulari wrote: >>=20 >> > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the >> > git@2.10 package with an origin reference of the source code. >> > (git@2.10): Remove variable. >>=20 >> It would be useful if outside of the changelog, but in the commit >> message, you could put why you are making the change. As far as I can >> tell, this won't change the cgit package, so I'm guessing the intent is >> to neaten up the code? > > Recently we started running the test suite of the "main" git package. > > That caused the build of this package to fail, which also made cgit > fail to build, and that was annoying. cgit was not affected by the failing git@2.10 package since it only uses the *source* derivation. It does not care about what's going on in git's [arguments]. :-) So this patch won't change anything from cgits perspective. I'm slightly in favor of keeping git@2.10 until it's really uneeded (awkward if we have to add it back later), but no strong opinion either way. I would probably have done this instead of disabling tests if I had thought about it. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmTVmoACgkQoqBt8qM6 VPriLQf8DICFhwc0zqmEUm3aTy6ua3vmaMj8uzDCdpYGyFxsdqiXww+qZjfCxZ81 0vmfr+kWHIRxGlm8G+Z9FhnsNBHAmqPVO6jNpaP05hQ9NBVSNvmabUON2tlLqyqk 9bGfEQPQWRBrHnTnuaXphLvCdNaa56F5kUcoajxATgb4FBvrZ8ZOBrmzU06aJm3U dIxwBugTkyW8LeOxkQitgyAaxkywCJJEqDH/N/codjGi9DbbN0dYJMYRcDEev/9Y +W6lic2WhUcTOKNvRDYm+uzrxbeg0x9BIKhvxZHFMLck3LUGxVKf9VDSrwthghUF 2SqRUuQKob58ctA+noIxVHg8zFk6kA== =mDuf -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 16:24:44 2017 Received: (at 28093) by debbugs.gnu.org; 15 Aug 2017 20:24:44 +0000 Received: from localhost ([127.0.0.1]:39541 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhiOK-0003Dq-6r for submit@debbugs.gnu.org; Tue, 15 Aug 2017 16:24:44 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47863) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhiOI-0003Dk-Td for 28093@debbugs.gnu.org; Tue, 15 Aug 2017 16:24:43 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 1917B22A31; Tue, 15 Aug 2017 16:24:42 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Tue, 15 Aug 2017 16:24:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=dQP3AGj5FSCwIxQkeB+ZCuLcJIb5bs88FDlVqR tId0g=; b=GSteCFdt28OJ9262ajqcXlNtNGz69nN2yIeX7xGkcjUq7HjWhz0SSv RBjM1/cNbhR2+IrIlsTrCGL6bd3OzaGvDwgbXYbtLqumBWFpStzC3P20TVpfqary c1PEF8AosJ6DIDHvBfJoG92C7hmt3gWGpRB1pqSkM1XjGSJ6SXmRY= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=dQP3AGj5FSCwIxQkeB +ZCuLcJIb5bs88FDlVqRtId0g=; b=TfdWc3fvyGewzaCvAdjduePS+XORrsdO+D Zpc9upzoeGd9dcrl2L9vCJUlg4uLTGaOkrvQ5AFp1C4dIZykQaNSIBpkMBXnoGb2 VKv2hi7PyUh5cuEhXZ+mJLOSg9i/dBzsFQnwKfFiVUuPfOGFLoAS+iohivt5oYHL T0gUhHf3RG2/KEUQtO8NnPIhrKKc1y3bGHP09z9Slgj6ixVjtw3JxrIizKSUCILE Yd7dQs5mrwmJBbBl8qKfxVHsIRE3PMPAgVUDl5rqU82UwWMzhwfXm6vvRMA1V89G KhhdC5lR/hU6DI9ebjWqmfsJCqNmGQiTtjgyapwHfU5lVihdfC5g== X-ME-Sender: X-Sasl-enc: QU777XnGKdP7hw1CI/2uiC1kM9tVsLrAZwGAkhJxcohM 1502828681 Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id C41087E4F0; Tue, 15 Aug 2017 16:24:41 -0400 (EDT) Date: Tue, 15 Aug 2017 16:24:40 -0400 From: Leo Famulari To: Marius Bakke Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. Message-ID: <20170815202440.GA13279@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> <20170815192136.GB9893@jasmine.lan> <87valozixh.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <87valozixh.fsf@fastmail.com> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28093 Cc: 28093@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 15, 2017 at 10:15:38PM +0200, Marius Bakke wrote: > cgit was not affected by the failing git@2.10 package since it only uses > the *source* derivation. It does not care about what's going on in > git's [arguments]. :-) Ah, that's right. > So this patch won't change anything from cgits perspective. I'm > slightly in favor of keeping git@2.10 until it's really uneeded (awkward > if we have to add it back later), but no strong opinion either way. >=20 > I would probably have done this instead of disabling tests if I had > thought about it. This change won't make a measurable difference to Hydra's workload, but I'd still like to avoid building this package unnecessarily. --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmTWIUACgkQJkb6MLrK fwjU4w//TE51+bup3euj4HxWK+60ViOvYV8NiQaVbvtBAta5kXq7/r3Q6slGp/Lw fohelFwPS3bVupJz9MjdN4wLksKlGMLsN2jaxaihzI/dkldvwnpUIgwYxkIoCnUZ wbHkeKpIshfcJFx+ZU+6rHlcXKREVb+Zt4v/e1Fce09LMvtX4AOZZIA3Wu7NKMzf /nWLJTebLRMLUpVLo0Te11yw6/6d5FPT0P4QfwGbItrhtHxMALkTceXG1N1NIFBx IHP49zyKD24WZIm5cW33HLUPPEVIJ0F1xftiN0QTqlX7Ba5otjpySRcSv76tjz4Y UOlC45juP0SxBFcCnYBj0EdyJQLet8zXbGl0GlRsc3tpAQAl02U/Bb+wKZ0m8zXL JRXuxAT7wk3MwVYEWN5S3H9JVPFOLuMHKP/RvkCq61aDxS54novvCel1Sj35iwHr NZ2H52uQwDrUW6FYTLRLx1Mr6fcMUF+QKDPyEg9LrxO30ja3440OW6zMZAVAJ5qf M5C9mgsUqaHomk8XwxGQuXXo6SjYbFnrbVB2k5uMPuWdE+4lP23y/nRvqCr15VNL nRiQf0OxjBxbrIg746sz7KutEfxfdEDXq5R089epkMDr31AG2y/gdD60F4BFOgYQ tNFAZpqKthhoZU91UIR+7ix7SUf0hBfj1m3sNcUAbovNIqNi2V4= =Fe4N -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 17:46:33 2017 Received: (at 28093) by debbugs.gnu.org; 15 Aug 2017 21:46:33 +0000 Received: from localhost ([127.0.0.1]:39879 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhjfV-0005nz-HX for submit@debbugs.gnu.org; Tue, 15 Aug 2017 17:46:33 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:51933) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhjfT-0005nt-B4 for 28093@debbugs.gnu.org; Tue, 15 Aug 2017 17:46:32 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 106AC21966; Tue, 15 Aug 2017 17:44:37 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Tue, 15 Aug 2017 17:44:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=fiisoJNLV5xrWY51PzeyATkDmD+FMObZt5PL3qb82 NM=; b=d67HJUKeE8RiIW/jvCM4udUmUnEEYdzBsmRb0v0qKMdMXsVWrcqpi1qJ6 EQWpatQ0NNuTqzOwdlhKa/qSb+OJAzOlzMWZlUwBIAITJJyZbgxLvjCQaIbujhVq wXnJ2QMcYgbntvwEV95GiS7UUeLX8mXuwsff0YrT30vppO7mT6HSQHw/bHYaKP1P DZCBfiYaKxtpbvjv4JsIsApDwFhos4Xj3GPHDjWsrg4sukvFqXhJK5PUlDLskNQS 9xNdHoqrSY85wmQNsRexkF6winEqo8d0S0U5hQSTytLduOXqqzGQtpXGBKY24xAC lpw2YPcJuMVhdMU0owEVFBpE6i9lg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=fiisoJNLV5xrWY51Pz eyATkDmD+FMObZt5PL3qb82NM=; b=cSwenzzbZI9R2hOD0bUIeGfPpzT1RPIhST m/nkr7A+9R0/87cHMqy4r/a+qJtGULQwzWb+J4YO0lmjzBXFKdfkdcW4o9AgTA7q 7b0OuwSHUIXxFH+p2tBJ3hdx1NIBhq5jmZ8eTnGJxT08Vdia3f2/nzGwu60KQYAr HN/i5pc/6y3JyQo0HfZPKkp74eumEDacfc1czsiGSiGr0UuzBaFSO+pHN/J6ijws WOIWiCkR1uaR8ILrdeO9mJpYE+H/8Wx5/4ZzxSwoAiuoDYVtxrZknQ9oddVAVRkR lSTyPj+7SB0Qjmk2Xb+oZZ6LiPluAQ8yC8Y76BqOc6VcmWWz0u+w== X-ME-Sender: X-Sasl-enc: uP3XCNlb/DqCmkPfAP9R8IEpEo/Ggi+h7LPElC75aVv1 1502833476 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 8E4F97E70C; Tue, 15 Aug 2017 17:44:36 -0400 (EDT) From: Marius Bakke To: Leo Famulari Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input. In-Reply-To: <20170815202440.GA13279@jasmine.lan> References: <20170815073531.4b72ab02@cbaines.net> <20170815192136.GB9893@jasmine.lan> <87valozixh.fsf@fastmail.com> <20170815202440.GA13279@jasmine.lan> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Tue, 15 Aug 2017 23:44:16 +0200 Message-ID: <87shgszetr.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28093 Cc: 28093@debbugs.gnu.org, Christopher Baines X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Leo Famulari writes: >> So this patch won't change anything from cgits perspective. I'm >> slightly in favor of keeping git@2.10 until it's really uneeded (awkward >> if we have to add it back later), but no strong opinion either way. >>=20 >> I would probably have done this instead of disabling tests if I had >> thought about it. > > This change won't make a measurable difference to Hydra's workload, but > I'd still like to avoid building this package unnecessarily. Sounds good! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmTazAACgkQoqBt8qM6 VPoifgf/Q8HxV7yx74vJgYaYtyLiALaf6LgxAyAd4DEEg15mUQw1uHoZjIozZ8M3 dMkOKNirf+GrqcGRMdLeWbQUol4ld3HS0ZF95oaF/1uVdCMfoCkuarCxJhvv4iGz NV5SKzwobRuGER1rWH1WHT1nIYg0Fp59p6RrQR3jsIUWRr7HZA5ntn1Fo4FDRVps muh/QTChLRC/ewJNLDdoJtLBs+g4EKW1dy4y3UKnUnvluOW115xlvjjNSc8zaOzr kr9pFwGKqnXpxkW1017TiPjWSW4UHoXBtsCJ8yOWLrj88KhjJQ3L/Cf+Ouk8W2pT z3w8+5ikqIyJfTKspKLAdPfwKNZxcg== =khdB -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 18:01:28 2017 Received: (at control) by debbugs.gnu.org; 15 Aug 2017 22:01:28 +0000 Received: from localhost ([127.0.0.1]:39951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhjtw-0005w9-7h for submit@debbugs.gnu.org; Tue, 15 Aug 2017 18:01:28 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:39135) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhjtt-0005w3-Ki for control@debbugs.gnu.org; Tue, 15 Aug 2017 18:01:26 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 789D9228C3; Tue, 15 Aug 2017 18:01:25 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Tue, 15 Aug 2017 18:01:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=content-type:date:from:message-id:mime-version:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=JJipAUvr+HKVMQ9 cz9dWvlD0PsW5VGEpgrEP8hO+8MU=; b=SgdVZwd2Y1nSzEtuh6evd4gZiGB6Arh yBPwKS6eKMXBeXK4krJSS2HYBvcp1JOgui5DVzqdEEIFdU/dEiAFnZ5A1Meu/ODS 0waaHPcPRQb7eOuufduASZsJWQ9f6hdWJNQa8AX0VoEk2ghZ71FWFObUIYez7XzI 7dCUmQmH+PUs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:message-id :mime-version:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=JJipAUvr+HKVMQ9cz9dWvlD0PsW5VGEpgrEP8hO+8MU=; b=QEGE+ d6zMBGBcC/a+e2Nmms1WoVfYRVhJm7V2cP/OoKJLqzK3mQLZNNRTxE5qMN9pUHGH AsrD+1NbvjGJVGd+zh5BQdtlIgSz3KhzhtBIC1pvXn+FCiYmIOXtiC2AUnkre0S0 ZwoQiUDvIyLOpqh/b7zJcH21jS+/552gLfpQq0So4dOeCxd7/yIfx+LoIWgWFM6r Oyr4/dHWvTM9R7/FHlpK03rrxKrTKI8rLKDPfVUGhuEk4vn01RC9m5pmWAQ2ztMU XJLIBPKZNIU2kP7g1N3qhtm/7aUdUy8dI3SBDZARN369Myh8sXt393XeaH+qr//j /uZp8qjSZFV+nfAGg== X-ME-Sender: X-Sasl-enc: wbCi7hBVYfh68VEpKi/oQ9EjFLdf7cSSQTE/zQvSogcc 1502834485 Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 281442486E for ; Tue, 15 Aug 2017 18:01:25 -0400 (EDT) Date: Tue, 15 Aug 2017 18:01:23 -0400 From: Leo Famulari To: control@debbugs.gnu.org Message-ID: <20170815220123.GA19789@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 28093 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.25 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.25 listed in wl.mailspike.net] 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.3 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: close 28093 [...] Content analysis details: (1.3 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [66.111.4.25 listed in wl.mailspike.net] -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low trust [66.111.4.25 listed in list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 T_DKIM_INVALID DKIM-Signature header exists but is not valid 0.0 TVD_SPACE_RATIO No description available. 1.8 MISSING_SUBJECT Missing Subject: header 0.2 NO_SUBJECT Extra score for no subject -0.0 RCVD_IN_MSPIKE_WL Mailspike good senders close 28093 From unknown Sat Jun 21 03:16:18 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Sep 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator