GNU bug report logs - #28093
[PATCH] gnu: cgit: Don't build cgit's special 'git:src' input.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28093 in the body.
You can then email your comments to 28093 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: cgit: Don't build cgit's special 'git:src' input.
Date: Mon, 14 Aug 2017 23:31:37 -0400

* gnu/packages/version-control.scm (cgit)[inputs]: Replace the git <at> 2.10
package with an origin reference of the source code.
(git <at> 2.10): Remove variable.
---
 gnu/packages/version-control.scm | 31 ++++++++++++-------------------
 1 file changed, 12 insertions(+), 19 deletions(-)

diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm
index 7c1f02d5a..3f76ed7f3 100644
--- a/gnu/packages/version-control.scm
+++ b/gnu/packages/version-control.scm
@@ -9,7 +9,7 @@
 ;;; Copyright © 2015, 2016, 2017 Efraim Flashner <efraim <at> flashner.co.il>
 ;;; Copyright © 2015 Kyle Meyer <kyle <at> kyleam.com>
 ;;; Copyright © 2015, 2017 Ricardo Wurmus <rekado <at> elephly.net>
-;;; Copyright © 2016 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2016, 2017 Leo Famulari <leo <at> famulari.name>
 ;;; Copyright © 2016, 2017 ng0 <contact.ng0 <at> cryptolab.net>
 ;;; Copyright © 2017 Tobias Geerinckx-Rice <me <at> tobias.gr>
 ;;; Copyright © 2017 Vasile Dumitrascu <va511e <at> yahoo.com>
@@ -121,6 +121,8 @@ as well as the classic centralized workflow.")
 (define-public git
   (package
    (name "git")
+   ;; XXX When updating Git, check if the special 'git:src' input to cgit needs
+   ;; to be updated as well.
    (version "2.14.1")
    (source (origin
             (method url-fetch)
@@ -349,23 +351,6 @@ everything from small to very large projects with speed and efficiency.")
    (license license:gpl2)
    (home-page "https://git-scm.com/")))
 
-;; Some dependent packages directly access internal interfaces which
-;; have changed in 2.12. TODO: Remove this for cgit > 1.1.
-(define-public git <at> 2.10
-  (package
-    (inherit git)
-    (version "2.10.4")
-    (source (origin
-              (method url-fetch)
-              (uri (string-append "mirror://kernel.org/software/scm/git/git-"
-                                  version ".tar.xz"))
-              (sha256
-               (base32
-                "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l"))))
-    (arguments
-     `(#:tests? #f
-       ,@(package-arguments git)))))
-
 (define-public libgit2
   (package
     (name "libgit2")
@@ -502,6 +487,8 @@ collaboration using typical untrusted file hosts or services.")
 (define-public cgit
   (package
     (name "cgit")
+    ;; XXX When updating cgit, try removing the special 'git:src' input and
+    ;; using the source of the git package.
     (version "1.1")
     (source (origin
               (method url-fetch)
@@ -546,7 +533,13 @@ collaboration using typical untrusted file hosts or services.")
      ;; For building manpage.
      `(("asciidoc" ,asciidoc)))
     (inputs
-     `(("git:src" ,(package-source git <at> 2.10))
+     `(("git:src"
+        ,(origin
+           (method url-fetch)
+           (uri "mirror://kernel.org/software/scm/git/git-2.10.4.tar.xz")
+           (sha256
+            (base32
+             "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l"))))
        ("openssl" ,openssl)
        ("zlib" ,zlib)))
     (home-page "https://git.zx2c4.com/cgit/")
-- 
2.14.1

Message #8 received at 28093 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 28093 <at> debbugs.gnu.org
Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special
 'git:src' input.
Date: Tue, 15 Aug 2017 07:35:31 +0100

[Message part 1 (text/plain, inline)]

On Mon, 14 Aug 2017 23:31:37 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> * gnu/packages/version-control.scm (cgit)[inputs]: Replace the
> git <at> 2.10 package with an origin reference of the source code.
> (git <at> 2.10): Remove variable.

It would be useful if outside of the changelog, but in the commit
message, you could put why you are making the change. As far as I can
tell, this won't change the cgit package, so I'm guessing the intent is
to neaten up the code?

> ---
>  gnu/packages/version-control.scm | 31 ++++++++++++-------------------
>  1 file changed, 12 insertions(+), 19 deletions(-)
> 
> diff --git a/gnu/packages/version-control.scm
> b/gnu/packages/version-control.scm index 7c1f02d5a..3f76ed7f3 100644
> --- a/gnu/packages/version-control.scm
> +++ b/gnu/packages/version-control.scm
> @@ -9,7 +9,7 @@
>  ;;; Copyright © 2015, 2016, 2017 Efraim Flashner
> <efraim <at> flashner.co.il> ;;; Copyright © 2015 Kyle Meyer
> <kyle <at> kyleam.com> ;;; Copyright © 2015, 2017 Ricardo Wurmus
> <rekado <at> elephly.net> -;;; Copyright © 2016 Leo Famulari
> <leo <at> famulari.name> +;;; Copyright © 2016, 2017 Leo Famulari
> <leo <at> famulari.name> ;;; Copyright © 2016, 2017 ng0
> <contact.ng0 <at> cryptolab.net> ;;; Copyright © 2017 Tobias
> Geerinckx-Rice <me <at> tobias.gr> ;;; Copyright © 2017 Vasile Dumitrascu
> <va511e <at> yahoo.com> @@ -121,6 +121,8 @@ as well as the classic
> centralized workflow.") (define-public git
>    (package
>     (name "git")
> +   ;; XXX When updating Git, check if the special 'git:src' input to
> cgit needs
> +   ;; to be updated as well.
>     (version "2.14.1")
>     (source (origin
>              (method url-fetch)
> @@ -349,23 +351,6 @@ everything from small to very large projects
> with speed and efficiency.") (license license:gpl2)
>     (home-page "https://git-scm.com/")))
>  
> -;; Some dependent packages directly access internal interfaces which
> -;; have changed in 2.12. TODO: Remove this for cgit > 1.1.
> -(define-public git <at> 2.10
> -  (package
> -    (inherit git)
> -    (version "2.10.4")
> -    (source (origin
> -              (method url-fetch)
> -              (uri (string-append
> "mirror://kernel.org/software/scm/git/git-"
> -                                  version ".tar.xz"))
> -              (sha256
> -               (base32
> -
> "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l"))))
> -    (arguments
> -     `(#:tests? #f
> -       ,@(package-arguments git)))))
> -
>  (define-public libgit2
>    (package
>      (name "libgit2")
> @@ -502,6 +487,8 @@ collaboration using typical untrusted file hosts
> or services.") (define-public cgit
>    (package
>      (name "cgit")
> +    ;; XXX When updating cgit, try removing the special 'git:src'
> input and
> +    ;; using the source of the git package.
>      (version "1.1")
>      (source (origin
>                (method url-fetch)
> @@ -546,7 +533,13 @@ collaboration using typical untrusted file hosts
> or services.") ;; For building manpage.
>       `(("asciidoc" ,asciidoc)))
>      (inputs
> -     `(("git:src" ,(package-source git <at> 2.10))
> +     `(("git:src"
> +        ,(origin
> +           (method url-fetch)
> +           (uri
> "mirror://kernel.org/software/scm/git/git-2.10.4.tar.xz")
> +           (sha256
> +            (base32
> +
> "1pni4mgih5w42813dxljl61s7xmcpdnar34d9m4548hzpljjyd4l"))))
> ("openssl" ,openssl) ("zlib" ,zlib)))
>      (home-page "https://git.zx2c4.com/cgit/")

[Message part 2 (application/pgp-signature, inline)]

Message #11 received at 28093 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 28093 <at> debbugs.gnu.org
Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special
 'git:src' input.
Date: Tue, 15 Aug 2017 15:21:36 -0400

[Message part 1 (text/plain, inline)]

On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote:
> On Mon, 14 Aug 2017 23:31:37 -0400
> Leo Famulari <leo <at> famulari.name> wrote:
> 
> > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the
> > git <at> 2.10 package with an origin reference of the source code.
> > (git <at> 2.10): Remove variable.
> 
> It would be useful if outside of the changelog, but in the commit
> message, you could put why you are making the change. As far as I can
> tell, this won't change the cgit package, so I'm guessing the intent is
> to neaten up the code?

Recently we started running the test suite of the "main" git package.

That caused the build of this package to fail, which also made cgit
fail to build, and that was annoying.

But, we don't even need to build this source code as a package, since it
gets built within the cgit build process, and we don't run the tests
there.

So, I figured we might as well not provide this as a package at all,
since it's really just intended to provide source code to cgit.

Does that sound reasonable?

If so, I'll summarize this in the commit message.

[signature.asc (application/pgp-signature, inline)]

Message #14 received at 28093 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 28093 <at> debbugs.gnu.org
Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special
 'git:src' input.
Date: Tue, 15 Aug 2017 20:54:32 +0100

[Message part 1 (text/plain, inline)]

On Tue, 15 Aug 2017 15:21:36 -0400
Leo Famulari <leo <at> famulari.name> wrote:

> On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote:
> > On Mon, 14 Aug 2017 23:31:37 -0400
> > Leo Famulari <leo <at> famulari.name> wrote:
> >   
> > > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the
> > > git <at> 2.10 package with an origin reference of the source code.
> > > (git <at> 2.10): Remove variable.  
> > 
> > It would be useful if outside of the changelog, but in the commit
> > message, you could put why you are making the change. As far as I
> > can tell, this won't change the cgit package, so I'm guessing the
> > intent is to neaten up the code?  
> 
> Recently we started running the test suite of the "main" git package.
> 
> That caused the build of this package to fail, which also made cgit
> fail to build, and that was annoying.
> 
> But, we don't even need to build this source code as a package, since
> it gets built within the cgit build process, and we don't run the
> tests there.
> 
> So, I figured we might as well not provide this as a package at all,
> since it's really just intended to provide source code to cgit.
> 
> Does that sound reasonable?

Yep, makes sense, and the diff looks good to me.

> If so, I'll summarize this in the commit message.

Great :D

[Message part 2 (application/pgp-signature, inline)]

Message #17 received at 28093 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>, Christopher Baines <mail <at> cbaines.net>
Cc: 28093 <at> debbugs.gnu.org
Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special
 'git:src'	input.
Date: Tue, 15 Aug 2017 22:15:38 +0200

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Aug 15, 2017 at 07:35:31AM +0100, Christopher Baines wrote:
>> On Mon, 14 Aug 2017 23:31:37 -0400
>> Leo Famulari <leo <at> famulari.name> wrote:
>> 
>> > * gnu/packages/version-control.scm (cgit)[inputs]: Replace the
>> > git <at> 2.10 package with an origin reference of the source code.
>> > (git <at> 2.10): Remove variable.
>> 
>> It would be useful if outside of the changelog, but in the commit
>> message, you could put why you are making the change. As far as I can
>> tell, this won't change the cgit package, so I'm guessing the intent is
>> to neaten up the code?
>
> Recently we started running the test suite of the "main" git package.
>
> That caused the build of this package to fail, which also made cgit
> fail to build, and that was annoying.

cgit was not affected by the failing git <at> 2.10 package since it only uses
the *source* derivation.  It does not care about what's going on in
git's [arguments]. :-)

So this patch won't change anything from cgits perspective.  I'm
slightly in favor of keeping git <at> 2.10 until it's really uneeded (awkward
if we have to add it back later), but no strong opinion either way.

I would probably have done this instead of disabling tests if I had
thought about it.

[signature.asc (application/pgp-signature, inline)]

Message #20 received at 28093 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 28093 <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special
 'git:src'	input.
Date: Tue, 15 Aug 2017 16:24:40 -0400

[Message part 1 (text/plain, inline)]

On Tue, Aug 15, 2017 at 10:15:38PM +0200, Marius Bakke wrote:
> cgit was not affected by the failing git <at> 2.10 package since it only uses
> the *source* derivation.  It does not care about what's going on in
> git's [arguments]. :-)

Ah, that's right.

> So this patch won't change anything from cgits perspective.  I'm
> slightly in favor of keeping git <at> 2.10 until it's really uneeded (awkward
> if we have to add it back later), but no strong opinion either way.
> 
> I would probably have done this instead of disabling tests if I had
> thought about it.

This change won't make a measurable difference to Hydra's workload, but
I'd still like to avoid building this package unnecessarily.

[signature.asc (application/pgp-signature, inline)]

Message #23 received at 28093 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 28093 <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: [bug#28093] [PATCH] gnu: cgit: Don't build cgit's special
 'git:src'	input.
Date: Tue, 15 Aug 2017 23:44:16 +0200

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:
>> So this patch won't change anything from cgits perspective.  I'm
>> slightly in favor of keeping git <at> 2.10 until it's really uneeded (awkward
>> if we have to add it back later), but no strong opinion either way.
>> 
>> I would probably have done this instead of disabling tests if I had
>> thought about it.
>
> This change won't make a measurable difference to Hydra's workload, but
> I'd still like to avoid building this package unnecessarily.

Sounds good!

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.