From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 14 22:31:48 2017 Received: (at submit) by debbugs.gnu.org; 15 Aug 2017 02:31:48 +0000 Received: from localhost ([127.0.0.1]:37563 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhRdz-0006or-Pb for submit@debbugs.gnu.org; Mon, 14 Aug 2017 22:31:48 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52683) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhRdy-0006ol-BW for submit@debbugs.gnu.org; Mon, 14 Aug 2017 22:31:46 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhRds-0000Zv-6C for submit@debbugs.gnu.org; Mon, 14 Aug 2017 22:31:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.0 required=5.0 tests=BAYES_20,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:49664) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dhRds-0000Zq-2f for submit@debbugs.gnu.org; Mon, 14 Aug 2017 22:31:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:43653) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dhRdq-0007oS-W5 for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 22:31:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dhRdm-0000ZD-RT for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 22:31:38 -0400 Received: from mail-pg0-x235.google.com ([2607:f8b0:400e:c05::235]:33315) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dhRdm-0000Z7-Ke for bug-gnu-emacs@gnu.org; Mon, 14 Aug 2017 22:31:34 -0400 Received: by mail-pg0-x235.google.com with SMTP id u5so58639280pgn.0 for ; Mon, 14 Aug 2017 19:31:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=4RWFkTVp0jW+WVs1AixOPllKkn7FGl+RiGY6FcrlekE=; b=TkZfhc95LgL+Dt1lu+RnW02hROWRGfLkdle60Fn0+eeRCgyuNRdyvNhCMgxaJIyI+S 0HKhohSgdmH+Djx+r7C8dsFfJl3SO95BX7o9lEYUWLAI0pPrA2EyLwdgQr6k0VsINJKl B/3Bro1cl1CtrlJ0vptnZTYpm8JL/JjFJKi46/r3u45eMnbzOoFmlMW8FeolGNl1r4ek fD4L1ojkglQPgNwWfNEFUxLSOhwfOY6S8mUBkWEPWlAkq8tWTH8NKjWgwoDuwtF4MXdo WG4Ho7NoQPokf9rJDIp/CcSKbb9Gv3ys+wFQVuLJj5c1oQMNyA788ZPZxewFG68F2Gq8 3lJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=4RWFkTVp0jW+WVs1AixOPllKkn7FGl+RiGY6FcrlekE=; b=bnY85tsYblUpQW+7nk8ETHWdCkE9xZK/8XcYHfZ+VZ+3V+7JsEtM7SWHCIGa6TO2CQ dva6+PONuDnEHjprHklujL/wo6Y5UatUgi0r+NFoduwPhpnWZLTmeFDXr0W3MYyP8nj5 5EBAlP9gVEcEnr5tJ07h21TN+tj0Xu3WR3T3iuVgKBIYZR1L6Id2wsIDg/ESEufA2gRy RXhoXrn1PPu1ntw0CjgidgxCBNoDqYT2gU0pJu3yq+jb8TItdB8WXBfYEUjhgQYVzFf/ 88s0QhlbfocmXGtS7FKYSH9NROQM0m4CKIEWju3NXbriXK35SMpjaiK4uVl5U9k19vyu j14A== X-Gm-Message-State: AHYfb5jzNW0Etjx9Ik84uwO/xdN2NwrNyFkWnP36tmtnvpiUSOho/Q0N lkhtLEbbjIhcF5a/ X-Received: by 10.84.213.136 with SMTP id g8mr24045508pli.107.1502764293488; Mon, 14 Aug 2017 19:31:33 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id z5sm13690073pgr.35.2017.08.14.19.31.32 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Aug 2017 19:31:33 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; archive-int-to-mode check S_ISUID, S_ISGID bits in reverse order Date: Tue, 15 Aug 2017 11:31:25 +0900 Message-ID: <87tw19a7eq.fsf@calancha-pc> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Tags: patch emacs -Q -l arc-mode (archive-int-to-mode 2048) => "------S---" ; It should be: "---S------" (archive-int-to-mode 1024) => "---S------" ; It should be: "------S---" --8<-----------------------------cut here---------------start------------->8--- commit 03b830d7ad819118c8b9d4e30cf6da638a579c88 Author: Tino Calancha Date: Tue Aug 15 11:15:10 2017 +0900 archive-int-to-mode: Fix order of testing S_ISUID, S_ISGID bits * lisp/arc-mode.el (archive-int-to-mode): Swap order of 2048 with 1024 tests (Bug#28092). * test/lisp/arc-mode-tests.el (arc-mode-test-archive-int-to-mode): Update test. diff --git a/lisp/arc-mode.el b/lisp/arc-mode.el index bd7548b704..938c143b8e 100644 --- a/lisp/arc-mode.el +++ b/lisp/arc-mode.el @@ -559,13 +559,13 @@ archive-int-to-mode (if (zerop (logand 256 mode)) ?- ?r) (if (zerop (logand 128 mode)) ?- ?w) (if (zerop (logand 64 mode)) - (if (zerop (logand 1024 mode)) ?- ?S) - (if (zerop (logand 1024 mode)) ?x ?s)) + (if (zerop (logand 2048 mode)) ?- ?S) + (if (zerop (logand 2048 mode)) ?x ?s)) (if (zerop (logand 32 mode)) ?- ?r) (if (zerop (logand 16 mode)) ?- ?w) (if (zerop (logand 8 mode)) - (if (zerop (logand 2048 mode)) ?- ?S) - (if (zerop (logand 2048 mode)) ?x ?s)) + (if (zerop (logand 1024 mode)) ?- ?S) + (if (zerop (logand 1024 mode)) ?x ?s)) (if (zerop (logand 4 mode)) ?- ?r) (if (zerop (logand 2 mode)) ?- ?w) (if (zerop (logand 1 mode)) ?- ?x))) diff --git a/test/lisp/arc-mode-tests.el b/test/lisp/arc-mode-tests.el index 04047bab62..c2501e921a 100644 --- a/test/lisp/arc-mode-tests.el +++ b/test/lisp/arc-mode-tests.el @@ -27,7 +27,7 @@ (cons 420 "-rw-r--r--") (cons 292 "-r--r--r--") (cons 512 "----------") - (cons 1024 "---S------")))) + (cons 1024 "------S---")))) (dolist (x alist) (should (equal (cdr x) (archive-int-to-mode (car x))))))) --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-08-15 Repository revision: e88bbd22c5ffb1d6008c0c7e18a36043b0f397dd From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 02:47:56 2017 Received: (at 28092-done) by debbugs.gnu.org; 15 Aug 2017 06:47:56 +0000 Received: from localhost ([127.0.0.1]:37645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhVds-0000Or-Hk for submit@debbugs.gnu.org; Tue, 15 Aug 2017 02:47:56 -0400 Received: from mail-pg0-f41.google.com ([74.125.83.41]:38384) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhVdp-0000Ol-AD for 28092-done@debbugs.gnu.org; Tue, 15 Aug 2017 02:47:54 -0400 Received: by mail-pg0-f41.google.com with SMTP id l64so786192pge.5 for <28092-done@debbugs.gnu.org>; Mon, 14 Aug 2017 23:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=kmswjPxmtLhLpeZFV6PMf2KsP/WyoIU5WVved8XXBSU=; b=Tt47ITknuBKZhEWvjjs/qjFxxA6VXGQZoWc+lW45BN8BMO6oHnN0FeC2Lgtd+t7b8E hgQlKbrv3Wu+UlD+3Ed7UleMja/9zJg0APsFHvmiLPeVv3rCQnF3caew65NrAdpjgaLa V5ii2AWsG9qlt54ce8bkOBqBOos8HGGHPN4S44fhv8QNfshoqjAvfhiGxgklXznjJ7iy wXflTQaeD6gkjJb30EI0UEruA0+DPk5+Hqz6uLXWfViUrwNvM58zw8HAUj6O9RJKbw5G 7B36Ea8DPnEigl4j9DksD0dvA3mWuJBKCfuIFM24NAaqfhB0HaRHLKNIcFKCCdrNzExT wT+w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=kmswjPxmtLhLpeZFV6PMf2KsP/WyoIU5WVved8XXBSU=; b=FHLTA+lTk+oTO2rM7sB0pp1L0lHAih2M9/YPMQmUC9SUDqJ7jqKGhXk9MJjdtujI46 DVmynFCkKG2r2U1wnXSkz4i43DedN4lTbdeDtBXlLfOuq0w+0rnVmiBH/RxVjKX7lUKp T9vqm5U/buQ5APF9B6pDd0Lbx5LKkdVM4iBaVy0ZnjUxMl4OD+KfEeldZEpVJd5GpLxi d1jxObSJ1oNUIdHHNtsNhQFUXAbfv43RCbaHtuIh7LQvbKxafv+Uz0tpy+hXRnYalpWu MmVKaYK1Eo4t6+Dh2l/yfJI4JMdjVF88r+DbGfddAt3QnlJFtBV8vDImB9d1RbTrMnlK /shA== X-Gm-Message-State: AHYfb5iV62lqzjCDbWbRayKHnAJIvj+dTwDNYpLPYXvD5voNHg+Vd7Tq PVsvUhwWb5zrVuYz X-Received: by 10.84.233.207 with SMTP id m15mr30535677pln.334.1502779667012; Mon, 14 Aug 2017 23:47:47 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id v19sm16013507pgc.93.2017.08.14.23.47.45 for <28092-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 14 Aug 2017 23:47:46 -0700 (PDT) From: Tino Calancha To: 28092-done@debbugs.gnu.org Subject: Re: bug#28092: 26.0.50; archive-int-to-mode check S_ISUID, S_ISGID bits in reverse order References: <87tw19a7eq.fsf@calancha-pc> Date: Tue, 15 Aug 2017 15:47:40 +0900 In-Reply-To: <87tw19a7eq.fsf@calancha-pc> (Tino Calancha's message of "Tue, 15 Aug 2017 11:31:25 +0900") Message-ID: <87h8x92upf.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 28092-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Tino Calancha writes: > Tags: patch > > emacs -Q -l arc-mode > > (archive-int-to-mode 2048) > => "------S---" ; It should be: "---S------" > (archive-int-to-mode 1024) > => "---S------" ; It should be: "------S---" Fixed in master branch as commit 66b75d3f2002459edccd241af57c63b380b192d3 (archive-int-to-mode: Fix order of testing S_ISUID, S_ISGID bits) From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 15 12:06:55 2017 Received: (at 28092) by debbugs.gnu.org; 15 Aug 2017 16:06:55 +0000 Received: from localhost ([127.0.0.1]:38398 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dheMp-0007WU-LM for submit@debbugs.gnu.org; Tue, 15 Aug 2017 12:06:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:36730) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dheMo-0007WO-5L for 28092@debbugs.gnu.org; Tue, 15 Aug 2017 12:06:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dheMe-00089d-4J for 28092@debbugs.gnu.org; Tue, 15 Aug 2017 12:06:49 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37530) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dheMe-00089V-0s; Tue, 15 Aug 2017 12:06:44 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1891 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dheMd-0004YC-EO; Tue, 15 Aug 2017 12:06:43 -0400 Date: Tue, 15 Aug 2017 19:06:40 +0300 Message-Id: <83bmnghl2n.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87h8x92upf.fsf@calancha-pc> (message from Tino Calancha on Tue, 15 Aug 2017 15:47:40 +0900) Subject: Re: bug#28092: 26.0.50; archive-int-to-mode check S_ISUID, S_ISGID bits in reverse order References: <87tw19a7eq.fsf@calancha-pc> <87h8x92upf.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28092 Cc: 28092@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Tue, 15 Aug 2017 15:47:40 +0900 > > Tino Calancha writes: > > > Tags: patch > > > > emacs -Q -l arc-mode > > > > (archive-int-to-mode 2048) > > => "------S---" ; It should be: "---S------" > > (archive-int-to-mode 1024) > > => "---S------" ; It should be: "------S---" > Fixed in master branch as commit > 66b75d3f2002459edccd241af57c63b380b192d3 > (archive-int-to-mode: Fix order of testing S_ISUID, S_ISGID bits) Please in the future allow at least 1 full day for people to respond to a patch you propose. 4 hours is way too short time... There's no need to rush with installing changes, unless they fix some bug that breaks a build or something. Thanks. From unknown Sat Jun 21 10:42:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 13 Sep 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator