GNU bug report logs - #28083
Two patches for grep on Windows, fixing directory recursion and leaking color

Previous Next

Full log

Message #17 received at 28083 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Stephan Lavavej <stl <at> nuwen.net>
Cc: 28083 <at> debbugs.gnu.org
Subject: Re: bug#28083: Two patches for grep on Windows, fixing directory
 recursion and leaking color
Date: Sun, 26 Nov 2017 18:58:19 -0800

On Sun, Nov 26, 2017 at 6:13 PM, Stephan Lavavej <stl <at> nuwen.net> wrote:
> On Sun, Nov 26, 2017 at 3:58 PM, Jim Meyering <jim <at> meyering.net> wrote:
>> [for reference, we're discussing these:
>> https://debbugs.gnu.org/db/28/28083.html]
>> Thank you for preparing those.
>
> You're welcome!
>
>> Would you please follow the contribution guidelines in grep's HACKING
>> file, https://git.savannah.gnu.org/cgit/grep.git/tree/HACKING to
>> create two git change sets? Since each fixes a bug, each should also
>> add a brief comment to the NEWS file.
>>
>> Your first patch is tiny and looks fine, so I can apply it with no
>> paperwork required.
>
> Great, I've attached the output of git format-patch for that one.
> Please let me know if you need it in a different form.

I made only these changes to the commit log before pushing that:
- removed capitalization and trailing period from the one-line summary
in the log message
- added ChangeLog-style "* FILENAME (function): Sentence/phrase
describing the change" line for each modified file.

Please follow suit for your next patch(es).
Thanks,
Jim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.