From unknown Fri Jun 20 07:19:25 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#28066 <28066@debbugs.gnu.org> To: bug#28066 <28066@debbugs.gnu.org> Subject: Status: eshell-tramp sudo ignores C-c Reply-To: bug#28066 <28066@debbugs.gnu.org> Date: Fri, 20 Jun 2025 14:19:25 +0000 retitle 28066 eshell-tramp sudo ignores C-c reassign 28066 emacs submitter 28066 Yegor Timoshenko severity 28066 normal thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 12 10:45:58 2017 Received: (at submit) by debbugs.gnu.org; 12 Aug 2017 14:45:58 +0000 Received: from localhost ([127.0.0.1]:56631 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgXfq-0001Rb-1s for submit@debbugs.gnu.org; Sat, 12 Aug 2017 10:45:58 -0400 Received: from eggs.gnu.org ([208.118.235.92]:37341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgXfo-0001L8-3u for submit@debbugs.gnu.org; Sat, 12 Aug 2017 10:45:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgXfh-0004qQ-Lc for submit@debbugs.gnu.org; Sat, 12 Aug 2017 10:45:50 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,FREEMAIL_FROM, HTML_MESSAGE,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:40493) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dgXfh-0004pr-Ha for submit@debbugs.gnu.org; Sat, 12 Aug 2017 10:45:49 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56543) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dgXfg-0007C0-5c for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 10:45:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dgXff-0004l2-2I for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 10:45:48 -0400 Received: from mail-wr0-x22e.google.com ([2a00:1450:400c:c0c::22e]:36477) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dgXfe-0004jW-Ls for bug-gnu-emacs@gnu.org; Sat, 12 Aug 2017 10:45:46 -0400 Received: by mail-wr0-x22e.google.com with SMTP id y43so21857259wrd.3 for ; Sat, 12 Aug 2017 07:45:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=EkufzRkdQJAcv/L4lNRbyBTzeBuV3T2az9AQOaC4h04=; b=SrjyAOxfTv9SFpbc8WDUBGCZRGU9qok5Mtoi6jfG974d27a0TT6CCOFvNoSN2b88Ko 8XPlcPMoqG8PDJGHa76EePAiTwZIxMfQx5571EWNqgv6QCSrAyeF5nHTXx+COPYy8d8P m+zhY+ZK6frcflBkdH1acrX5VqH4vTQpWjbjIeMRSXISezSKPcv0vXrwvLT9usdYrCcG Vb2JL9TTtc6EjlVlFV1E5meHSZtyzc+qlxccnUIBqx2ESHDAlAAiWvJ5KCyznjl4u6/q UbEIiLDYTdGF7189+dFUIEpWLiDpGkhJB92cP1LjUpoimhZuAwd4jRyiGfZJ7jnFHU5J X6jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=EkufzRkdQJAcv/L4lNRbyBTzeBuV3T2az9AQOaC4h04=; b=pThmFvS6/ivElPGgooeBGUPjZJXa1pekjFb5MxkDQM+fVtShEvXBnxHXEkV+PlBn0T DcVo7LY1w8co3F1SkESifM55+ynGRLNnsRS0WI1t5dxK7H1A/trRIvRdxepmrAg4BTVi wx1UGzw2Czk0hmYGIq2W0m4UTVUZQEO3yQ9fNJFZkOf/IIUo031feGygVPluodan+Hz/ chNVj7j58TkcspGOCvpvXvdp6P17Oj3c4tv94ih+nRzeaxiBytpKYZSOOYUN4wHjAkhN ZNzTWXj0B6M0U0XyxPNDOTrEq2ySiaK873OhvEvObZUjude8bkXGKr3i6FpISWKWyC/d TYSw== X-Gm-Message-State: AHYfb5iILSa6uWVNuq180Ic94Bj3dC7tIP6qALyjr4sJNSfjOJoJSB0L dmUiNFf+KMR8Y23po/O+SGfh471zYKIl X-Received: by 10.223.170.2 with SMTP id p2mr15428339wrd.22.1502549145393; Sat, 12 Aug 2017 07:45:45 -0700 (PDT) MIME-Version: 1.0 From: Yegor Timoshenko Date: Sat, 12 Aug 2017 14:45:34 +0000 Message-ID: Subject: eshell-tramp sudo ignores C-c To: "bug-gnu-emacs@gnu.org" Content-Type: multipart/alternative; boundary="94eb2c1cc5c4119e1f05568f7c91" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) --94eb2c1cc5c4119e1f05568f7c91 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.16) of 2017-08-09 To reproduce, you'll need to add eshell-tramp module to configuration. Add the following form to your Emacs configuration file: (eval-after-load 'esh-module '(add-to-list 'eshell-modules-list 'eshell-tramp)) Then, M-x eshell. $ which sudo eshell/sudo is a compiled Lisp function in =E2=80=98em-tramp.el=E2=80=99 $ sudo sleep 10 Now, if you try to leave interrupt `sleep` using C-c, it won't work. --94eb2c1cc5c4119e1f05568f7c91 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Vers= ion 3.22.16)
=C2=A0of 2017-08-09

To repr= oduce, you'll need to add eshell-tramp module to configuration. Add the= following form to your Emacs configuration file:

=
(eval-after-load 'esh-module
=C2=A0 '(add-to-list &#= 39;eshell-modules-list 'eshell-tramp))

T= hen, M-x eshell.
$ which sudo
eshell/sudo is a com= piled Lisp function in =E2=80=98em-tramp.el=E2=80=99
$ sudo= sleep 10

Now, if you try to leave interrupt `slee= p` using C-c, it won't work.
--94eb2c1cc5c4119e1f05568f7c91-- From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 04:40:07 2017 Received: (at 28066) by debbugs.gnu.org; 13 Aug 2017 08:40:07 +0000 Received: from localhost ([127.0.0.1]:59195 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgoRL-00062T-BI for submit@debbugs.gnu.org; Sun, 13 Aug 2017 04:40:07 -0400 Received: from mout.gmx.net ([212.227.15.18]:52293) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dgoRJ-000622-VK for 28066@debbugs.gnu.org; Sun, 13 Aug 2017 04:40:06 -0400 Received: from detlef.gmx.de ([178.20.95.72]) by mail.gmx.com (mrgmx001 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MPlY2-1dcwoe118c-004xrl; Sun, 13 Aug 2017 10:39:58 +0200 From: Michael Albinus To: Yegor Timoshenko Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: Date: Sun, 13 Aug 2017 10:39:57 +0200 In-Reply-To: (Yegor Timoshenko's message of "Sat, 12 Aug 2017 14:45:34 +0000") Message-ID: <87a833uahu.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K0:HR9C0POSu0lVuVh2rNYLPucMGQNvvjJJBYdMKpFTsBTQrjnHNGq vU56Nl0AJ3wU30Wmdqs2baQHY5HrhBPDzEc0gOi/aUdwXupYLDpi/5Klb0UpFXlvOnnXna7 RPP/pEu97mFKcwAclcl7i4B4lfixSpRzN7qQc1XnXaN9+Ij9YwEUyqvZEl6V91DsLZ6aA02 k1piRZHgmLXL620PyNyOg== X-UI-Out-Filterresults: notjunk:1;V01:K0:MesaKJsQyDk=:xMl98B+fxLrlTcW9aaBXAH t4iqZ6kEj7fMWPE5Dwpnk7CYTNcOwPkj9Qh8Ckd4qSAafDeH7/cWsWR7l5N6PudgrAPyV+b/j g4O7QUaEW/LbDAO1Al3a2prxAKKlmcQHsFlR2ttT2z+9R6gAiUx4nYkzENC6hqNMdaCPmNL0d 8emWdSM67rEx3kJ4QZNR8VEsk8hnk5+1wGy+wXuex2c+Rplq8mEB/DxD1YWEDFE+w4waCmTF2 A2y3pkI6rqpT8Je/OHy6WUd2THvHdtfKPtw4tg5DJJCHhMXPgNKSIVtNSw2eCc78CFFAW6HQz TZTdGWa02wli01QZVyHtLrAnYGsigY6hUEY9u+Fv1wCNu2szFjjreJPeStN/orRtcuTI7yj4W ttwoLJBIndZKdDRXm3MDlG4zJuwzG2mq4dL3okJhO9JZMCvtokcS/iaH5Hw9abWRuhyT6S8Fs I2C8aDXVdIYyIhLYIxOjGQXtcwcvsAkBdwvCS5wsGnNrpLAapPhsHj5Te5XrCBy71XAziZnHB ocSphZduaEOxsR1kbyMZoyWLqoZ3s+fqgcGsjvx7USFmqe561gHXgK2U0tqwe/FiGtKr7WgBC zyddt9ic+3G9hXe6T6xLbRbtmngMSi44XT/2fa7av7K3fgVy2WdeuRiF32F1Cdn0qwS8LDHac B4zZCPAV0Q+aNz7EOXbklwC5c8ApQ3mhp2uoSoMYusaqpsmJPLNdm/fbP7v2cU9QrG3G204AA LBdjGJq6CFI/SdcARW+3QtZLV+wPKfRgAhTRjdDPkV5P29s5O8rxW7VE/H+ZVlQig/hMYAZ5E 4yz4CRTyY12xxQdTFJ9pgEvCGNSSAT3OMcIz+4+w8LOiBeRBNc= X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.0 (---) Yegor Timoshenko writes: Hi Yegor, > To reproduce, you'll need to add eshell-tramp module to configuration. > Add the following form to your Emacs configuration file: > > (eval-after-load 'esh-module > '(add-to-list 'eshell-modules-list 'eshell-tramp)) > > Then, M-x eshell. > $ which sudo > eshell/sudo is a compiled Lisp function in =E2=80=98em-tramp.el=E2=80=99 > $ sudo sleep 10 > > Now, if you try to leave interrupt `sleep` using C-c, it won't work. Unfortunately, it is not possible to send signals to the remote process Tramp is running on. This has been discussed already on the Tramp ML, with no result. See also the TODO list on the bottom of tramp-sh.el. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 13 21:51:15 2017 Received: (at 28066) by debbugs.gnu.org; 14 Aug 2017 01:51:15 +0000 Received: from localhost ([127.0.0.1]:33931 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh4XD-0004g7-GM for submit@debbugs.gnu.org; Sun, 13 Aug 2017 21:51:15 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dh4XB-0004g1-Mo for 28066@debbugs.gnu.org; Sun, 13 Aug 2017 21:51:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dh4X5-0004em-QJ for 28066@debbugs.gnu.org; Sun, 13 Aug 2017 21:51:08 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:47634) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dh4Wz-0004aV-JZ; Sun, 13 Aug 2017 21:51:01 -0400 Received: from rms by fencepost.gnu.org with local (Exim 4.82) (envelope-from ) id 1dh4Wz-00018Y-1w; Sun, 13 Aug 2017 21:51:01 -0400 Content-Type: text/plain; charset=Utf-8 From: Richard Stallman To: Michael Albinus In-reply-to: <87a833uahu.fsf@detlef> (message from Michael Albinus on Sun, 13 Aug 2017 10:39:57 +0200) Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> Message-Id: Date: Sun, 13 Aug 2017 21:51:01 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: rms@gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) [[[ To any NSA and FBI agents reading my email: please consider ]]] [[[ whether defending the US Constitution against all enemies, ]]] [[[ foreign or domestic, requires you to follow Snowden's example. ]]] > > Now, if you try to leave interrupt `sleep` using C-c, it won't work. > Unfortunately, it is not possible to send signals to the remote process > Tramp is running on. This has been discussed already on the Tramp ML, > with no result. Maybe eshell could detect this case and display a message to explain to the user why it doesn't work. -- Dr Richard Stallman President, Free Software Foundation (gnu.org, fsf.org) Internet Hall-of-Famer (internethalloffame.org) Skype: No way! See stallman.org/skype.html. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 15:29:44 2017 Received: (at 28066) by debbugs.gnu.org; 20 Aug 2017 19:29:44 +0000 Received: from localhost ([127.0.0.1]:46926 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djVup-0004pS-Rh for submit@debbugs.gnu.org; Sun, 20 Aug 2017 15:29:43 -0400 Received: from mout.gmx.net ([212.227.15.15]:59647) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djVuo-0004pC-Ad for 28066@debbugs.gnu.org; Sun, 20 Aug 2017 15:29:43 -0400 Received: from detlef.gmx.de ([213.220.149.52]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0MhiTL-1dwvvR34Hz-00MtWQ; Sun, 20 Aug 2017 21:29:34 +0200 From: Michael Albinus To: Richard Stallman Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> Date: Sun, 20 Aug 2017 21:29:33 +0200 In-Reply-To: (Richard Stallman's message of "Sun, 13 Aug 2017 21:51:01 -0400") Message-ID: <87378mavhe.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:OUYKvc5RPA8X4kD7q0T8IDpdUWs5rKOOOm5v5hEv3WaZqAdHX4a Kv7XgG8sVi78NZaoh7cHK+ZI1njH9wKMj39Yi++dNLn8vJAmatiUYoRAS0iRr8iOBL6jFzp 4PsJ7eiChrViYHVhZ4Qu4eEMALNy2tRqi/Sd1+FSpfJ7sJBb8U8o/p7QAWlc8x9Dk/qknSR 4DulTkCwBzFrNyY5vcq4g== X-UI-Out-Filterresults: notjunk:1;V01:K0:Ji8q3gLQfEM=:kR22oeWS8tXzv+83TAHUAR mLUzdDA1gZG1nIOYMVdvD0q8o9kjgVFIkGkPgT7ShP+j0C0m+tKboCJxdEhI23VC+hHSvhhcb Zh0yLXFHzrV9BDqA3VzbfLKNZr4g6tjA6PHemVIRC3Ny9sdCG36B0YACvAIZSIiZ6LNeUipqB KAmLNuSOlV0BSsy7houOKvOC+ymopRn0YTPR3LoQxGwfBXJw0FiHcwVy/j3J+E7E3Jykm5NaU WYySPJ1A+8ZufgWCvZexATj4Zno2HXNZz80gP8FkY6AWXXpwWIK1yf+554rUNJK+7HMqXEmy+ kHHsr+0u5LzXrnEafNTijC/2wJp0PrrhMTHmqw54s+JkqtRcLwOMBaBZX95Cg2RfeckhWgyfh 8TCpdHqY4x7wTmZdtRInjmP8lCwbaxHj4X1q5JYfDInu+9B/VlBgvqNYXxCheAtre6G1H3cyE NT79jLAcBO9veaSasSMSU2B7EPZXvNYVOYy1XcwbeyB8kQxYFsD+xlnui7MEGVohb32vB5Kv3 +7VxFOl0hXQt8USwTHOSqFV9gDpZW/0YUc9tOwJ95Dt3ZruANf5OlTZv9U1soKVeOE6zr7JnG kLB5NOIqNmn2reEHcJRcMefstMcENgzcs47bjyzM32yGFFdC5aXUQujbyFU6NBtk9Ocqk2K51 Xrh6/U0NY26gRt9+pUwDzCXd/99rkeS8R5BAyZGuMK8JDpsU73uSTOkHEtqUBX8Fo0rh3tP/x O+iCMUr/7rajx9UnB/lf8hUOVYRhtBpVeIiaPsqLEvdvLC58e4SYS6pMrqiZiRuEFAKW3NSIX KuuzfqkORfGcc+BV0zvmak3a+rsqWqXfQ1hBjFQdT0nVU6WMFA= X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Richard Stallman writes: > > > Now, if you try to leave interrupt `sleep` using C-c, it won't work. > > > Unfortunately, it is not possible to send signals to the remote process > > Tramp is running on. This has been discussed already on the Tramp ML, > > with no result. > > Maybe eshell could detect this case > and display a message to explain to the user why it doesn't work. Finally, I have implemented `interrupt-process' for remote processes. I've committed 296472f5c5 to the Emacs repository. Yegor, do you have a chance to test Emacs 26.1, whether this works for you? I've implemented this as advice on `interrupt-process', but this is discouraged for primitives. Maybe we should spend `interrupt-process' a hook where Tramp could enter? Or even a file name handler, based on default-directory of the related process-buffer? Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 15:38:20 2017 Received: (at 28066) by debbugs.gnu.org; 20 Aug 2017 19:38:20 +0000 Received: from localhost ([127.0.0.1]:46935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djW39-00052J-Tl for submit@debbugs.gnu.org; Sun, 20 Aug 2017 15:38:20 -0400 Received: from eggs.gnu.org ([208.118.235.92]:39901) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djW37-000525-Vn for 28066@debbugs.gnu.org; Sun, 20 Aug 2017 15:38:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djW32-0007n2-7G for 28066@debbugs.gnu.org; Sun, 20 Aug 2017 15:38:12 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43791) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djW2w-0007ku-Ll; Sun, 20 Aug 2017 15:38:06 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1djW2n-0000h3-6p; Sun, 20 Aug 2017 15:37:59 -0400 Date: Sun, 20 Aug 2017 22:37:31 +0300 Message-Id: <837exyc9ok.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-reply-to: <87378mavhe.fsf@detlef> (message from Michael Albinus on Sun, 20 Aug 2017 21:29:33 +0200) Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, rms@gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Albinus > Date: Sun, 20 Aug 2017 21:29:33 +0200 > Cc: 28066@debbugs.gnu.org, yegortimoshenko@gmail.com > > I've implemented this as advice on `interrupt-process', but this is > discouraged for primitives. Maybe we should spend `interrupt-process' a > hook where Tramp could enter? Or even a file name handler, based on > default-directory of the related process-buffer? In such cases, we usually provide a variable whose value is a function. The default value is a function that does whatever interrupt-process is doing now, and Tramp can replace it with its own function. Does this make sense in your case? From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 15:46:45 2017 Received: (at 28066) by debbugs.gnu.org; 20 Aug 2017 19:46:45 +0000 Received: from localhost ([127.0.0.1]:46939 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djWBI-0005Dw-U4 for submit@debbugs.gnu.org; Sun, 20 Aug 2017 15:46:45 -0400 Received: from mout.gmx.net ([212.227.17.21]:55985) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djWBG-0005Dk-Qp for 28066@debbugs.gnu.org; Sun, 20 Aug 2017 15:46:43 -0400 Received: from detlef.gmx.de ([213.220.149.52]) by mail.gmx.com (mrgmx103 [212.227.17.168]) with ESMTPSA (Nemesis) id 0MVNWU-1e4son43lm-00YfIw; Sun, 20 Aug 2017 21:46:36 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> <837exyc9ok.fsf@gnu.org> Date: Sun, 20 Aug 2017 21:46:33 +0200 In-Reply-To: <837exyc9ok.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2017 22:37:31 +0300") Message-ID: <87fucmowdi.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:cGa13DLThIe+Xu9DFL6HBbChmAQqupcvb4QQjJ9LV9lrIm/+Rnu LKBl2Jkq71ChQuSuhVGDhR2xWFs/UEc1O5aHiVrU0IS4KINzeJxe/p4bIx4DlLQ0IvyIDxp QkBaWPF5KcD8xow2JRdrhZ6YkwgqT2olEEyk+YVD29dEwplFfTAIXcDMMsNcRRKNJQQ6lB0 WUr9myzXS9gQtlZDgTWYw== X-UI-Out-Filterresults: notjunk:1;V01:K0:1EHp6i9XlCw=:CThcjCrucv4p/boOxv1fZ5 YJUfqdACkBFz+BzD270tEMDVFbcaJLake3tY7jrsbEjjW8vZcPdYO4cB8Gjits9bWZAqBHCcR yNRNVG+8tGT8CC+zcyv84EsMndkBfoqjIJqq01JCr2Kz6H1hA6fH3WJ5AYMoCdh6Yhu7KyrkC 2J4QWTWXk9OR+7Wld2E1nFN6T1OpHLDTDHCNYREB3VkZ3XWOCa5EL3yEKpf/zun17gY2jx1fv rBTvkCAeE6V4ph5WEhSB8HWD8PyCdDsEStFtMAp2caPXtRy8YzqhXq4QeSmydxl5ZPghoMbNI W3G6w0NFiYdBnydc7p1koMDYS3dEF8DY5gCJ/1aZUcmMWetApPqrz5EUQNSSthjA+qEl4Eq96 ZlptVo3NYZGJnD4VKaUMTzibZa/OZUdfd3Z+h0JB4eDg2OTCyGTAMk5ZdYH6veN2vrXuH16Va qr0xyFTamdPYRIk/jQbr/bhbFxXgdCsyCjbF65uHg6RIkVDt7tvgV/3JPTuumgs6DHoNp6/co Hu5xDG0Ue5xiiWil7ubEy6oqB/qqMi9NsaFQ7LZPdqS6fkMPDpQ59ZYnHgShPKQAI2XIajwPR j3dOH+xinW8+WH5P5ZszN1cpiNtFJXrMX0nMgqKnqU0t8rUQWIwv3B3507kTtDUMDyJN1dVMf 7rs1d5WQxiKBujgQBPLINe/kO114t3/5xrfDbOQ6bJK+qjTQ6Clk++fKsSpvFPPH6FZLf9DRT hl1Vsun53Q0uMP8sDEFe7b6LRpKp9t17TUXx/wXzeYA23VEcrbD67O71lb0TZop5SpBJ2/SV6 M5IZd5lxrTKCr7WRLSuTSIVt0+w+fveYa2yTt/P0py5VGX9XuY= X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, rms@gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: Michael Albinus >> Date: Sun, 20 Aug 2017 21:29:33 +0200 >> Cc: 28066@debbugs.gnu.org, yegortimoshenko@gmail.com >> >> I've implemented this as advice on `interrupt-process', but this is >> discouraged for primitives. Maybe we should spend `interrupt-process' a >> hook where Tramp could enter? Or even a file name handler, based on >> default-directory of the related process-buffer? > > In such cases, we usually provide a variable whose value is a > function. The default value is a function that does whatever > interrupt-process is doing now, and Tramp can replace it with its own > function. > > Does this make sense in your case? Perfect. As long as no other package replaces Tramp's function. Maybe the variable shall keep a list of functions, which are tried until one of the functions reports success (returns t, for example). The default function would be the last in the queue. Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 20 18:31:51 2017 Received: (at 28066) by debbugs.gnu.org; 20 Aug 2017 22:31:51 +0000 Received: from localhost ([127.0.0.1]:47048 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djYl5-000664-6y for submit@debbugs.gnu.org; Sun, 20 Aug 2017 18:31:51 -0400 Received: from mail-wr0-f182.google.com ([209.85.128.182]:32968) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djYl3-00065s-Gd for 28066@debbugs.gnu.org; Sun, 20 Aug 2017 18:31:49 -0400 Received: by mail-wr0-f182.google.com with SMTP id 30so11434786wrk.0 for <28066@debbugs.gnu.org>; Sun, 20 Aug 2017 15:31:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=n2RfAzQe9ZEyi/wAAPfBtrjxg+p5jugaLf5mr53R3CA=; b=HMStopnIjAQzBpS3YfGJ6jozUNH5DEBcCSCy7IfutPcVIE1MECNwE7Top1nEV1aIRd BbCeTFfvFxe9AOPqSsdlLj8sp3+D56R3EeapL5bd2um5+3bNUDPQ8icjM4APtnE0/8rN xq4vebF9cXdCPqjiqzx90ezF2wnhqeEHFCt5VPhUbizFY8sz9zzmP9FvimBHXlJi6DOv HWS4OdIMuMEbZSJHhHHgd3vCQerFC+QLvMCHGjOz2wgjlwuzF7hNuhPUeFC8t3SmzZLg nHVAHOyjfiFBBDfk52ReXGqNxNst8zEnePZxyWU0p1FYjTZylUVmzzMz+/bS8vHkuyRA k/Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=n2RfAzQe9ZEyi/wAAPfBtrjxg+p5jugaLf5mr53R3CA=; b=gy6blMquV1FXdB3uIbWJS2tlgJAxmk3bEopZbPHsp+8GAh7NtueJrao9h8cxbWApj+ dlXq1w4NFeKnFknOcT0AAgeoUJpEOIlb7AXODw88rBwaGhqZ1HGYJRvU1jw2AbTkt1Fq CUSNWFoQ2Yq6JBSWbuH5o0AtnLVzcNXW4ntfmpbEiFtL/GlfpTMK0DAqSw0SWb7bnMLG FSvG3Tc2IkBZy/MunjhWvEmrbPD5MO2ePVipdTRD586Xua4ExoczfHjlp6fTateEd+Ph 3l627SQLY+b7JhnO0UL6S9NYbyfWOAgtBPvqTW98iSZKnjI7Ftv/jUqexPfirIK3IbHl GbnA== X-Gm-Message-State: AHYfb5jBgurlcqn28iRfVUTYhSYV9nmO/JaMGNfj91BFg6FS4HLdFiNs +4waXYl1BI5QQYURbIIM+e/O6MCtww== X-Received: by 10.223.185.53 with SMTP id k50mr1739047wrf.44.1503268303680; Sun, 20 Aug 2017 15:31:43 -0700 (PDT) MIME-Version: 1.0 Received: by 10.28.146.84 with HTTP; Sun, 20 Aug 2017 15:31:43 -0700 (PDT) In-Reply-To: <87378mavhe.fsf@detlef> References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> From: Yegor Timoshenko Date: Sun, 20 Aug 2017 22:31:43 +0000 Message-ID: Subject: Re: bug#28066: eshell-tramp sudo ignores C-c To: Michael Albinus Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) > Finally, I have implemented `interrupt-process' for remote > processes. I've committed 296472f5c5 to the Emacs repository. Yegor, do > you have a chance to test Emacs 26.1, whether this works for you? I've built 296472f and it does work for me! Now I can interrupt eshell/sudo processes. Eshell is the only shell that I directly use, so that means a lot to me. Thank you very much, Michael! From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 03:30:07 2017 Received: (at 28066-done) by debbugs.gnu.org; 21 Aug 2017 07:30:08 +0000 Received: from localhost ([127.0.0.1]:47248 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djh9z-0001TM-MT for submit@debbugs.gnu.org; Mon, 21 Aug 2017 03:30:07 -0400 Received: from mout.gmx.net ([212.227.17.20]:63138) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djh9y-0001S4-9M for 28066-done@debbugs.gnu.org; Mon, 21 Aug 2017 03:30:06 -0400 Received: from detlef.gmx.de ([213.220.149.52]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LmeGF-1dA55h3RkB-00aG2k; Mon, 21 Aug 2017 09:29:58 +0200 From: Michael Albinus To: Yegor Timoshenko Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> Date: Mon, 21 Aug 2017 09:29:57 +0200 In-Reply-To: (Yegor Timoshenko's message of "Sun, 20 Aug 2017 22:31:43 +0000") Message-ID: <87bmn9pedm.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:RBlZvSD2Kj9ZuQ+WICBT6OclyaZNVpspxX9k7yPYAwdERwcmTiK 2vdbXmlkLbTYQoWd7jgdMhguyUAshgXAKAAI9YW8uzgFAqGj9laCGzPiTNYIYZ5GN1jSwB5 b7jwodBcQ6Ir6eu4aomGkOf+WuLk5Iqp3UEuaCpDh6PLAesThdN6nPnEphSFUP6m5Arz0Ir qoQrjGHSkxoO1qXvzT4OQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:tUtpYhXz8Vo=:PPuznSbOyHPGok198BgbTX ieadvWPdIHxfDtF5NUNt72lV1EkAVA/o/U6jBJ/UsQWIVE9yCsRhcTdXGpNL7xJocNDjJ9sye 5O2ITgkFEJ6AZTSfWKppUOIcRNt5F5XwcPmk5ActjPHD1+tNzbczqtXNEfDSfg2KKVnMYyUll uufowWO46D5sfspn5urNqUK4fyKHqzKcpfbfPWPTAeL5ymSZRh2QMQt0r7YuN138BHd3NsHUM ihFgogtwN1zKw5PBvPpxBORrMNK6ozZywzik5NxiXDjfJdHizpuYwrWVOHNbqTk7YwtFsClRU TdcdkJ0OWjECilrB6mYdjrXxrt0UIJCmWuRVMWFbRh7LRBtfkGyOVQ6EgmY+xftSGCykV7cwc qvntDsosEh6kxlRvg27tcUVC42LOgAM40LSy8kY0gDI5aETFIW5rknNU1KbESZN394au9OEyA qR8eE9SwQq+3aLdPrzhq0haqrsmY5WF5x4neGcMBGODkhQxK4Z8cwv5hfUNrbS0UxjJaHEXKI X3WJ7lhebq2c8LH0vXqIjuv6tYQRfrNAKonGfyMtxLdgrn+ttU82qENgZoOsHWsm+vYtEfK+3 kpduQKEuiumrvqfKtAJw7tqOvFZLfVIL8s8PhL9iNy886qq8T8JykZSG71DutSi88AuCwvXz4 FwRPow2HGKlc0CpgfcyVyroTjOoWKIV5axoeNFLLsrXOlVbI5Pjav2w8zrVWjP4txhA6uJCOr +LivgNAHVBqw0oQYhSQtWGry3c3poWaJkDff9mmN8mjcbklBPJS0wB2aAjaobexc98PWWcH+f brh6IzV3UEd96j1SJL1sKu1TMxdyL+kFl5kE52VCn4U2sCncWE= X-Spam-Score: -0.2 (/) X-Debbugs-Envelope-To: 28066-done Cc: 28066-done@debbugs.gnu.org, Richard Stallman X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Version: 26.1 Yegor Timoshenko writes: Hi Yegor, > I've built 296472f and it does work for me! Now I can interrupt > eshell/sudo processes. Eshell is the only shell that I directly use, > so that means a lot to me. Thanks for confirmation, I'm closing the bug. We'll might change implementation details, but this shouldn't hurt you. > Thank you very much, Michael! Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 07:36:18 2017 Received: (at 28066) by debbugs.gnu.org; 21 Aug 2017 11:36:18 +0000 Received: from localhost ([127.0.0.1]:47355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djl0E-0000Zm-9J for submit@debbugs.gnu.org; Mon, 21 Aug 2017 07:36:18 -0400 Received: from mout.gmx.net ([212.227.17.21]:51732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djl0C-0000Za-Kt for 28066@debbugs.gnu.org; Mon, 21 Aug 2017 07:36:17 -0400 Received: from detlef.gmx.de ([213.220.149.52]) by mail.gmx.com (mrgmx102 [212.227.17.168]) with ESMTPSA (Nemesis) id 0LtUHA-1dbsgW1DiG-010t09; Mon, 21 Aug 2017 13:36:08 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> <837exyc9ok.fsf@gnu.org> Date: Mon, 21 Aug 2017 13:36:06 +0200 In-Reply-To: <837exyc9ok.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 20 Aug 2017 22:37:31 +0300") Message-ID: <87y3qdnoex.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K0:d7JtkO/LnXLCT3QvSuuSmu3aT1rLwZpJ2IirS8Z/8cF7K10jR32 unHUZM1ib7OfPeZ9hQKnpfDmS8+663xHLACbLKNh9Z0AR/6gNoz/QIF+W9XgAclbFQYwplo biYkDWAW90leXP3M5DrjLa3rGpyj43bhBDgj2So8bA1Tn3x4kvJtNq5SalYjS6R4+NrhwLq nUn6t1qfWRxiMbKOv5QqA== X-UI-Out-Filterresults: notjunk:1;V01:K0:fiGVbOMD3CI=:Am4BFGOVC4G6E4MYk6Vxy8 HVdvBuVZ/BFcamUE6j7g93QuASx1VoOHLlRUr8NM+HGUuuOtuQBydFJzQ+8J1Guj5a0cQnC4e 7XtCKEYu/pGZd5g6XTs0nHQQB7nH3OR8GqU5WAZ1AtEZcqFGXuybG6VS3nDUpaVYig3xHJEgb 7nfNVCUCDU6XlZcLU99sLsPpw07+8y7xrZBErPdNXln2ac66WvI15Wuzw/wnox/Tt+zuN+t1e o32WpKZHjUYXWmjneKt/fe2IgwhFvJqXF+o7y34kXgs9w92LTae5kugQzBIwP7VjQ5xJ/eMjI NE0PXmmgATGycU4l6sHkqR3Fu0pBLnzGFJ7D542wUbU6A4bmRojUhtsI8yqWZV0UnXw4iolHi lqxpTcIcUlAd+aOIen4IJVFY0ePigIcHimxEirelPIuKgbqq+RLaWbiRHfundd4RJyL+VJ8Lz pCdjlQTguZUr1Rb+4rKy9AKAphST3yCCEh+sZDRBSoNYy+wrfQXSt6rjZ6pPniqlrRdrfuwAz A1SkiUubDaqzQ/XBufYhS6s8WtUK9geWtGpc2HfgO/bgp7XjO1t7sl3Ciw6GbZ15M8fpYbXbD PZk3+ERXu8AJ+TYVU56j6sylVfNkqGIVek804HujFoVUToI7MOl6Hhu7Qn4B51ZYg0n53hNe3 V8nOEqgJSIgMcMHr+tCU2Ft9HH28/j4YUgpeLBk2GV4wmXp1i8oeHSzKMD950j8T7gsKMI10v /aLgrwAiTklPXJq3UIQ6unSdAKyt5bGZ2Q11XyN3RllrX5cNRCgRq0KmEzM2WOePeF16Xtoyc Ji2Yqu80WGYMTjUuC0zedUVgyC+Sw== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, rms@gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Eli Zaretskii writes: Hi Eli, > In such cases, we usually provide a variable whose value is a > function. The default value is a function that does whatever > interrupt-process is doing now, and Tramp can replace it with its own > function. > > Does this make sense in your case? What about the appended patch? Best regards, Michael. --=-=-= Content-Type: text/plain Content-Disposition: attachment diff --git a/src/process.c b/src/process.c index 1900951533..e7ee99ab3d 100644 --- a/src/process.c +++ b/src/process.c @@ -6677,6 +6677,18 @@ process_send_signal (Lisp_Object process, int signo, Lisp_Object current_group, unblock_child_signal (&oldset); } +DEFUN ("internal-default-interrupt-process", + Finternal_default_interrupt_process, + Sinternal_default_interrupt_process, 0, 2, 0, + doc: /* Default function to interrupt process PROCESS. +It shall be the last element in list `interrupt-process-functions'. +See function `interrupt-process' for more details on usage. */) + (Lisp_Object process, Lisp_Object current_group) +{ + process_send_signal (process, SIGINT, current_group, 0); + return process; +} + DEFUN ("interrupt-process", Finterrupt_process, Sinterrupt_process, 0, 2, 0, doc: /* Interrupt process PROCESS. PROCESS may be a process, a buffer, or the name of a process or buffer. @@ -6688,11 +6700,14 @@ If the process is a shell, this means interrupt current subjob rather than the shell. If CURRENT-GROUP is `lambda', and if the shell owns the terminal, -don't send the signal. */) +don't send the signal. + +This function calls the functions of `interrupt-process-functions' in +the order of the list, until one of them returns non-`nil'. */) (Lisp_Object process, Lisp_Object current_group) { - process_send_signal (process, SIGINT, current_group, 0); - return process; + return CALLN (Frun_hook_with_args_until_success, Qinterrupt_process_functions, + process, current_group); } DEFUN ("kill-process", Fkill_process, Skill_process, 0, 2, 0, @@ -8176,6 +8191,17 @@ non-nil value means that the delay is not reset on write. The variable takes effect when `start-process' is called. */); Vprocess_adaptive_read_buffering = Qt; + DEFVAR_LISP ("interrupt-process-functions", Vinterrupt_process_functions, + doc: /* List of functions to be called for `interrupt-function'. +The arguments of the functions are the same as for `interrupt-function'. +These functions are called in the order of the list, until one of them +returns non-`nil'. */); + Vinterrupt_process_functions = list1 (Qinternal_default_interrupt_process); + + DEFSYM (Qinternal_default_interrupt_process, + "internal-default-interrupt-process"); + DEFSYM (Qinterrupt_process_functions, "interrupt-process-functions"); + defsubr (&Sprocessp); defsubr (&Sget_process); defsubr (&Sdelete_process); @@ -8218,6 +8244,7 @@ The variable takes effect when `start-process' is called. */); defsubr (&Saccept_process_output); defsubr (&Sprocess_send_region); defsubr (&Sprocess_send_string); + defsubr (&Sinternal_default_interrupt_process); defsubr (&Sinterrupt_process); defsubr (&Skill_process); defsubr (&Squit_process); --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 10:35:33 2017 Received: (at 28066) by debbugs.gnu.org; 21 Aug 2017 14:35:33 +0000 Received: from localhost ([127.0.0.1]:47933 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djnnh-0008Nm-43 for submit@debbugs.gnu.org; Mon, 21 Aug 2017 10:35:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djnnf-0008Na-CJ for 28066@debbugs.gnu.org; Mon, 21 Aug 2017 10:35:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1djnnZ-0001hv-Jt for 28066@debbugs.gnu.org; Mon, 21 Aug 2017 10:35:26 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56975) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1djnnT-0001VA-0s; Mon, 21 Aug 2017 10:35:19 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1502 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1djnnJ-0000le-U2; Mon, 21 Aug 2017 10:35:12 -0400 Date: Mon, 21 Aug 2017 17:34:44 +0300 Message-Id: <83tw11at17.fsf@gnu.org> From: Eli Zaretskii To: Michael Albinus In-reply-to: <87y3qdnoex.fsf@detlef> (message from Michael Albinus on Mon, 21 Aug 2017 13:36:06 +0200) Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> <837exyc9ok.fsf@gnu.org> <87y3qdnoex.fsf@detlef> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, rms@gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Michael Albinus > Cc: rms@gnu.org, 28066@debbugs.gnu.org, yegortimoshenko@gmail.com > Date: Mon, 21 Aug 2017 13:36:06 +0200 > > > In such cases, we usually provide a variable whose value is a > > function. The default value is a function that does whatever > > interrupt-process is doing now, and Tramp can replace it with its own > > function. > > > > Does this make sense in your case? > > What about the appended patch? LGTM, but did you consider to define the variable in Lisp? From debbugs-submit-bounces@debbugs.gnu.org Mon Aug 21 11:01:47 2017 Received: (at 28066) by debbugs.gnu.org; 21 Aug 2017 15:01:47 +0000 Received: from localhost ([127.0.0.1]:47959 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djoD3-0000Za-QW for submit@debbugs.gnu.org; Mon, 21 Aug 2017 11:01:47 -0400 Received: from mout.gmx.net ([212.227.15.15]:52203) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1djoD1-0000ZL-M8 for 28066@debbugs.gnu.org; Mon, 21 Aug 2017 11:01:44 -0400 Received: from detlef.gmx.de ([213.220.149.52]) by mail.gmx.com (mrgmx003 [212.227.17.190]) with ESMTPSA (Nemesis) id 0LoVOE-1d3Jif2yiI-00gUmp; Mon, 21 Aug 2017 17:01:35 +0200 From: Michael Albinus To: Eli Zaretskii Subject: Re: bug#28066: eshell-tramp sudo ignores C-c References: <87a833uahu.fsf@detlef> <87378mavhe.fsf@detlef> <837exyc9ok.fsf@gnu.org> <87y3qdnoex.fsf@detlef> <83tw11at17.fsf@gnu.org> Date: Mon, 21 Aug 2017 17:01:34 +0200 In-Reply-To: <83tw11at17.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 21 Aug 2017 17:34:44 +0300") Message-ID: <87a82t9d81.fsf@detlef> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K0:eoHUFx1ot3VVpJPA438+yFB56J4QJPH8T7IfOTxCAjMOcFUSOSU NYR1WjvP4IOApVvenoSKEWs6n7Gm4GiCntbn3wpTjyQjeYHU7VCJppgkhP0VuoVOpwqh103 hTiab9FUVCOvIictXoP5uEKiDQdcqnb/zu9GXbK42b1Nkf7sEkYgcG+DzFAqJs32lEA/te7 RQuWXnTL5N+aKbdZOuqbg== X-UI-Out-Filterresults: notjunk:1;V01:K0:qoNH13swVW8=:PPjX/sSfAtnkaXEXW3+at5 5hPbhmZnJntSSZoVQz8PIFBE9JweBaD0bM9V2/Ts3uqr+AUdANE5IeWwN8h3+Ap7O487wCZDF M29tUt1R7xv2iuv/qtbIm4qO1RTQyQnFuK5OlIzMasawS8FWxcXrwTTORbY6CUPRJrj3nhaWw xbk08MoHX3Y0PJSMUcWgOuqDj6XmXrXtDBOjaFx6hLyfqomif7hgTo4qgbR6Z8lK1wMxdBOJR kutdk6FXram5sVnXXpnAphYsRXugZhRUxoeZ8KqZnWl9uarbTLbEmWMwtNHuhrBhEDONbyTH+ QucfeUT/nnVHss8Ezz93W3+pXNh2vLqbnxxanZJBNNjDy0XZOs7tPZF4I+W7Hhkf5K4I9Hg67 IOOk+1lApQH/UKR5Dh7DPuV+LGIXouYPWvnehninzMc+I6r3TR61VHDpuokFAaqMEdofn02As 88u6HS8mfY3Ogl2uSPwrmhILvswbd7lEFS+lLzmNe3fxHBQEWWeTxtOjSEaRYset8zn8ROFXI 8Yf90Onucupk8ZFsN7B1rRAAkgWnHBp/y14U64I37cYdQPHYqSQTTGV4TOlpFc5hk2aonZN7m 8BEvkF4Of7L/K5aWL5A5XvrGyRXRctsQ7uppMrb5VzirCi8shEyHDQqrV+9AOE4r3pk3Xv3Tv mM/fYLjbD0odcvJ0bvaPib8EzhA7ZmiVDvoEQJWsidf4u4UX7G/nxNVpbUlqQ1vDXa55nvfNH FFrrwE3Vfn7Gp/qvlf7o7DiTnWuwc3Tr69gzVxObaH5O5FgW9S9t/jgL7h5s3k7GblsUdqSFU 7zixGagzbJfb2Jq7NjWQj44DO8RS51dGmo1yjgcX9HIGdZdfmo= X-Spam-Score: 0.8 (/) X-Debbugs-Envelope-To: 28066 Cc: 28066@debbugs.gnu.org, rms@gnu.org, yegortimoshenko@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.2 (/) Eli Zaretskii writes: >> From: Michael Albinus >> Cc: rms@gnu.org, 28066@debbugs.gnu.org, yegortimoshenko@gmail.com >> Date: Mon, 21 Aug 2017 13:36:06 +0200 >> >> > In such cases, we usually provide a variable whose value is a >> > function. The default value is a function that does whatever >> > interrupt-process is doing now, and Tramp can replace it with its own >> > function. >> > >> > Does this make sense in your case? >> >> What about the appended patch? > > LGTM, but did you consider to define the variable in Lisp? Sure, Vinterrupt_process_functions is declared with DEFVAR_LISP, see the end of the patch. And it works, I've tested already my changed Tramp implementation :-) Anyway, I'll commit it to the master. People could raise their concerns then, if any. Updating the documentation will be the next step afterwards. Best regards, Michael. From unknown Fri Jun 20 07:19:25 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 19 Sep 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator