GNU bug report logs - #28066
eshell-tramp sudo ignores C-c

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 28066 in the body.
You can then email your comments to 28066 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Yegor Timoshenko <yegortimoshenko <at> gmail.com>
To: "bug-gnu-emacs <at> gnu.org" <bug-gnu-emacs <at> gnu.org>
Subject: eshell-tramp sudo ignores C-c
Date: Sat, 12 Aug 2017 14:45:34 +0000

[Message part 1 (text/plain, inline)]

GNU Emacs 25.2.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.22.16)
 of 2017-08-09

To reproduce, you'll need to add eshell-tramp module to configuration. Add
the following form to your Emacs configuration file:

(eval-after-load 'esh-module
  '(add-to-list 'eshell-modules-list 'eshell-tramp))

Then, M-x eshell.
$ which sudo
eshell/sudo is a compiled Lisp function in ‘em-tramp.el’
$ sudo sleep 10

Now, if you try to leave interrupt `sleep` using C-c, it won't work.

[Message part 2 (text/html, inline)]

Message #8 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Yegor Timoshenko <yegortimoshenko <at> gmail.com>
Cc: 28066 <at> debbugs.gnu.org
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Sun, 13 Aug 2017 10:39:57 +0200

Yegor Timoshenko <yegortimoshenko <at> gmail.com> writes:

Hi Yegor,

> To reproduce, you'll need to add eshell-tramp module to configuration.
> Add the following form to your Emacs configuration file:
>
> (eval-after-load 'esh-module
>   '(add-to-list 'eshell-modules-list 'eshell-tramp))
>
> Then, M-x eshell.
> $ which sudo
> eshell/sudo is a compiled Lisp function in ‘em-tramp.el’
> $ sudo sleep 10
>
> Now, if you try to leave interrupt `sleep` using C-c, it won't work.

Unfortunately, it is not possible to send signals to the remote process
Tramp is running on. This has been discussed already on the Tramp ML,
with no result.

See also the TODO list on the bottom of tramp-sh.el.

Best regards, Michael.

Message #11 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 28066 <at> debbugs.gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Sun, 13 Aug 2017 21:51:01 -0400

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > > Now, if you try to leave interrupt `sleep` using C-c, it won't work.

  > Unfortunately, it is not possible to send signals to the remote process
  > Tramp is running on. This has been discussed already on the Tramp ML,
  > with no result.

Maybe eshell could detect this case
and display a message to explain to the user why it doesn't work.

-- 
Dr Richard Stallman
President, Free Software Foundation (gnu.org, fsf.org)
Internet Hall-of-Famer (internethalloffame.org)
Skype: No way! See stallman.org/skype.html.

Message #14 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Richard Stallman <rms <at> gnu.org>
Cc: 28066 <at> debbugs.gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Sun, 20 Aug 2017 21:29:33 +0200

Richard Stallman <rms <at> gnu.org> writes:

>   > > Now, if you try to leave interrupt `sleep` using C-c, it won't work.
>
>   > Unfortunately, it is not possible to send signals to the remote process
>   > Tramp is running on. This has been discussed already on the Tramp ML,
>   > with no result.
>
> Maybe eshell could detect this case
> and display a message to explain to the user why it doesn't work.

Finally, I have implemented `interrupt-process' for remote
processes. I've committed 296472f5c5 to the Emacs repository. Yegor, do
you have a chance to test Emacs 26.1, whether this works for you?

I've implemented this as advice on `interrupt-process', but this is
discouraged for primitives. Maybe we should spend `interrupt-process' a
hook where Tramp could enter? Or even a file name handler, based on
default-directory of the related process-buffer?

Best regards, Michael.

Message #17 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 28066 <at> debbugs.gnu.org, rms <at> gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Sun, 20 Aug 2017 22:37:31 +0300

> From: Michael Albinus <michael.albinus <at> gmx.de>
> Date: Sun, 20 Aug 2017 21:29:33 +0200
> Cc: 28066 <at> debbugs.gnu.org, yegortimoshenko <at> gmail.com
> 
> I've implemented this as advice on `interrupt-process', but this is
> discouraged for primitives. Maybe we should spend `interrupt-process' a
> hook where Tramp could enter? Or even a file name handler, based on
> default-directory of the related process-buffer?

In such cases, we usually provide a variable whose value is a
function.  The default value is a function that does whatever
interrupt-process is doing now, and Tramp can replace it with its own
function.

Does this make sense in your case?

Message #20 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28066 <at> debbugs.gnu.org, rms <at> gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Sun, 20 Aug 2017 21:46:33 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Michael Albinus <michael.albinus <at> gmx.de>
>> Date: Sun, 20 Aug 2017 21:29:33 +0200
>> Cc: 28066 <at> debbugs.gnu.org, yegortimoshenko <at> gmail.com
>> 
>> I've implemented this as advice on `interrupt-process', but this is
>> discouraged for primitives. Maybe we should spend `interrupt-process' a
>> hook where Tramp could enter? Or even a file name handler, based on
>> default-directory of the related process-buffer?
>
> In such cases, we usually provide a variable whose value is a
> function.  The default value is a function that does whatever
> interrupt-process is doing now, and Tramp can replace it with its own
> function.
>
> Does this make sense in your case?

Perfect. As long as no other package replaces Tramp's function.

Maybe the variable shall keep a list of functions, which are tried until
one of the functions reports success (returns t, for example). The
default function would be the last in the queue.

Best regards, Michael.

Message #23 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Yegor Timoshenko <yegortimoshenko <at> gmail.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 28066 <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Sun, 20 Aug 2017 22:31:43 +0000

> Finally, I have implemented `interrupt-process' for remote
> processes. I've committed 296472f5c5 to the Emacs repository. Yegor, do
> you have a chance to test Emacs 26.1, whether this works for you?

I've built 296472f and it does work for me! Now I can interrupt
eshell/sudo processes. Eshell is the only shell that I directly use,
so that means a lot to me.

Thank you very much, Michael!

Message #28 received at 28066-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Yegor Timoshenko <yegortimoshenko <at> gmail.com>
Cc: 28066-done <at> debbugs.gnu.org, Richard Stallman <rms <at> gnu.org>
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Mon, 21 Aug 2017 09:29:57 +0200

Version: 26.1

Yegor Timoshenko <yegortimoshenko <at> gmail.com> writes:

Hi Yegor,

> I've built 296472f and it does work for me! Now I can interrupt
> eshell/sudo processes. Eshell is the only shell that I directly use,
> so that means a lot to me.

Thanks for confirmation, I'm closing the bug. We'll might change
implementation details, but this shouldn't hurt you.

> Thank you very much, Michael!

Best regards, Michael.

Message #31 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28066 <at> debbugs.gnu.org, rms <at> gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Mon, 21 Aug 2017 13:36:06 +0200

[Message part 1 (text/plain, inline)]

Eli Zaretskii <eliz <at> gnu.org> writes:

Hi Eli,

> In such cases, we usually provide a variable whose value is a
> function.  The default value is a function that does whatever
> interrupt-process is doing now, and Tramp can replace it with its own
> function.
>
> Does this make sense in your case?

What about the appended patch?

Best regards, Michael.

[Message part 2 (text/plain, attachment)]

Message #34 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: 28066 <at> debbugs.gnu.org, rms <at> gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Mon, 21 Aug 2017 17:34:44 +0300

> From: Michael Albinus <michael.albinus <at> gmx.de>
> Cc: rms <at> gnu.org,  28066 <at> debbugs.gnu.org,  yegortimoshenko <at> gmail.com
> Date: Mon, 21 Aug 2017 13:36:06 +0200
> 
> > In such cases, we usually provide a variable whose value is a
> > function.  The default value is a function that does whatever
> > interrupt-process is doing now, and Tramp can replace it with its own
> > function.
> >
> > Does this make sense in your case?
> 
> What about the appended patch?

LGTM, but did you consider to define the variable in Lisp?

Message #37 received at 28066 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 28066 <at> debbugs.gnu.org, rms <at> gnu.org, yegortimoshenko <at> gmail.com
Subject: Re: bug#28066: eshell-tramp sudo ignores C-c
Date: Mon, 21 Aug 2017 17:01:34 +0200

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Michael Albinus <michael.albinus <at> gmx.de>
>> Cc: rms <at> gnu.org,  28066 <at> debbugs.gnu.org,  yegortimoshenko <at> gmail.com
>> Date: Mon, 21 Aug 2017 13:36:06 +0200
>> 
>> > In such cases, we usually provide a variable whose value is a
>> > function.  The default value is a function that does whatever
>> > interrupt-process is doing now, and Tramp can replace it with its own
>> > function.
>> >
>> > Does this make sense in your case?
>> 
>> What about the appended patch?
>
> LGTM, but did you consider to define the variable in Lisp?

Sure, Vinterrupt_process_functions is declared with DEFVAR_LISP, see the
end of the patch. And it works, I've tested already my changed Tramp
implementation :-)

Anyway, I'll commit it to the master. People could raise their concerns
then, if any. Updating the documentation will be the next step afterwards.

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.