GNU bug report logs - #28033
[PATCH] Add new face 'header-line-highlight'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Alex <agrambot <at> gmail.com>
Subject: bug#28033: closed (Re: bug#28033: [PATCH] Add new face
 'header-line-highlight')
Date: Sat, 12 Aug 2017 07:21:02 +0000

[Message part 1 (text/plain, inline)]

Your bug report

#28033: [PATCH] Add new face 'header-line-highlight'

which was filed against the emacs package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 28033 <at> debbugs.gnu.org.

-- 
28033: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28033
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Alex <agrambot <at> gmail.com>
Cc: 28033-done <at> debbugs.gnu.org
Subject: Re: bug#28033: [PATCH] Add new face 'header-line-highlight'
Date: Sat, 12 Aug 2017 10:20:03 +0300

> From: Alex <agrambot <at> gmail.com>
> Cc: 28033 <at> debbugs.gnu.org
> Date: Fri, 11 Aug 2017 16:10:02 -0600
> 
> > Thanks, this makes sense.  But please add some of this rationale to
> > the documentation.
> 
> I'm not sure exactly what you're looking for, but I added a brief
> explanation to the doc.

That's what I was looking for (although I made minor wording changes
in the actual commit).

> > Also, it is preferable to have the first line of a NEWS item be a full
> > sentence, if possible.  In this case, I would just say
> >
> >   ** New face 'header-line-highlight'.
> >
> > and then follow that by the details.
> 
> Sure. It seems that a lot of nearby entries don't follow that style,
> though...

Yes, something to work on.  Patches welcome.

I've pushed the changes.  A couple of minor comments for the future:

 . Please mention the bug number in the log message.
 . The order of the references to various parts of the changes in the
   log message should assume the reading order of top to bottom, so
   the log message might need some minor reordering.  In this case,
   your original order:

> * doc/emacs/display.texi (Standard Faces):
> * etc/NEWS: Document the face.
> * lisp/emacs-lisp/tabulated-list.el (tabulated-list-init-header):
> * lisp/info.el (Info-fontify-node): Use the face.
> * lisp/faces.el: Define the face.

   refers to "the face" before it was defined.  I've reordered it to
   put the reference to the lisp/faces.el change before all the rest.

Thanks again for working on this.

[Message part 3 (message/rfc822, inline)]

From: Alex <agrambot <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Add new face 'header-line-highlight'
Date: Wed, 09 Aug 2017 17:29:19 -0600

[Message part 4 (text/plain, inline)]

Some header-line configurations don't interact nicely with the
'highlight' face, particularly when they use the :box attribute.

[0001-Add-new-face-header-line-highlight.patch (text/x-diff, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.