GNU bug report logs - #28021
[PATCH] gnu: Fix memcached service startup.

Previous Next

Full log

Message #10 received at 28021-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 28021-done <at> debbugs.gnu.org
Subject: Re: [bug#28021] [PATCH] gnu: Fix memcached service startup.
Date: Tue, 15 Aug 2017 22:26:10 +0100

[Message part 1 (text/plain, inline)]

On Tue,  8 Aug 2017 21:48:39 +0100
Christopher Baines <mail <at> cbaines.net> wrote:

> Memcached changes to the memcached user from root before writing the
> PID file. This means that it must be able to write the PID file as
> the memcached user.
> 
> To make this work, create the /var/run/memcached directory when the
> service starts, make it owned by memcached, and change memcached to
> write the PID file to /var/run/memcached/pid.
> 
> This wasn't picked up by the system test as the "service running"
> part was too permissive, and only failed on an error. Instead, test
> the response from calling start-service and check that the PID is a
> number.
> 
> * gnu/services/databases.scm (memcached-activation): New variable.
>   (memcached-shepherd-service): Change PID file location.
>   (memcached-service-type): Extend the activation-service-type.
> * gnu/tests/databases.scm (run-memcached-test)[test]: Change the
> "service running" test to check the response from the shepherd.

This was reviewed by lfam and rekado on IRC, and I've now pushed :)

[Message part 2 (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.