GNU bug report logs - #28017
[PATCH] Reproducible issue for skalibs

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28017: closed ([PATCH] Reproducible issue for skalibs)
Date: Tue, 22 Aug 2017 13:00:02 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 22 Aug 2017 14:59:18 +0200
with message-id <87valf69nd.fsf <at> gnu.org>
and subject line Re: [bug#28017] [PATCH] Reproducible issue for skalibs
has caused the debbugs.gnu.org bug report #28017,
regarding [PATCH] Reproducible issue for skalibs
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28017: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28017
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: "Z. Ren" <zren <at> dlut.edu.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] Reproducible issue for skalibs
Date: Tue, 8 Aug 2017 15:33:34 +0800 (GMT+08:00)

[Message part 3 (text/plain, inline)]

Hi!
While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package skalibs could not be built reproducibly.

After investigation, we observe that the unreproducibility is caused by "Makefile", in which the order of ALL_SRCS is not sorted. Consequently, the file order of the library files "lib/{libskarnet.so.2.3.10.0, skalibs/libskarnet.a}" may not be deterministic.

The attached patch sorts the ALL_SRCS list, so that the file order in the libraries is deterministic. Once applied, skalibs could be built reproducibly.

 [1]: https://wiki.debian.org/ReproducibleBuilds

[0001-reproducible-fix-for-skalibs.patch (application/octet-stream, attachment)]

[Message part 5 (message/rfc822, inline)]

From: ludo <at> gnu.org (Ludovic Courtès)
To: "Z. Ren" <zren <at> dlut.edu.cn>
Cc: 28017-done <at> debbugs.gnu.org
Subject: Re: [bug#28017] [PATCH] Reproducible issue for skalibs
Date: Tue, 22 Aug 2017 14:59:18 +0200

Hello,

"Z. Ren" <zren <at> dlut.edu.cn> skribis:

> While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package skalibs could not be built reproducibly.
>
> After investigation, we observe that the unreproducibility is caused by "Makefile", in which the order of ALL_SRCS is not sorted. Consequently, the file order of the library files "lib/{libskarnet.so.2.3.10.0, skalibs/libskarnet.a}" may not be deterministic.

Indeed.  Pushed with slight reindentation and a commit message that
follows our conventions.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.