Subject: bug#28017: closed (Re: [bug#28017] [PATCH] Reproducible issue for skalibs)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 22 Aug 2017 13:00:02 +0000

Your bug report

#28017: [PATCH] Reproducible issue for skalibs

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
28017: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28017
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#28017] [PATCH] Reproducible issue for skalibs
From: [email-masked] (Ludovic Courtès)
To: "Z. Ren" <[email-masked]>
Cc: [email-masked]
Date: Tue, 22 Aug 2017 14:59:18 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Hello,

"Z. Ren" <[email-masked]> skribis:

> While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package skalibs could not be built reproducibly.
>
> After investigation, we observe that the unreproducibility is caused by "Makefile", in which the order of ALL_SRCS is not sorted. Consequently, the file order of the library files "lib/{libskarnet.so.2.3.10.0, skalibs/libskarnet.a}" may not be deterministic.

Indeed.  Pushed with slight reindentation and a commit message that
follows our conventions.

Thank you!

Ludo’.

Subject: [PATCH] Reproducible issue for skalibs
From: "Z. Ren" <[email-masked]>
To: [email-masked]
Date: Tue, 8 Aug 2017 15:33:34 +0800 (GMT+08:00)
List-Id: <debbugs-submit.debbugs.gnu.org>

Hi!
While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package skalibs could not be built reproducibly.

After investigation, we observe that the unreproducibility is caused by "Makefile", in which the order of ALL_SRCS is not sorted. Consequently, the file order of the library files "lib/{libskarnet.so.2.3.10.0, skalibs/libskarnet.a}" may not be deterministic.

The attached patch sorts the ALL_SRCS list, so that the file order in the libraries is deterministic. Once applied, skalibs could be built reproducibly.

 [1]: https://wiki.debian.org/ReproducibleBuilds