From unknown Mon Aug 18 09:03:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28016] [PATCH] Reproducible issue for libjpeg-turbo Resent-From: "Z. Ren" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 08 Aug 2017 15:30:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28016 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28016@debbugs.gnu.org X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150220619532051 (code B ref -1); Tue, 08 Aug 2017 15:30:04 +0000 Received: (at submit) by debbugs.gnu.org; 8 Aug 2017 15:29:55 +0000 Received: from localhost ([127.0.0.1]:52142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1df6SA-0008Kn-Md for submit@debbugs.gnu.org; Tue, 08 Aug 2017 11:29:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dez0e-0003To-LA for submit@debbugs.gnu.org; Tue, 08 Aug 2017 03:33:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dez0Y-0006mx-EZ for submit@debbugs.gnu.org; Tue, 08 Aug 2017 03:32:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54296) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dez0Y-0006ms-Bo for submit@debbugs.gnu.org; Tue, 08 Aug 2017 03:32:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dez0X-0002bl-0g for guix-patches@gnu.org; Tue, 08 Aug 2017 03:32:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dez0S-0006lc-1H for guix-patches@gnu.org; Tue, 08 Aug 2017 03:32:53 -0400 Received: from mx2.dlut.edu.cn ([202.118.66.81]:51762 helo=dlut.edu.cn) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dez0R-0006lK-Ce for guix-patches@gnu.org; Tue, 08 Aug 2017 03:32:47 -0400 Received: by ajax-webmail-mx2 (Coremail) ; Tue, 8 Aug 2017 15:32:45 +0800 (GMT+08:00) X-Originating-IP: [210.30.107.182] Date: Tue, 8 Aug 2017 15:32:45 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Z. Ren" X-Priority: 3 X-Mailer: Coremail Webmail Server Version 5.0.4 dev build 20151203(78088.8298) Copyright (c) 2002-2017 www.mailtech.cn dlut X-SendMailWithSms: false Content-Type: multipart/mixed; boundary="----=_Part_313551_1424283932.1502177565090" MIME-Version: 1.0 Message-ID: <2b044d63.16150.15dc0c299a2.Coremail.zren@dlut.edu.cn> X-Coremail-Locale: en_US X-CM-TRANSID: UUJ2ygDHqM0daYlZpKKAAA--.5307W X-CM-SenderInfo: h2uh0qhgox3hxhgxhubq/1tbiAgAGAlPExfY8AAADsd X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Mailman-Approved-At: Tue, 08 Aug 2017 11:29:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) ------=_Part_313551_1424283932.1502177565090 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi! While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package libjpeg-turbo could not be built reproducibly. After investigation, we observe that the unreproducibility is caused by the "configure" script, in which the output of `date` is captured. The attached patch substitutes the `date` according to the SOUR_DATE_EPOCH. Once applied, libjpeg-turbo could be built deterministically. [1]: https://wiki.debian.org/ReproducibleBuilds ------=_Part_313551_1424283932.1502177565090 Content-Type: application/octet-stream; name="0001-reproducible-fix-for-libjpeg-turbo.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-reproducible-fix-for-libjpeg-turbo.patch" RnJvbSAxN2EzM2Y2MTk5ZDQ3Y2RlMWJkMmY3Njg0OTg5OWZlNWQzOWY3NjNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBaLiBSZW4gPHpyZW5AZGx1dC5lZHUuY24+CkRhdGU6IFR1ZSwg OCBBdWcgMjAxNyAxNDowNToyNSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHJlcHJvZHVjaWJsZSBm aXggZm9yIGxpYmpwZWctdHVyYm8KCi0tLQogZ251L3BhY2thZ2VzL2ltYWdlLnNjbSB8IDE2ICsr KysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2ltYWdlLnNjbSBiL2dudS9wYWNrYWdl cy9pbWFnZS5zY20KaW5kZXggNjNlM2ZhNTA0Li44NTRhODVhZTIgMTAwNjQ0Ci0tLSBhL2dudS9w YWNrYWdlcy9pbWFnZS5zY20KKysrIGIvZ251L3BhY2thZ2VzL2ltYWdlLnNjbQpAQCAtMTEyMiw3 ICsxMTIyLDIxIEBAIFBORywgYW5kIHBlcmZvcm1zIFBORyBpbnRlZ3JpdHkgY2hlY2tzIGFuZCBj b3JyZWN0aW9ucy4iKQogICAgIChuYXRpdmUtaW5wdXRzCiAgICAgIGAoKCJuYXNtIiAsbmFzbSkp KQogICAgIChhcmd1bWVudHMKLSAgICAgJygjOnRlc3QtdGFyZ2V0ICJ0ZXN0IikpCisgICAgICco Izp0ZXN0LXRhcmdldCAidGVzdCIKKyAgICAgICAjOm1vZHVsZXMgKChzcmZpIHNyZmktMTkpCisg ICAgICAgICAgICAgICAgICAoZ3VpeCBidWlsZCB1dGlscykKKyAgICAgICAgICAgICAgICAgIChn dWl4IGJ1aWxkIGdudS1idWlsZC1zeXN0ZW0pKQorICAgICAgICM6cGhhc2VzCisgICAgICAgKG1v ZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAoYWRkLWJlZm9yZSAnY29uZmln dXJlICdyZXByb2R1Y2libGUKKyAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgIChsZXQgKChz b3VyY2UtZGF0ZS1lcG9jaAorICAgICAgICAgICAodGltZS11dGMtPmRhdGUKKyAgICAgICAgICAg IChtYWtlLXRpbWUgdGltZS11dGMgMCAoc3RyaW5nLT5udW1iZXIKKyAgICAgICAgICAgICAoZ2V0 ZW52ICJTT1VSQ0VfREFURV9FUE9DSCIpKSkpKSkKKyAgICAgICAgICAgICAgKHN1YnN0aXR1dGUq ICJjb25maWd1cmUiCisgICAgICAgICAgICAgICAoKCJgZGF0ZSAuKmAiKSAoZGF0ZS0+c3RyaW5n IHNvdXJjZS1kYXRlLWVwb2NoICIne35Zfm1+ZH0nIikpCisgICAgICAgICAgICAgICkpKSkpKSkK ICAgICAoaG9tZS1wYWdlICJodHRwOi8vd3d3LmxpYmpwZWctdHVyYm8ub3JnLyIpCiAgICAgKHN5 bm9wc2lzICJTSU1ELWFjY2VsZXJhdGVkIEpQRUcgaW1hZ2UgaGFuZGxpbmcgbGlicmFyeSIpCiAg ICAgKGRlc2NyaXB0aW9uICJsaWJqcGVnLXR1cmJvIGlzIGEgSlBFRyBpbWFnZSBjb2RlYyB0aGF0 IGFjY2VsZXJhdGVzIGJhc2VsaW5lCi0tIAoyLjExLjAKCg== ------=_Part_313551_1424283932.1502177565090-- From unknown Mon Aug 18 09:03:10 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#28016] [PATCH] Reproducible issue for libjpeg-turbo References: <2b044d63.16150.15dc0c299a2.Coremail.zren@dlut.edu.cn> In-Reply-To: <2b044d63.16150.15dc0c299a2.Coremail.zren@dlut.edu.cn> Resent-From: "Z. Ren" Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 16 Aug 2017 04:03:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28016 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 28016@debbugs.gnu.org Cc: leo@famulari.name Received: via spool by 28016-submit@debbugs.gnu.org id=B28016.150285613618201 (code B ref 28016); Wed, 16 Aug 2017 04:03:01 +0000 Received: (at 28016) by debbugs.gnu.org; 16 Aug 2017 04:02:16 +0000 Received: from localhost ([127.0.0.1]:40112 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhpX6-0004jV-49 for submit@debbugs.gnu.org; Wed, 16 Aug 2017 00:02:16 -0400 Received: from mx1.dlut.edu.cn ([202.118.66.80]:37758 helo=dlut.edu.cn) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dhpX2-0004jH-RD for 28016@debbugs.gnu.org; Wed, 16 Aug 2017 00:02:13 -0400 Received: by ajax-webmail-mx1 (Coremail) ; Wed, 16 Aug 2017 12:02:05 +0800 (GMT+08:00) X-Originating-IP: [210.30.107.182] Date: Wed, 16 Aug 2017 12:02:05 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Z. Ren" X-Priority: 3 X-Mailer: Coremail Webmail Server Version 5.0.4 dev build 20151203(78088.8298) Copyright (c) 2002-2017 www.mailtech.cn dlut X-SendMailWithSms: false Content-Type: multipart/mixed; boundary="----=_Part_337594_2101304195.1502856125324" MIME-Version: 1.0 Message-ID: <2578d464.17dbf.15de9349b8f.Coremail.zren@dlut.edu.cn> X-Coremail-Locale: en_US X-CM-TRANSID: UEJ2ygBHmuG9w5NZLGe3AA--.7355W X-CM-SenderInfo: h2uh0qhgox3hxhgxhubq/1tbiAgAOAlPExfhXDQACs8 X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) ------=_Part_337594_2101304195.1502856125324 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, There was a typo (redundant brackets around SOURCE_DATE_EPOCH) in the previous submitted patch, sorry that I'm not very familiar with the Guix system. I attach the modified patch. Following the suggestion of Leo (https://lists.gnu.org/archive/html/help-guix/2017-08/msg00053.html Thanks for the suggestion), I investigate the source code of libjpeg-turbo. It appears that the upstream package supports the argument --with-build-date. Maybe this is more suitable for fixing the unreproducible problem? Based on this idea, I tried setting configure-flags with SOURCE_DATE_EPOCH. Unfortunately, the flag is not assigned properly with the following snippet: #:configure-flags (list (string-append "--with-build-date=" (date->string (time-utc->date (make-time time-utc 0 (string->number (getenv "SOURCE_DATE_EPOCH")))) "'~Y~m~d'"))) Is it because the environmental variable SOURCE_DATE_EPOCH is not yet set at the time of #:configure-flags? I read the recipe of other packages, maybe "replace 'configure" is the right solution? Again, sorry that I'm not very familiar with Guix, and haven't come up with the patch yet. However, it would be appreciated if it could be confirmed whether the unreproducibility is caused by the `date` command in the onfigure script. Best regards, Ren ------=_Part_337594_2101304195.1502856125324 Content-Type: application/octet-stream; name="0001-reproducible.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-reproducible.patch" RnJvbSA1MzBiYzdiNDJjOTFmZTE3YTMwYTVlNDAwN2UzODE1NDFhMDk1YTNlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBaLiBSZW4gPHpyZW5AZGx1dC5lZHUuY24+CkRhdGU6IFdlZCwg MTYgQXVnIDIwMTcgMTA6MzU6NDAgKzA4MDAKU3ViamVjdDogW1BBVENIXSByZXByb2R1Y2libGUg Zml4IGZvciBsaWJqcGVnLXR1cmJvCgotLS0KIGdudS9wYWNrYWdlcy9pbWFnZS5zY20gfCAxNiAr KysrKysrKysrKysrKystCiAxIGZpbGUgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMSBkZWxl dGlvbigtKQoKZGlmZiAtLWdpdCBhL2dudS9wYWNrYWdlcy9pbWFnZS5zY20gYi9nbnUvcGFja2Fn ZXMvaW1hZ2Uuc2NtCmluZGV4IDk1YTRjOTFiMS4uZTRjMmFkNjIwIDEwMDY0NAotLS0gYS9nbnUv cGFja2FnZXMvaW1hZ2Uuc2NtCisrKyBiL2dudS9wYWNrYWdlcy9pbWFnZS5zY20KQEAgLTExMjAs NyArMTEyMCwyMSBAQCBQTkcsIGFuZCBwZXJmb3JtcyBQTkcgaW50ZWdyaXR5IGNoZWNrcyBhbmQg Y29ycmVjdGlvbnMuIikKICAgICAobmF0aXZlLWlucHV0cwogICAgICBgKCgibmFzbSIgLG5hc20p KSkKICAgICAoYXJndW1lbnRzCi0gICAgICcoIzp0ZXN0LXRhcmdldCAidGVzdCIpKQorICAgICAn KCM6dGVzdC10YXJnZXQgInRlc3QiCisgICAgICAgIzptb2R1bGVzICgoc3JmaSBzcmZpLTE5KQor ICAgICAgICAgICAgICAgICAgKGd1aXggYnVpbGQgdXRpbHMpCisgICAgICAgICAgICAgICAgICAo Z3VpeCBidWlsZCBnbnUtYnVpbGQtc3lzdGVtKSkKKyAgICAgICAjOnBoYXNlcworICAgICAgICht b2RpZnktcGhhc2VzICVzdGFuZGFyZC1waGFzZXMKKyAgICAgICAgKGFkZC1iZWZvcmUgJ2NvbmZp Z3VyZSAncmVwcm9kdWNpYmxlCisgICAgICAgICAobGFtYmRhIF8KKyAgICAgICAgICAobGV0ICgo c291cmNlLWRhdGUtZXBvY2gKKyAgICAgICAgICAgKHRpbWUtdXRjLT5kYXRlCisgICAgICAgICAg ICAobWFrZS10aW1lIHRpbWUtdXRjIDAgKHN0cmluZy0+bnVtYmVyCisgICAgICAgICAgICAgKGdl dGVudiAiU09VUkNFX0RBVEVfRVBPQ0giKSkpKSkpCisgICAgICAgICAgICAgIChzdWJzdGl0dXRl KiAiY29uZmlndXJlIgorICAgICAgICAgICAgICAgKCgiYGRhdGUgLipgIikgKGRhdGUtPnN0cmlu ZyBzb3VyY2UtZGF0ZS1lcG9jaCAiJ35Zfm1+ZCciKSkKKyAgICAgICAgICAgICAgKSkpKSkpKQog ICAgIChob21lLXBhZ2UgImh0dHA6Ly93d3cubGlianBlZy10dXJiby5vcmcvIikKICAgICAoc3lu b3BzaXMgIlNJTUQtYWNjZWxlcmF0ZWQgSlBFRyBpbWFnZSBoYW5kbGluZyBsaWJyYXJ5IikKICAg ICAoZGVzY3JpcHRpb24gImxpYmpwZWctdHVyYm8gaXMgYSBKUEVHIGltYWdlIGNvZGVjIHRoYXQg YWNjZWxlcmF0ZXMgYmFzZWxpbmUKLS0gCjIuMTMuMgoK ------=_Part_337594_2101304195.1502856125324-- From unknown Mon Aug 18 09:03:10 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: "Z. Ren" Subject: bug#28016: closed (Re: [bug#28016] [PATCH] Reproducible issue for libjpeg-turbo) Message-ID: References: <874lsz7ohj.fsf@gnu.org> <2b044d63.16150.15dc0c299a2.Coremail.zren@dlut.edu.cn> X-Gnu-PR-Message: they-closed 28016 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 28016@debbugs.gnu.org Date: Tue, 22 Aug 2017 12:54:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1503406442-11261-1" This is a multi-part message in MIME format... ------------=_1503406442-11261-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #28016: [PATCH] Reproducible issue for libjpeg-turbo which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 28016@debbugs.gnu.org. --=20 28016: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D28016 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1503406442-11261-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 28016-done) by debbugs.gnu.org; 22 Aug 2017 12:53:42 +0000 Received: from localhost ([127.0.0.1]:48758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dk8gg-0002v8-6W for submit@debbugs.gnu.org; Tue, 22 Aug 2017 08:53:42 -0400 Received: from eggs.gnu.org ([208.118.235.92]:52797) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dk8ge-0002uw-PF for 28016-done@debbugs.gnu.org; Tue, 22 Aug 2017 08:53:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dk8gU-0006Me-Pu for 28016-done@debbugs.gnu.org; Tue, 22 Aug 2017 08:53:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:57225) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dk8gU-0006Ma-Ml; Tue, 22 Aug 2017 08:53:30 -0400 Received: from [193.50.110.251] (port=38312 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dk8gU-00067r-8d; Tue, 22 Aug 2017 08:53:30 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: "Z. Ren" Subject: Re: [bug#28016] [PATCH] Reproducible issue for libjpeg-turbo References: <2b044d63.16150.15dc0c299a2.Coremail.zren@dlut.edu.cn> <2578d464.17dbf.15de9349b8f.Coremail.zren@dlut.edu.cn> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 5 Fructidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 22 Aug 2017 14:53:28 +0200 In-Reply-To: <2578d464.17dbf.15de9349b8f.Coremail.zren@dlut.edu.cn> (Z. Ren's message of "Wed, 16 Aug 2017 12:02:05 +0800 (GMT+08:00)") Message-ID: <874lsz7ohj.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 28016-done Cc: 28016-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) Hi, "Z. Ren" skribis: > There was a typo (redundant brackets around SOURCE_DATE_EPOCH) in the pre= vious submitted patch, sorry that I'm not very familiar with the Guix syste= m. I attach the modified patch. Following the suggestion of Leo (https://li= sts.gnu.org/archive/html/help-guix/2017-08/msg00053.html Thanks for the sug= gestion), I investigate the source code of libjpeg-turbo. It appears that t= he upstream package supports the argument --with-build-date. Maybe this is = more suitable for fixing the unreproducible problem? > > Based on this idea, I tried setting configure-flags with SOURCE_DATE_EPOC= H. Unfortunately, the flag is not assigned properly with the following snip= pet: > > #:configure-flags > (list (string-append "--with-build-date=3D" > (date->string > (time-utc->date > (make-time time-utc 0 > (string->number (getenv "SOURCE_DATE_EPOCH")))) "'~Y~m~d'"))) > > Is it because the environmental variable SOURCE_DATE_EPOCH is not yet > set at the time of #:configure-flags? Yes, that=E2=80=99s correct. I=E2=80=99ve pushed a simple version that does: #:configure-flags (list "--with-build-date=3D1970-01-01") It=E2=80=99s good enough because we set SOURCE_DATE_EPOCH to 0 anyway. Thank you for working on reproducibility issues! Ludo=E2=80=99. ------------=_1503406442-11261-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 8 Aug 2017 15:29:55 +0000 Received: from localhost ([127.0.0.1]:52142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1df6SA-0008Kn-Md for submit@debbugs.gnu.org; Tue, 08 Aug 2017 11:29:54 -0400 Received: from eggs.gnu.org ([208.118.235.92]:53777) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dez0e-0003To-LA for submit@debbugs.gnu.org; Tue, 08 Aug 2017 03:33:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dez0Y-0006mx-EZ for submit@debbugs.gnu.org; Tue, 08 Aug 2017 03:32:55 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:54296) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dez0Y-0006ms-Bo for submit@debbugs.gnu.org; Tue, 08 Aug 2017 03:32:54 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44743) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dez0X-0002bl-0g for guix-patches@gnu.org; Tue, 08 Aug 2017 03:32:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dez0S-0006lc-1H for guix-patches@gnu.org; Tue, 08 Aug 2017 03:32:53 -0400 Received: from mx2.dlut.edu.cn ([202.118.66.81]:51762 helo=dlut.edu.cn) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dez0R-0006lK-Ce for guix-patches@gnu.org; Tue, 08 Aug 2017 03:32:47 -0400 Received: by ajax-webmail-mx2 (Coremail) ; Tue, 8 Aug 2017 15:32:45 +0800 (GMT+08:00) X-Originating-IP: [210.30.107.182] Date: Tue, 8 Aug 2017 15:32:45 +0800 (GMT+08:00) X-CM-HeaderCharset: UTF-8 From: "Z. Ren" To: guix-patches@gnu.org Subject: [PATCH] Reproducible issue for libjpeg-turbo X-Priority: 3 X-Mailer: Coremail Webmail Server Version 5.0.4 dev build 20151203(78088.8298) Copyright (c) 2002-2017 www.mailtech.cn dlut X-SendMailWithSms: false Content-Type: multipart/mixed; boundary="----=_Part_313551_1424283932.1502177565090" MIME-Version: 1.0 Message-ID: <2b044d63.16150.15dc0c299a2.Coremail.zren@dlut.edu.cn> X-Coremail-Locale: en_US X-CM-TRANSID: UUJ2ygDHqM0daYlZpKKAAA--.5307W X-CM-SenderInfo: h2uh0qhgox3hxhgxhubq/1tbiAgAGAlPExfY8AAADsd X-Coremail-Antispam: 1Ur529EdanIXcx71UUUUU7IcSsGvfJ3iIAIbVAYjsxI4VWxJw CS07vEb4IE77IF4wCS07vE1I0E4x80FVAKz4kxMIAIbVAFxVCaYxvI4VCIwcAKzIAtYxBI daVFxhVjvjDU= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Tue, 08 Aug 2017 11:29:51 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) ------=_Part_313551_1424283932.1502177565090 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi! While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package libjpeg-turbo could not be built reproducibly. After investigation, we observe that the unreproducibility is caused by the "configure" script, in which the output of `date` is captured. The attached patch substitutes the `date` according to the SOUR_DATE_EPOCH. Once applied, libjpeg-turbo could be built deterministically. [1]: https://wiki.debian.org/ReproducibleBuilds ------=_Part_313551_1424283932.1502177565090 Content-Type: application/octet-stream; name="0001-reproducible-fix-for-libjpeg-turbo.patch" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="0001-reproducible-fix-for-libjpeg-turbo.patch" RnJvbSAxN2EzM2Y2MTk5ZDQ3Y2RlMWJkMmY3Njg0OTg5OWZlNWQzOWY3NjNjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBaLiBSZW4gPHpyZW5AZGx1dC5lZHUuY24+CkRhdGU6IFR1ZSwg OCBBdWcgMjAxNyAxNDowNToyNSArMDgwMApTdWJqZWN0OiBbUEFUQ0hdIHJlcHJvZHVjaWJsZSBm aXggZm9yIGxpYmpwZWctdHVyYm8KCi0tLQogZ251L3BhY2thZ2VzL2ltYWdlLnNjbSB8IDE2ICsr KysrKysrKysrKysrKy0KIDEgZmlsZSBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspLCAxIGRlbGV0 aW9uKC0pCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL2ltYWdlLnNjbSBiL2dudS9wYWNrYWdl cy9pbWFnZS5zY20KaW5kZXggNjNlM2ZhNTA0Li44NTRhODVhZTIgMTAwNjQ0Ci0tLSBhL2dudS9w YWNrYWdlcy9pbWFnZS5zY20KKysrIGIvZ251L3BhY2thZ2VzL2ltYWdlLnNjbQpAQCAtMTEyMiw3 ICsxMTIyLDIxIEBAIFBORywgYW5kIHBlcmZvcm1zIFBORyBpbnRlZ3JpdHkgY2hlY2tzIGFuZCBj b3JyZWN0aW9ucy4iKQogICAgIChuYXRpdmUtaW5wdXRzCiAgICAgIGAoKCJuYXNtIiAsbmFzbSkp KQogICAgIChhcmd1bWVudHMKLSAgICAgJygjOnRlc3QtdGFyZ2V0ICJ0ZXN0IikpCisgICAgICco Izp0ZXN0LXRhcmdldCAidGVzdCIKKyAgICAgICAjOm1vZHVsZXMgKChzcmZpIHNyZmktMTkpCisg ICAgICAgICAgICAgICAgICAoZ3VpeCBidWlsZCB1dGlscykKKyAgICAgICAgICAgICAgICAgIChn dWl4IGJ1aWxkIGdudS1idWlsZC1zeXN0ZW0pKQorICAgICAgICM6cGhhc2VzCisgICAgICAgKG1v ZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAoYWRkLWJlZm9yZSAnY29uZmln dXJlICdyZXByb2R1Y2libGUKKyAgICAgICAgIChsYW1iZGEgXworICAgICAgICAgIChsZXQgKChz b3VyY2UtZGF0ZS1lcG9jaAorICAgICAgICAgICAodGltZS11dGMtPmRhdGUKKyAgICAgICAgICAg IChtYWtlLXRpbWUgdGltZS11dGMgMCAoc3RyaW5nLT5udW1iZXIKKyAgICAgICAgICAgICAoZ2V0 ZW52ICJTT1VSQ0VfREFURV9FUE9DSCIpKSkpKSkKKyAgICAgICAgICAgICAgKHN1YnN0aXR1dGUq ICJjb25maWd1cmUiCisgICAgICAgICAgICAgICAoKCJgZGF0ZSAuKmAiKSAoZGF0ZS0+c3RyaW5n IHNvdXJjZS1kYXRlLWVwb2NoICIne35Zfm1+ZH0nIikpCisgICAgICAgICAgICAgICkpKSkpKSkK ICAgICAoaG9tZS1wYWdlICJodHRwOi8vd3d3LmxpYmpwZWctdHVyYm8ub3JnLyIpCiAgICAgKHN5 bm9wc2lzICJTSU1ELWFjY2VsZXJhdGVkIEpQRUcgaW1hZ2UgaGFuZGxpbmcgbGlicmFyeSIpCiAg ICAgKGRlc2NyaXB0aW9uICJsaWJqcGVnLXR1cmJvIGlzIGEgSlBFRyBpbWFnZSBjb2RlYyB0aGF0 IGFjY2VsZXJhdGVzIGJhc2VsaW5lCi0tIAoyLjExLjAKCg== ------=_Part_313551_1424283932.1502177565090-- ------------=_1503406442-11261-1--