GNU bug report logs - #28015
[PATCH] Reproducible issue for djvulibre

Previous Next

Package: guix-patches;

Reported by: "Z. Ren" <zren <at> dlut.edu.cn>

Date: Tue, 8 Aug 2017 15:30:03 UTC

Severity: normal

Tags: patch

Done: ludo <at> gnu.org (Ludovic Courtès)

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: ludo <at> gnu.org (Ludovic Courtès)
Cc: tracker <at> debbugs.gnu.org
Subject: bug#28015: closed ([PATCH] Reproducible issue for djvulibre)
Date: Fri, 01 Sep 2017 09:09:01 +0000
[Message part 1 (text/plain, inline)]
Your message dated Fri, 01 Sep 2017 11:08:35 +0200
with message-id <87d17a7pm4.fsf <at> gnu.org>
and subject line Re: [bug#28015] Re: [bug#28015] [PATCH] Reproducible issue for djvulibre
has caused the debbugs.gnu.org bug report #28015,
regarding [PATCH] Reproducible issue for djvulibre
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
28015: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=28015
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: "Z. Ren" <zren <at> dlut.edu.cn>
To: guix-patches <at> gnu.org
Subject: [PATCH] Reproducible issue for djvulibre
Date: Tue, 8 Aug 2017 15:31:52 +0800 (GMT+08:00)
[Message part 3 (text/plain, inline)]
Hi!
While conducting a study inspired by the "reproducible builds" practice [1], we have noticed that the package djvulibre could not be built reproducibly.

After investigation, we observe that the unreproducibility is caused by "desktopfiles/Makefile.in", in which the command gzip is invoked without the "-n" argument. Consequently, timestamp is captured in the built file "share/icons/hicolor/scalable/mimetypes/djvu.svgz".

The attached patch adds the argument to the gzip command. Once applied, djvulibre could be built reproducibly.

 [1]: https://wiki.debian.org/ReproducibleBuilds
[0001-reproducible-fix-for-djvulibre.patch (application/octet-stream, attachment)]
[Message part 5 (message/rfc822, inline)]
From: ludo <at> gnu.org (Ludovic Courtès)
To: "Z. Ren" <zren <at> dlut.edu.cn>
Cc: 28015-done <at> debbugs.gnu.org
Subject: Re: [bug#28015] Re: [bug#28015] [PATCH] Reproducible issue for
 djvulibre
Date: Fri, 01 Sep 2017 11:08:35 +0200
Hello,

"Z. Ren" <zren <at> dlut.edu.cn> skribis:

> Thanks for your kind reply. I re-check the build result. According to the output of diffoscope (see below for the snippet), the file that's different between the two builds is scalable/mimetypes/djvu.svgz. It is indeed a gzip file, though the extension is svgz. Not sure whether it could be handled automatically by the upcoming build system?
>
> ├── scalable
> ├── mimetypes
> ├── djvu.svgz
> ├── metadata
> │ │ │ │ │ │ │ @@ -1 +1 @@
> │ │ │ │ │ │ │ -gzip compressed data, last modified: Fri Mar 10 23:39:11 2017, from Unix
> │ │ │ │ │ │ │ +gzip compressed data, last modified: Wed Aug 23 09:27:59 2017, from Unix

Oh right, .svgz is not handled by the new phase.

I pushed your patch with small cosmetic changes:

  https://git.savannah.gnu.org/cgit/guix.git/commit/?id=5fe2a139dfdef058f544fc4b83742628e1fa04bc

Thanks!

Ludo’.


This bug report was last modified 7 years and 325 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.