GNU bug report logs - #27983
[PATCH] gnu: googletest: Build shared libraries.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27983 in the body.
You can then email your comments to 27983 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: guix-patches <at> gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: [PATCH] gnu: googletest: Build shared libraries.
Date: Sun,  6 Aug 2017 17:12:17 +0300

From: Manolis Ragkousis <manolis837 <at> gmail.com>

* gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
  in #:configure-flags.
---
 gnu/packages/check.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/check.scm b/gnu/packages/check.scm
index 2ab5c0135..ddfcf1750 100644
--- a/gnu/packages/check.scm
+++ b/gnu/packages/check.scm
@@ -213,6 +213,8 @@ normally do not detect.  The goal is to detect only real errors in the code
         (base32
          "1n5p1m2m3fjrjdj752lf92f9wq3pl5cbsfrb49jqbg52ghkz99jq"))))
     (build-system cmake-build-system)
+    (arguments
+     `(#:configure-flags '("-DBUILD_SHARED_LIBS=ON")))
     (native-inputs
      `(("python-2" ,python-2)))
     (home-page "https://github.com/google/googletest/")
-- 
2.13.4

Message #8 received at 27983 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: manolis837 <at> gmail.com
Cc: 27983 <at> debbugs.gnu.org
Subject: Re: [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
Date: Mon, 7 Aug 2017 14:22:48 -0400

[Message part 1 (text/plain, inline)]

On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837 <at> gmail.com wrote:
> From: Manolis Ragkousis <manolis837 <at> gmail.com>
> 
> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
>   in #:configure-flags.

Does it still build the static library in this case? If not, do packages
that are currently using googletest need to be adjusted?

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 27983 <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27983 <at> debbugs.gnu.org
Subject: Re: [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
Date: Tue, 8 Aug 2017 14:31:51 +0300

Hello Leo

On 08/07/2017 09:22 PM, Leo Famulari wrote:
> On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837 <at> gmail.com wrote:
>> From: Manolis Ragkousis <manolis837 <at> gmail.com>
>>
>> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
>>   in #:configure-flags.
> 
> Does it still build the static library in this case? If not, do packages
> that are currently using googletest need to be adjusted?
> 

No it doesn't but I rebuilt all the packages that depend on googletest
and everything built and worked the same. No need for anything to be
adjusted.

Manolis

Message #14 received at 27983 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Manolis Ragkousis <manolis837 <at> gmail.com>
Cc: 27983 <at> debbugs.gnu.org
Subject: Re: [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
Date: Tue, 8 Aug 2017 09:58:03 -0400

[Message part 1 (text/plain, inline)]

On Tue, Aug 08, 2017 at 02:31:51PM +0300, Manolis Ragkousis wrote:
> Hello Leo
> 
> On 08/07/2017 09:22 PM, Leo Famulari wrote:
> > On Sun, Aug 06, 2017 at 05:12:17PM +0300, manolis837 <at> gmail.com wrote:
> >> From: Manolis Ragkousis <manolis837 <at> gmail.com>
> >>
> >> * gnu/packages/check.scm (googletest)[arguments]: Pass "-DBUILD_SHARED_LIBS=ON"
> >>   in #:configure-flags.
> > 
> > Does it still build the static library in this case? If not, do packages
> > that are currently using googletest need to be adjusted?
> > 
> 
> No it doesn't but I rebuilt all the packages that depend on googletest
> and everything built and worked the same. No need for anything to be
> adjusted.

Okay then, LGTM!

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 27983-done <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: 27983-done <at> debbugs.gnu.org
Subject: Re: [bug#27983] [PATCH] gnu: googletest: Build shared libraries.
Date: Wed, 9 Aug 2017 14:01:17 +0300

Pushed to master.

Thank you Leo!

Manolis

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.