Subject: Re: [bug#27971] [PATCH] gnu: Add ois.

From: Marius Bakke <[email-masked]>
Date: Tue, 08 Aug 2017 00:04:15 +0200

[email-masked] writes:

> From: Manolis Ragkousis <[email-masked]>
>
> * gnu/packages/game-development.scm (ois): New variable.

[...]

> +(define-public ois
> +  (package
> +    (name "ois")
> +    (version "1.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "git://github.com/wgois/OIS.git")
> +             (commit "bb75ccc1aabc1c547195579963601ff6080ca2f2")))

Can you add a note about why we need a git checkout? Also, please use
HTTPS here.

> +       (file-name (string-append name "-" version))
> +       (sha256
> +        (base32
> +         "0w0pamjc3vj0jr718hysrw8x076fq6n9rd6wcb36sn2jd0lqvi98"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda _ (zero? (system* "sh" "bootstrap")))))))

This should be done after 'unpack' to not compete against the various
'patch-shebang' phases.

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("m4" ,m4)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("libxaw" ,libxaw)))
> +    (synopsis "Object Oriented Input System")
> +    (description
> +     "Cross Platform Object Oriented Input Lib System.  Meant to be very robust
> +and compatiable with many systems and operating systems.")
            ^^^ typo

Feel free to expand on the description if you can, but LGTM.