GNU bug report logs - #27971
[PATCH] gnu: Add ois.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27971 in the body.
You can then email your comments to 27971 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: guix-patches <at> gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: [PATCH] gnu: Add ois.
Date: Sat,  5 Aug 2017 20:08:20 +0300

From: Manolis Ragkousis <manolis837 <at> gmail.com>

* gnu/packages/game-development.scm (ois): New variable.
---
 gnu/packages/game-development.scm | 37 +++++++++++++++++++++++++++++++++++++
 1 file changed, 37 insertions(+)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index 7ab9a1aef..75f2c47e9 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -35,6 +35,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages databases)
@@ -45,6 +46,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnunet)
   #:use-module (gnu packages guile)
+  #:use-module (gnu packages m4)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
@@ -915,3 +917,38 @@ suitable for pixel art, game graphics, and generally any detailed graphics
 painted with a mouse.")
     (home-page "http://pulkomandy.tk/projects/GrafX2")
     (license license:gpl2))) ; GPLv2 only
+
+(define-public ois
+  (package
+    (name "ois")
+    (version "1.3")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "git://github.com/wgois/OIS.git")
+             (commit "bb75ccc1aabc1c547195579963601ff6080ca2f2")))
+       (file-name (string-append name "-" version))
+       (sha256
+        (base32
+         "0w0pamjc3vj0jr718hysrw8x076fq6n9rd6wcb36sn2jd0lqvi98"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-before 'configure 'bootstrap
+           (lambda _ (zero? (system* "sh" "bootstrap")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("m4" ,m4)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libxaw" ,libxaw)))
+    (synopsis "Object Oriented Input System")
+    (description
+     "Cross Platform Object Oriented Input Lib System.  Meant to be very robust
+and compatiable with many systems and operating systems.")
+    (home-page "https://github.com/wgois/OIS")
+    (license license:zlib)))
-- 
2.13.4

Message #8 received at 27971 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: manolis837 <at> gmail.com, 27971 <at> debbugs.gnu.org
Subject: Re: [bug#27971] [PATCH] gnu: Add ois.
Date: Tue, 08 Aug 2017 00:04:15 +0200

[Message part 1 (text/plain, inline)]

manolis837 <at> gmail.com writes:

> From: Manolis Ragkousis <manolis837 <at> gmail.com>
>
> * gnu/packages/game-development.scm (ois): New variable.

[...]

> +(define-public ois
> +  (package
> +    (name "ois")
> +    (version "1.3")
> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "git://github.com/wgois/OIS.git")
> +             (commit "bb75ccc1aabc1c547195579963601ff6080ca2f2")))

Can you add a note about why we need a git checkout? Also, please use
HTTPS here.

> +       (file-name (string-append name "-" version))
> +       (sha256
> +        (base32
> +         "0w0pamjc3vj0jr718hysrw8x076fq6n9rd6wcb36sn2jd0lqvi98"))))
> +    (build-system gnu-build-system)
> +    (arguments
> +     `(#:phases
> +       (modify-phases %standard-phases
> +         (add-before 'configure 'bootstrap
> +           (lambda _ (zero? (system* "sh" "bootstrap")))))))

This should be done after 'unpack' to not compete against the various
'patch-shebang' phases.

> +    (native-inputs
> +     `(("autoconf" ,autoconf)
> +       ("automake" ,automake)
> +       ("libtool" ,libtool)
> +       ("m4" ,m4)
> +       ("pkg-config" ,pkg-config)))
> +    (inputs
> +     `(("libxaw" ,libxaw)))
> +    (synopsis "Object Oriented Input System")
> +    (description
> +     "Cross Platform Object Oriented Input Lib System.  Meant to be very robust
> +and compatiable with many systems and operating systems.")
            ^^^ typo

Feel free to expand on the description if you can, but LGTM.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 27971 <at> debbugs.gnu.org (full text, mbox):

From: manolis837 <at> gmail.com
To: 27971 <at> debbugs.gnu.org
Cc: mbakke <at> fastmail.com, Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: [PATCH] gnu: Add ois.
Date: Tue,  8 Aug 2017 23:45:24 +0300

From: Manolis Ragkousis <manolis837 <at> gmail.com>

* gnu/packages/game-development.scm (ois): New variable.
---
 gnu/packages/game-development.scm | 41 +++++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/game-development.scm b/gnu/packages/game-development.scm
index efd8f6d03..c98c15e46 100644
--- a/gnu/packages/game-development.scm
+++ b/gnu/packages/game-development.scm
@@ -35,6 +35,7 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python)
   #:use-module (gnu packages)
+  #:use-module (gnu packages autotools)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages curl)
   #:use-module (gnu packages databases)
@@ -45,6 +46,7 @@
   #:use-module (gnu packages glib)
   #:use-module (gnu packages gnunet)
   #:use-module (gnu packages guile)
+  #:use-module (gnu packages m4)
   #:use-module (gnu packages multiprecision)
   #:use-module (gnu packages music)
   #:use-module (gnu packages ncurses)
@@ -893,3 +895,42 @@ suitable for pixel art, game graphics, and generally any detailed graphics
 painted with a mouse.")
     (home-page "http://pulkomandy.tk/projects/GrafX2")
     (license license:gpl2))) ; GPLv2 only
+
+(define-public ois
+  (package
+    (name "ois")
+    (version "1.3")
+    (source
+     (origin
+       ;; Development has moved to github and there are no recent tarball
+       ;; releases.
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/wgois/OIS.git")
+             (commit "bb75ccc1aabc1c547195579963601ff6080ca2f2")))
+       (file-name (string-append name "-" version))
+       (sha256
+        (base32
+         "0w0pamjc3vj0jr718hysrw8x076fq6n9rd6wcb36sn2jd0lqvi98"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'bootstrap
+           (lambda _ (zero? (system* "sh" "bootstrap")))))))
+    (native-inputs
+     `(("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("libtool" ,libtool)
+       ("m4" ,m4)
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("libxaw" ,libxaw)))
+    (synopsis "Object Oriented Input System")
+    (description
+     "Cross Platform Object Oriented Input Lib System is a cross platform,
+simple solution for using all kinds of Input Devices (Keyboards, Mice,
+Joysticks, etc) and feedback devices (e.g. force feedback).  Meant to be very
+robust and compatible with many systems and operating systems.")
+    (home-page "https://github.com/wgois/OIS")
+    (license license:zlib)))
-- 
2.13.4

Message #14 received at 27971 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: manolis837 <at> gmail.com, 27971 <at> debbugs.gnu.org
Cc: Manolis Ragkousis <manolis837 <at> gmail.com>
Subject: Re: [PATCH] gnu: Add ois.
Date: Tue, 08 Aug 2017 23:15:29 +0200

[Message part 1 (text/plain, inline)]

manolis837 <at> gmail.com writes:

> From: Manolis Ragkousis <manolis837 <at> gmail.com>
>
> * gnu/packages/game-development.scm (ois): New variable.

LGTM, thanks! Good job on the description :-)

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 27971-done <at> debbugs.gnu.org (full text, mbox):

From: Manolis Ragkousis <manolis837 <at> gmail.com>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27971-done <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add ois.
Date: Wed, 9 Aug 2017 14:04:01 +0300

On 08/09/2017 12:15 AM, Marius Bakke wrote:
> manolis837 <at> gmail.com writes:
> 
>> From: Manolis Ragkousis <manolis837 <at> gmail.com>
>>
>> * gnu/packages/game-development.scm (ois): New variable.
> 
> LGTM, thanks! Good job on the description :-)
> 
Pushed to master.

Thank you Marius!

Manolis

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.