Subject: Re: [bug#27970] [PATCH] gnu: Add rss-bridge.

From: Ricardo Wurmus <[email-masked]>
Date: Wed, 16 Aug 2017 16:24:47 +0200

Hi Arun,

> * gnu/packages/web.scm (rss-bridge): New variable.
[…]
> +
> +(define-public rss-bridge
> +  (package
> +    (name "rss-bridge")
> +    (version "2017-08-03")
> +    (source
> +     (origin
> +       (method url-fetch)
> +       (uri (string-append "https://github.com/RSS-Bridge/rss-bridge/archive/"
> +                           version ".tar.gz"))
> +       (file-name (string-append name "-" version ".tar.gz"))
> +       (sha256
> +        (base32
> +         "05s16y552hbyj91s7bnlkx1bi64s6aw0fjy29az8via3i3b21yhl"))))
> +    (build-system trivial-build-system)
> +    (native-inputs
> +     `(("gzip" ,gzip)
> +       ("tar" ,tar)))
> +    (arguments
> +     '(#:modules ((guix build utils))
> +       #:builder
> +       (begin
> +         (use-modules (guix build utils)
> +                      (ice-9 match))
> +         (let* ((out (assoc-ref %outputs "out"))
> +                (share-rss-bridge (string-append out "/share/rss-bridge")))
> +           (set-path-environment-variable
> +            "PATH" '("bin") (map (match-lambda ((_ . input) input))
> +                                 %build-inputs))
> +           (mkdir-p share-rss-bridge)
> +           (system* "tar" "xvf" (assoc-ref %build-inputs "source")
> +                    "--strip-components" "1" "-C" share-rss-bridge)
> +           #t))))
> +    (home-page "https://github.com/RSS-Bridge/rss-bridge")
> +    (synopsis "Generate ATOM feeds for social networking websites")
> +    (description "rss-bridge generates ATOM feeds for social networking

I think this should be “Atom”, not “ATOM”.

> +websites lacking feeds.  Supported websites include Facebook, Twitter,
> +Instagram and YouTube.")
> +    (license (list l:public-domain
> +                   l:expat)))) ;; vendor/simplehtmldom/simple_html_dom.php

How is this supposed to be used?  If these are just PHP files I think it
may be worth prepending “php-” to the package name and the variable
name.

What do you think?

-- 
Ricardo

GPG: BCA6 89B6 3655 3801 C3C6  2150 197A 5888 235F ACAC
https://elephly.net