From unknown Mon Jun 23 02:22:10 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27968 <27968@debbugs.gnu.org> To: bug#27968 <27968@debbugs.gnu.org> Subject: Status: 26.0.50; dired-revert: Saved positions might change if a dired header changes Reply-To: bug#27968 <27968@debbugs.gnu.org> Date: Mon, 23 Jun 2025 09:22:10 +0000 retitle 27968 26.0.50; dired-revert: Saved positions might change if a dire= d header changes reassign 27968 emacs submitter 27968 Tino Calancha severity 27968 normal tag 27968 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 09:01:56 2017 Received: (at submit) by debbugs.gnu.org; 5 Aug 2017 13:01:56 +0000 Received: from localhost ([127.0.0.1]:42622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddyiK-0004FG-Bv for submit@debbugs.gnu.org; Sat, 05 Aug 2017 09:01:56 -0400 Received: from eggs.gnu.org ([208.118.235.92]:41691) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddyiI-0004F2-2I for submit@debbugs.gnu.org; Sat, 05 Aug 2017 09:01:54 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddyiB-000187-E0 for submit@debbugs.gnu.org; Sat, 05 Aug 2017 09:01:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=0.8 required=5.0 tests=BAYES_50,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41782) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1ddyiB-000182-Ay for submit@debbugs.gnu.org; Sat, 05 Aug 2017 09:01:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60886) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddyi9-0000DY-6g for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 09:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddyi6-00014d-4g for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 09:01:45 -0400 Received: from mail-pf0-x233.google.com ([2607:f8b0:400e:c00::233]:34781) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ddyi5-00012R-RL for bug-gnu-emacs@gnu.org; Sat, 05 Aug 2017 09:01:42 -0400 Received: by mail-pf0-x233.google.com with SMTP id o86so17762773pfj.1 for ; Sat, 05 Aug 2017 06:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=ey+IHJ4/9cKOGfHQb5wbSk8Skfq6EKI4JP7GHcuA1WM=; b=V7OndwqXqfXCIqvV0Hny6fQMeK7n+DFXUMfkH5Uj8DPpY+3DkDppyr+PUpNCEqXIyj MGONXjShrW5Cfq0K+zHD/csYAIOHLRWkJQKKaLpHruYEKWfNSmEuSQB2fIq7q9yru3+b geJ/VXdC0GQsWGQWqgrX/rl1GCu7OLOPQDg0lavrOaPZ0ezlA359subvO9h4KY6G8W04 SLsv12aZEkJ0D45PnobyNyKlUcwHBPbUS42VYD4rSQhGF+U684qCkrUe/iwJN6VSpNoa QAc16FcWJIdQ+eU7TZiARZGFSAgW+ZyIkzVCw4g33Ft6wOsrdykgvmLisN2U/jejVhed VMcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ey+IHJ4/9cKOGfHQb5wbSk8Skfq6EKI4JP7GHcuA1WM=; b=ZMRZfBVgTzecpDKOVpZ+P5x/E9r5VE9O7euoBy1ao7Y3PfvNMzU+gDj65y/Cd1Lehb Mocr9uxFUAbpJWyG6QexuZ28MOnXiIUnbl4h2h/HLEmeVgh1P4wEuXpbffI/ZulE9hIx b0p/Xr6//D9EUpejKVPv0b0zO2qx4sxN70MtJAKkiTUoAeG8BS6oBz/7eZZ9zlv1x8m4 cfGFMXRpy/PlCnyd/8TOuoA1Sx91/UBnqTqLCodWY4X0jBY4ePDB7wN+IhdbcDPrquAc LGJ9a9ISnRyexxnmB6EdnShNzVmHGHrCUWGDgxA/welHltLqlsavvrTuTBCOhAOF0PiQ bDag== X-Gm-Message-State: AIVw113aQXBrR2usLp3Dobq5UkUPbTR5Dm97K1hkygiuTUkNC6t0tZRf tPXEq7taWVcc0Wbg X-Received: by 10.99.7.131 with SMTP id 125mr5451317pgh.136.1501938098816; Sat, 05 Aug 2017 06:01:38 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id l2sm7314677pgc.27.2017.08.05.06.01.37 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 06:01:38 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; dired-revert: Saved positions might change if a dired header changes Date: Sat, 05 Aug 2017 22:01:34 +0900 Message-ID: <87bmnu6udt.fsf@calancha-pc> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) X-Debbugs-CC: Stephen Berman Tag: patch Dired headers also changes; if you add/deleted some files, the used space shown changes: that will mess up the saved buffer positions if the length of the header is different. This problem causes dired-test-bug27243-01 to fail in hydra. One possible solution is the patch below. It saves line numbers instead of positions. Line numbers won't change if a dired header changes its length. --8<-----------------------------cut here---------------start------------->8--- commit a6799f27a9d18618f3046a1db7ffebc480310e8f Author: Tino Calancha Date: Sat Aug 5 21:59:06 2017 +0900 dired-revert: save line numbers instead of positions Positions might change if the length of one dired header line changes; this happen, for instance, if we add new files. https://lists.gnu.org/archive/html/emacs-devel/2017-07/msg01092.html * lisp/dired.el (dired-save-positions): Save the line numbers at point. (dired-restore-positions): Use forward-line to restore the original position (Bug#27968). * test/lisp/dired-tests.el (dired-test-bug27968): Add test. diff --git a/lisp/dired.el b/lisp/dired.el index 24759c6c9b..d04bd6fe03 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1444,18 +1444,22 @@ dired-save-positions The positions have the form (BUFFER-POSITION WINDOW-POSITIONS). BUFFER-POSITION is the point position in the current Dired buffer. -It has the form (BUFFER DIRED-FILENAME BUFFER-POINT). +It has the form (BUFFER DIRED-FILENAME BUFFER-LINE-NUMBER). WINDOW-POSITIONS are current positions in all windows displaying this dired buffer. The window positions have the form (WINDOW -DIRED-FILENAME WINDOW-POINT)." +DIRED-FILENAME WINDOW-LINE-NUMBER). + +We store line numbers instead of point positions because the header +lines might change as well: when this happen the line number doesn't +change; the point does." (list - (list (current-buffer) (dired-get-filename nil t) (point)) + (list (current-buffer) (dired-get-filename nil t) (line-number-at-pos)) (mapcar (lambda (w) - (list w - (with-selected-window w - (dired-get-filename nil t)) - (window-point w))) + (with-selected-window w + (list w + (dired-get-filename nil t) + (line-number-at-pos (window-point w))))) (get-buffer-window-list nil 0 t)))) (defun dired-restore-positions (positions) @@ -1464,7 +1468,8 @@ dired-restore-positions (buffer (nth 0 buf-file-pos))) (unless (and (nth 1 buf-file-pos) (dired-goto-file (nth 1 buf-file-pos))) - (goto-char (nth 2 buf-file-pos)) + (goto-char (point-min)) + (forward-line (1- (nth 2 buf-file-pos))) (dired-move-to-filename)) (dolist (win-file-pos (nth 1 positions)) ;; Ensure that window still displays the original buffer. @@ -1472,7 +1477,8 @@ dired-restore-positions (with-selected-window (nth 0 win-file-pos) (unless (and (nth 1 win-file-pos) (dired-goto-file (nth 1 win-file-pos))) - (goto-char (nth 2 win-file-pos)) + (goto-char (point-min)) + (forward-line (1- (nth 2 win-file-pos))) (dired-move-to-filename))))))) (defun dired-remember-marks (beg end) diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el index b14bbc6360..4bbf72ab74 100644 --- a/test/lisp/dired-tests.el +++ b/test/lisp/dired-tests.el @@ -308,5 +308,44 @@ dired-dwim-target (should (eq 2 (current-column)))) (dired-hide-details-mode orig)))) +(ert-deftest dired-test-bug27968 () + (let* ((top-dir (make-temp-file "top-dir" t)) + (subdir (expand-file-name "subdir" top-dir)) + (header-len-fn (lambda () + (save-excursion + (goto-char 1) + (forward-line 1) + (- (point-at-eol) (point))))) + orig-len len diff pos) + (make-directory subdir 'parents) + (unwind-protect + (with-current-buffer (dired-noselect subdir) + (setq orig-len (funcall header-len-fn) + pos (point)) + ;; Bug arises when the header line changes its length; this may + ;; happen if the used space has changed: for instance, with the + ;; creation of additional files. + (make-directory "subdir" t) + (dired-revert) + ;; Change the header line. + (save-excursion + (goto-char 1) + (forward-line 1) + (let ((inhibit-read-only t)) + (delete-region (point) (point-at-eol)) + (insert " test-bug27968"))) + (setq len (funcall header-len-fn) + diff (- len orig-len)) + (should-not (zerop diff)) ; Header length has changed. + ;; If diff > 0, then the point moves back. + ;; If diff < 0, then the point moves forward. + ;; If diff = 0, then the point doesn't move. + ;; We correct `point' with diff to obtain the right line number. + (should (equal (line-number-at-pos (+ (point) diff)) + (line-number-at-pos pos))) + ;; After revert, the point must be in 'subdir' line. + (should (equal "subdir" (dired-get-filename nil t)))) + (delete-directory top-dir t)))) + (provide 'dired-tests) ;; dired-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-08-05 built on calancha-pc Repository revision: 1d51b265075ea9852dab678071b0e400a2c36ae7 Windowing system distributor 'The X.Org Foundation', version 11.0.11902000 System Description: Debian GNU/Linux 9.1 (stretch) From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 09:15:51 2017 Received: (at 27968) by debbugs.gnu.org; 5 Aug 2017 13:15:52 +0000 Received: from localhost ([127.0.0.1]:42637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddyvn-0004Zc-My for submit@debbugs.gnu.org; Sat, 05 Aug 2017 09:15:51 -0400 Received: from eggs.gnu.org ([208.118.235.92]:45585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ddyvm-0004ZQ-0Q for 27968@debbugs.gnu.org; Sat, 05 Aug 2017 09:15:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ddyvf-0004h2-PZ for 27968@debbugs.gnu.org; Sat, 05 Aug 2017 09:15:44 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49553) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ddyvX-0004TS-LL; Sat, 05 Aug 2017 09:15:35 -0400 Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2367 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1ddyvX-0000Hz-2U; Sat, 05 Aug 2017 09:15:35 -0400 Date: Sat, 05 Aug 2017 16:15:27 +0300 Message-Id: <83h8xmupe8.fsf@gnu.org> From: Eli Zaretskii To: Tino Calancha In-reply-to: <87bmnu6udt.fsf@calancha-pc> (message from Tino Calancha on Sat, 05 Aug 2017 22:01:34 +0900) Subject: Re: bug#27968: 26.0.50; dired-revert: Saved positions might change if a dired header changes References: <87bmnu6udt.fsf@calancha-pc> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27968 Cc: stephen.berman@gmx.net, 27968@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Eli Zaretskii Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) > From: Tino Calancha > Date: Sat, 05 Aug 2017 22:01:34 +0900 > Cc: stephen berman > > Dired headers also changes; if you add/deleted some files, > the used space shown changes: that will mess up the saved > buffer positions if the length of the header is different. > > This problem causes dired-test-bug27243-01 to fail in hydra. > > One possible solution is the patch below. It saves line numbers > instead of positions. Line numbers won't change if a dired header > changes its length. Won't using markers be a better solution? From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 11:45:14 2017 Received: (at 27968) by debbugs.gnu.org; 5 Aug 2017 15:45:14 +0000 Received: from localhost ([127.0.0.1]:43549 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de1GL-0008Du-S2 for submit@debbugs.gnu.org; Sat, 05 Aug 2017 11:45:14 -0400 Received: from mail-pf0-f175.google.com ([209.85.192.175]:33861) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de1GK-0008Dh-IP for 27968@debbugs.gnu.org; Sat, 05 Aug 2017 11:45:12 -0400 Received: by mail-pf0-f175.google.com with SMTP id o86so18603347pfj.1 for <27968@debbugs.gnu.org>; Sat, 05 Aug 2017 08:45:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:in-reply-to:message-id:references :user-agent:mime-version; bh=u2HqkT86Y6sBVDfmfrJYZ6Xye3yvhU0RTD2EVt8/5N4=; b=inaY3gn8LEODQj/PsEyG7zfMJocoqX4W1aZX8WlZtMn9KV+361FjAiitfZmyDh3D0+ XuPjPH33qwTLdYPSyFjnwPp3doxkqRTk7hqctCM1Uj+dU7DC94DJOiGm111fqlLd3oY3 D7rRXl9SkhTktkjrI3kSy9z5eIp8b8T9GEhI/Nt4WG3/00eBSgWYZqBxcEqldFAZGe3L eVA4JYDDY7dOMHkTBPqgJPFPcAnFVFKcSLdTWV8UFJXtaeQJBcFgD0DLpFTLgLb2FWSh Ut+MBP5VDPb4rXz28Uj0InVcV3HzQ6zyrRS0w5U4vjlIxb5mJxDzmmJIy2cnfGfkM8Wo pzTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:in-reply-to:message-id :references:user-agent:mime-version; bh=u2HqkT86Y6sBVDfmfrJYZ6Xye3yvhU0RTD2EVt8/5N4=; b=GnuczYpjUcYtHa2tjYVekBCi7pX48p8l4pRCx2DYZRoTLhFfjbXQYb0SeAHXx82VXn 9XHSl1NyTocJX4e3xNbsgIWQN5jPCbIrRUpLRJ9QC69l7U+rinlkaD152dH1trcU0zKr TRWtFJ7I+vmevMDNMx5ItHFQxc4RcegGhYXGBdgAwAW+bJB3wruvwDGZR69vsBbJencW Qtv00php2dyvJkwa20LAWjGPw5Y2lHoNvDiKgJJ6C3u9V0bf040qT9EvkNNK5ohG2zmr D36yIQe1/PQBrAt0uNX10+Fn+zcp/qRcg74YDhDvxnTjfCVotjBqeuH+KGqinG03l38g 9jPQ== X-Gm-Message-State: AIVw1112A+NQyCHiYl7jZ2vfE5WYT+aZ5NvqXRXhMsK5hwnkO9Z0y+M2 90wWzsiEH0H1CA== X-Received: by 10.84.248.69 with SMTP id e5mr7340907pln.38.1501947906305; Sat, 05 Aug 2017 08:45:06 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id r86sm8773756pfi.138.2017.08.05.08.45.03 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 05 Aug 2017 08:45:05 -0700 (PDT) From: Tino Calancha X-Google-Original-From: Tino Calancha Date: Sun, 6 Aug 2017 00:45:02 +0900 (JST) X-X-Sender: calancha@calancha-pc To: Eli Zaretskii Subject: Re: bug#27968: 26.0.50; dired-revert: Saved positions might change if a dired header changes In-Reply-To: <83h8xmupe8.fsf@gnu.org> Message-ID: References: <87bmnu6udt.fsf@calancha-pc> <83h8xmupe8.fsf@gnu.org> User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset=US-ASCII X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27968 Cc: 27968@debbugs.gnu.org, stephen.berman@gmx.net, Tino Calancha X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On Sat, 5 Aug 2017, Eli Zaretskii wrote: >> From: Tino Calancha >> Date: Sat, 05 Aug 2017 22:01:34 +0900 >> Cc: stephen berman >> >> Dired headers also changes; if you add/deleted some files, >> the used space shown changes: that will mess up the saved >> buffer positions if the length of the header is different. >> >> This problem causes dired-test-bug27243-01 to fail in hydra. >> >> One possible solution is the patch below. It saves line numbers >> instead of positions. Line numbers won't change if a dired header >> changes its length. > > Won't using markers be a better solution? Yes, but `dired-revert' erases the buffer when calls `dired-readin', so that the markers will 'gone baby gone': neither the very same Casey Affleck could recover those markers. From debbugs-submit-bounces@debbugs.gnu.org Sat Aug 05 15:23:39 2017 Received: (at control) by debbugs.gnu.org; 5 Aug 2017 19:23:39 +0000 Received: from localhost ([127.0.0.1]:43697 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de4fj-00070F-0c for submit@debbugs.gnu.org; Sat, 05 Aug 2017 15:23:39 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38722) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1de4fh-000701-Mh for control@debbugs.gnu.org; Sat, 05 Aug 2017 15:23:37 -0400 Received: by mail-it0-f44.google.com with SMTP id m34so4376110iti.1 for ; Sat, 05 Aug 2017 12:23:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:mime-version; bh=cODG4b/qH1EHBWDHzE44le/3Kj1jY/t9ICBX1OT9LcI=; b=oq2fV/hggN0RPtC6OaOir7EuYCe6boLmuyLrCjDYHnUcyLL0zhF+6NB67NVGaeNkeI ldWq/KiUBqcA4av6Iz9qkOmrtRuSK6smJ4CsPPTzdhnle4jIaYcsY29CkIcOw1Fh9jne AXPWeza19+hsxSQ+5B44A61uP3D9F7qQp5NXHSRdV9VRQzv82+hisw46Zvo9zhLtKShy C+QdtErxDGVZpcoaqPmaMsY8T9ZuPBAXIcw3xsu+rNBGIsfCD8T38gPhS1qWunZ76DaN 3OScoIc3CK9312cYO1uJFBXKoPY4RH9ZVhOvAin7Qq5HLyrJQrjDrUGTb3Zf2gHNFiba gyOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :mime-version; bh=cODG4b/qH1EHBWDHzE44le/3Kj1jY/t9ICBX1OT9LcI=; b=LcFVzyqCF90jNZWnshR0p8zbUwnrcJcyumLVGaRqbY2p8imZajLdDJ0GKsx95OKdc6 cTHUJHaRbaEBXDBb8FyuObwq0KzPj6MkmIcbi8YFU33z2ZctToJhDcIsbaAu6IJTvwYq DDW6l+NnUE794+/wlqoTCzpcdu10ZLW4/roEAYXijyg9JqWkL5HzAIPQ7fMMqCjqjvlr oyGorQZ+lE3yTxcGEy5f07EABob5gDj96LFLBMN4p0Hm8UAGQqz26stCrO1RwvqDFPRq i0DEqT70fvaSzx60XF6hHWYrrHJNVvi08GtJUJPPKZ2gfjj3QLMH+4sv2nsyU+SDbjn8 QQ7w== X-Gm-Message-State: AIVw112RJ1sv1aGZ+4tE4GMKPpVSzX7m0aK45CP/0Uqc+wp97ZFTenFn ZCilkdZ13HPpnEa2 X-Received: by 10.36.215.199 with SMTP id y190mr6423038itg.68.1501961012114; Sat, 05 Aug 2017 12:23:32 -0700 (PDT) Received: from zony ([45.2.119.48]) by smtp.googlemail.com with ESMTPSA id 70sm2085554iop.77.2017.08.05.12.23.31 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 12:23:31 -0700 (PDT) From: npostavs@users.sourceforge.net To: control@debbugs.gnu.org Subject: control message for bug #27968 Date: Sat, 05 Aug 2017 15:25:11 -0400 Message-ID: <87fud56cmg.fsf@users.sourceforge.net> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.7 (/) tags 27968 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 06 00:15:42 2017 Received: (at 27968-done) by debbugs.gnu.org; 6 Aug 2017 04:15:42 +0000 Received: from localhost ([127.0.0.1]:43981 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCyc-00082E-Eb for submit@debbugs.gnu.org; Sun, 06 Aug 2017 00:15:42 -0400 Received: from mail-pg0-f51.google.com ([74.125.83.51]:37274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deCya-000820-72 for 27968-done@debbugs.gnu.org; Sun, 06 Aug 2017 00:15:40 -0400 Received: by mail-pg0-f51.google.com with SMTP id y129so21912414pgy.4 for <27968-done@debbugs.gnu.org>; Sat, 05 Aug 2017 21:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=820PD8urs/f5Oj9djVAzEt2PbLI2gjIGxeF8NbLvKAs=; b=llR+5rfAKVTsKrEfgTPWD8Iv+ybEKtpqo5zYquhDuHEyjqfZOMFLaz0znAhid+XEyB KkHBgum2py0JPfa1WOFNgXDcAEZR3sSTC+0tnmxs6wTn4/cUGvxySSgxVG1ajzVDjrAW uiDpiDGrbnPXGoW2sA4G43LyVSh/U4cfrBzuAMIUgsAz2i2D4CWgvDBKH0ZUQFXFrLly fdicFSPShg6Yo5u5KQm9UpXOGSf7Cez0NwUqrxMvAQR/AJ0RghKTsVJbTeqxPoNs30w5 LK7NqCRvvcfS8N0aQhQsJ5yFJZOfLQzKqWlsXHgbQyV742kXGCK1LNexxAok+iOjKxAR T8tQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=820PD8urs/f5Oj9djVAzEt2PbLI2gjIGxeF8NbLvKAs=; b=Pu8tj0FQpzR0/qBUd9eCi5zI9TktVfEN4XptFVElKa+4vYzwJn/0Hx/3TWg+z0fmLv 0BiOAqCH9qBc2l381rkEwRSzLie3LnuXRcuoTcCbPuT+XSygZ70AWNJrjwChwFZaCDzC A5n1XlUorfwbnywjJOGia94XPa5md/k8YFGSZIoyMF99hu9GaCpvMVaFcTxjj5nkh7Ke U8KgksqlrjQEElAjvQUmfdD6p+n66VzsTpIDDtfrXCzkeGBhr6TQ1xV7zvCX2RCl2ZKy wyOufuEdVR/pEjfXTKbx65C9NF2Yr0XD8sRyD8qBpD5yNe3eXrtnBmc5eWntg/yQZgVh 73dA== X-Gm-Message-State: AIVw110j7ov0fgE2OT9OCZStUfRi1HY2OCA/qn0xwGV8fz4OcgYhzIWm uD7F+8CFcSnCS8Bq X-Received: by 10.99.126.86 with SMTP id o22mr7258024pgn.385.1501992934086; Sat, 05 Aug 2017 21:15:34 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id d135sm10492124pga.6.2017.08.05.21.15.32 for <27968-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 21:15:33 -0700 (PDT) From: Tino Calancha To: 27968-done@debbugs.gnu.org Subject: Re: bug#27968: 26.0.50; dired-revert: Saved positions might change if a dired header changes References: <87bmnu6udt.fsf@calancha-pc> <83h8xmupe8.fsf@gnu.org> Date: Sun, 06 Aug 2017 13:15:28 +0900 In-Reply-To: (Tino Calancha's message of "Sun, 6 Aug 2017 00:45:02 +0900 (JST)") Message-ID: <87mv7dmivz.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 27968-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) Tino Calancha writes: > On Sat, 5 Aug 2017, Eli Zaretskii wrote: > >>> One possible solution is the patch below. It saves line numbers >>> instead of positions. Line numbers won't change if a dired header >>> changes its length. >> >> Won't using markers be a better solution? > Yes, but `dired-revert' erases the buffer when calls > `dired-readin', so that the markers will be gone, *) I really want to have buildboot clean again (http://emacs.bioswarm.net:8010/#/), in order to this tool be effective to catch new problems. *) so i pushed a fix in master branch as commit 7c3593f81724d0c7a2ee2f90797db0e705adc859 (dired-revert: save line numbers instead of positions) From unknown Mon Jun 23 02:22:10 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Sep 2017 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator