GNU bug report logs - #27959
26.0.50; File renaming fails on sshfs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27959 in the body.
You can then email your comments to 27959 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.0.50; File renaming fails on sshfs
Date: Fri, 04 Aug 2017 23:38:14 +0200

/tv is mounted via sshfs.

(rename-file "/tv/a.foo" "/tv/b.foo")

Debugger entered--Lisp error: (file-error "Renaming" "Invalid argument" "/tv/a.foo" "/tv/b.foo")
  rename-file("/tv/a.foo" "/tv/b.foo")
  eval((rename-file "/tv/a.foo" "/tv/b.foo") nil)
  eval-expression((rename-file "/tv/a.foo" "/tv/b.foo") nil nil 127)
  funcall-interactively(eval-expression (rename-file "/tv/a.foo" "/tv/b.foo") nil nil 127)
  call-interactively(eval-expression nil nil)
  command-execute(eval-expression)

But if I say

larsi <at> amy:~$ mv /tv/a.foo /tv/b.foo

on the same machine, it works fine.  So ... where is the "Invalid
argument" coming from?

Renaming on non-sshfs file systems works fine in Emacs.


In GNU Emacs 26.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.22.11)
 of 2017-08-02 built on amy
Repository revision: fe80d58ca4ead89e8887aa726482694888a8ef7f
Windowing system distributor 'The X.Org Foundation', version 11.0.11903000
System Description:	Ubuntu 17.04

Message #8 received at 27959 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>, 27959 <at> debbugs.gnu.org
Subject: Re: bug#27959: 26.0.50; File renaming fails on sshfs
Date: Sat, 05 Aug 2017 08:24:41 +0000

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> schrieb am Fr., 4. Aug. 2017 um
23:39 Uhr:

>
> /tv is mounted via sshfs.
>
> (rename-file "/tv/a.foo" "/tv/b.foo")
>
> Debugger entered--Lisp error: (file-error "Renaming" "Invalid argument"
> "/tv/a.foo" "/tv/b.foo")
>   rename-file("/tv/a.foo" "/tv/b.foo")
>   eval((rename-file "/tv/a.foo" "/tv/b.foo") nil)
>   eval-expression((rename-file "/tv/a.foo" "/tv/b.foo") nil nil 127)
>   funcall-interactively(eval-expression (rename-file "/tv/a.foo"
> "/tv/b.foo") nil nil 127)
>   call-interactively(eval-expression nil nil)
>   command-execute(eval-expression)
>
> But if I say
>
> larsi <at> amy:~$ mv /tv/a.foo /tv/b.foo
>
> on the same machine, it works fine.  So ... where is the "Invalid
> argument" coming from?
>

Probably more fallout of 1f9f514e7c2ba41b0954d0141f99652f6a53a107. Does it
work if you compile without that commit (e.g. git reset --hard
1f9f514e7c2ba41b0954d0141f99652f6a53a107^ from a clean working directory)?

[Message part 2 (text/html, inline)]

Message #11 received at 27959 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 27959 <at> debbugs.gnu.org
Subject: Re: bug#27959: 26.0.50; File renaming fails on sshfs
Date: Sat, 05 Aug 2017 11:24:38 +0200

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

> Probably more fallout of 1f9f514e7c2ba41b0954d0141f99652f6a53a107.
> Does it work if you compile without that commit (e.g. git reset --hard
> 1f9f514e7c2ba41b0954d0141f99652f6a53a107^ from a clean working
> directory)? 

Yes, renaming files on sshfs works again if I build after doing that git
command.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 27959 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 27959 <at> debbugs.gnu.org
Subject: Re: bug#27959: 26.0.50; File renaming fails on sshfs
Date: Sat, 05 Aug 2017 20:51:21 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Philipp Stephani <p.stephani2 <at> gmail.com> writes:
>
>> Probably more fallout of 1f9f514e7c2ba41b0954d0141f99652f6a53a107.
>> Does it work if you compile without that commit (e.g. git reset --hard
>> 1f9f514e7c2ba41b0954d0141f99652f6a53a107^ from a clean working
>> directory)? 
>
> Yes, renaming files on sshfs works again if I build after doing that git
> command.

Paul, I'm just Cc-ing you this bug report in case you didn't see it --
it relates to changes you've made recently and that makes renaming files
on certain file systems not work any more.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 27959 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 27959 <at> debbugs.gnu.org
Subject: Re: bug#27959: 26.0.50; File renaming fails on sshfs
Date: Sat, 5 Aug 2017 13:59:49 -0700

Lars Ingebrigtsen wrote:
> Paul, I'm just Cc-ing you this bug report in case you didn't see it --
> it relates to changes you've made recently and that makes renaming files
> on certain file systems not work any more.

Thanks, I hadn't seen that bug report. I think that I fixed that bug in commit 
ddc1ff58dec92a782b233d97a254fc41c1c887eb dated Thu Aug 3 16:18:45 2017 -0700, so 
please try pulling from master and rebuilding.

Message #22 received at 27959-done <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 27959-done <at> debbugs.gnu.org
Subject: Re: bug#27959: 26.0.50; File renaming fails on sshfs
Date: Sat, 05 Aug 2017 23:09:30 +0200

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> Thanks, I hadn't seen that bug report. I think that I fixed that bug
> in commit ddc1ff58dec92a782b233d97a254fc41c1c887eb dated Thu Aug 3
> 16:18:45 2017 -0700, so please try pulling from master and rebuilding.

Ah, thanks; this does indeed seem to be fixed now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.