GNU bug report logs - #27953
vc-region-history doesn't follow renames

Previous Next

Full log

View this message in rfc822 format

From: Clément Pit--Claudel <clement.pitclaudel <at> live.com>
To: Stefan Monnier <monnier <at> IRO.UMontreal.CA>
Cc: 27953 <at> debbugs.gnu.org
Subject: bug#27953: vc-region-history doesn't follow renames
Date: Sat, 5 Aug 2017 15:06:00 +0200

[Message part 1 (text/plain, inline)]

On 2017-08-04 19:21, Stefan Monnier wrote:
>> Indeed, `git log -p --follow -L5,25:file.c' doesn't work.  But `git
>> log -p --follow -L5,25:file.c file.c' does work (note the extra mention of
>> the file name).
> 
> Hmm... what's the difference between
> 
>     git log -p -L5,25:file.c
> and
>     git log -p -L5,25:file.c file.c

The second one allows --follow; the first one doesn't.  I don't know what differences they may be beyond that :/

> Would this issue deserve a bug-report to Git?

Possibly; it's a bit intimidating.

>> Any arguments against the attached patch?
> 
> I'd suggest to compute (file-relative-name file) only once, and to add
> bug#27953 to the comment, but otherwise, looks good.

Attached an updated version :)

Clément.

[0001-Follow-renames-in-vc-git-region-history.patch (text/x-patch, attachment)]

[signature.asc (application/pgp-signature, attachment)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.