GNU bug report logs - #27952
26.0.50; Combine archive-int-to-mode and tar-grind-file-mode

Previous Next

Package: emacs;

Reported by: Tino Calancha <tino.calancha <at> gmail.com>

Date: Fri, 4 Aug 2017 13:55:01 UTC

Severity: wishlist

Tags: patch

Found in version 26.0.50

Done: Tino Calancha <tino.calancha <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: 27952 <at> debbugs.gnu.org, Lars Ingebrigtsen <larsi <at> gnus.org>, Stefan Kangas <stefan <at> marxist.se>
Subject: bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode
Date: Fri, 08 May 2020 16:06:27 -0400

> +(defalias 'archive-int-to-mode 'file-modes-number-to-symbolic)

Make it a `define-obsolete-function-alias`.

>  (defun tar-grind-file-mode (mode)
>    "Construct a `rw-r--r--' string indicating MODE.
[...]
> +MODE should be an integer which is a file mode value.
> +For instance, if mode is #o700, then it produces `rwx------'."
> +  (substring (file-modes-number-to-symbolic mode) 1))

LGTM.  A second step might be to mark this function as obsolete and
update all the call sites so they are happy with the output format of
`file-modes-number-to-symbolic`.


        Stefan
This bug report was last modified 5 years and 86 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.