GNU bug report logs - #27952
26.0.50; Combine archive-int-to-mode and tar-grind-file-mode

Previous Next

Full log

Message #22 received at 27952 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: npostavs <at> users.sourceforge.net
Cc: Eli Zaretskii <eliz <at> gnu.org>, 27952 <at> debbugs.gnu.org,
 stefan monnier <monnier <at> iro.umontreal.ca>,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#27952: 26.0.50; Combine archive-int-to-mode and
 tar-grind-file-mode
Date: Wed, 16 Aug 2017 22:13:48 +0900 (JST)

On Wed, 16 Aug 2017, npostavs <at> users.sourceforge.net wrote:

> Tino Calancha <tino.calancha <at> gmail.com> writes:
>
>> +                          (replace-regexp-in-string
>> +                           ",\\`" ""
>
> This regex doesn't match anything, did you mean \\' at the end?
Yes, you are right.  I wanted to drop comma at the end.

>>  (defun tar-grind-file-mode (mode)
>>    "Construct a `rw-r--r--' string indicating MODE.
>
>> +MODE should be an integer which is a file mode value.
>> +For instance, if mode is 448, then it produces `rwx------'."
>
> IMO, it's clearer if you write #o700 instead of 448 here, perhaps in the
> code too.
Yeah, for those people not having nbc.el (num-base-converters) might be
easier to follow.  Opps, i am the only one having nbc.el! :-)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.