GNU bug report logs - #27952
26.0.50; Combine archive-int-to-mode and tar-grind-file-mode

Previous Next

Full log

Message #19 received at 27952 <at> debbugs.gnu.org (full text, mbox):

From: Tino Calancha <tino.calancha <at> gmail.com>
To: Andreas Schwab <schwab <at> suse.de>
Cc: 27952 <at> debbugs.gnu.org, stefan monnier <monnier <at> iro.umontreal.ca>,
 Tino Calancha <tino.calancha <at> gmail.com>
Subject: Re: bug#27952: 26.0.50; Combine archive-int-to-mode and
 tar-grind-file-mode
Date: Wed, 16 Aug 2017 22:10:17 +0900 (JST)

On Wed, 16 Aug 2017, Andreas Schwab wrote:

> On Aug 16 2017, Tino Calancha <tino.calancha <at> gmail.com> wrote:
>
>> +Note: This is not the inverse of `file-modes-symbolic-to-number';
>> +The reason is that this function might return an string containing 'S'
>> +or 'T' i.e., not valid characters for `file-modes-symbolic-to-number'.
>> +For example, (file-modes-symbolic-to-number \"o=t\") returns 512;
>> +and (file-modes-number-to-symbolic 512 t) returns \"o=T\"."
>
> Why would it use uppercase T in the detailed case?  Uppercase is only
> needed when it would overlay the 'x' position in the non-detailed case.
Not special reason i think.  To keep more similar with
the case when DETAILED is nil.
 (file-modes-number-to-symbolic 512)
=> "---------T"

At the end of the function that is changed into
"o=T"
with:

(funcall replace-fn
   (replace-regexp-in-string
      "-" "" ...

I liked like this when i wrote the patch.  We could changed it in
case is confusing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.