GNU bug report logs - #27952
26.0.50; Combine archive-int-to-mode and tar-grind-file-mode

Previous Next

Full log

Message #13 received at 27952 <at> debbugs.gnu.org (full text, mbox):

From: npostavs <at> users.sourceforge.net
To: Tino Calancha <tino.calancha <at> gmail.com>
Cc: Eli Zaretskii <eliz <at> gnu.org>, 27952 <at> debbugs.gnu.org,
 stefan monnier <monnier <at> iro.umontreal.ca>
Subject: Re: bug#27952: 26.0.50;
 Combine archive-int-to-mode and tar-grind-file-mode
Date: Wed, 16 Aug 2017 08:00:03 -0400

Tino Calancha <tino.calancha <at> gmail.com> writes:

> +                          (replace-regexp-in-string
> +                           ",\\`" ""

This regex doesn't match anything, did you mean \\' at the end?

>  (defun tar-grind-file-mode (mode)
>    "Construct a `rw-r--r--' string indicating MODE.

> +MODE should be an integer which is a file mode value.
> +For instance, if mode is 448, then it produces `rwx------'."

IMO, it's clearer if you write #o700 instead of 448 here, perhaps in the
code too.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.