Subject: Re: bug#27952: 26.0.50; Combine archive-int-to-mode and tar-grind-file-mode

From: Tino Calancha <[email-masked]>
Date: Wed, 16 Aug 2017 22:13:48 +0900 (JST)

On Wed, 16 Aug 2017, [email-masked] wrote:

> Tino Calancha <[email-masked]> writes:
>
>> +                          (replace-regexp-in-string
>> +                           ",\\`" ""
>
> This regex doesn't match anything, did you mean \\' at the end?
Yes, you are right.  I wanted to drop comma at the end.

>>  (defun tar-grind-file-mode (mode)
>>    "Construct a `rw-r--r--' string indicating MODE.
>
>> +MODE should be an integer which is a file mode value.
>> +For instance, if mode is 448, then it produces `rwx------'."
>
> IMO, it's clearer if you write #o700 instead of 448 here, perhaps in the
> code too.
Yeah, for those people not having nbc.el (num-base-converters) might be
easier to follow.  Opps, i am the only one having nbc.el! :-)