From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 02 09:32:46 2017 Received: (at submit) by debbugs.gnu.org; 2 Aug 2017 13:32:46 +0000 Received: from localhost ([127.0.0.1]:37848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dctlR-0003o3-U1 for submit@debbugs.gnu.org; Wed, 02 Aug 2017 09:32:46 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dctlQ-0003ns-SY for submit@debbugs.gnu.org; Wed, 02 Aug 2017 09:32:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dctlK-0005H7-CX for submit@debbugs.gnu.org; Wed, 02 Aug 2017 09:32:35 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=BAYES_20,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:42303) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dctlK-0005Gp-8d for submit@debbugs.gnu.org; Wed, 02 Aug 2017 09:32:34 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:41523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dctlD-00035l-UB for guix-patches@gnu.org; Wed, 02 Aug 2017 09:32:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dctl2-000519-Nv for guix-patches@gnu.org; Wed, 02 Aug 2017 09:32:20 -0400 Received: from serenity.mcc.ac.uk ([130.88.200.93]:36248) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dctl2-0004xm-A7 for guix-patches@gnu.org; Wed, 02 Aug 2017 09:32:16 -0400 Received: from asmtp2.its.manchester.ac.uk ([130.88.13.150]) by serenity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dctl0-000FRx-ER for guix-patches@gnu.org; Wed, 02 Aug 2017 14:32:14 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:60706 helo=i-ulialbion.it.manchester.ac.uk) by asmtp2.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dctl0-0000Vy-4f for guix-patches@gnu.org; Wed, 02 Aug 2017 14:32:14 +0100 From: Dave Love To: guix-patches@gnu.org Subject: libnl additions Date: Wed, 02 Aug 2017 14:32:13 +0100 Message-ID: <87r2wu5c4i.fsf@i-ulialbion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="National-infrastructure-David-John-Oates-embassy-Lexis-Nexis-Ft.-" X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk (i-ulialbion.it.manchester.ac.uk) [130.88.138.79]:60706 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.150 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on serenity.mcc.ac.uk); SAEximRunCond expanded to false X-detected-operating-system: by eggs.gnu.org: FreeBSD 9.x [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --National-infrastructure-David-John-Oates-embassy-Lexis-Nexis-Ft.- Content-Type: text/plain These put the extra bits from what I previously did as libnl3 into libnl. I don't know whether the handling of the Python interface is the right way to do it, but I don't think the Python is important anyway -- Debian doesn't ship it. --National-infrastructure-David-John-Oates-embassy-Lexis-Nexis-Ft.- Content-Type: text/x-diff Content-Disposition: attachment; filename=0003-gnu-libnl-Add-doc-output.patch >From d4986401bfcb2eacd7c7f437a50ca85d752cc904 Mon Sep 17 00:00:00 2001 From: Dave Love Date: Wed, 2 Aug 2017 12:09:02 +0100 Subject: [PATCH 3/4] gnu: libnl: Add "doc" output. * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc source. [arguments]: New field. --- gnu/packages/linux.scm | 25 ++++++++++++++++++++++++- 1 file changed, 24 insertions(+), 1 deletion(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index a189458ad..3902560a8 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -1463,7 +1463,30 @@ transparently through a bridge.") (base32 "1r3lw3hjvqxi5zqyq2w1qadm3gisd9nlf71dkl4yplacmssnhm3h")))) (build-system gnu-build-system) - (native-inputs `(("flex" ,flex) ("bison" ,bison))) + (native-inputs + `(("flex" ,flex) ("bison" ,bison) + ("libnl3-doc" + ,(origin + (method url-fetch) + (uri (string-append + "https://github.com/thom311/libnl/releases/download/libnl" + (string-join (string-split version #\.) "_") + "/libnl-doc-" version ".tar.gz")) + (sha256 + (base32 "0srab805yj8wb13l64qjyp3mdbqapxg5vk46v3zlhhzpmxqw8j7r")))))) + (outputs '("out" "doc")) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'install 'install-doc + (lambda* (#:key inputs outputs #:allow-other-keys) + (let ((dest (format #f "~a/share/doc" + (assoc-ref outputs "doc")))) + (mkdir-p dest) + (with-directory-excursion dest + (and + (zero? (system* "tar" "xf" (assoc-ref inputs "libnl3-doc"))) + (zero? (system "mv *libnl-doc* libnl3")))))))))) (home-page "http://www.infradead.org/~tgr/libnl/") (synopsis "NetLink protocol library suite") (description -- 2.11.0 --National-infrastructure-David-John-Oates-embassy-Lexis-Nexis-Ft.- Content-Type: text/x-diff Content-Disposition: attachment; filename=0004-gnu-libnl-Add-python2-and-python3-outputs.patch >From e64186082735f533bf172fcad491eaabed2928f0 Mon Sep 17 00:00:00 2001 From: Dave Love Date: Wed, 2 Aug 2017 13:39:28 +0100 Subject: [PATCH 4/4] gnu: libnl: Add "python2" and "python3" outputs. * gnu/packages/linux.scm (libnl)[native-inputs]: Extend. [outputs]: Add python2, python3. [install-python]: New phase. --- gnu/packages/linux.scm | 27 +++++++++++++++++++++++++-- 1 file changed, 25 insertions(+), 2 deletions(-) diff --git a/gnu/packages/linux.scm b/gnu/packages/linux.scm index 3902560a8..dd9c34999 100644 --- a/gnu/packages/linux.scm +++ b/gnu/packages/linux.scm @@ -101,6 +101,7 @@ #:use-module (gnu packages xorg) #:use-module (gnu packages groff) #:use-module (gnu packages selinux) + #:use-module (gnu packages swig) #:use-module (guix build-system cmake) #:use-module (guix build-system gnu) #:use-module (guix build-system python) @@ -1464,7 +1465,12 @@ transparently through a bridge.") "1r3lw3hjvqxi5zqyq2w1qadm3gisd9nlf71dkl4yplacmssnhm3h")))) (build-system gnu-build-system) (native-inputs - `(("flex" ,flex) ("bison" ,bison) + `(("flex" ,flex) + ("bison" ,bison) + ("python-2" ,python-2) + ("python-3" ,python-3) + ("swig" ,swig) + ("pkg-config" ,pkg-config) ("libnl3-doc" ,(origin (method url-fetch) @@ -1474,10 +1480,27 @@ transparently through a bridge.") "/libnl-doc-" version ".tar.gz")) (sha256 (base32 "0srab805yj8wb13l64qjyp3mdbqapxg5vk46v3zlhhzpmxqw8j7r")))))) - (outputs '("out" "doc")) + (outputs '("out" "doc" "python2" "python3")) (arguments `(#:phases (modify-phases %standard-phases + (add-after 'install 'install-python + (lambda* (#:key outputs #:allow-other-keys) + (define (python-inst python) + (let ((ldflags (format #f "LDFLAGS=-Wl,-rpath=~a/lib" + (assoc-ref %outputs "out"))) + (pyout (assoc-ref %outputs python))) + (and + ;; The rpm spec quoth "build twice, otherwise capi.py is + ;; not copied to the build directory" + (zero? (system (format #f "~a ~a setup.py build" + ldflags python pyout))) + (zero? + (system (format #f "~a ~a setup.py install --prefix=~a" + ldflags python pyout))) + (zero? (system* python "setup.py" "clean"))))) + (with-directory-excursion "./python" + (for-each python-inst '("python2" "python3"))))) (add-after 'install 'install-doc (lambda* (#:key inputs outputs #:allow-other-keys) (let ((dest (format #f "~a/share/doc" -- 2.11.0 --National-infrastructure-David-John-Oates-embassy-Lexis-Nexis-Ft.--- From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 17 17:55:25 2017 Received: (at 27915-done) by debbugs.gnu.org; 17 Aug 2017 21:55:25 +0000 Received: from localhost ([127.0.0.1]:43250 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diSlB-0003Tz-7B for submit@debbugs.gnu.org; Thu, 17 Aug 2017 17:55:25 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:49015) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1diSl9-0003Ts-Nl for 27915-done@debbugs.gnu.org; Thu, 17 Aug 2017 17:55:24 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 8402220C10; Thu, 17 Aug 2017 17:55:20 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute5.internal (MEProxy); Thu, 17 Aug 2017 17:55:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=J5eG1+4xxGbS6hAhyCh4GCE4qEzVgNsQ0K2iV8/3y bk=; b=AUtXejjqUmha/rXl45aXLMX0Cbc0GGU+62G7uaBbXpX17FV+g2Bk7YOYW hXk8e4217SaHUr2O8lZrGDwrPtHzt9vF5La7bh9sts/viG5Ivx/O43An0nf+1Pg9 boFsnEmr+rdV7bouUs2DkMLaN5Mjoa3E6RO23yG1H57zNA77nQLmcv7M93IMFiiN XgIEoAGoH5YBOBfwkT6jv4AzfemVfwzwPdlAwjw4C1jCT7VKxaAXw2XqRx5MjwL7 nX0dAY4o+4NG79zACOo5Mzhtm9Nt2IFzleCZ0lsMCyLO44HPCxTSumzWf5FZ9d1g xsNIZ8JigwaooGEv9YdqZhEZJ+IFg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=J5eG1+4xxGbS6hAhyC h4GCE4qEzVgNsQ0K2iV8/3ybk=; b=kWczROy30D5jcEqeMaC0IIyEzeraPjSCVn Ot2/Tus+/RyLEXw2mnBKA2PcJBh0cBa5FikyeBPYO6Rc9tr9JhOrQ7T/wVV0cK7a vzk38lr6p+g+sVKC91fyvxdiNSQ26Bd8fgeCOa/U0+mHUqKimOfkTXpJr8WYwL04 sE/1GZGkdvs9XXA8aDHJfXZoAYPyb6wF9nIaz/1qzWEK8OfHM4XmlQo1qyJJQpWm iJ7yuELjwa69D4tQT3VDj0YbKaAEiHpnEIK7H1baPgKFfU0UaA/MSceWQRp1y44Z ewFFDzAqbSfORqQUwP15Sr9u+QY44zqI7r1wArdiqhC5NfPUJEIg== X-ME-Sender: X-Sasl-enc: lgI5qOZU+OPs5tBnrBVH7Jjrj6PDuhFet8Z1B5IjDaQc 1503006920 Received: from localhost (unknown [188.113.81.93]) by mail.messagingengine.com (Postfix) with ESMTPA id 2AE017F985; Thu, 17 Aug 2017 17:55:20 -0400 (EDT) From: Marius Bakke To: Dave Love , 27915-done@debbugs.gnu.org Subject: Re: [bug#27915] libnl additions In-Reply-To: <87r2wu5c4i.fsf@i-ulialbion.it.manchester.ac.uk> References: <87r2wu5c4i.fsf@i-ulialbion.it.manchester.ac.uk> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Thu, 17 Aug 2017 23:54:54 +0200 Message-ID: <87d17tzwpd.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27915-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dave Love writes: > These put the extra bits from what I previously did as libnl3 into > libnl. I don't know whether the handling of the Python interface is the > right way to do it, but I don't think the Python is important anyway -- > Debian doesn't ship it. Hello Dave, Sorry for the delay, these fell through the cracks a bit. To save these patches from bitrot, I went ahead and applied them with some changes, detailed below. Hope I didn't mess anything up! > From d4986401bfcb2eacd7c7f437a50ca85d752cc904 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Wed, 2 Aug 2017 12:09:02 +0100 > Subject: [PATCH 3/4] gnu: libnl: Add "doc" output. > > * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc source. > [arguments]: New field. I ended up rewriting the install-doc phase so that it extracts directly to the "doc" output, and adjusted the commit message slightly.=20=20 > From e64186082735f533bf172fcad491eaabed2928f0 Mon Sep 17 00:00:00 2001 > From: Dave Love > Date: Wed, 2 Aug 2017 13:39:28 +0100 > Subject: [PATCH 4/4] gnu: libnl: Add "python2" and "python3" outputs. > > * gnu/packages/linux.scm (libnl)[native-inputs]: Extend. Please mention all changed inputs here (e.g. for grepping purposes). > [outputs]: Add python2, python3. > [install-python]: New phase. > (native-inputs > - `(("flex" ,flex) ("bison" ,bison) > + `(("flex" ,flex) > + ("bison" ,bison) > + ("python-2" ,python-2) > + ("python-3" ,python-3) The Pythons here need to be regular inputs since they are referenced. > + (add-after 'install 'install-python > + (lambda* (#:key outputs #:allow-other-keys) > + (define (python-inst python) > + (let ((ldflags (format #f "LDFLAGS=3D-Wl,-rpath=3D~a/li= b" > + (assoc-ref %outputs "out"))) > + (pyout (assoc-ref %outputs python))) > + (and > + ;; The rpm spec quoth "build twice, otherwise capi.p= y is > + ;; not copied to the build directory" I went ahead and removed this comment since we are not an RPM derived distro, and always run "setup.py build" before "install" anyway. > + (zero? (system (format #f "~a ~a setup.py build" > + ldflags python pyout))) > + (zero? > + (system (format #f "~a ~a setup.py install --prefix= =3D~a" > + ldflags python pyout))) > + (zero? (system* python "setup.py" "clean"))))) > + (with-directory-excursion "./python" > + (for-each python-inst '("python2" "python3"))))) (for-each ...) does not check (or preserve) the return value, so I changed this to use (every ...) from SRFI-1. Thanks for the patches! --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmWEK4ACgkQoqBt8qM6 VPrI+ggAi4t6J1278Pz7/j9KJEXtUM1ByttTauQPqw4GHeAxy6eSoDuyUBA9C5p+ MXEMXaswNPg2KBffVc/tLHh6oxuODECnJLozd7Ozmc8TOlXxqHKPlRgndQed0hai 4ZVa/+CihEua1PqC9+2s1Hju4Zx4TDPA02b3gLP86e2eiz/pO5LTpoO4Gm8zooAi jwsfNg3i4piMzDC5sumwa6rij86Llnkfp2Ci6C5v5ltPR5hshDHr0i36LjOk/GmP x9CZOe1BlZ4TTgmgHEoVwpMxiNywi3c3+KaGO/3Ge9wlI5ZTL8vpR+1QoMcL62/k 3LQbzZrf1PMdgkUjoipGeO+eq0qIyA== =KKFO -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Aug 23 06:15:44 2017 Received: (at 27915-done) by debbugs.gnu.org; 23 Aug 2017 10:15:44 +0000 Received: from localhost ([127.0.0.1]:50383 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkShL-0002hC-SH for submit@debbugs.gnu.org; Wed, 23 Aug 2017 06:15:44 -0400 Received: from clarity.mcc.ac.uk ([130.88.200.144]:33464) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkShK-0002h4-4G for 27915-done@debbugs.gnu.org; Wed, 23 Aug 2017 06:15:42 -0400 Received: from asmtp1.its.manchester.ac.uk ([130.88.13.149]) by clarity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dkShJ-000I1c-1G; Wed, 23 Aug 2017 11:15:41 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:34184) by asmtp1.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dkShI-0004iy-OV; Wed, 23 Aug 2017 11:15:40 +0100 From: Dave Love To: Marius Bakke Subject: Re: [bug#27915] libnl additions References: <87r2wu5c4i.fsf@i-ulialbion.it.manchester.ac.uk> <87d17tzwpd.fsf@fastmail.com> X-Draft-From: ("Misc" 2571) Date: Wed, 23 Aug 2017 11:15:40 +0100 In-Reply-To: <87d17tzwpd.fsf@fastmail.com> (Marius Bakke's message of "Thu, 17 Aug 2017 23:54:54 +0200") Message-ID: <87pobmh9o3.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:34184 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.149 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on clarity.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 27915-done Cc: 27915-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Marius Bakke writes: > Sorry for the delay, these fell through the cracks a bit. No worries; thanks. I don't mean to argue below, just explain. Apologies if this re-opens the issue -- I can't remember what debbugs does. >> * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc source. >> [arguments]: New field. > > I ended up rewriting the install-doc phase so that it extracts directly > to the "doc" output, and adjusted the commit message slightly. I wondered about that, but just did it as in rpm. For info, are there policy or technical reasons for it? > Please mention all changed inputs here (e.g. for grepping purposes). > >> [outputs]: Add python2, python3. >> [install-python]: New phase. >> (native-inputs >> - `(("flex" ,flex) ("bison" ,bison) >> + `(("flex" ,flex) >> + ("bison" ,bison) >> + ("python-2" ,python-2) >> + ("python-3" ,python-3) > > The Pythons here need to be regular inputs since they are referenced. I think the documentation could do with clarification in this area; I'll make a bug report about what's unclear to me. (For what it's worth, I thought regular inputs would propagate to "out", and it wouldn't be important to depend on Python for the Python outputs.) >> + (add-after 'install 'install-python >> + (lambda* (#:key outputs #:allow-other-keys) >> + (define (python-inst python) >> + (let ((ldflags (format #f "LDFLAGS=-Wl,-rpath=~a/lib" >> + (assoc-ref %outputs "out"))) >> + (pyout (assoc-ref %outputs python))) >> + (and >> + ;; The rpm spec quoth "build twice, otherwise capi.py is >> + ;; not copied to the build directory" > > I went ahead and removed this comment since we are not an RPM derived > distro, and always run "setup.py build" before "install" anyway. [I just meant to note an apparent deficiency documented elsewhere that might be relevant before the install step, e.g. in tests; I do the same for rpm if I'm looking at an existing dpkg.] It's probably worth specifying using build before install in the manual if that's required. From debbugs-submit-bounces@debbugs.gnu.org Thu Aug 24 14:11:12 2017 Received: (at 27915-done) by debbugs.gnu.org; 24 Aug 2017 18:11:12 +0000 Received: from localhost ([127.0.0.1]:53142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkway-0006rG-3k for submit@debbugs.gnu.org; Thu, 24 Aug 2017 14:11:12 -0400 Received: from out2-smtp.messagingengine.com ([66.111.4.26]:41341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dkwaw-0006r8-7w for 27915-done@debbugs.gnu.org; Thu, 24 Aug 2017 14:11:06 -0400 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 2FACF2143F; Thu, 24 Aug 2017 14:11:06 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute5.internal (MEProxy); Thu, 24 Aug 2017 14:11:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=NojlqEiC7g5NdPl2IE6H/n1fT1+3gPNhrMsnWfBb8 6Y=; b=xUu9yPISLS+Y+ZNOOGGY2DrzSKBGUkXl59d2bsWLygGLZcxSCeoiUV5Zs Axp6A455zdyaGWZOKH141aLMlvxi4xo9cpQQSkbnTAqggVrgqxIOauipIyCcll7m Y3ULbrGQWbqx1xsFZlzKR5iHVWe+UJAAvoccKKyRkqNQZcXzjM8QJ9jhYIMCUfue 9z9JYb6xM1kTP2sMiIjFR+h75EMtDJQNhwzwCuxHFimTQKG+hzRYtI+IwxnQnNKi yhVCZCpeerHGYj1U7OAyyR9hE+21R9nGPY/sO1qCeGxCyVzLne4pIhwCqqC+5ZN/ 3eIvSXsK+bnQkiJsmftTDUz3Ci2ZQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=NojlqEiC7g5NdPl2IE 6H/n1fT1+3gPNhrMsnWfBb86Y=; b=CxwP27M1+ZqKNd5KddBk/1MJjXvEcWlPTX 2xBUAunzLvObsyRS0aih/tqsIAPgQgZO18wQV3gzfKr2qpnPUI4z8jBV/Xb194iy lKl6mMiSDNhYQEK5+VI37NaTxOgoXgzai4ahmq8hxEQlBbqFPYh3QxpRyL0I7O82 ifRPU5x4yyfZn4MNXOj8mCCzKWUzIOurN3lDieF33w78dXoFDdKUXFc+V/ogLtMO h0DPiilp9P7U4lTyCB3MgXpIUJTpPIbyv2xkp9fEQtqaSRvGqvVT3RClyLgeabKB JfmYezPwX/NsfLWtfKw7uTr823u9zVmhLsE8fmyuzlz9D/YufIVg== X-ME-Sender: X-Sasl-enc: 0O/YlBuRJmoc8XXaLCo0fODP2gN0gk9zvolhK3/XOx+b 1503598265 Received: from localhost (unknown [92.62.32.184]) by mail.messagingengine.com (Postfix) with ESMTPA id AA0B9245A8; Thu, 24 Aug 2017 14:11:05 -0400 (EDT) From: Marius Bakke To: Dave Love Subject: Re: [bug#27915] libnl additions In-Reply-To: <87pobmh9o3.fsf@albion.it.manchester.ac.uk> References: <87r2wu5c4i.fsf@i-ulialbion.it.manchester.ac.uk> <87d17tzwpd.fsf@fastmail.com> <87pobmh9o3.fsf@albion.it.manchester.ac.uk> User-Agent: Notmuch/0.25 (https://notmuchmail.org) Emacs/25.2.1 (x86_64-unknown-linux-gnu) Date: Thu, 24 Aug 2017 20:11:03 +0200 Message-ID: <87mv6o25vs.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27915-done Cc: 27915-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Dave Love writes: > Marius Bakke writes: > >> Sorry for the delay, these fell through the cracks a bit. > > No worries; thanks. I don't mean to argue below, just explain. > Apologies if this re-opens the issue -- I can't remember what debbugs doe= s. > >>> * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc sourc= e. >>> [arguments]: New field. >> >> I ended up rewriting the install-doc phase so that it extracts directly >> to the "doc" output, and adjusted the commit message slightly.=20=20 > > I wondered about that, but just did it as in rpm. For info, are there > policy or technical reasons for it? I did it mainly to avoid the double copy. Don't think there is any policy or clear-cut technical reason (but avoiding I/O is good). >>> [outputs]: Add python2, python3. >>> [install-python]: New phase. >>> (native-inputs >>> - `(("flex" ,flex) ("bison" ,bison) >>> + `(("flex" ,flex) >>> + ("bison" ,bison) >>> + ("python-2" ,python-2) >>> + ("python-3" ,python-3) >> >> The Pythons here need to be regular inputs since they are referenced. > > I think the documentation could do with clarification in this area; I'll > make a bug report about what's unclear to me. (For what it's worth, I > thought regular inputs would propagate to "out", and it wouldn't be > important to depend on Python for the Python outputs.) I was not sure where the references came from, just checked with `guix gc -R /gnu/store/...libnl-python2`. Looking closer, capi.so sems to be linked against the various Pythons. Documentation updates greatly appreciated! >>> + (add-after 'install 'install-python >>> + (lambda* (#:key outputs #:allow-other-keys) >>> + (define (python-inst python) >>> + (let ((ldflags (format #f "LDFLAGS=3D-Wl,-rpath=3D~a/= lib" >>> + (assoc-ref %outputs "out"))) >>> + (pyout (assoc-ref %outputs python))) >>> + (and >>> + ;; The rpm spec quoth "build twice, otherwise capi= .py is >>> + ;; not copied to the build directory" >> >> I went ahead and removed this comment since we are not an RPM derived >> distro, and always run "setup.py build" before "install" anyway. > > [I just meant to note an apparent deficiency documented elsewhere that > might be relevant before the install step, e.g. in tests; I do the same > for rpm if I'm looking at an existing dpkg.] It's probably worth > specifying using build before install in the manual if that's required. Right. Maybe removing the comment entirely was a bit rash. I just found it confusing, since we don't explicitly build it twice, but eventually noticed that capi.py was "built" in the install step. Anyway I'm sure the comment will reappear soon enough if this deficiency indeed becomes apparent. Thanks for following up. :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlmfFrgACgkQoqBt8qM6 VPrmuggAtE5Mxx68jf3Nw4arm+vndIckMOUYkWoEeZxb3QQ2ND27pd3t+63YH/i8 jVr3X3WwrYBddAA49cxtkFnObsU7fDVTsg/NTVeUx2ILi0m0ovZ4ufHzxNzoqhM2 ShryiBWRqaH2aekVzqDrqmn3A1GssONVwPPXTnlf6Fyhcs5lhOGEa5YfHAXAEqnD i1DqdhFskDLkaKNimk/xnbin1JFUXy3SBu9FNEH1OROQjolIYM2u89s1xqPPqALf ti+KttDGkn4tjwajw+G7+EW+B1yn5CaccRqVpv0+ZuSUaURwLzRzBj/7bndMYdYt 7okYOy0j0r0XI7k9Rd999tZNy0k6og== =iGs0 -----END PGP SIGNATURE----- --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Sep 01 06:49:13 2017 Received: (at 27915-done) by debbugs.gnu.org; 1 Sep 2017 10:49:14 +0000 Received: from localhost ([127.0.0.1]:39229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnjVh-0007QF-O6 for submit@debbugs.gnu.org; Fri, 01 Sep 2017 06:49:13 -0400 Received: from serenity.mcc.ac.uk ([130.88.200.93]:40837) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dnjVg-0007Q5-A7 for 27915-done@debbugs.gnu.org; Fri, 01 Sep 2017 06:49:12 -0400 Received: from asmtp2.its.manchester.ac.uk ([130.88.13.150]) by serenity.mcc.ac.uk with esmtps (TLSv1:DHE-RSA-AES256-SHA:256) (Exim 4.85 (FreeBSD)) (envelope-from ) id 1dnjVf-000I1S-Fx; Fri, 01 Sep 2017 11:49:11 +0100 Received: from albion.it.manchester.ac.uk ([130.88.138.79]:55326) by asmtp2.its.manchester.ac.uk with esmtpsa (TLSv1.2:ECDHE-RSA-AES256-GCM-SHA384:256) (Exim 4.89) (envelope-from ) id 1dnjVf-0002Wl-5s; Fri, 01 Sep 2017 11:49:11 +0100 From: Dave Love To: Marius Bakke Subject: Re: [bug#27915] libnl additions References: <87r2wu5c4i.fsf@i-ulialbion.it.manchester.ac.uk> <87d17tzwpd.fsf@fastmail.com> <87pobmh9o3.fsf@albion.it.manchester.ac.uk> <87mv6o25vs.fsf@fastmail.com> X-Draft-From: ("Misc" 2671) Date: Fri, 01 Sep 2017 11:49:10 +0100 In-Reply-To: <87mv6o25vs.fsf@fastmail.com> (Marius Bakke's message of "Thu, 24 Aug 2017 20:11:03 +0200") Message-ID: <87h8wmzobd.fsf@albion.it.manchester.ac.uk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Authenticated-Sender: David Love from albion.it.manchester.ac.uk [130.88.138.79]:55326 X-Authenticated-From: Dave.Love@manchester.ac.uk X-SA-Exim-Connect-IP: 130.88.13.150 X-SA-Exim-Mail-From: fx@gnu.org X-SA-Exim-Scanned: No (on serenity.mcc.ac.uk); SAEximRunCond expanded to false X-Spam-Score: -5.0(?) X-Spam-Flag: NO X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: 27915-done Cc: 27915-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.3 (-) Marius Bakke writes: > Documentation updates greatly appreciated! Of course, once it's clear. Thanks for the explanations. From unknown Sun Jun 22 07:34:26 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 29 Sep 2017 11:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator