GNU bug report logs - #27915
libnl additions

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 27915 in the body.
You can then email your comments to 27915 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dave Love <fx <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: libnl additions
Date: Wed, 02 Aug 2017 14:32:13 +0100

[Message part 1 (text/plain, inline)]

These put the extra bits from what I previously did as libnl3 into
libnl.  I don't know whether the handling of the Python interface is the
right way to do it, but I don't think the Python is important anyway --
Debian doesn't ship it.

[0003-gnu-libnl-Add-doc-output.patch (text/x-diff, attachment)]

[0004-gnu-libnl-Add-python2-and-python3-outputs.patch (text/x-diff, attachment)]

Message #10 received at 27915-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Dave Love <fx <at> gnu.org>, 27915-done <at> debbugs.gnu.org
Subject: Re: [bug#27915] libnl additions
Date: Thu, 17 Aug 2017 23:54:54 +0200

[Message part 1 (text/plain, inline)]

Dave Love <fx <at> gnu.org> writes:

> These put the extra bits from what I previously did as libnl3 into
> libnl.  I don't know whether the handling of the Python interface is the
> right way to do it, but I don't think the Python is important anyway --
> Debian doesn't ship it.

Hello Dave,

Sorry for the delay, these fell through the cracks a bit.  To save these
patches from bitrot, I went ahead and applied them with some changes,
detailed below.  Hope I didn't mess anything up!

> From d4986401bfcb2eacd7c7f437a50ca85d752cc904 Mon Sep 17 00:00:00 2001
> From: Dave Love <fx <at> gnu.org>
> Date: Wed, 2 Aug 2017 12:09:02 +0100
> Subject: [PATCH 3/4] gnu: libnl: Add "doc" output.
>
> * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc source.
> [arguments]: New field.

I ended up rewriting the install-doc phase so that it extracts directly
to the "doc" output, and adjusted the commit message slightly.  

> From e64186082735f533bf172fcad491eaabed2928f0 Mon Sep 17 00:00:00 2001
> From: Dave Love <fx <at> gnu.org>
> Date: Wed, 2 Aug 2017 13:39:28 +0100
> Subject: [PATCH 4/4] gnu: libnl: Add "python2" and "python3" outputs.
>
> * gnu/packages/linux.scm (libnl)[native-inputs]: Extend.

Please mention all changed inputs here (e.g. for grepping purposes).

> [outputs]: Add python2, python3.
> [install-python]: New phase.
>      (native-inputs
> -     `(("flex" ,flex) ("bison" ,bison)
> +     `(("flex" ,flex)
> +       ("bison" ,bison)
> +       ("python-2" ,python-2)
> +       ("python-3" ,python-3)

The Pythons here need to be regular inputs since they are referenced.

> +           (add-after 'install 'install-python
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (define (python-inst python)
> +                 (let ((ldflags (format #f "LDFLAGS=-Wl,-rpath=~a/lib"
> +                                        (assoc-ref %outputs "out")))
> +                       (pyout (assoc-ref %outputs python)))
> +                   (and
> +                    ;; The rpm spec quoth "build twice, otherwise capi.py is
> +                    ;; not copied to the build directory"

I went ahead and removed this comment since we are not an RPM derived
distro, and always run "setup.py build" before "install" anyway.

> +                    (zero? (system (format #f "~a ~a setup.py build"
> +                                           ldflags python pyout)))
> +                    (zero?
> +                     (system (format #f "~a ~a setup.py install --prefix=~a"
> +                                     ldflags python pyout)))
> +                    (zero? (system* python "setup.py" "clean")))))
> +               (with-directory-excursion "./python"
> +                 (for-each python-inst '("python2" "python3")))))

(for-each ...) does not check (or preserve) the return value, so I
changed this to use (every ...) from SRFI-1.

Thanks for the patches!

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 27915-done <at> debbugs.gnu.org (full text, mbox):

From: Dave Love <fx <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27915-done <at> debbugs.gnu.org
Subject: Re: [bug#27915] libnl additions
Date: Wed, 23 Aug 2017 11:15:40 +0100

Marius Bakke <mbakke <at> fastmail.com> writes:

> Sorry for the delay, these fell through the cracks a bit.

No worries; thanks.  I don't mean to argue below, just explain.
Apologies if this re-opens the issue -- I can't remember what debbugs does.

>> * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc source.
>> [arguments]: New field.
>
> I ended up rewriting the install-doc phase so that it extracts directly
> to the "doc" output, and adjusted the commit message slightly.  

I wondered about that, but just did it as in rpm.  For info, are there
policy or technical reasons for it?

> Please mention all changed inputs here (e.g. for grepping purposes).
>
>> [outputs]: Add python2, python3.
>> [install-python]: New phase.
>>      (native-inputs
>> -     `(("flex" ,flex) ("bison" ,bison)
>> +     `(("flex" ,flex)
>> +       ("bison" ,bison)
>> +       ("python-2" ,python-2)
>> +       ("python-3" ,python-3)
>
> The Pythons here need to be regular inputs since they are referenced.

I think the documentation could do with clarification in this area; I'll
make a bug report about what's unclear to me.  (For what it's worth, I
thought regular inputs would propagate to "out", and it wouldn't be
important to depend on Python for the Python outputs.)

>> +           (add-after 'install 'install-python
>> +             (lambda* (#:key outputs #:allow-other-keys)
>> +               (define (python-inst python)
>> +                 (let ((ldflags (format #f "LDFLAGS=-Wl,-rpath=~a/lib"
>> +                                        (assoc-ref %outputs "out")))
>> +                       (pyout (assoc-ref %outputs python)))
>> +                   (and
>> +                    ;; The rpm spec quoth "build twice, otherwise capi.py is
>> +                    ;; not copied to the build directory"
>
> I went ahead and removed this comment since we are not an RPM derived
> distro, and always run "setup.py build" before "install" anyway.

[I just meant to note an apparent deficiency documented elsewhere that
might be relevant before the install step, e.g. in tests; I do the same
for rpm if I'm looking at an existing dpkg.]  It's probably worth
specifying using build before install in the manual if that's required.

Message #16 received at 27915-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Dave Love <fx <at> gnu.org>
Cc: 27915-done <at> debbugs.gnu.org
Subject: Re: [bug#27915] libnl additions
Date: Thu, 24 Aug 2017 20:11:03 +0200

[Message part 1 (text/plain, inline)]

Dave Love <fx <at> gnu.org> writes:

> Marius Bakke <mbakke <at> fastmail.com> writes:
>
>> Sorry for the delay, these fell through the cracks a bit.
>
> No worries; thanks.  I don't mean to argue below, just explain.
> Apologies if this re-opens the issue -- I can't remember what debbugs does.
>
>>> * gnu/packages/linux.scm (libnl)[native-inputs, outputs]: Add doc source.
>>> [arguments]: New field.
>>
>> I ended up rewriting the install-doc phase so that it extracts directly
>> to the "doc" output, and adjusted the commit message slightly.  
>
> I wondered about that, but just did it as in rpm.  For info, are there
> policy or technical reasons for it?

I did it mainly to avoid the double copy.  Don't think there is any
policy or clear-cut technical reason (but avoiding I/O is good).

>>> [outputs]: Add python2, python3.
>>> [install-python]: New phase.
>>>      (native-inputs
>>> -     `(("flex" ,flex) ("bison" ,bison)
>>> +     `(("flex" ,flex)
>>> +       ("bison" ,bison)
>>> +       ("python-2" ,python-2)
>>> +       ("python-3" ,python-3)
>>
>> The Pythons here need to be regular inputs since they are referenced.
>
> I think the documentation could do with clarification in this area; I'll
> make a bug report about what's unclear to me.  (For what it's worth, I
> thought regular inputs would propagate to "out", and it wouldn't be
> important to depend on Python for the Python outputs.)

I was not sure where the references came from, just checked with `guix
gc -R /gnu/store/...libnl-python2`.  Looking closer, capi.so sems to be
linked against the various Pythons.

Documentation updates greatly appreciated!

>>> +           (add-after 'install 'install-python
>>> +             (lambda* (#:key outputs #:allow-other-keys)
>>> +               (define (python-inst python)
>>> +                 (let ((ldflags (format #f "LDFLAGS=-Wl,-rpath=~a/lib"
>>> +                                        (assoc-ref %outputs "out")))
>>> +                       (pyout (assoc-ref %outputs python)))
>>> +                   (and
>>> +                    ;; The rpm spec quoth "build twice, otherwise capi.py is
>>> +                    ;; not copied to the build directory"
>>
>> I went ahead and removed this comment since we are not an RPM derived
>> distro, and always run "setup.py build" before "install" anyway.
>
> [I just meant to note an apparent deficiency documented elsewhere that
> might be relevant before the install step, e.g. in tests; I do the same
> for rpm if I'm looking at an existing dpkg.]  It's probably worth
> specifying using build before install in the manual if that's required.

Right.  Maybe removing the comment entirely was a bit rash.  I just
found it confusing, since we don't explicitly build it twice, but
eventually noticed that capi.py was "built" in the install step.

Anyway I'm sure the comment will reappear soon enough if this deficiency
indeed becomes apparent.  Thanks for following up. :-)

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 27915-done <at> debbugs.gnu.org (full text, mbox):

From: Dave Love <fx <at> gnu.org>
To: Marius Bakke <mbakke <at> fastmail.com>
Cc: 27915-done <at> debbugs.gnu.org
Subject: Re: [bug#27915] libnl additions
Date: Fri, 01 Sep 2017 11:49:10 +0100

Marius Bakke <mbakke <at> fastmail.com> writes:

> Documentation updates greatly appreciated!

Of course, once it's clear.  Thanks for the explanations.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.