Subject: bug#27906: closed (Re: [bug#27906] [PATCH] r-foreign: Update hash and remove duplicate recipe.)

From: [email-masked] (GNU bug Tracking System)
Date: Tue, 01 Aug 2017 22:50:03 +0000

Your bug report

#27906: [PATCH] r-foreign: Update hash and remove duplicate recipe.

which was filed against the guix-patches package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to [email-masked].

-- 
27906: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=27906
GNU Bug Tracking System
Contact [email-masked] with problems

Subject: Re: [bug#27906] [PATCH] r-foreign: Update hash and remove duplicate recipe.
From: Roel Janssen <[email-masked]>
To: Ludovic Courtès <[email-masked]>
Cc: Efraim Flashner <[email-masked]>, [email-masked]
Date: Wed, 02 Aug 2017 00:49:24 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

Ludovic Courtès writes:

> Roel Janssen <[email-masked]> skribis:
>
>> Efraim Flashner writes:
>>
>>> I have /gnu/store/l1xl1hya1q2vdr059i00s0q9rpwb846a-foreign_0.8-67.tar.gz
>>> if that would help
>>
>> Now this is odd:
>> $ wget http://cran.r-project.org/src/contrib/Archive/foreign/foreign_0.8-67.tar.gz
>
> The other one is at:
>
>   https://mirror.hydra.gnu.org/file/foreign_0.8-67.tar.gz/sha256/1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd
>
> The contents are identical per “diff -r --no-dereference”.  However
> metadata differs:
>
> --8<---------------cut here---------------start------------->8---
> ludo@ribbon /tmp$ tar tvf t.tgz |head
> drwxr-xr-x hornik/users      0 2016-09-13 13:04 foreign/
> drwxr-xr-x hornik/users      0 2014-03-28 10:08 foreign/po/
> -rw-r--r-- hornik/users   5913 2012-10-04 12:33 foreign/po/R-fr.po
> -rw-r--r-- hornik/users  27343 2014-03-28 10:08 foreign/po/de.po
> -rw-r--r-- hornik/users  49598 2014-03-28 10:08 foreign/po/pl.po
> -rw-r--r-- hornik/users   5203 2012-10-11 18:41 foreign/po/R-de.po
> -rw-r--r-- hornik/users  28708 2014-03-28 10:08 foreign/po/fr.po
> -rw-r--r-- hornik/users  17250 2014-03-28 10:08 foreign/po/foreign.pot
> -rw-r--r-- hornik/users   2853 2014-03-28 10:08 foreign/po/R-foreign.pot
> -rw-r--r-- hornik/users  10262 2014-03-28 10:08 foreign/po/R-pl.po
> ludo@ribbon /tmp$ tar tvf foreign_0.8-67.tar.gz |head
> drwxr-xr-x ligges/users      0 2016-09-13 13:04 foreign/
> drwxr-xr-x ligges/users      0 2014-03-28 10:08 foreign/po/
> -rw-r--r-- ligges/users   5913 2012-10-04 12:33 foreign/po/R-fr.po
> -rw-r--r-- ligges/users  27343 2014-03-28 10:08 foreign/po/de.po
> -rw-r--r-- ligges/users  49598 2014-03-28 10:08 foreign/po/pl.po
> -rw-r--r-- ligges/users   5203 2012-10-11 18:41 foreign/po/R-de.po
> -rw-r--r-- ligges/users  28708 2014-03-28 10:08 foreign/po/fr.po
> -rw-r--r-- ligges/users  17250 2014-03-28 10:08 foreign/po/foreign.pot
> -rw-r--r-- ligges/users   2853 2014-03-28 10:08 foreign/po/R-foreign.pot
> -rw-r--r-- ligges/users  10262 2014-03-28 10:08 foreign/po/R-pl.po
> --8<---------------cut here---------------end--------------->8---
>
> In short, it’s safe to update the hash.
>
> Ludo’.

Thanks for explaining the differences.  I pushed the hash change as a
separate commit from the removal of the duplicate recipe.

Kind regards,
Roel Janssen

Subject: [PATCH] r-foreign: Update hash and remove duplicate recipe.
From: Roel Janssen <[email-masked]>
To: guix-patches <[email-masked]>
Date: Tue, 01 Aug 2017 15:58:59 +0200
List-Id: <debbugs-submit.debbugs.gnu.org>

>From 8f53dba37fbb34740801bb684e9ddb4f5d22c607 Mon Sep 17 00:00:00 2001
From: Roel Janssen <[email-masked]>
Date: Tue, 1 Aug 2017 15:51:16 +0200
Subject: [PATCH] r-foreign: Update hash and remove duplicate recipe.

* gnu/packages/statistics.scm (r-foreign): Update hash and remove
  duplicate recipe.
---
 gnu/packages/statistics.scm | 22 +---------------------
 1 file changed, 1 insertion(+), 21 deletions(-)

diff --git a/gnu/packages/statistics.scm b/gnu/packages/statistics.scm
index e9bda5c..99fd2e8 100644
--- a/gnu/packages/statistics.scm
+++ b/gnu/packages/statistics.scm
@@ -373,7 +373,7 @@ Hubert, based on Kaufman and Rousseeuw (1990) \"Finding Groups in Data\".")
        (uri (cran-uri "foreign" version))
        (sha256
         (base32
-         "1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd"))))
+         "0j0z815zyp8n97rk6hlk68d1r8b26vls39s03viq0pnx3cbpwyga"))))
     (build-system r-build-system)
     (home-page "http://cran.r-project.org/web/packages/foreign")
     (synopsis "Read data stored by other statistics software")
@@ -1602,26 +1602,6 @@ It is based on the methods described in Kaufman and Rousseeuw (1990) \"Finding
 Groups in Data\".")
     (license license:gpl2+)))
 
-(define-public r-foreign
-  (package
-    (name "r-foreign")
-    (version "0.8-67")
-    (source
-     (origin
-       (method url-fetch)
-       (uri (cran-uri "foreign" version))
-       (sha256
-        (base32
-         "1mcrm2pydimbyjhkrw5h380bifj1jhwzifph1xgh90asf3lvd1xd"))))
-    (build-system r-build-system)
-    (home-page "http://cran.r-project.org/web/packages/foreign")
-    (synopsis "Read data stored by other statistics software in R")
-    (description
-     "This package provides functions for reading and writing data stored by
-some versions of Epi Info, Minitab, S, SAS, SPSS, Stata, Systat and Weka, and
-for reading and writing some dBase files.")
-    (license license:gpl2+)))
-
 (define-public r-formula
   (package
     (name "r-formula")
-- 
2.7.4

Dear Guix,

It seems we have two (almost identical) package recipes for r-foreign.
This patch removes one of them.

Also, the upstream tarball seems to have changed, so I updated the
SHA256 hash.

If someone has the old tarball, we could look at what exactly has
changed.

Kind regards,
Roel Janssen