From unknown Fri Aug 15 03:57:35 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#27899 <27899@debbugs.gnu.org> To: bug#27899 <27899@debbugs.gnu.org> Subject: Status: 26.0.50; dired-align-file forget about text properties Reply-To: bug#27899 <27899@debbugs.gnu.org> Date: Fri, 15 Aug 2025 10:57:35 +0000 retitle 27899 26.0.50; dired-align-file forget about text properties reassign 27899 emacs submitter 27899 Tino Calancha severity 27899 minor thanks From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 03:27:22 2017 Received: (at submit) by debbugs.gnu.org; 1 Aug 2017 07:27:22 +0000 Received: from localhost ([127.0.0.1]:36045 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcRaM-0003fo-8b for submit@debbugs.gnu.org; Tue, 01 Aug 2017 03:27:22 -0400 Received: from eggs.gnu.org ([208.118.235.92]:35725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcRaK-0003fb-9X for submit@debbugs.gnu.org; Tue, 01 Aug 2017 03:27:20 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcRaE-0002vG-1N for submit@debbugs.gnu.org; Tue, 01 Aug 2017 03:27:15 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=BAYES_05,FREEMAIL_FROM, T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:52266) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcRaD-0002v3-U8 for submit@debbugs.gnu.org; Tue, 01 Aug 2017 03:27:13 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:54925) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcRaC-00058G-K3 for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 03:27:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcRa9-0002qi-DS for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 03:27:12 -0400 Received: from mail-pg0-x22b.google.com ([2607:f8b0:400e:c05::22b]:35322) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dcRa9-0002pU-6t for bug-gnu-emacs@gnu.org; Tue, 01 Aug 2017 03:27:09 -0400 Received: by mail-pg0-x22b.google.com with SMTP id v189so4587611pgd.2 for ; Tue, 01 Aug 2017 00:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:date:message-id:mime-version; bh=ImWlk4Z+Tny03NY1hFzYsWQlm9lC5qmmz7Fh+HiniV8=; b=I+GEx3BKOD7zY9jYzDDC4MIm05rHL8Gs3LSqJvXVBKHg6XPlZdcp6J+OkZpfaCkIBq VC1bQIqUutouI9/iKQ7C/I9BTHpVp74hpXJhtzSgvhly6ld22bHY6wvZo3dSoVzAFBQk KLFfkSzlaUqhXzpJMrIIWbDdX0ThxujU1btG1z+EUtR8Zqr3AQ0uz37Lj69h0DsEpGi6 hBqy7AjdhxP+9hFzYG4S3mEr8oMKMHQa27elZr4sxhXPme/aJWubwqSPLiVLJNvaGQTt OZdE5+KhZ8onZLD39SumJ5oFs+qUNOUhyw1QZq5Vy66zObGaHLOhITkiGQ1a4bPE5xIu a2Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=ImWlk4Z+Tny03NY1hFzYsWQlm9lC5qmmz7Fh+HiniV8=; b=HZz6aO7jRISZNlPlb8AcR3K4XZyTOuZO9EZUASOZuf4U5pFsoYYrvyVDN90oLrBSv7 3ySBOGpYSYZowE4h0biRYdREsCSjiTQsBRpBQUP8eAgQ5nKL7SJ/gIfHQY3w1EP+32os Tn8e3IyaJywFyDOvldvqec4Rgs7m1R8sdTWHv8sT1OLhW6+wGDw7KJWfTqst2Ar7ESNM s9CTrYuOxOG0E1/tWxG8u5UhfzZeRlsmhitWqGcJa24eqMA83jc2CXKjDYeMkv1DFMwc 7wTkmlHTOlw2p4EE6kgimQ7pNcKaMoqSNpHIOWfJHnjnGUaNc2Sv9/IuAsN346Z4uMNh Vbag== X-Gm-Message-State: AIVw112khYvf3FEJ0PuZi4xCMcvKEVSTX6TzhuMQrw+urk+dcuIyIojm aSze3nSQ6LB9rDA+ X-Received: by 10.98.7.204 with SMTP id 73mr18150512pfh.110.1501572428000; Tue, 01 Aug 2017 00:27:08 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id v9sm33127020pgo.39.2017.08.01.00.27.06 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Aug 2017 00:27:07 -0700 (PDT) From: Tino Calancha To: bug-gnu-emacs@gnu.org Subject: 26.0.50; dired-align-file forget about text properties Date: Tue, 01 Aug 2017 16:27:04 +0900 Message-ID: <8760e7kat3.fsf@calancha-pc> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) The addes spaces must inherit the nearby text properties: for instance, the 'invisible' property. --8<-----------------------------cut here---------------start------------->8--- commit 556c5281d3b5056b9bf636b88ae3baf57a1d2f48 Author: Tino Calancha Date: Tue Aug 1 16:24:00 2017 +0900 dired-align-file: Inherit text properties in inserted spaces * lisp/dired.el (dired-align-file): Inherit text properties in inserted spaces (Bug#27899). * test/lisp/dired-tests.el (dired-test-bug27899): Add test. diff --git a/lisp/dired.el b/lisp/dired.el index c502dd8a50..f31993f367 100644 --- a/lisp/dired.el +++ b/lisp/dired.el @@ -1162,7 +1162,7 @@ dired-align-file (setq file-col (+ spaces file-col)) (if (> file-col other-col) (setq spaces (- spaces (- file-col other-col)))) - (insert-char ?\s spaces) + (insert-char ?\s spaces 'inherit) ;; Let's just make really sure we did not mess up. (unless (save-excursion (eq (dired-move-to-filename) (marker-position file))) diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el index d6fe839708..313381f22c 100644 --- a/test/lisp/dired-tests.el +++ b/test/lisp/dired-tests.el @@ -319,6 +319,19 @@ (delete-directory dir 'recursive) (when (buffer-live-p buf) (kill-buffer buf))))) +(ert-deftest dired-test-bug27899 () + "Test for http://debbugs.gnu.org/27899 ." + :expected-result :failed + (let* ((dir (expand-file-name "src" source-directory)) + (buf (dired (list dir "cygw32.c" "alloc.c" "w32xfns.c" "xdisp.c"))) + (orig dired-hide-details-mode)) + (dired-goto-file (expand-file-name "cygw32.c")) + (forward-line 0) + (let ((inhibit-read-only t)) + (dired-align-file (point) (point-max))) + (dired-hide-details-mode t) + (dired-move-to-filename) + (should (eq 2 (current-column))))) (provide 'dired-tests) ;; dired-tests.el ends here --8<-----------------------------cut here---------------end--------------->8--- In GNU Emacs 26.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.22.11) of 2017-07-31 Repository revision: 3a8d0cc825635e07da2a90c4ac987b476fc9b05d From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 03:33:29 2017 Received: (at 27899) by debbugs.gnu.org; 1 Aug 2017 07:33:29 +0000 Received: from localhost ([127.0.0.1]:36051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcRgG-0003q8-Vt for submit@debbugs.gnu.org; Tue, 01 Aug 2017 03:33:29 -0400 Received: from mail-pf0-f172.google.com ([209.85.192.172]:35092) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcRgF-0003pp-OK for 27899@debbugs.gnu.org; Tue, 01 Aug 2017 03:33:28 -0400 Received: by mail-pf0-f172.google.com with SMTP id t86so4500066pfe.2 for <27899@debbugs.gnu.org>; Tue, 01 Aug 2017 00:33:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=FhGEdoVhX1QtKT8LsZ8lu7VcEFWI6NpCdLGxymkWb6g=; b=aKMRFfXnuWIICd3rrt4d5YQIXoJw1ULv985YXCFXbvFGCCzQbVkEcMbXtnzwuAJwWs KMVQfjO8AbEDp3Bi6EDohNRwEhnRIXi+Osw0P42yB++3oC3VRgsRcJXp6TMTKGyC5QJV q92aLa/uFs3g/UwPZHBWSkTs7t+Gs60EcoHDMGP3vuUIL+NdKafE9JSDwqUEaeJvb0Nh uCuoOcl3XNjPbhF01b391sZbxo8AbcwrSurJ3JlfmlI9X+R45BmpquqE5H/epQ2/JHs3 KddPOmqvLmTXGol6c4DLrejJNP7RqVL/xlnNfzyp7kN+WI0gtQOmFwqnZRSS709LQmKK ZI9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=FhGEdoVhX1QtKT8LsZ8lu7VcEFWI6NpCdLGxymkWb6g=; b=kcm+2aDkcd3EnZbpGE54L6LedHhcsWvHigNI6lO9jyO4P6s+Y7UsaFYyccv+t1mIA4 wIyl2IEnrqfCJkRACXVhP8BMZXuEuwmJf4HXW5CgTFMhOoGN3F4ts/sxYXeQ2hGiW2L7 +9Xrx49nYfoY4jJgvveOwt3em2VEtZC26oB9zPyQlhtJfN+/ctIiJXrU0m1eyD1R8pX6 dpbqjdPlrNVOz7dTXBKNyvQ8at1nCQHDPkE/hyV26c4gKGJk7d7ldgxYfGlXqo0deN2M Gutn6zJxeLkZxJFyqn5vU+tBkAEO46SX3gdRCeN7Qpwf+c/+QjZgcWVcv62XsK2zP4AB kdpA== X-Gm-Message-State: AIVw112mK5EJOXIxVeuTdiiFDe8i4s5atDoFH2w0HqSg7ycXnWZXjksg KRyGY09St5t9aVMC X-Received: by 10.84.140.3 with SMTP id 3mr20655543pls.374.1501572801687; Tue, 01 Aug 2017 00:33:21 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id x1sm1554569pgt.82.2017.08.01.00.33.20 for <27899@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 01 Aug 2017 00:33:21 -0700 (PDT) From: Tino Calancha To: 27899@debbugs.gnu.org Subject: Re: bug#27899: 26.0.50; dired-align-file forget about text properties References: <8760e7kat3.fsf@calancha-pc> Date: Tue, 01 Aug 2017 16:33:18 +0900 In-Reply-To: <8760e7kat3.fsf@calancha-pc> (Tino Calancha's message of "Tue, 01 Aug 2017 16:27:04 +0900") Message-ID: <871sovkaip.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27899 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Tino Calancha writes: > +(ert-deftest dired-test-bug27899 () > + "Test for http://debbugs.gnu.org/27899 ." > + :expected-result :failed > + (let* ((dir (expand-file-name "src" source-directory)) > + (buf (dired (list dir "cygw32.c" "alloc.c" "w32xfns.c" "xdisp.c"))) > + (orig dired-hide-details-mode)) > + (dired-goto-file (expand-file-name "cygw32.c")) > + (forward-line 0) > + (let ((inhibit-read-only t)) > + (dired-align-file (point) (point-max))) > + (dired-hide-details-mode t) > + (dired-move-to-filename) > + (should (eq 2 (current-column))))) > > (provide 'dired-tests) > ;; dired-tests.el ends here The test must pass and set dired-hide-details-mode to orig at the end: diff --git a/test/lisp/dired-tests.el b/test/lisp/dired-tests.el index d6fe839708..937386de78 100644 --- a/test/lisp/dired-tests.el +++ b/test/lisp/dired-tests.el @@ -319,6 +319,21 @@ (delete-directory dir 'recursive) (when (buffer-live-p buf) (kill-buffer buf))))) +(ert-deftest dired-test-bug27899 () + "Test for http://debbugs.gnu.org/27899 ." + (let* ((dir (expand-file-name "src" source-directory)) + (buf (dired (list dir "cygw32.c" "alloc.c" "w32xfns.c" "xdisp.c"))) + (orig dired-hide-details-mode)) + (dired-goto-file (expand-file-name "cygw32.c")) + (forward-line 0) + (unwind-protect + (progn + (let ((inhibit-read-only t)) + (dired-align-file (point) (point-max))) + (dired-hide-details-mode t) + (dired-move-to-filename) + (should (eq 2 (current-column)))) + (dired-hide-details-mode orig)))) (provide 'dired-tests) ;; dired-tests.el ends here From debbugs-submit-bounces@debbugs.gnu.org Sun Aug 06 00:19:32 2017 Received: (at 27899-done) by debbugs.gnu.org; 6 Aug 2017 04:19:32 +0000 Received: from localhost ([127.0.0.1]:43988 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deD2J-00088F-Vu for submit@debbugs.gnu.org; Sun, 06 Aug 2017 00:19:32 -0400 Received: from mail-pf0-f182.google.com ([209.85.192.182]:33810) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1deD2H-000881-Ot for 27899-done@debbugs.gnu.org; Sun, 06 Aug 2017 00:19:30 -0400 Received: by mail-pf0-f182.google.com with SMTP id o86so21832306pfj.1 for <27899-done@debbugs.gnu.org>; Sat, 05 Aug 2017 21:19:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:subject:references:date:in-reply-to:message-id:user-agent :mime-version; bh=VUZt6zP8aRLb0nzrsTq66efabL2eTPepwmY3zCvKiKs=; b=mdSUA9QQvUqVUkPnRNEM49seasy7W7va8B7c4MpgTqabOSwgTWjDczsD3Sf8r/g+SL zoeVHmhYRQgEA3RPO1Dvdi/m7IkTW1uMehkCwstWP9c2mXn4Rcfe8FYh1mVedquuMwUt LczJ6KZJf50Wu9wxQR5Fmk4qgm8SYRbySzwQwA4C4B0CJHG0lDTZ72YhjhMxMNPpx2W4 fdTW6EsKWDNSv46AT9k9jFOd5yPNimFx68Nh97aR4bS1oIqf1l/5vFvonyvGqZKq58mx 5WTGymGsjn+QwjNWgoXmn14ixN4wRAOdKgKRTQiepJeytALOGTplSJFnixbtbL3rBuRd DH3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=VUZt6zP8aRLb0nzrsTq66efabL2eTPepwmY3zCvKiKs=; b=XWvVR3PIJtOKQoNCQwR2kQ4bJr8N2vHE3YR64IWsN6s6yQyGgA0Y7TY9FWgp4HOYoG 5wUgMJqotqxQIEKruJDcToYQCmwmmyp4qis3ugx5xdyr0KlUBo3nA18a1Mq/a/h278GL xg7ZYQ53kzXyRUAINrZ2HUdq3jVIGK7ce2UiBBhjVUko9VhYsyL8297UtEI8ZNQOFlhn pSF9/OxH16BY7ZsDSKiDQLNOCrevZGyi3CZBYj0TR9rVIcXvT5FKoOtHjTyqbGifrNyn BvvpnzW/uOZ+OFSZFQjD9YuyfnFV2He0KOecSJKSyLWniV3DfZewt4+caGsEV4aUm9V0 vI7g== X-Gm-Message-State: AHYfb5joK4TTVdkuhLL0T6dvVXEVdsgPXdaQrYtgaQDP+sk9hrk1yCse VxqHK6S7956dcP9G X-Received: by 10.99.153.9 with SMTP id d9mr6587969pge.91.1501993163933; Sat, 05 Aug 2017 21:19:23 -0700 (PDT) Received: from calancha-pc (170.224.128.101.dy.bbexcite.jp. [101.128.224.170]) by smtp.gmail.com with ESMTPSA id c19sm9386770pfk.3.2017.08.05.21.19.22 for <27899-done@debbugs.gnu.org> (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 05 Aug 2017 21:19:23 -0700 (PDT) From: Tino Calancha To: 27899-done@debbugs.gnu.org Subject: Re: bug#27899: 26.0.50; dired-align-file forget about text properties References: <8760e7kat3.fsf@calancha-pc> Date: Sun, 06 Aug 2017 13:19:21 +0900 In-Reply-To: <8760e7kat3.fsf@calancha-pc> (Tino Calancha's message of "Tue, 01 Aug 2017 16:27:04 +0900") Message-ID: <87k22hmipi.fsf@calancha-pc> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27899-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Tino Calancha writes: > The addes spaces must inherit the nearby text properties: for instance, > the 'invisible' property. Pushed fix into master branch as commit ae055834a99b26bf46180b6c78fe7ca24b7c8194 From unknown Fri Aug 15 03:57:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 03 Sep 2017 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator