GNU bug report logs - #27898
Clean-up of package phases

Previous Next

Package: guix-patches;

Reported by: Kei Kebreau <kei <at> openmailbox.org>

Date: Tue, 1 Aug 2017 07:20:02 UTC

Severity: normal

Done: Ricardo Wurmus <rekado <at> elephly.net>

Bug is archived. No further changes may be made.

Full log


Message #44 received at 27898 <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <mbakke <at> fastmail.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: Kei Kebreau <kei <at> openmailbox.org>, 27898 <at> debbugs.gnu.org
Subject: Re: [bug#27898] [PATCH 1/2] gnu: Use 'modify-phases' syntax.
Date: Thu, 03 Aug 2017 01:06:05 +0200
[Message part 1 (text/plain, inline)]
Marius Bakke <mbakke <at> fastmail.com> writes:

> Leo Famulari <leo <at> famulari.name> writes:
>
>> On Wed, Aug 02, 2017 at 10:08:18PM +0200, Marius Bakke wrote:
>>> Leo Famulari <leo <at> famulari.name> writes:
>>> > I agree, wow! Thanks for this. It should help new Schemers to feel more
>>> > comfortable editing packages.
>>> >
>>> > This might be annoying but it should wait until after the core-updates
>>> > branch is done and merged into the master branch. I want to minimize the
>>> > number of merge conflicts because they are 1) annoying and 2) relatively
>>> > opaque when reading the Git history. Marius's suggestion is another good
>>> > one, and would help with issues like that.
>>> >
>>> > But if we were to wait until after core-updates and push it as one
>>> > commit, I wouldn't mind. It's up to the two of you and everyone else :)
>>> 
>>> Yeah I guess the squashed patch is okay. If we delay the patches until
>>> after 'staging' and 'python-updates' as well, no merge will be
>>> necessary. But it won't be a pretty cherry-pick either, by then.
>>
>> True, we should not wait *too* long. I think that doing it after
>> core-updates and before staging and python-updates could be good
>> compromise, because those branches touch a relatively small number of
>> modules. WDYT?
>
> I think the least painful path is:
>
> * Merge 'core-updates'.
> * Merge to 'staging'.
> * <apply these commits>
> * Branch 'python-updates' from staging.
> * Build staging.
>
> Sounds good? :-)

Actually we probably should swap 2 and 3 if we can take the rebuild hit
on 'master'. I don't know how many rebuilds this will cause, but I guess
as long as it's in the three-digit range it should not take too long.
[signature.asc (application/pgp-signature, inline)]

This bug report was last modified 7 years and 277 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.