From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 31 20:14:33 2017 Received: (at submit) by debbugs.gnu.org; 1 Aug 2017 00:14:33 +0000 Received: from localhost ([127.0.0.1]:35900 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcKpV-00026g-H6 for submit@debbugs.gnu.org; Mon, 31 Jul 2017 20:14:33 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcKpR-00026R-2L for submit@debbugs.gnu.org; Mon, 31 Jul 2017 20:14:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcKpK-00082x-FX for submit@debbugs.gnu.org; Mon, 31 Jul 2017 20:14:23 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:41788) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcKpK-00082t-CK for submit@debbugs.gnu.org; Mon, 31 Jul 2017 20:14:22 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcKpI-0008SJ-TG for guix-patches@gnu.org; Mon, 31 Jul 2017 20:14:22 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcKpE-0007zR-F1 for guix-patches@gnu.org; Mon, 31 Jul 2017 20:14:20 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:56925) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dcKpE-0007z2-95 for guix-patches@gnu.org; Mon, 31 Jul 2017 20:14:16 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 8B09A20B3D; Mon, 31 Jul 2017 20:14:15 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute4.internal (MEProxy); Mon, 31 Jul 2017 20:14:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:message-id:subject:to:x-me-sender:x-me-sender :x-sasl-enc:x-sasl-enc; s=mesmtp; bh=83JkgzrxmHoqQh0NxOsFKtjLJ29 Au8qD6KU+AE2iKeE=; b=Wq8bSuvV6I4Ga2C6AvxVEcRIozjPl3RGZV6KfHSq2O8 qg3aa3acoYdE4cu9ZdJLJfGg1FbAkWENCshpnFTGc0DBfyvABl9qUS8u/0unVVcU HwMLuT2tVuvNAwUu/r1o3+HbINsD2Y0d6YD5ELbZ0uYa392e5eUdYw1pMN/HreXY = DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=date:from:message-id:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=83Jkgz rxmHoqQh0NxOsFKtjLJ29Au8qD6KU+AE2iKeE=; b=MZZq/ksHAnPGTF89Mo6Oe8 9gwBsrqYQLY2o8Nvb4gSj0ix3Ab1lVASZAZOEgcMRHCZZogMkAc3aSd2kPX3KWFV Ov8VjFXpkxWIkWRgZCzoNWg+TXntfGv/C0XZqMgOiWHM7TP15tysbU5Oj7eopJV8 zB4XL/D5xlRfNtKYo7bnhRnmOesE9R+fNVBm9nrHQRhbMYjC/CP1KF2GLRgavWsY B/M3Ti+xvZsAU6mtIq96XiRBmsVAsoUEE5HJx50BgOietFTLX9rym7cBOFeLVGv2 OzheNLerICMjkw9T+4xBmFbscBLRvs5+tybhaQHbYZ6aNQCVZwMPFaqlHLXn39KQ == X-ME-Sender: X-Sasl-enc: +QlNJWj/LmvoilSpSBM33y0rHwrjqTNrm3rkdmtFCSVe 1501546455 Received: from jasmine.lan (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 41B5A241DF for ; Mon, 31 Jul 2017 20:14:15 -0400 (EDT) From: Leo Famulari To: guix-patches@gnu.org Subject: [PATCH] gnu: julia: Work around some test failures related to libgit2. Date: Mon, 31 Jul 2017 20:14:10 -0400 Message-Id: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> X-Mailer: git-send-email 2.13.3 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.1 (----) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.1 (----) * gnu/packages/version-control.scm (libgit2-0.25): New variable. * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-0.25. * gnu/packages/patches/libgit2-use-after-free.patch: New file. * gnu/local.mk (dist_patch_DATA): Add it. --- gnu/local.mk | 1 + gnu/packages/julia.scm | 2 +- gnu/packages/patches/libgit2-use-after-free.patch | 24 +++++++++++++++++++++++ gnu/packages/version-control.scm | 16 +++++++++++++++ 4 files changed, 42 insertions(+), 1 deletion(-) create mode 100644 gnu/packages/patches/libgit2-use-after-free.patch diff --git a/gnu/local.mk b/gnu/local.mk index 3fb8f168d..df8252b16 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -754,6 +754,7 @@ dist_patch_DATA = \ %D%/packages/patches/libevent-2.1-dns-tests.patch \ %D%/packages/patches/libevent-2.1-skip-failing-test.patch \ %D%/packages/patches/libgit2-0.25.1-mtime-0.patch \ + %D%/packages/patches/libgit2-use-after-free.patch \ %D%/packages/patches/libgdata-fix-tests.patch \ %D%/packages/patches/libgdata-glib-duplicate-tests.patch \ %D%/packages/patches/libjxr-fix-function-signature.patch \ diff --git a/gnu/packages/julia.scm b/gnu/packages/julia.scm index f6df2817d..dd8ebce77 100644 --- a/gnu/packages/julia.scm +++ b/gnu/packages/julia.scm @@ -310,7 +310,7 @@ ("libunwind" ,libunwind-for-julia) ("openlibm" ,openlibm) ("openspecfun" ,openspecfun) - ("libgit2" ,libgit2) + ("libgit2" ,libgit2-0.25) ; XXX Julia's libgit2 tests fail with libgit 0.26.0. ("fftw" ,fftw) ("fftwf" ,fftwf) ("fortran" ,gfortran) diff --git a/gnu/packages/patches/libgit2-use-after-free.patch b/gnu/packages/patches/libgit2-use-after-free.patch new file mode 100644 index 000000000..580af8781 --- /dev/null +++ b/gnu/packages/patches/libgit2-use-after-free.patch @@ -0,0 +1,24 @@ +This patch is taken from ; +we need it to fix the use-after-free error in 'git_commit_extract_signature' +reported at . + +From ade0d9c658fdfc68d8046935f6908f033fe7a529 Mon Sep 17 00:00:00 2001 +From: Patrick Steinhardt +Date: Mon, 13 Feb 2017 13:46:17 +0100 +Subject: [PATCH 3/3] commit: avoid possible use-after-free + +diff --git a/src/commit.c b/src/commit.c +index 89a4db1..05b70a9 100644 +--- a/src/commit.c ++++ b/src/commit.c +@@ -766,8 +766,9 @@ int git_commit_extract_signature(git_buf *signature, git_buf *signed_data, git_r + if (git_buf_oom(signature)) + goto oom; + ++ error = git_buf_puts(signed_data, eol+1); + git_odb_object_free(obj); +- return git_buf_puts(signed_data, eol+1); ++ return error; + } + + giterr_set(GITERR_OBJECT, "this commit is not signed"); diff --git a/gnu/packages/version-control.scm b/gnu/packages/version-control.scm index 9667b2f3e..a161a9662 100644 --- a/gnu/packages/version-control.scm +++ b/gnu/packages/version-control.scm @@ -380,6 +380,22 @@ write native speed custom Git applications in any language with bindings.") ;; GPLv2 with linking exception (license license:gpl2))) +(define-public libgit2-0.25 + (package + (inherit libgit2) + (name "libgit2") + (version "0.25.1") + (source (origin + (method url-fetch) + (uri (string-append "https://github.com/libgit2/libgit2/" + "archive/v" version ".tar.gz")) + (file-name (string-append name "-" version ".tar.gz")) + (sha256 + (base32 + "1cdwcw38frc1wf28x5ppddazv9hywc718j92f3xa3ybzzycyds3s")) + (patches (search-patches "libgit2-use-after-free.patch" + "libgit2-0.25.1-mtime-0.patch")))))) + (define-public git-crypt (package (name "git-crypt") -- 2.13.3 From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 05:47:02 2017 Received: (at 27893) by debbugs.gnu.org; 1 Aug 2017 09:47:02 +0000 Received: from localhost ([127.0.0.1]:36124 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcTlU-0006uA-Kp for submit@debbugs.gnu.org; Tue, 01 Aug 2017 05:47:02 -0400 Received: from eggs.gnu.org ([208.118.235.92]:50877) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcTlR-0006tw-Bg for 27893@debbugs.gnu.org; Tue, 01 Aug 2017 05:46:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dcTlI-0002WL-88 for 27893@debbugs.gnu.org; Tue, 01 Aug 2017 05:46:52 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD autolearn=disabled version=3.3.2 Received: from fencepost.gnu.org ([2001:4830:134:3::e]:49307) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dcTlI-0002WE-3r; Tue, 01 Aug 2017 05:46:48 -0400 Received: from [193.50.110.251] (port=38188 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dcTlH-0007z1-KP; Tue, 01 Aug 2017 05:46:47 -0400 From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Leo Famulari Subject: Re: [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2. References: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Thermidor an 225 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-unknown-linux-gnu Date: Tue, 01 Aug 2017 11:46:44 +0200 In-Reply-To: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> (Leo Famulari's message of "Mon, 31 Jul 2017 20:14:10 -0400") Message-ID: <87379bsjqz.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-Spam-Score: -5.0 (-----) X-Debbugs-Envelope-To: 27893 Cc: 27893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) --=-=-= Content-Type: text/plain Hi Leo, Leo Famulari skribis: > * gnu/packages/version-control.scm (libgit2-0.25): New variable. > * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-0.25. > * gnu/packages/patches/libgit2-use-after-free.patch: New file. > * gnu/local.mk (dist_patch_DATA): Add it. Sorry for not noticing the breakage! I wonder if it would be easier/safer to fix Julia than to keep the old libgit2. Does this upstream commit fix the failures that you saw? --=-=-= Content-Type: text/x-patch Content-Disposition: inline commit 782460f9bab4af35097c13c4dbab61cb263490b9 Author: Milan Bouchet-Valat Date: Tue Jul 11 10:02:32 2017 +0200 Fix libgit2 test failure with system libgit2 and OpenSSL (#22722) The first letter of the error message is in lowercase in some systems, notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f. diff --git a/test/libgit2.jl b/test/libgit2.jl index d7e32d21a9..f5104e9ec7 100644 --- a/test/libgit2.jl +++ b/test/libgit2.jl @@ -1905,7 +1905,8 @@ mktempdir() do dir deserialize(f) end @test err.code == LibGit2.Error.ECERTIFICATE - @test startswith(err.msg, "The SSL certificate is invalid") + @test startswith(lowercase(err.msg), + lowercase("The SSL certificate is invalid")) rm(errfile) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 DQpMdWRv4oCZLg0K --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Aug 01 16:31:57 2017 Received: (at 27893) by debbugs.gnu.org; 1 Aug 2017 20:31:57 +0000 Received: from localhost ([127.0.0.1]:37345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcdpd-0002Dl-Ji for submit@debbugs.gnu.org; Tue, 01 Aug 2017 16:31:57 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:47419) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dcdpZ-0002Da-19 for 27893@debbugs.gnu.org; Tue, 01 Aug 2017 16:31:56 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id 6202E209E5; Tue, 1 Aug 2017 16:31:52 -0400 (EDT) Received: from frontend1 ([10.202.2.160]) by compute4.internal (MEProxy); Tue, 01 Aug 2017 16:31:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=cc:content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=mesmtp; bh=pUUobFxzHaLYi4bXquE81UtJ9zgq6UGO/LVfYA 9x2fc=; b=uNmmaYqf72GdlY4pk4vB6dJgfrhWk/5sqbsWYz0qJ0Sised+ubwtKw 1ne3OVLSRw34ZNQrQNXDAoe2tRTLnu+0eYCCff1E4QUT9Ipkh2GJEXDSVlsj00eZ f4Dgce8IBDMcqbm9PCFI6gl4D+UndbxoBm843yjWpoYymL+7OBYEM= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=pUUobFxzHaLYi4bXqu E81UtJ9zgq6UGO/LVfYA9x2fc=; b=f5T3xq6IERf8jt9mEvtqoZ5d7DFeKHd49E w6t/gI08+bPFIXvfow4qkcTgQ5+ADUUjSkURqA1/ecKl1KpmFQI2Vo5trFkJSCVa 5Q8WHMgMtGzBYlWJIaa2xTdbYC0bUBC4P1RzJj52/OJE/GRGd0KyOWLsU/EJwySF H4kKoroxj5eMXFN0/2aoVHLpIfpjy/wxgb+bPa7lpuQdFTASuxaHVOOAdip0VZe9 72BQDwITb8Ap1oVhZM/TuNSvK7CzTLlttxzjiIiCTSyOr5PECwfVzL9fMoY/+tM0 SmpEbLDu9yQ5YWJCghp/hAszopWKGkMx/FL9jLRnX5SzBfCCUIww== X-ME-Sender: X-Sasl-enc: OHQt7FyPgUG0w/l6r/NCSsPwKfBkWIPf/TyrEygrQWfp 1501619512 Received: from localhost (c-73-165-108-70.hsd1.pa.comcast.net [73.165.108.70]) by mail.messagingengine.com (Postfix) with ESMTPA id 25D2C7E804; Tue, 1 Aug 2017 16:31:52 -0400 (EDT) Date: Tue, 1 Aug 2017 16:31:40 -0400 From: Leo Famulari To: Ludovic =?iso-8859-1?Q?Court=E8s?= Subject: Re: [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2. Message-ID: <20170801203140.GA7468@jasmine.lan> References: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> <87379bsjqz.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="3MwIy2ne0vdjdPXF" Content-Disposition: inline In-Reply-To: <87379bsjqz.fsf@gnu.org> User-Agent: Mutt/1.8.3 (2017-05-23) X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 27893 Cc: 27893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) --3MwIy2ne0vdjdPXF Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Aug 01, 2017 at 11:46:44AM +0200, Ludovic Court=E8s wrote: > Hi Leo, >=20 > Leo Famulari skribis: >=20 > > * gnu/packages/version-control.scm (libgit2-0.25): New variable. > > * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-= 0.25. > > * gnu/packages/patches/libgit2-use-after-free.patch: New file. > > * gnu/local.mk (dist_patch_DATA): Add it. >=20 > Sorry for not noticing the breakage! I wonder if it would be > easier/safer to fix Julia than to keep the old libgit2. >=20 > Does this upstream commit fix the failures that you saw? The context of this patch actually doesn't exist in the Julia release. Based on the very large number of changes to this test between releases, my impression is that Julia is just not ready for libgit2 0.26.0, even though there are some commits addressing libgit2 0.26.0 in Julia. The thing is, I found this test failure building locally but on Hydra there are different failures [0]. So, even if we fix this issue, we still probably won't be offering a Julia substitute. Thus, I don't mind carrying this libgit2-0.25 package privately for now. [0] Has anyone got the Julia test suite to pass at all? Spill the beans! :) --3MwIy2ne0vdjdPXF Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAlmA5SgACgkQJkb6MLrK fwiaQg//RG4EieO47GzC8maj0V0O0Ic/dEGQZjXYfFRiPFVzIyiv/Na8GumK0FLV 7dxvsLBaFJPeAUSmPrXVVPn49f8amJ4Wy2o8As2cZxO6DeBej27ew6+B2dLhOKcR fuRxnlS1txvdR/VfUNccnmFDYqYPJ1DMBbi8EUxZUKzcJnOKHZsIvT4KrUgoMPS+ +gdoG8SbP6aBn/T7U7b3tMbyAkdnAw5yFiF8pzk/LCtHyFUwgAf4DYgHtO6fMWwn e8mEbDBBCJzrjElQMOOinox00511vXTf0SQIPOBN/kyU09fjQ0C/viHLQX1zOPO0 D/BBBUQLvLpRdfrsWS/nNLbGak8s/qxh4VV/c5HOKwMYAnX3SueaR5px2sTUxHZS KrsfHNHTNJ78I7/b2S6+SsU5cRom+j+pOze84SgupxWttU656ANIsbhxXac4thpc +Ch2aknrfmT8c6RxWP5BGLC0mXAgYKRA9ezWufHzScjkYjO0QwnjXP1NhZ2oCGgw B3IarU7ifOn2HkswNGyDbNDgFux3ITQMAuApf3Sz5ORiod76rvZodjaetjNZXo5b RNl4F/T67eYZ/n5aFoECqGat1o9BqLYPYQJ3Ipg8NuDBuW2U65KGdtRAGhJ++UHD RkV9nOVWpOQ2zrm9C1KRcP+PAR2DpdR9VZ7owVgUrluLYgYAZdU= =S10v -----END PGP SIGNATURE----- --3MwIy2ne0vdjdPXF-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 18 17:31:36 2017 Received: (at 27893) by debbugs.gnu.org; 18 Oct 2017 21:31:36 +0000 Received: from localhost ([127.0.0.1]:48768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4vw8-0002U6-54 for submit@debbugs.gnu.org; Wed, 18 Oct 2017 17:31:36 -0400 Received: from sender-of-o51.zoho.com ([135.84.80.216]:21027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4vw5-0002Rb-Ms for 27893@debbugs.gnu.org; Wed, 18 Oct 2017 17:31:34 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1508361343; s=zoho; d=elephly.net; i=rekado@elephly.net; h=References:From:To:Cc:Subject:In-reply-to:Date:MIME-Version:Content-Type:Content-Transfer-Encoding:Message-ID; l=671; bh=xaqrDZPSLWQyFc5yUW6BNr+kCR39lPutk1yi3pfpCjA=; b=FP03gLQ7qNnr07OFhTrA5JKX9T+K/vmJDvYa349JKNff4PfwHTt1hZCqntVCk/0i cEpHglVFb+VgBFoEBwYnuRxvvi0aykWKqaRfEdLtS16AvN07m9H4ehfkDAzFmlWfF7P uhU8o07nTv8MB8Ddbkik+RsUqZQmtVkvWcQDBm+M= Received: from localhost (port-92-200-55-161.dynamic.qsc.de [92.200.55.161]) by mx.zohomail.com with SMTPS id 1508361343250861.3713762816541; Wed, 18 Oct 2017 14:15:43 -0700 (PDT) References: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> <87379bsjqz.fsf@gnu.org> <20170801203140.GA7468@jasmine.lan> User-agent: mu4e 0.9.18; emacs 25.3.1 From: Ricardo Wurmus To: Leo Famulari Subject: Re: [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2. In-reply-to: <20170801203140.GA7468@jasmine.lan> X-URL: https://elephly.net X-PGP-Key: https://elephly.net/rekado.pubkey X-PGP-Fingerprint: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC Date: Wed, 18 Oct 2017 23:15:40 +0200 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Message-ID: <8760bc40oz.fsf@elephly.net> X-ZohoMailClient: External X-Spam-Score: -2.8 (--) X-Debbugs-Envelope-To: 27893 Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , 27893@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) Leo Famulari writes: > Has anyone got the Julia test suite to pass at all? Spill the beans! :) I have, repeatedly, but it=E2=80=99s been a while since I=E2=80=99ve built = Julia locally. The tests are a bit memory-hungry if I recall correctly, but they did pass on my workstation in the office. I always made sure that the tests pass and the few known failing tests were disabled. About this patch: I=E2=80=99d prefer if this version of libgit were a priva= te variable in the julia module, just like libunwind-for-julia and libuv-julia. -- Ricardo GPG: BCA6 89B6 3655 3801 C3C6 2150 197A 5888 235F ACAC https://elephly.net From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 07 09:03:33 2018 Received: (at 27893-done) by debbugs.gnu.org; 7 Mar 2018 14:03:33 +0000 Received: from localhost ([127.0.0.1]:48592 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etZfI-0004hw-RV for submit@debbugs.gnu.org; Wed, 07 Mar 2018 09:03:33 -0500 Received: from hera.aquilenet.fr ([185.233.100.1]:45412) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1etZfD-0004hk-O6 for 27893-done@debbugs.gnu.org; Wed, 07 Mar 2018 09:03:31 -0500 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 4BFDE11D05; Wed, 7 Mar 2018 15:03:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id U3nYq7fWl0N5; Wed, 7 Mar 2018 15:03:22 +0100 (CET) Received: from ribbon (vpn-0-27.aquilenet.fr [IPv6:2a0c:e300:4:27::]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 99012114EB; Wed, 7 Mar 2018 15:03:22 +0100 (CET) From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) To: Leo Famulari Subject: Re: [bug#27893] [PATCH] gnu: julia: Work around some test failures related to libgit2. References: <3460381662f16e6d267a21c7d2f83a9cea216b6e.1501546450.git.leo@famulari.name> <87379bsjqz.fsf@gnu.org> Date: Wed, 07 Mar 2018 15:03:14 +0100 In-Reply-To: <87379bsjqz.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Tue, 01 Aug 2017 11:46:44 +0200") Message-ID: <87po4grnj1.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 1.0 (+) X-Debbugs-Envelope-To: 27893-done Cc: 27893-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.0 (+) Hello, ludo@gnu.org (Ludovic Court=C3=A8s) skribis: > Leo Famulari skribis: > >> * gnu/packages/version-control.scm (libgit2-0.25): New variable. >> * gnu/packages/julia.scm (julia)[inputs]: Replace LIBGIT2 with LIBGIT2-0= .25. >> * gnu/packages/patches/libgit2-use-after-free.patch: New file. >> * gnu/local.mk (dist_patch_DATA): Add it. > > Sorry for not noticing the breakage! I wonder if it would be > easier/safer to fix Julia than to keep the old libgit2. > > Does this upstream commit fix the failures that you saw? > > commit 782460f9bab4af35097c13c4dbab61cb263490b9 > Author: Milan Bouchet-Valat > Date: Tue Jul 11 10:02:32 2017 +0200 > > Fix libgit2 test failure with system libgit2 and OpenSSL (#22722) >=20=20=20=20=20 > The first letter of the error message is in lowercase in some systems, > notably Fedora Rawhide with libgit2 0.26 and OpenSSL 1.1.0f. > > diff --git a/test/libgit2.jl b/test/libgit2.jl > index d7e32d21a9..f5104e9ec7 100644 > --- a/test/libgit2.jl > +++ b/test/libgit2.jl > @@ -1905,7 +1905,8 @@ mktempdir() do dir > deserialize(f) > end > @test err.code =3D=3D LibGit2.Error.ECERTIFICATE > - @test startswith(err.msg, "The SSL certificate is in= valid") > + @test startswith(lowercase(err.msg), > + lowercase("The SSL certificate is i= nvalid")) As it turns out, I later fixed this in a different way, having forgotten about this discussion, in commit d40b5684c533e0188ffa213b20f2d3c88406d895. Case closed! Note that there are other issues discussed at . Ludo=E2=80=99. From unknown Mon Aug 18 15:39:35 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Thu, 05 Apr 2018 11:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator