GNU bug report logs - #27881
New major mode: Less mode

Previous Next

Full log

Message #23 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tom Tromey <tom <at> tromey.com>
To: Simen Heggestøyl <simenheg <at> gmail.com>
Cc: Steve Purcell <steve <at> sanityinc.com>, bug-gnu-emacs <at> gnu.org,
 Tom Tromey <tom <at> tromey.com>, Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Dmitry Gutov <dgutov <at> yandex.ru>
Subject: Re: New major mode: Less mode
Date: Tue, 01 Aug 2017 20:16:59 -0600

>>>>> "Simen" == Simen Heggestøyl <simenheg <at> gmail.com> writes:

Simen> +(defcustom less-css-lessc-command "lessc"
Simen> +  "Command used to compile LESS files.
Simen> +Should be lessc or the complete path to your lessc executable,
Simen> +  e.g.: \"~/.gem/ruby/1.8/bin/lessc\""
Simen> +  :type 'file
Simen> +  :group 'less-css
Simen> +  :safe 'stringp)
Simen> +
Simen> +;;;###autoload
Simen> +(defcustom less-css-compile-at-save nil
Simen> +  "If non-nil, the LESS buffers will be compiled to CSS after each save."
Simen> +  :type 'boolean
Simen> +  :group 'less-css
Simen> +  :safe 'booleanp)

It seems dangerous to me to mark these both as safe.  A file could
specify a dangerous command and then say it's ok to run it on save.

Probably the command should not be :safe.

Maybe the other variables defined after this should also not be safe.

Tom

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.