GNU bug report logs - #27880
25.2; elisp-mode-tests may downcase too aggressively

Previous Next

Package: emacs;

Reported by: Rob Browning <rlb <at> defaultvalue.org>

Date: Sun, 30 Jul 2017 16:22:02 UTC

Severity: normal

Merged with 25534

Found in versions 25.2, 26.0

Fixed in version 26.2

Done: Glenn Morris <rgm <at> gnu.org>

Bug is archived. No further changes may be made.

Full log

Message #13 received at 27880 <at> debbugs.gnu.org (full text, mbox):

From: Rob Browning <rlb <at> defaultvalue.org>
To: npostavs <at> users.sourceforge.net
Cc: 27880 <at> debbugs.gnu.org
Subject: Re: bug#27880: 25.2; elisp-mode-tests may downcase too aggressively
Date: Sun, 30 Jul 2017 18:17:00 -0500

npostavs <at> users.sourceforge.net writes:

> This is the same as Bug#25534 "xref ERT tests fail when the source path
> is mixed case", right?

Looks likely.  And at least for Debian, something like this fixes it:

  +++ b/test/automated/elisp-mode-tests.el
  @@ -179,11 +179,15 @@ xref-elisp-test-descr-to-target
   (defun xref-elisp-test-run (xrefs expected-xrefs)
     (should (= (length xrefs) (length expected-xrefs)))
     (while xrefs
  -    (let* ((xref (pop xrefs))
  +    (let* ((real-xref (pop xrefs))
  +           (xref (clone real-xref))
              (expected (pop expected-xrefs))
              (expected-xref (or (when (consp expected) (car expected)) expected))
              (expected-source (when (consp expected) (cdr expected))))

  +      (setf (oref xref location)
  +            (copy-xref-elisp-location (oref xref location)))
  +
         ;; Downcase the filenames for case-insensitive file systems.
         (setf (xref-elisp-location-file (oref xref location))
               (downcase (xref-elisp-location-file (oref xref location))))
  @@ -193,7 +197,7 @@ xref-elisp-test-run

         (should (equal xref expected-xref))

  -      (xref--goto-location (xref-item-location xref))
  +      (xref--goto-location (xref-item-location real-xref))
         (back-to-indentation)
         (should (looking-at (or expected-source
                                 (xref-elisp-test-descr-to-target expected)))))

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4
This bug report was last modified 6 years and 159 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.