From unknown Mon Jun 23 02:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27880: 25.2; elisp-mode-tests may downcase too aggressively Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2017 16:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 27880@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.15014317151735 (code B ref -1); Sun, 30 Jul 2017 16:22:02 +0000 Received: (at submit) by debbugs.gnu.org; 30 Jul 2017 16:21:55 +0000 Received: from localhost ([127.0.0.1]:34438 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbqyZ-0000Rv-By for submit@debbugs.gnu.org; Sun, 30 Jul 2017 12:21:55 -0400 Received: from eggs.gnu.org ([208.118.235.92]:58137) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbqyX-0000Rd-Bw for submit@debbugs.gnu.org; Sun, 30 Jul 2017 12:21:53 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbqyR-0005ax-BD for submit@debbugs.gnu.org; Sun, 30 Jul 2017 12:21:48 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:45730) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1dbqyR-0005al-7v for submit@debbugs.gnu.org; Sun, 30 Jul 2017 12:21:47 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49101) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbqyQ-0006dJ-3a for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 12:21:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dbqyN-0005Xz-01 for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 12:21:46 -0400 Received: from defaultvalue.org ([70.85.129.156]:47514) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dbqyM-0005XY-R0 for bug-gnu-emacs@gnu.org; Sun, 30 Jul 2017 12:21:42 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id EB7AF200A5 for ; Sun, 30 Jul 2017 11:21:40 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id 2108214E0AD; Sun, 30 Jul 2017 11:21:40 -0500 (CDT) From: Rob Browning Date: Sun, 30 Jul 2017 11:21:40 -0500 Message-ID: <87fudd6gkr.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: text/plain X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -5.0 (-----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -5.0 (-----) [Refiling as a bug report from a list thread.] It looks like (in 25.2, and perhaps master too) elisp-mode-tests.el downcases the xref path (location) for comparison in xref-elisp-test-run, but that seems to also affect the filesystem lookup lower down (in xref--goto-location) such that a handful of tests fail if the build path contains uppercase characters. i.e. it tries to read the downcased path, which of course (on ext4) doesn't exist. In any case, I've hacked up a temporary fix by keeping the original as "real-xref" and cloning that (and copying the location) to produce the xref used by the modification and comparison. Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4 From unknown Mon Jun 23 02:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27880: 25.2; elisp-mode-tests may downcase too aggressively Resent-From: npostavs@users.sourceforge.net Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2017 20:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Rob Browning Cc: 27880@debbugs.gnu.org Received: via spool by 27880-submit@debbugs.gnu.org id=B27880.150144717825364 (code B ref 27880); Sun, 30 Jul 2017 20:40:02 +0000 Received: (at 27880) by debbugs.gnu.org; 30 Jul 2017 20:39:38 +0000 Received: from localhost ([127.0.0.1]:34569 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbuzy-0006b2-1o for submit@debbugs.gnu.org; Sun, 30 Jul 2017 16:39:38 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:35115) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbuzt-0006ac-T5; Sun, 30 Jul 2017 16:39:34 -0400 Received: by mail-it0-f50.google.com with SMTP id h199so116882306ith.0; Sun, 30 Jul 2017 13:39:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=FFa13b266YGLuwPKvYH+/NkGYMY0/4P1r7J3ipM0sew=; b=R+IlArcCyIz4NNZlHzicsYsqlqqNGmFldFpvHL/r0BZTvFYXdIrXi0ctu7QGaAUzMQ AN1bSFN5Wp5gVIB1ti/w/zTG9EO8bbHanwG625emHP60Fn/BFLiEj6U4AQgb4GseaiYq CuLae3i3MgmtuGm/l33+0+JzhC29AJC6VFjKKE34jpEw3jyj1N8ypoD94f1GMcuvIlI6 jz1R4iEohbr84iW0cTwtqTBaDRchpZ1/61kZa4W4xl2jD2CzAOPw+HIXBqlNHRaATLop QmFkRLhuPsdN098VsCUPKmAiHPY4dArZ0PNq8yyW7i88FEbxi/yM1Sd9K/O8FwlOBGm4 P81A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:references:date :in-reply-to:message-id:user-agent:mime-version; bh=FFa13b266YGLuwPKvYH+/NkGYMY0/4P1r7J3ipM0sew=; b=keU4IJ4YZKICwseq+9dkHTGhX0cv8Hm4+pkSxaeK1yI37jeqYl+5U78lqt6BuUy+bt UCA2aq4yzYH5HleJS4E/jpucaNQyVXiWs49SxV8YU5HKoUWnP30ufJiNZQjZE17ZcILz 2qLFNCvXbhvAJz6Id97jA5rQO0hPaKJ0FHZE+Z/Y/fxR1i8gh86AX6JFZRm4DWa4UCDF 02XUvBYuJrc4t8G7YLa7V9LsO8FcyPwNWNeBn82WFvQvENYgC6HiOQtzRUUWRHgjsZEu IRWO4DXjEmbfxbY5ptw8xoKWaV3aAAkAs207nvuRIA2gYjpkZAGj/Moq+00Hp9NvjFqx wzJg== X-Gm-Message-State: AIVw112TSqJIf7Coyd3QNzQZY+wbiY6L+S5eYsWs717TqNUeHAQPDM2x ZL3mKLcf11JaTlvX X-Received: by 10.36.48.198 with SMTP id q189mr16154750itq.61.1501447167922; Sun, 30 Jul 2017 13:39:27 -0700 (PDT) Received: from zony ([45.2.7.65]) by smtp.googlemail.com with ESMTPSA id p65sm4708022itb.33.2017.07.30.13.39.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 30 Jul 2017 13:39:27 -0700 (PDT) From: npostavs@users.sourceforge.net References: <87fudd6gkr.fsf@trouble.defaultvalue.org> Date: Sun, 30 Jul 2017 16:41:08 -0400 In-Reply-To: <87fudd6gkr.fsf@trouble.defaultvalue.org> (Rob Browning's message of "Sun, 30 Jul 2017 11:21:40 -0500") Message-ID: <87zibl7j4r.fsf@users.sourceforge.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) merge 27880 25534 quit Rob Browning writes: > [Refiling as a bug report from a list thread.] > > It looks like (in 25.2, and perhaps master too) elisp-mode-tests.el > downcases the xref path (location) for comparison in > xref-elisp-test-run, but that seems to also affect the filesystem lookup > lower down (in xref--goto-location) such that a handful of tests fail if > the build path contains uppercase characters. i.e. it tries to read the > downcased path, which of course (on ext4) doesn't exist. > > In any case, I've hacked up a temporary fix by keeping the original as > "real-xref" and cloning that (and copying the location) to produce the > xref used by the modification and comparison. > > Thanks This is the same as Bug#25534 "xref ERT tests fail when the source path is mixed case", right? From unknown Mon Jun 23 02:25:40 2025 X-Loop: help-debbugs@gnu.org Subject: bug#27880: 25.2; elisp-mode-tests may downcase too aggressively Resent-From: Rob Browning Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 30 Jul 2017 23:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 27880 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: npostavs@users.sourceforge.net Cc: 27880@debbugs.gnu.org Received: via spool by 27880-submit@debbugs.gnu.org id=B27880.150145662814220 (code B ref 27880); Sun, 30 Jul 2017 23:18:01 +0000 Received: (at 27880) by debbugs.gnu.org; 30 Jul 2017 23:17:08 +0000 Received: from localhost ([127.0.0.1]:34621 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbxSO-0003hH-9X for submit@debbugs.gnu.org; Sun, 30 Jul 2017 19:17:08 -0400 Received: from defaultvalue.org ([70.85.129.156]:51762 ident=postfix) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbxSM-0003h7-6J for 27880@debbugs.gnu.org; Sun, 30 Jul 2017 19:17:06 -0400 Received: from trouble.defaultvalue.org (localhost [127.0.0.1]) (Authenticated sender: rlb@defaultvalue.org) by defaultvalue.org (Postfix) with ESMTPSA id 8638B20106; Sun, 30 Jul 2017 18:17:03 -0500 (CDT) Received: by trouble.defaultvalue.org (Postfix, from userid 1000) id C8BEC14E0AD; Sun, 30 Jul 2017 18:17:00 -0500 (CDT) From: Rob Browning In-Reply-To: <87zibl7j4r.fsf@users.sourceforge.net> References: <87fudd6gkr.fsf@trouble.defaultvalue.org> <87zibl7j4r.fsf@users.sourceforge.net> Date: Sun, 30 Jul 2017 18:17:00 -0500 Message-ID: <878tj55xcj.fsf@trouble.defaultvalue.org> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.0 (/) npostavs@users.sourceforge.net writes: > This is the same as Bug#25534 "xref ERT tests fail when the source path > is mixed case", right? Looks likely. And at least for Debian, something like this fixes it: +++ b/test/automated/elisp-mode-tests.el @@ -179,11 +179,15 @@ xref-elisp-test-descr-to-target (defun xref-elisp-test-run (xrefs expected-xrefs) (should (= (length xrefs) (length expected-xrefs))) (while xrefs - (let* ((xref (pop xrefs)) + (let* ((real-xref (pop xrefs)) + (xref (clone real-xref)) (expected (pop expected-xrefs)) (expected-xref (or (when (consp expected) (car expected)) expected)) (expected-source (when (consp expected) (cdr expected)))) + (setf (oref xref location) + (copy-xref-elisp-location (oref xref location))) + ;; Downcase the filenames for case-insensitive file systems. (setf (xref-elisp-location-file (oref xref location)) (downcase (xref-elisp-location-file (oref xref location)))) @@ -193,7 +197,7 @@ xref-elisp-test-run (should (equal xref expected-xref)) - (xref--goto-location (xref-item-location xref)) + (xref--goto-location (xref-item-location real-xref)) (back-to-indentation) (should (looking-at (or expected-source (xref-elisp-test-descr-to-target expected))))) -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4