From unknown Mon Aug 18 17:54:05 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#27845] [PATCH] gnu: emacs: Check GUIX_ENVIRONMENT when autoloading packages Resent-From: Kyle Meyer Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 27 Jul 2017 05:02:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 27845 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 27845@debbugs.gnu.org Cc: Alex Kost , Kyle Meyer X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.150113170919758 (code B ref -1); Thu, 27 Jul 2017 05:02:01 +0000 Received: (at submit) by debbugs.gnu.org; 27 Jul 2017 05:01:49 +0000 Received: from localhost ([127.0.0.1]:57842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daavl-00058b-0V for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daavi-00058P-H6 for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daavc-0002ey-DS for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daavc-0002er-Au for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daavb-0005Ig-5n for guix-patches@gnu.org; Thu, 27 Jul 2017 01:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daavX-0002br-4a for guix-patches@gnu.org; Thu, 27 Jul 2017 01:01:39 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60652 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daavW-0002ag-Ti for guix-patches@gnu.org; Thu, 27 Jul 2017 01:01:35 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 949E19A7C1; Thu, 27 Jul 2017 01:01:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id; s=sasl; bh=B0rVdn+7AfLXeD00ncFhc2tmcvI =; b=f24CyXjphHeNBonxKHmhUJYFHrzy0bFXCXQuirbdnR+XdSCooCrpWG14bZd 5tN9tey+f11ZOGuElZl5+ECCstxD3MJGC8KUftwSNCwb9+FWON3Z/71GZ8TB4AcI 1JDW+H+MXDiDpZOlCk3B88/DmvkcDUCcJDPrTBdl9HGw3MZA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 8CC499A7C0; Thu, 27 Jul 2017 01:01:31 -0400 (EDT) Received: from kmlap.hsd1.ct.comcast.net (unknown [24.60.167.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id E6DD59A7BF; Thu, 27 Jul 2017 01:01:30 -0400 (EDT) From: Kyle Meyer Date: Thu, 27 Jul 2017 01:01:26 -0400 Message-Id: <20170727050126.27817-1-kyle@kyleam.com> X-Mailer: git-send-email 2.13.3 X-Pobox-Relay-ID: A791C7F2-7288-11E7-9C57-FE4B1A68708C-24757444!pb-smtp1.pobox.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:date:message-id; s=mesmtp; bh=bay3TOsl3yjWMk+e4hyMzY7RxpAqA+ecr5sgifk+caU=; b=OPtKPLGVir5RsxfVdPo31YwQNEip1ksjTTEfCKGvVb5y0DszXdBCfTGMmu4U4OXKox7BveDHtC7upGu21KjfNtizBXHS0lX/wawoGmPHEuVOT6GNMVJt17pN97fimuSlh8BAtn0u+4W4GTph79Nb0BgUDG0hghqf1iimDn31smM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Check the environment profile so that we autoload packages that are given as arguments to "guix environment" but are not in the system or user profile. Note that the union of Emacs packages in the system, user, and environment profiles will be autoloaded even when --pure was passed to "guix environment", because it's not clear how to detect that --pure was given. * gnu/packages/aux-files/emacs/guix-emacs.el (guix-emacs-autoload-packages): Add Emacs packages from GUIX_ENVIRONMENT profile. --- Follow-up to https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00378.html gnu/packages/aux-files/emacs/guix-emacs.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/packages/aux-files/emacs/guix-emacs.el b/gnu/packages/aux-files/emacs/guix-emacs.el index 2bbd639ff..10bad0272 100644 --- a/gnu/packages/aux-files/emacs/guix-emacs.el +++ b/gnu/packages/aux-files/emacs/guix-emacs.el @@ -87,9 +87,11 @@ (defun guix-emacs-autoload-packages (&rest profiles) (interactive (list (if (fboundp 'guix-read-package-profile) (funcall 'guix-read-package-profile) guix-user-profile))) - (let ((profiles (or profiles - (list "/run/current-system/profile" - guix-user-profile)))) + (let* ((env (getenv "GUIX_ENVIRONMENT")) + (profiles (or profiles + (append (list "/run/current-system/profile" + guix-user-profile) + (and env (list env)))))) (dolist (profile profiles) (let ((dirs (guix-emacs-directories profile))) (when dirs -- 2.13.3 From unknown Mon Aug 18 17:54:05 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kyle Meyer Subject: bug#27845: closed (Re: [bug#27845] [PATCH] gnu: emacs: Check GUIX_ENVIRONMENT when autoloading packages) Message-ID: References: <87lgn7m1ne.fsf@gmail.com> <20170727050126.27817-1-kyle@kyleam.com> X-Gnu-PR-Message: they-closed 27845 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 27845@debbugs.gnu.org Date: Sat, 29 Jul 2017 20:26:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1501359962-8087-1" This is a multi-part message in MIME format... ------------=_1501359962-8087-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #27845: [PATCH] gnu: emacs: Check GUIX_ENVIRONMENT when autoloading packages which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 27845@debbugs.gnu.org. --=20 27845: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D27845 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1501359962-8087-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 27845-done) by debbugs.gnu.org; 29 Jul 2017 20:25:17 +0000 Received: from localhost ([127.0.0.1]:33380 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbYIX-00025S-HA for submit@debbugs.gnu.org; Sat, 29 Jul 2017 16:25:17 -0400 Received: from mail-lf0-f48.google.com ([209.85.215.48]:35665) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dbYIW-00025F-9i for 27845-done@debbugs.gnu.org; Sat, 29 Jul 2017 16:25:16 -0400 Received: by mail-lf0-f48.google.com with SMTP id t128so71841985lff.2 for <27845-done@debbugs.gnu.org>; Sat, 29 Jul 2017 13:25:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=lOzIcfLELuihiaHkJXy8MbI78mRLaX3Gat35MP1UwRw=; b=b5bjhcCkF7u1TVZXLUvG84FD4reXlN3UIwMlJxxSeZSbgIUfBjr2eltHkvE+lXKBkO DV/xEFgh19g4s2OCnhxOe0ruKItxtONhPRGa78qaxH3lLZ3xHtTS2OTVtPjgENhLghQj oJ1FniBbo7ru29K0X4nTRD18Ldg+fXYzROuJ4mmg42nhxWqrvGbo7UAu/GJsnbfkWkep Ok6B/eI1dWmWfRT6COwBElbXDBYU7DKQfj20n6cjo/4lXwgMB49wCuErbJrRRPJ9588E THNo+2MHroxwo3fF3UCUvu3jzw0OYZ/vg9hG8ipwpra5YLDWt+lfVuZ9ocdokClSFDjd LhCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=lOzIcfLELuihiaHkJXy8MbI78mRLaX3Gat35MP1UwRw=; b=JnFMR5N/n48/cOqyFxzdHkSHLWO6yf6uXEf1ehdcAbZPLOEMwGu9cEH6x9lx1bhXVa 8qkSDXtWXQz70qkaKp5EFaCfmKruZhHQwGsvgqndKjBTQAi5OU1tL5QsOx+fA2pMD8ph Cq1JaMfpqWhCURATHIj8rtIb91NI3g0TgcFceRBifdi3gwQVIkuZx1MYONyKndERlVV9 n0iu1wdVhbvQtPKqUFBB6kbSJyuefCcNzE84Bg71eYVrhKE9jtHOuBSLihTTbjzbY3gR RMCftfTp2R/t6r99ZUbK93krjARnfJR/YJ7RpYTtksl87fJi5hIgCsG3wVoK2SxWETN8 sbbw== X-Gm-Message-State: AIVw111aKw5h6+HDiBnTeb3Ynxsl/DZfFvIhYfjKyvFi8s/Ebv2Pl6qu 1x8pHy+iYoAEZsPF X-Received: by 10.25.44.81 with SMTP id s78mr4240017lfs.65.1501359910061; Sat, 29 Jul 2017 13:25:10 -0700 (PDT) Received: from leviafan ([217.107.194.134]) by smtp.gmail.com with ESMTPSA id m12sm4655307lfe.12.2017.07.29.13.25.08 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sat, 29 Jul 2017 13:25:09 -0700 (PDT) From: Alex Kost To: Kyle Meyer Subject: Re: [bug#27845] [PATCH] gnu: emacs: Check GUIX_ENVIRONMENT when autoloading packages References: <20170727050126.27817-1-kyle@kyleam.com> Date: Sat, 29 Jul 2017 23:25:09 +0300 In-Reply-To: <20170727050126.27817-1-kyle@kyleam.com> (Kyle Meyer's message of "Thu, 27 Jul 2017 01:01:26 -0400") Message-ID: <87lgn7m1ne.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 27845-done Cc: 27845-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 0.5 (/) Kyle Meyer (2017-07-27 01:01 -0400) wrote: > Check the environment profile so that we autoload packages that are given as > arguments to "guix environment" but are not in the system or user profile. > Note that the union of Emacs packages in the system, user, and environment > profiles will be autoloaded even when --pure was passed to "guix environment", > because it's not clear how to detect that --pure was given. > > * gnu/packages/aux-files/emacs/guix-emacs.el (guix-emacs-autoload-packages): > Add Emacs packages from GUIX_ENVIRONMENT profile. Great! Applied as commit 24b115dff, thank you! -- Alex ------------=_1501359962-8087-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 27 Jul 2017 05:01:49 +0000 Received: from localhost ([127.0.0.1]:57842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daavl-00058b-0V for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:49 -0400 Received: from eggs.gnu.org ([208.118.235.92]:43002) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1daavi-00058P-H6 for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daavc-0002ey-DS for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:41 -0400 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on eggs.gnu.org X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,T_DKIM_INVALID autolearn=disabled version=3.3.2 Received: from lists.gnu.org ([2001:4830:134:3::11]:57462) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daavc-0002er-Au for submit@debbugs.gnu.org; Thu, 27 Jul 2017 01:01:40 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33972) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1daavb-0005Ig-5n for guix-patches@gnu.org; Thu, 27 Jul 2017 01:01:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1daavX-0002br-4a for guix-patches@gnu.org; Thu, 27 Jul 2017 01:01:39 -0400 Received: from pb-smtp1.pobox.com ([64.147.108.70]:60652 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1daavW-0002ag-Ti for guix-patches@gnu.org; Thu, 27 Jul 2017 01:01:35 -0400 Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 949E19A7C1; Thu, 27 Jul 2017 01:01:31 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:date:message-id; s=sasl; bh=B0rVdn+7AfLXeD00ncFhc2tmcvI =; b=f24CyXjphHeNBonxKHmhUJYFHrzy0bFXCXQuirbdnR+XdSCooCrpWG14bZd 5tN9tey+f11ZOGuElZl5+ECCstxD3MJGC8KUftwSNCwb9+FWON3Z/71GZ8TB4AcI 1JDW+H+MXDiDpZOlCk3B88/DmvkcDUCcJDPrTBdl9HGw3MZA= Received: from pb-smtp1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-smtp1.pobox.com (Postfix) with ESMTP id 8CC499A7C0; Thu, 27 Jul 2017 01:01:31 -0400 (EDT) Received: from kmlap.hsd1.ct.comcast.net (unknown [24.60.167.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by pb-smtp1.pobox.com (Postfix) with ESMTPSA id E6DD59A7BF; Thu, 27 Jul 2017 01:01:30 -0400 (EDT) From: Kyle Meyer To: guix-patches@gnu.org Subject: [PATCH] gnu: emacs: Check GUIX_ENVIRONMENT when autoloading packages Date: Thu, 27 Jul 2017 01:01:26 -0400 Message-Id: <20170727050126.27817-1-kyle@kyleam.com> X-Mailer: git-send-email 2.13.3 X-Pobox-Relay-ID: A791C7F2-7288-11E7-9C57-FE4B1A68708C-24757444!pb-smtp1.pobox.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=kyleam.com; h=from:to:cc:subject:date:message-id; s=mesmtp; bh=bay3TOsl3yjWMk+e4hyMzY7RxpAqA+ecr5sgifk+caU=; b=OPtKPLGVir5RsxfVdPo31YwQNEip1ksjTTEfCKGvVb5y0DszXdBCfTGMmu4U4OXKox7BveDHtC7upGu21KjfNtizBXHS0lX/wawoGmPHEuVOT6GNMVJt17pN97fimuSlh8BAtn0u+4W4GTph79Nb0BgUDG0hghqf1iimDn31smM= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2001:4830:134:3::11 X-Spam-Score: -4.0 (----) X-Debbugs-Envelope-To: submit Cc: Alex Kost , Kyle Meyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -4.0 (----) Check the environment profile so that we autoload packages that are given as arguments to "guix environment" but are not in the system or user profile. Note that the union of Emacs packages in the system, user, and environment profiles will be autoloaded even when --pure was passed to "guix environment", because it's not clear how to detect that --pure was given. * gnu/packages/aux-files/emacs/guix-emacs.el (guix-emacs-autoload-packages): Add Emacs packages from GUIX_ENVIRONMENT profile. --- Follow-up to https://lists.gnu.org/archive/html/guix-devel/2017-07/msg00378.html gnu/packages/aux-files/emacs/guix-emacs.el | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/gnu/packages/aux-files/emacs/guix-emacs.el b/gnu/packages/aux-files/emacs/guix-emacs.el index 2bbd639ff..10bad0272 100644 --- a/gnu/packages/aux-files/emacs/guix-emacs.el +++ b/gnu/packages/aux-files/emacs/guix-emacs.el @@ -87,9 +87,11 @@ (defun guix-emacs-autoload-packages (&rest profiles) (interactive (list (if (fboundp 'guix-read-package-profile) (funcall 'guix-read-package-profile) guix-user-profile))) - (let ((profiles (or profiles - (list "/run/current-system/profile" - guix-user-profile)))) + (let* ((env (getenv "GUIX_ENVIRONMENT")) + (profiles (or profiles + (append (list "/run/current-system/profile" + guix-user-profile) + (and env (list env)))))) (dolist (profile profiles) (let ((dirs (guix-emacs-directories profile))) (when dirs -- 2.13.3 ------------=_1501359962-8087-1--